Commit Graph
121209 Commits
Author SHA1 Message Date
Yannick Tivisse b2b9545cf3 [IMP] ir_ui_view: Log warning on incorrect 'groups' attribute
Purpose
=======

They are a lot of places where we set an attribute 'groups' on a view element and:

- The group doesn't exist anymore
- The group xmlid is not correct
- The group xmlid exists but the modularity is not respected (example: group_stock_user
  used in a view in the 'product' module).

Where it happens, nothing warns the user or the developer. The element is just never
rendered.

Specification
=============

In the method _check_xml, log a warning if a 'groups' attribute is set and if
a group doesn't not exist at that moment.
2018-10-02 12:35:34 +02:00
Yannick Tivisse eaba05b9ae [FIX] sale,stock,account,...: Use groups in views only if they exist
Purpose
=======

They are a lot of places where we set an attribute 'groups' on a view element and:
- The group doesn't exist anymore
- The group xmlid is not correct
- The group xmlid exists but the modularity is not respected (example: group_stock_user
  used in a view in the 'product' module).

Where it happends, nothing warns the user of the developer. The element is just never
rendered.

Specification
=============

Fix the occurences of bad groups definition
2018-10-02 12:35:34 +02:00
Aurélien Warnon 497e134664 [FIX] (website_)sale: show missing attributes combination message
Targets commit d3530eb07e

Purpose
=======
- A message showing "This combination does not exist" should appear on both webshop and backend
  when the selected product combination is not available (due to exclusions)
2018-10-02 11:59:35 +02:00
Martin Trigaux c9837ac5dc [FIX] base: compare on original module
Introduced at 574f4c3d
model._module has for value of the last module extending the model.
This means that, when a module B inherit from a model defined in a module A (e.g
to add a field on the model), an external id, tagged with module B, will be
created for each field of the model, including the one defined only in A.

The intention of the patch at 574f4c3d was to include the automatic fields (i.e.
LOG_ACCESS_COLUMNS) into the condition.
Without that condition, the fields such as create_date were deleted when
upgrading a module (not defined in any module)
2018-10-02 11:51:15 +02:00
Martin Trigaux 718b0f8b63 [FIX] models: display first external id onyl
In case the result matches two records (e.g. a model has one external id per
module inheriting it), the last was used.

Use the first only.

Fixes #27363
2018-10-02 11:20:01 +02:00
Christophe Simonis dece365d52 [FIX] mail: avoid reading from abstract models 2018-10-02 11:12:15 +02:00
Laurent Smet adc08d02bb [FIX] account: fix 'go to bank statements' in rainbowman
When all statement lines are reconcilied automatically, the rainbowman
is displayed directly but the 'Go To Bank statements' button is not visible.
2018-10-02 10:27:53 +02:00
Laurent Smet b39c778bfb [FIX] account: fix empty label on write-off lines
In a reconciliation model having some write-off lines configurated but no
label set, the line must keep the statement line name.
2018-10-02 10:27:53 +02:00
Aurélien Warnon 783e884ddc [IMP] product,(website_)sale: Fix parent exclusions - product configurator
Targets commit d3530eb07e

Purpose
=======
- Exclusions for optional/accessory products do not work for attributes configured as "never create variants".
  These attributes are now added to the reference_product context so that they can be taken into account when
  evaluating exclusions.
2018-10-02 10:17:59 +02:00
Aaron Bohy b7d11d6891 [FIX] doc: correct two typos 2018-10-02 09:50:18 +02:00
Yenthe V.G eace8edec0 [FIX] website_forum: correct typo in badge name 2018-10-02 09:24:21 +02:00
Olivier Colson 0ef7e7411f [FIX] account: allow creating a new line on an invoice without crashing if not pricelist is defined
This bug had been introduced in https://github.com/odoo/odoo/commit/154fc7d9dd550d35b7266af024e54c20e18938fc .
2018-10-02 09:02:46 +02:00
Gert Pellin bb015818ea [imp] hw_scale: Disable Adam if not used
Adam scales give a beep if it has no changed value to send. This commit
disable the beeping outside the weight screen
2018-10-02 08:38:21 +02:00
Olivier Dony 7fda09549c [ADD] payment_ogone: log s2s ALIAS creation
This is an important event, including for PCI compliance, so it is useful
to log it.
2018-10-02 01:03:03 +02:00
Olivier Dony 9bae56acd4 [IMP] http: reinstate session rotation after login
Session rotation was introduced a long time ago, but deactivated at
login due to obscure side-effects related to #6949 (aka the "BBQ" PR).
This commit reinstates the rotation, which is better from a security
standpoint.

In order to also prevent session ID reuse, we force the renewal of
deleted sessions, at the SessionStore level (via `renew_missing`).
2018-10-02 01:00:37 +02:00
qsm-odoo c47600887f [FIX] website: resolve failed-forward-ported website demo
The following series of commits were badly forward-ported:
- https://github.com/odoo/odoo/commit/24a8bce5429eef7139bdd1bc87aa1ef8733670a7
- https://github.com/odoo/odoo/commit/9ef7763ecdf4fb102e49ce68ac4ca3ce7557016e
- https://github.com/odoo/odoo/commit/66d37834284f890c00f00c8ab32ca820f757beb6
2018-10-01 21:51:17 +02:00
qsm-odoo ba237a43af [FIX] website_hr: review the "our team" section
The 'our team' section on the about us page was broken since BS4. This
was because the previous implementation in BS3 was not properly done,
this commit correctly uses the grid system and make the publish
management appear not broken.

Thanks to @kea14 for spotting the issue.
2018-10-01 21:33:32 +02:00
qsm-odoo 09d47cc65d [FIX] portal: remove useless inline-flex rule on breadcrumb items
It seemed useless before but now it is breaking layouts (as flex ignore
whitespaces), so let us remove it.
2018-10-01 21:33:32 +02:00
qsm-odoo 9df7bca6f5 [FIX] web: prevent users to type invalid values for opacity
Also, make all the _updateXXX methods follow the same structure.

Thanks to @kig-odoo for spotting the issue.
2018-10-01 21:33:32 +02:00
qsm-odoo 8b2dbd1441 [FIX] website: handle light colors as body text color
Before this commit, if the user chose a light color for the text (with
a dark color for the body for example), that color was also used for the
automatic "dark" color, leaving the "light" color to the default $white.
That means that when a light snippet background was set, the automatic
color which was used was the light color the user chose. We want to
invert the system in that case: use the user color as the "light" color
to use over dark backgrounds and leave the "dark" color to the default
$gray-900. This is what this commit does.
2018-10-01 21:33:32 +02:00
qsm-odoo 89678c6041 [FIX] base, website: make attachment serving multi-website
- Reaching an attachment datas thanks to its URL was not multi-website
- Compiling assets with URLs to attachment datas was not multi-website
2018-10-01 21:33:32 +02:00
Alexandre Kühn 03a93f0968 [FIX] google_drive:tests: adapt from forward-port 2018-10-01 18:28:51 +02:00
Alexandre Kühn e8a071a744 [FIX] mail: show/hide 'New Message/Channel' in discuss mobile
Before this commit, the buttons 'New Message' and 'New Channel'
were shown in all tabs of discuss mobile, even though they should
only be displayed in some tabs.

This issue comes from a change from BS3 to BS4, in which the classname
`visible-xs` has been replaced with `d-block d-md-none`. With BS4,
the classnames `d_*` are now `!important`. As a result,
`d-block d-md-none o_hidden` still displayed the button because
`o_hidden` does not have `!important`.

This commit fixes this issue by removing the reliance on `o_hidden`,
and now only uses `d-*` for the visibility of the button. The toggling
of `o_hidden` has been replaced with adding or removing the classes
`d-none` (hidden) and `d-block` (visible). Those buttons are not shown
in desktop thanks to `d-md-none`.

Task-ID 1877502
2018-10-01 18:19:48 +02:00
Alexandre Kühn 05971d0050 [FIX] web: 'Shortcuts' in user menu (community)
Revision on https://github.com/odoo/odoo/commit/19eacf7d23c9413de4430a3422b5ed74b37ef242

This menu item should not appear in the community version of Odoo.
The commit above mistakenly added this menu item, even though no
logic was implemented for it. This was a consequence of the copy
& paste approach to rapidly deploy the new navbar in community.

(Note: a big refactoring of the web client is coming very soon,
so this duplicated code issue should only be temporarily).

This commit fixes the issue by removing this menu item in the
community version.
2018-10-01 18:19:48 +02:00
Antony Lesuisse a171694644 [FIX] web: datababase manager add privacy policy link 2018-10-01 18:08:50 +02:00
Xavier Morel 00eefae98d [FIX] doc: implement delegation/inheritance in JS documenter
Else website_sale_wishlist.wishlist blows up the documenter:
``events`` is set to sAnimations.Class.events but that is not an "own
property" of sAnimation.Class, it is instead inherited from Widget.

If delegation is not implemented, the value resolves to <nothing>,
which blows up when trying to set its name to the "property name" (by
calling ``set_name``).
2018-10-01 17:31:41 +02:00
Christophe Simonis 453e81cdc8 [FIX] mail: used defined variable
Oversight of previous forward-port.
2018-10-01 17:04:22 +02:00
William Henrotin 47ea5f3260 [FIX] delivery: new error message
Making a delivery with an external carrier without setting any partner
will sometimes lead to a crash on the API respond from the carrier. This technical error is sent back to the user without any proper sentence human readable.

This commit set the field 'partner_id' required in case of delivery with external carrier to avoid any technical error

Task : 1886733
2018-10-01 17:02:26 +02:00
Mathieu Duckerts-Antoine 9b5dabd399 [FIX] web: right labels in bar chart and comparison mode
For a single groupby selected, the graph view didn't render well
the data when simultaneously in bar chart and comparison mode.
The labels were in that case always integers.
This commit fixes that situation.
2018-10-01 16:42:12 +02:00
Antony Lesuisse 2870af948e [MOV] account_budget: move to enterprise 2018-10-01 16:38:00 +02:00
Antony Lesuisse 2e63ead842 [MOV] account_asset: move to enterprise 2018-10-01 16:38:00 +02:00
Antony Lesuisse 62644f93fe [IMP] base: onboarding prefill email in company data 2018-10-01 16:38:00 +02:00
Antony Lesuisse 192c56b48a [FIX] mail: Hide system update notification cron
Reducing the possiblity of enterprise users of locking themselves.
2018-10-01 16:38:00 +02:00
Antony Lesuisse e51b4f659f [REM] account: Remove deprecated pdf reports 2018-10-01 16:37:59 +02:00
Antony Lesuisse 837c738d8b [FIX] mail_bot: Merge OdooBot and System
As we want that operations done by the system such as reordering rules be done
by him.
2018-10-01 16:37:59 +02:00
lejeune quentin b30df8f3fd [FIX] iot: restart Odoo after loading drivers in IoT Box web interface 2018-10-01 16:34:30 +02:00
Josse Colpaert c1a591531c [IMP] iot: IoT Box image with self-signed certificate and 2 nginx configs
One nginx config for the access point and one for the https with the self-signed
certificate.

This is a temporary fix for the IoT Box to work with the SaaS that is https-only
(except pos) This way you won't get an error when printing or asking a value from
the IoT Box telling you are mixing http and https.  The disadvantage is that
you still need to agree on accepting the certificate (and the banner will stay red).
A definitive solution will follow later on.

+ retry if hash sums are wrong on generating the IoT Box message
2018-10-01 16:32:21 +02:00
TWA 0dd92f7f21 [FIX] partner_autocomplete: No auto-create IAP Account in the settings
Instead of forcing the creation of iap account to consult its balance,
since it will most likely be 0 at creation, we only generate it on
explicit user action (e.g. Click to recharge the account).
2018-10-01 16:29:45 +02:00
Rémi Rahir 9342235fd4 [FIX] iap: remove temporary hack from 11.0
Remove the sudo create introduced in 2bf1af77fb
as we added corrects security access.
2018-10-01 16:26:05 +02:00
Christophe Simonis 9b477f5311 [FIX] web: define used variable in test
Oversight of previous forward-port
2018-10-01 16:21:46 +02:00
Christophe Simonis 43b63a0465 [MERGE] forward port branch saas-11.4 up to 57e387b645 2018-10-01 16:01:54 +02:00
RomainLibert b2870ae1eb [FIX] web: add shortcuts menuitem support
Since https://github.com/odoo/odoo/commit/19eacf7d23c9413de4430a3422b5ed74b37ef242, it was possible to click on a "Shortcuts" menu item
in community which triggered a call to _onMenuShortcuts whose
implementation was only defined in enteprise

As the keyboard shortcuts are available both in community and
enterprise, we should support this menu item
2018-10-01 15:13:57 +02:00
qsm-odoo 3207a5a45c [FIX] website: review s_tabs card's color option
Set the background color on the card instead of the column, just like
regular cards snippets.
2018-10-01 15:07:50 +02:00
qsm-odoo 517e84111a [FIX] website: properly allow multiple s_tabs snippets per page
Before this commit, the nav-tabs IDs/urls/... were the same when that
snippet was added multiple times or duplicated. Now, the IDs are
recomputed everytime a new .nav-tabs appears.
2018-10-01 15:07:50 +02:00
qsm-odoo a3aaad9286 [REF] website: use get_current_website method instead of context 2018-10-01 15:07:50 +02:00
Laurent Smet ac08187bb6 [FIX] account: fix a $.when() in the reconciliation widget
var defs = [def1, def2, def3]
$.when(defs) is not equal to $.when(def1, def2, def3) but $.when.apply($, defs) is.
2018-10-01 14:54:16 +02:00
David Beguin c603dc0706 [FIX] mass_mailing : fix buttons style for unsubscribed page (lead and contact case)
Buttons class was not aligned with unsubscribe page for mass_mailing.contact case.
Linked with Task ID 33224
Closes PR #27352
2018-10-01 14:32:23 +02:00
Adrien Dieudonne c4937132a3 [FIX] web: line chart x ticks labels overlapp
This commit hides some labels depending of the avalaible size
of the graph.

We had to skip some test because 'renderEnd' is not triggered
for line chart. We need to update nv.d3.
2018-10-01 14:24:51 +02:00
David Beguin a8ce59ce36 [FIX] mail : Fix blacklist search method
As building a custom filter on 'Blacklist is false' is creating a filter '!= True'
instead of '= False', the assumption that operator must always be '=' is wrong.
This commit inverts the value and operator if the operator is '!='.

Fix for Task ID 33224
PR #27334
2018-10-01 14:21:19 +02:00
Aurélien Warnon 6f9a223ca8 [IMP] product,(website_)sale: Product configurator default_get cleanup + bugfix
Targets commit d3530eb

Purpose
=======

[Follow up AL review]

Removed the default_get override in the sale_order_line model.
- The default values to create records are now specified by pefixing them with "default_" in the JS.
  That will use the built-in framework method, which is more simple/clean.

- The "list_editable_renderer.js" file for the product configurator was removed and its content is now merged within
  the SectionAndNoteListRenderer.

Updated fields:

- [sale_order_line in sale/sale.py] "product_no_variant_attribute_values" to "product_no_variant_attribute_value_ids"

[Follow up JCR testing]

Various bug fixes including:

- optional products dont show when they have variants configured on them
- when no variant is created, you cant choose the product one first time in the ecommerce
- when in debug, attribute and attribute value menu is double
- fix design of default picture in cart summary / product comparison
- fix missing href tag on product comparison "add to cart" buttons
- fix button "Configure Variants" is always shown even if there are no variants
2018-10-01 13:37:30 +02:00