Commit Graph
131989 Commits
Author SHA1 Message Date
Martin Trigaux b0b5fa6ec9 [FIX] website_sale: translate waiting message
closes odoo/odoo#40456

X-original-commit: 50d2a80e458bcf99025bf2e96afafd8606745c85
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-11-18 17:21:59 +00:00
Raphael Collet d2ff759ec0 [IMP] tools: make domain validation less strict
We do not want to block developers from using dynamic domains like:

    domain="country_id and [('country_id', 'in', [False, country_id])] or []"

closes odoo/odoo#40445

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
2019-11-18 15:17:02 +00:00
Martin Trigaux 69cbab713a [FIX] base,product: fix typos
closes odoo/odoo#40453

X-original-commit: 3b7a98bd5a7ce57a8f03b06fe9ac6c8eb349d2ad
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-11-18 16:41:57 +00:00
Nans Lefebvre 4fd8310e76 [FIX] account: send invoices with the right name
The mail_notification_paynow template expects a model_description
parameter or defaults to the model _description, "Journal Entries".
We add, similar to 4a3fd02af4 on sale.order, a type_name field to
get the correct type name in an extensible way.

Similar to 8c91b193fca3b, 65b6375cf3f9b.

opw 2120545

closes odoo/odoo#40245

X-original-commit: d1b66ca8ea46af1034e344dfd3eb99e00f5a2a34
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
2019-11-14 09:55:05 +00:00
Simon Lejeune ea92c813fd [FIX] stock_landed_cots: bring bach additional_landed_cost in the view
This field was deemed redundant and thus removed from the view but we
forgot the use case where multiple valuation adjustment lines are
generated (eg applying a lc on multiple pickings) and the added value
by picking must be adapted manually (eg decrease one to increase the
other).

task-2125127

closes odoo/odoo#40454

X-original-commit: 3e6d6315adf1c33ec3fd5eb106defb0c80d7290b
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-11-18 16:42:15 +00:00
fw-bot cf4a6cbdec [FIX] web: fix kanban "group by stage" wrong display
Reproduce the issue

    - Install Projects and Studio
    - Edit the projects app's kanban view
    - Enable group by stage
    - Close studio
    - Add several stages

    The stages are wrapped to the next line

Cause

    I think the problem comes from c5f6802, we apply a wrapping to
    all the kanban_dashboard items and in this cases the items are
    the stages.

This commits apply the wrap only on non-grouped kanban dashboard.

OPW-2123031

closes odoo/odoo#40449

X-original-commit: f40478d5bacfdc44c76b0aac2f749549bbc58681
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2019-11-18 15:52:03 +00:00
laa 70c370b01e [IMP] project,hr_expense,hr_timeshee: Add optional fields in list view
Add and modify multiple fields in tree view for next next model:
- hr.expense
- hr.expense.sheet
- project.project
- planning.slot
- Field Service project.task

closes odoo/odoo#39441

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-11-18 12:56:10 +00:00
fw-bot 4c28667efd [IMP] hr_holidays: prevent grouping leaves by name
closes odoo/odoo#40426

Taskid: 2088559
X-original-commit: 5653520252f321d1fa185bffd897952830b509c4
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-11-18 13:33:30 +00:00
Romain Derie e9106f8f98 [IMP] http_routing, portal, website: nicer 404 layout
This commit introduces a nicer 404 page, which is basically the same layout as
the one used on Odoo.com.

Also, the 404 is now fully customizable, blocks can be drag'd & drop'd.

task-1966460

closes odoo/odoo#38901

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-11-18 13:59:09 +00:00
Goffin Simon d3fe36d817 [FIX] account: Cannot search fiscal positions
It was not possible to search a fiscal position by name without a custom
filter.

opw:2124184

closes odoo/odoo#40404

X-original-commit: 72534d7ae21677b02d7cb26dd06d84d532be9514
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
2019-11-18 10:25:20 +00:00
jbm-odoo be15be7fa6 [IMP] hr_attendance: Introduce Kiosk users group
It's the unique group needed for a kiosk attendance. Avoid to give
to much rigths.

id=2088561

closes odoo/odoo#38954

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-11-18 12:37:42 +00:00
Victor Feyens 23d66d7045 [FIX] website_slides: default values for all compute fields.
closes odoo/odoo#36804

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
2019-11-18 12:25:05 +00:00
Victor Feyens 37b1689be7 [FIX] account, analytic: remove company_ids context key mechanism 2019-11-18 12:25:05 +00:00
Victor Feyens d52f8ce8b0 [FIX] portal: remove company_id context key. 2019-11-18 12:25:05 +00:00
Victor Feyens 3cf7b3778a [FIX] account: no impact company_id ctxt key. 2019-11-18 12:25:05 +00:00
Victor Feyens ce9fe1fcf6 [IMP] * : remove company context key 2019-11-18 12:25:05 +00:00
Victor Feyens 57b999d40a [FIX] sale,account,purchase_requisition: multi-company
Use correct company to get fiscal positions and properties

Ensure company used to fetch fiscal positions is always the correct one
when coming from a company restricted model (company_id required, or
related.required).

NB: if the company_id isn't defined, with_company doesn't change the
environment.

purchase: get_fiscal_position doesn't consider company_id ctxt key

others: properties were accessed with potentially the wrong company.
2019-11-18 12:25:05 +00:00
Victor Feyens 48b887618c [IMP] * : replace with_context(allowed_cids=[c]) by with_company(c). 2019-11-18 12:25:05 +00:00
Victor Feyens 9215e73fa2 [IMP] * : replace with_context(force_company=c) by with_company(c) 2019-11-18 12:25:05 +00:00
Victor Feyens 3455d02189 [IMP] base: remove force_company
From now on, if one wants to force following operations to happen in a given company,
use with_company(company) or with_company(cid) to update the environment.
2019-11-18 12:25:05 +00:00
Victor Feyens ef20d818ea [IMP] ORM: warn on bad company context keys usage. 2019-11-18 12:25:05 +00:00
Victor Feyens 0bfb695b4f [ADD] ORM: with_company 2019-11-12 16:23:33 +00:00
fw-bot e76276e083 [FIX] mrp,stock: error w/o traceback on create warehouse
If a warehouse is created without code (eg. when created as a new group
from a kanban view grouped by warehouse) we would get a traceback
instead of an error:

```
  The operation cannot be completed:
  - Create/update: a mandatory field is not set.
  - Delete: another model requires the record being deleted. If possible, archive it instead.

  Model: Warehouse (stock.warehouse), Field: Short Name (code)
```

opw-2124162
fix #40233
closes #40267

closes odoo/odoo#40382

X-original-commit: b6caa179e17199b29a9ca4009c53acb378423926
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2019-11-15 20:23:59 +00:00
Adrien Dieudonne 00e3eb8efd [FIX] web: restore responsive mode for website only
Due to a recent change: https://github.com/odoo/odoo/commit/c3335a0db03b7ef5e98bddb7c15b143510d58c1e#diff-c7dab7f11ffa06829bbc6ac5c87a99a8L420
website wasn't responsive anymore.
This was not intended as we only wanted to remove the
responsive support for the backend, not the frontend.

closes odoo/odoo#40314

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
2019-11-18 10:18:49 +00:00
Debauche Stéphane a7d029afa7 [FIX] crm_website: fix the type of a lead created with the contact form
Lead/Opportunity type
=====================
In the settings, if ``group_use_leads`` is checked, we add the group ``use_leads`` to all users in the group ``base.group_user``

To know if the setting is checked, in the model ``crm.lead``, we compute this code,
```
self.env['res.users'].has_group('crm.group_use_lead')
```

In 12.0
=======
When we compute ``sudo``, we are as the admin user.
The admin user is in the group ``base.group_user`` and so, he can be in the group ``use_leads``,
so everything work fine.

In 13.0
=======
When we perform a ``sudo``, we keep the same user.
But the visitor is not in the group ``base.group_user`` (he is in the group ``base.group_public``)
So, the visitor can never be in the group ``use_leads``

Fix
===
To fix it, we just need to compute the method ``has_group`` as the super user (which is in the group ``base.group_user``).
```
self.with_user(SUPERUSER_ID).env['res.users'].has_group('crm.group_use_lead')
```

Task #2124421

closes odoo/odoo#40418

X-original-commit: 8758bdc24297032ba8fd65f637a6990c6351dd27
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-11-18 11:49:28 +00:00
jvm-odoo 6188378e57 [FIX] web_editor: fix wrong datetime parsing
Reproduce the issue

    - Install Events
    - Set the english default format date to %d/%m/%Y
    - Create an event & edit the date

    The date is set correctly in the backend

    - Edit the date of an event on the website directly

    The date format is still the old one

Cause

    The `from_html` method of DateTime was using `parser.parse` and
    ignore the user's date format.

This commit changes `parser.parse` into `datetime.strptime` taking
into consideration the user's date format.

closes odoo/odoo#40415

X-original-commit: d00c0e317f8affbe8bea231972c2b6da70b9f240
Signed-off-by: Jason Van Malder <jasonvanmalder@users.noreply.github.com>
2019-11-18 11:35:19 +00:00
Simon Lejeune 94e91972d4 [FIX] sale_stock: hide effective_date when empty
task-2125070

closes odoo/odoo#40412

X-original-commit: 965ef8ea1b2dcf3415e3f002248c8fb68cbfdfb6
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-11-18 11:04:23 +00:00
Florimond Husquinet (fhu) c9bed78c2b [FIX] crm: compute lead probability on kanban quick create
-In CRM, click the CREATE button.
-Only enter a title for the new lead and directly click ADD.
-Click on the newly created lead to view its details.

Before this commit:

although a probability could be computed based on the stage of the lead, this
field has a default value and, at creation time, this value doesn't end up in
the list of values from which the `_write_probability` function decide whether
to recompute the probability.

After this commit:

The `_write_probability` function, renamed `_update_probability`, doesn't check
whether it should or not update the probability. It just does it. This function
is directly called in the `create`. `_should_update_probability` is called
before `_update_probability` in the `write`.

Task ID : 2081480

closes odoo/odoo#40411

X-original-commit: 483a94116629e418ebb224bad375747cf9ab3c1d
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-11-18 11:04:05 +00:00
laa a8fdda6638 [FIX] hr_holidays: don't show the name in edit mode
When changing fields in Manager -> Allocation Form, the name (display_name) was recalculated only after the form was saved or only after the description was changed.

closes odoo/odoo#39553

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-10-30 08:10:21 +00:00
qsm-odoo 00022bd7fc [REF] web_editor: get rid of we-collapse elements
Now, we should either use:
- A we-select (in the end, same as collapse except it does not push the
  elements in the UI)
- A simple div to always display the elements

Part of https://github.com/odoo/odoo/pull/38959
task-2066614

closes odoo/odoo#38959

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-11-18 09:56:40 +00:00
qsm-odoo 5db73c12d3 [IMP] web_editor: increase option sections readability
Part of https://github.com/odoo/odoo/pull/38959
task-2066614
2019-11-18 09:56:40 +00:00
Samuel Degueldre dfd98f49e7 [IMP] web_editor: rework background-sizing option
Previously, background size and position for snippets was configured in
a modal, the user could choose a "focus point", which is rather
unintuitive. They could also choose to use the "contain" background
mode, with or without repeat, or a third option, where they could
customize everything, from the background size in both directions to
whether to repeat the background in only one or in both directions.

This commit streamlines the background-sizing options, only the "cover"
and "repeat pattern" options have been kept, as they cover almost every
use case. Their configuration has been moved into the options menu for
consistency with the rest of the editor, and the background's position
is now chosen by clicking on the corresponding menu option, and dragging
the background to the desired place.

Part of https://github.com/odoo/odoo/pull/38959
maintask-2066614
task-2088304
2019-11-18 09:56:40 +00:00
qsm-odoo 01debf53f6 [IMP] web_editor: allow to temporary block preview overlay toggling
This will allow to do the following:

1) Show a preview overlay over an element
2) Block preview overlays -> the overlay at step 1 stays no matter what
3) Encourage the user to do something that edits what the preview
   overlay is currently showing.
4) The edition is finished, go back to normal by unblocking preview
   overlays.

Part of https://github.com/odoo/odoo/pull/38959
task-2066614
2019-11-18 09:56:40 +00:00
qsm-odooandSamuel Degueldre 688e21b6e0 [IMP] website, *: add slide management buttons for carousel snippets
* web_editor

This commit adds a slide counter in carousel snippets option menu, as
well as left and right buttons, this way the user can manage their
slides entirely from the options, instead of having to go to the block
itself to navigate to where they want before going back to the option
menu to add or remove a slide.

Part of https://github.com/odoo/odoo/pull/38959
maintask-2066614
task-2088291

Co-authored-by: Samuel Degueldre <sad@odoo.com>
2019-11-18 09:56:40 +00:00
qsm-odoo c879ac723b [FIX] website, *: no theme color suggestions during theme colors edition
* web_editor

Part of https://github.com/odoo/odoo/pull/38959
task-2066614
2019-11-18 09:56:40 +00:00
qsm-odooandfja-odoo ea994b0cbb [IMP] web_editor, *: review 'colorPalette' editor UI
*: website, mass_mailing

Part of https://github.com/odoo/odoo/pull/38959
maintask-2066614
task-2087383

Co-authored-by: fja-odoo <fja@odoo.com>
2019-11-18 09:56:40 +00:00
fja-odoo 22c5fc5dd2 [IMP] web_editor, website: generalize colorpicker
Currently we have:
- a colorpicker for background color of snippets
- a colorpicker for foreground and background text (topbar)
- a colorpicker for menu/footer/navbar/etc
These 3 are separate colorpickers with different options.

After this Commit
All 3 will use the same color palette wich allow you to select
theme color, common colors, custom color and transparent filter.

Part of https://github.com/odoo/odoo/pull/38959
maintask-2066614
task-2087383
2019-11-18 09:56:40 +00:00
qsm-odoo 2006959761 [REF] website_sale, *: review shop snippet options UI
* web_editor

Part of https://github.com/odoo/odoo/pull/38959
task-2066614
2019-11-18 09:56:08 +00:00
Samuel Degueldre f615cfda89 [IMP] website, *: rework snippet anchor system
* web_editor

Previously, the user could choose their anchor names using a modal
window, anchor names also have weird rules, this was not a great user
experience.

This commit makes the anchor button generate anchors automatically based
on the first title in a section, or the snippet name if there are none.
If the anchor name is already taken, it is suffixed by a number. After
it has been generated, it is also copied to the clipboard and the user
is shown a toast to tell them the anchor has been generated and copied.
The anchor is displayed in the toast along with an edit button that will
open the same edition modal as previously, but it is now less
restrictive.

Part of https://github.com/odoo/odoo/pull/38959
maintask-2066614
task-2088270
2019-11-18 09:56:08 +00:00
qsm-odoo bf5b4b6933 [IMP] website, *: introduce inputs in the left panel UI
* web_editor, website_sale

Part of https://github.com/odoo/odoo/pull/38959
task-2066614
2019-11-18 09:56:08 +00:00
qsm-odoo c47527b794 [IMP] web_editor: allow options to add UI in the overlay top bar
-> move the move buttons next to the drag button

Part of https://github.com/odoo/odoo/pull/38959
task-2066614
2019-11-18 09:56:08 +00:00
Samuel Degueldre 7623f3ecf7 [IMP] website: add quick move buttons for sections and columns
This commit adds buttons to move sections up or down and to move columns
left or right, which is more user-friendly than drag-and-drop in some
cases.

Part of https://github.com/odoo/odoo/pull/38959
maintask-2066614
task-2088265
2019-11-18 09:56:08 +00:00
qsm-odoo c213afab86 [IMP] web_editor, *: review 'background' options' UI
* website

Part of https://github.com/odoo/odoo/pull/38959
task-2066614
2019-11-18 09:56:08 +00:00
qsm-odoo 72a2f417ae [IMP] web_editor, *: introduce select & checkboxes for the left panel UI
* website, website_blog, website_form, website_sale

+ introduce default UI for snippet options
+ refactor style of icon buttons

Part of https://github.com/odoo/odoo/pull/38959
task-2066614
2019-11-18 09:56:08 +00:00
qsm-odoo ed8133c72f [IMP] web_editor, *: allow snippet options next to clone/delete buttons
* website

Now snippet options can be defined as a button which can be placed next
to the clone and delete buttons, through a new "isTopOption" method.

This commit also review the buttons and title design and take advantage
of the feature to review the way snippets options are added in their
container (that code indeed contained useless part since 13.0).

Part of https://github.com/odoo/odoo/pull/38959
task-2066614
2019-11-18 09:56:08 +00:00
qsm-odoo c611d92191 [REF] website, *: remove useless palette title option
Not relevant anymore in the new editor UI.

Part of https://github.com/odoo/odoo/pull/38959
task-2066614
2019-11-18 09:56:08 +00:00
qsm-odoo d9bbdf15ad [REF] website, *: remove all snippet options UI icons
* web_editor, website_blog, mass_mailing

In preparation of the new left panel UI, remove all snippet options UI
icons as we do not want them anymore to simplify the UI.

Part of https://github.com/odoo/odoo/pull/38959
task-2066614
2019-11-18 09:56:07 +00:00
qsm-odoo 0cbc188a71 [FIX] web_editor: prevent focus change on recording undos
Part of https://github.com/odoo/odoo/pull/38959
task-2066614
2019-11-18 09:56:07 +00:00
Katherine Zaoral 466203311e [FIX] l10n_latam_invoice_document: manual taxes widget
Before this change the manual taxes widget in the invoice form view was
broken for Argentinian invoices, with this change now the widget is
working.

It was broke because this method is used for the report/portal and
manual taxes in widget in the form view, and for Argentinian case
report/portal invoice should not discriminate some of the taxes depending og
the responsibility of the customer/issuer and the type of document
(example: Factura A, Factura B).

Also update the method in order to match the original one in odoo
account module and add missing group_id

closes odoo/odoo#40400

X-original-commit: 6260da7604b2a831668be42bf8745c53a09e8d16
Signed-off-by: Josse Colpaert <jco@openerp.com>
2019-11-18 09:40:26 +00:00
Andrea Grazioso (agr-odoo) 9daed92a6d [FIX] web: translate popup broken
Install accounting and activate a new language. Under
Accounting>Settings>Terms and Conditions input something, save and then
click on the near lanuage button.

A popup will appear with only the possibility to close and save but with
no text.

This is because no row is fetched from the ir.translation table, because
the domain for the search is

```
['&',
    ['res_id', '=', None],
    ['name', '=like', 'res.config.settings,%'],
    ['name', '=', 'undefined']
]
```

* wrong res.id "None" instead of the correct one (1)
* wrong name pointing to somewhat related to 'res.config.settings'
(the field name is "res.company,invoice_terms")
* another wrong condition on name equal "undefined"

The domain is malformed because in
addons/web/static/src/js/views/basic/basic_controller.js
record.res_id is unset while record.res_ids is it. Rewriting res_id to
make sure the id is there fix the issue

Thanks to mart-e

opw-2091779

closes odoo/odoo#40394

X-original-commit: 20e84558de476c17fed73f7ea5a11989401bffaf
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-11-18 07:58:38 +00:00