Commit Graph
128722 Commits
Author SHA1 Message Date
wan aca0e700ac [FIX] account: show partner in invoice list view
The customers were removed from the invoice list view in
https://github.com/odoo/odoo/commit/317802d69e6236a43b2249b38d2f352813644f20

This was probably because the name of the variables
invoice_vendor_display_name was missleading as it was only for vendors
beofre but also for customers now. So this commit also renames related
variables.
While we are at renaming things, I also renamed the type in variables
supsense -> suspense.

closes odoo/odoo#35531

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-08-07 13:59:55 +00:00
svs-odoo 302338cea5 [FIX] stock: duplicate inventory
Before this commit, when you duplicate a validated inventory, the new
one has the inventory lines of the original one.
Now, the duplicate inventory is created without inventory lines.

Task #2043851

closes odoo/odoo#35402

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-02 11:55:14 +00:00
svs-odoo f6f141559f [IMP] stock: add new filter for inv.adj. lines
New search filter to display of inventory lines with `difference_qty`
(diff. between `theoretical_qty` and `product_qty`) different than zero.

Task #2043851
2019-08-02 11:55:14 +00:00
svs-odoo cf737c2623 [IMP] stock: refresh On Hand qty button on line
Add a button in the inventory adjustment lines view to update the
`theoretical_qty`. This button appears beside the On Hand quantity when
this quantity is outdated.

Note: it's not possible to define explicitly width of non-field column,
so we cannot define width of button's column. The hack is to constrain
width of other columns to manage a little space to display the button.

Task #2043851
2019-08-02 11:55:14 +00:00
svs-odoo 8371299710 [IMP] stock: visual changes on inventory adjustment
On Inventory Adjustment lines view:
    - Changes some fields name...
    - The column Inventory Date has been moved between Location and
      Lot/Serial Number.
    - The columns Lot/Serial Number, On Hand, Difference, UoM and
      Inventory Date are now optional.
      Only Inventory Date is hide by default.

Task #2043851
2019-08-02 11:55:14 +00:00
svs-odoo 96ebfea37d [IMP] stock: prefill_counted_quantity as selection
Changes the type of `prefill_counted_quantity` from boolean to selection
to have a label for each option.
This change is only for a functional purpose.

Task #2043851
2019-08-02 11:55:14 +00:00
Robot Odoo 2679f45cc7 [MERGE][REF] website_slides: revamp channel form view and inline slide categories
PURPOSE

This PR completely reworks the slide.channel form view. Notably slide categories
management should be simplified like SO or invoices sections.

SPECIFICATIONS

This merge

* improves the content management from the form itself by adding a tree view
of slides with the possibility of drag and dropping slides from category to
category;
* adds buttons to quickly add content or certifications in the slide tree
views;
* reorders the tabs and fields on channel view and update some labels;
* adds a custom float field widget so that the ratings are actually displayed
as stars;
* contains some fixes and light improvements related to recent merges in
elearning application, especially backend;

In order to implement the content management in the channel form, the model
slide.category has been removed. Instead of having a fully fledged model for
the categories we now use slide.slide with a is_category flag.

LINKS

Task 1978731
PR #33255

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-08-08 15:25:08 +02:00
Victor Feyens a461e5ea17 [IMP] sale_product_matrix : product UI
closes odoo/odoo#35562

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-08-08 10:05:05 +00:00
Aurélien Warnon 0daf434ed8 [FIX] website_slides: correctly resolve course fullscreen YT Promise 2019-08-08 08:37:31 +00:00
Aurélien Warnon 654e9dd658 [FIX] website_slides: fix error message display on upload
When uploading twice the same video for a channel, the error message displayed unhandled html.
We removed the html to avoid having to use $el.html() for better safety (and it should not happen often anyway).
2019-08-08 08:37:22 +00:00
Aurélien Warnon 3716a9b261 [FIX] website_slides: fix pdfjs library loading
This is (most likely) related to #32181 which lazy loads most assets.

That caused an issue where the global 'Util' variable from PDFJS can be (depending of which libraries load first)
overridden by the global 'Util' variable of bootstrap.
(See 'lib/bootstrap/js/util.js' and 'lib/pdfjs/src/shared/util.js')

This commit ensures that the global 'Util' variable is set to the one of PDFJS right before it's used.

Eventually, we should update or get rid of one of the two libraries since they're not compatible together,
or make a wrapper that makes them compatible.
In the mean time, this small fix allows not refactoring all of this and can not cause much harm.
2019-08-08 08:37:07 +00:00
qmo-odoo 6e6b635557 [IMP] website_slides: improve slide.slide (lesson) code and view
PURPOSE

Improve daily use of slide, especially in backend.

SPECIFICATIONS

Make slide type editable in backend, notably at create. This commit makes it
possible for the user to manually define the type of the slide.

Slightly clean slide code about slide data.

LINKS

Task 1978731
PR #33255
2019-08-08 08:29:34 +00:00
qmo-odoo 340613d068 [REF] website_slides: revamp channel form view
PURPOSE

Like already done for sale order, invoice of survey, purpose of this commit
is to remove category model and replace by a flagged line (slide). It allows
to easily reorder slides in an embedded list view.

SPECIFICATIONS

This commit completely reworks the slide.channel form view

  * improve the content management from the form itself by adding a tree view
    with the possibility of drag and dropping slides from category to category.
    This tree view has buttons to quickly add content or certification. It
    also allow to add a category (slide with flag is_category) without opening
    a modal;
  * reorder tabs and fields, improve some labels;
  * add a custom float field widget to display ratings as stars;
  * add stat button for partners who completed/certified ;the course
  * add stat button that redirects to the forum posts;
  * add stat button that redirects to the channel reviews;

LINKS

Task 1978731
PR #33255
2019-08-08 08:29:34 +00:00
qmo-odoo b180c66a80 [REF] website_slides: replace slide.category by slide with is_category flag
PURPOSE

Like already done for sale order, invoice of survey, purpose of this commit
is to remove category model and replace by a flagged line (slide). It allows
to easily reorder slides in an embedded list view.

SPECIFICATIONS

Instead of having a fully fledged slide.category model, slide.slide will serve
that purpose with a is_category flag. This will allow to drag and drop slides
and sections in the channel form view.

This change had an impact on the way slides were added/sorted on the front-end.
In fact, whenever a slide is added from the front-end, a resequencing of all
the slides in the course has to be triggered.

Category of a slide is now a computed field based on the sequence. Order
of slides is based on sequence, with categories splitting the slide list based
on is_category flag.

In this commit tests are added. Some cleaning in tests is also performed to
speedup a bit tests (savepointcase) and some cleaning / renaming to ease
their understanding.

Future commit will add JS necessary to manage slides in the section list view.

LINKS

TaskID: 1978731
PR: #33255
2019-08-08 08:29:34 +00:00
qmo-odoo 5f4c7c5afa [FIX] website_slides_survey: fix certified correctly replacing members in kanban view
SPECIFICATIONS

Before this commit, installing survey would replace the number of done members
by its label. Now the number of members who completed the course will be
displayed correctly.

LINKS

Task 1978731
PR #33255
2019-08-08 08:26:08 +00:00
qmo-odoo b37243b85f [FIX] website_slides: fix crashes on channel creation/edit
SPECIFICATIONS

Before this commit, creating a channel would crash because of NewID key
not existing in a dictionary for compute fields. A crash would also happen
when deleting a slide from the channel form view.

LINKS

Task 1978731
PR #33255
2019-08-08 08:26:08 +00:00
qmo-odoo f5ddd6f151 [FIX] website_forum: rename compute method for forum statistics
SPECIFICATIONS

This commit renames the compute method _compute_slides_statistics to
_compute_forum_statistics. Purpose is to make read easier to understand
by having meaningful names .

LINKS

Task 1978731
PR #33255
2019-08-08 08:26:08 +00:00
Louis Baudoux d32c1d1958 [FIX] l10n_generic_coa: missing values for demo data for OCR
The demo invoice for the OCR had incomplete fields to work properly, the
'Send for digitalization' button was missing and there was no attachment
preview.

closes odoo/odoo#35528

Signed-off-by: Florian Daloze (fda) <fda@odoo.com>
2019-08-07 08:15:56 +00:00
Robot Odoo 3ddc2784bd [MERGE] sale: improvements in sales order UX
Back to Basics: Sales Order Drift

Various improvements in the UX of the Sales application, notably regarding
delivery and coupon. Other views/field labels/helper text changes as well.

Task 2033229

closes odoo/odoo#34963

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-08-08 14:04:35 +02:00
Parth Choksi 6173dd2141 [IMP] delivery, sale: improvements in recomputing of shipping cost
The "Recompute shipping cost" button will now reopen the wizard
to be able to change carrier.

When adding to the order, it will replace the current shipping cost.

Relabelled the "Recompute shipping cost" to “Update Shipping Cost”
and moved it to the right.

Shipping method field will have radio widget and cost will be editable
in the wizard.

Also, it was not allowed to delete a delivery line when the order was
confirmed ('sale' state). So here, as we want to allow user to change the
carrier even after the order is confirmed, we have allowed delivery line
to be deleted so that new line is added in place of that.

task-2033229
2019-08-08 07:54:29 +00:00
Parth Choksi 9f32b937ba [IMP] sale: changed default sequence prefix of order
There is a confusion with SO when it comes to payment ref. 'SO001' is too
visually to close to 'S0001'.

And wrong payment ref don't help the user reconciling the payments.
So, changed the prefix in default sequence of sales orders from 'SO' to 'S'.

task-2033229
2019-08-08 07:54:10 +00:00
Parth Choksi 9dde9ff29d [IMP] sale: added currency field for fixed amount in invoice
While creating the invoice order, if you choose the radio button of
Down Payment(Fixed amount) then the field with currency will be shown
and if you choose the Down Payment(Percentage) then the field with
percentage symbol will be shown and evaluated respectively.

task-2033229
2019-08-08 07:54:10 +00:00
Parth Choksi 5d7c0267a6 [IMP] *_sale, sale, sale_*: improvements in form view
Sending a quotation by mail is really rare and the option is still
available in dropdown menu. It is also confusing to see the document status
changed while you just want to print as a draft sometimes. So the PRINT button
is removed here.

Only displayed UNLOCK/LOCK for 'sales managers' if the
option “Lock confirmed orders” is activated in the settings.

Removed the ability to open the payment terms via external button
in edit mode

Removed the left,right and top borders in the field of terms and condition.
Kept only bottom border.

Event and Event ticket will come after Product regardless of it being a
template or the product.

In the sale order's form view, made certain changes like shifting
the positions, removing the field, adding title, keeping the field
in debug mode.

task-2033229
2019-08-08 07:54:07 +00:00
Parth Choksi 3ee0d3b68b [IMP] delivery, sale_coupon: layout changes
Changed positions of some buttons.
Changed wordings.
Some minor wording and layout improvements in wizard for coupon.

task-2033229
2019-08-08 07:53:44 +00:00
Mitali Patel e3f327a61f [IMP] *: add visual indicator for exception activities in list and kanban
The new visual indicator for exception activities has been added on all
corresponding kanban and list views.

A new filter "Exception Activities" has also been added in the
corresponding search views.

Task 1889379

closes odoo/odoo#31839

Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
2019-08-07 15:41:12 +00:00
Mitali Patel a54457e04d [IMP] mail: better exception activity handling in kanban and tree
The purpose of this task is to add a visual indicator on kanban and list
views when there is an exception activity on a record. To do so, two
fields have been added on the activity mixin that determine if the record
has an exception activity and its corresponding icon.

When there's an exception activity, the next activity icon is different
in the kanban and in the list view, the icon is displayed at the end of
the column with no label.

Prefetching all activity_type_ids in compute will allow to lessen
queries (3 query for this compute) and cache may benefit to other
mail.activity.mixin computed field, like activity_state in kanban view

Task 1889379
2019-08-07 15:41:05 +00:00
Mathieu Duckerts-Antoine 1e7f281070 [FIX] web: avoid graph flickering on firefox
The way in which graph tooltips were created and
positioned used to make the graph flicker on firefox.
This fix solves that problem by choosing a fixed initial
position for the tooltip before recompute it (when
the necessary information to choose a correct position
is available).

closes odoo/odoo#35552

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
2019-08-08 09:00:36 +00:00
Mathieu Duckerts-Antoine d925a4557a [IMP] web: default groupbys can be given a rank
Consider an action with a search view defined by the arch

<search>
<filter name="gb_foo" context="{'group_by':'foo'}"/>
<filter name="gb_bar" context="{'group_by':'bar'}"/>
</search>

If the action context is

{
search_defaults_gb_foo: true,
search_defaults_gb_bar: true,
}

the two groupbys will be activated at start but not necessarily in a suitable
order.

This commit allows to specify the order in which the default groupbys should be
activated by giving them a rank. For example

{
search_defaults_gb_foo: 2,
search_defaults_gb_bar: 1,
}

leads to group first by bar then by foo.
The rank number should be chosen between 1 and 99.

closes odoo/odoo#35538

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
2019-08-08 09:27:23 +00:00
Pragya Ladda f337496eba [REM] point_of_sale: Remove customised customer display feature
Purpose of this task is to remove the customization in the backend of the customer
display because feature allowing the customize the customer display is not
understandable as it is now and often broken.
Task-1944247
Closed- #34944

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-08-08 09:24:38 +00:00
Goaman 0eb0bede20 [IMP] account: auto install account_asset
Remove the settings that would previously install the account_asset and
account_deferred_revenue as they become automatically installed.

opw-2006605

closes odoo/odoo#35380

Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
2019-08-08 08:21:10 +00:00
Moisés López 9819d20688 [REF] l10n_mx: Remove MX fiscal position after odoo/enterprise#5038
closes odoo/odoo#35505

Signed-off-by: Josse Colpaert <jco@openerp.com>
2019-08-06 15:26:33 +00:00
mreficent 05cec95350 [FIX] purchase_product_matrix: wrong category
closes odoo/odoo#35543

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-08-07 16:06:12 +00:00
alexbclay d5e0b6ab45 [FIX] sale_stock: fix typo in field label
closes odoo/odoo#35507

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-08-07 12:57:20 +00:00
Alex Clay 7f6c71dfb5 [CLA] Signature for alexbclay 2019-08-07 12:57:12 +00:00
Martin Trigaux 85ee046b37 [IMP] *: use res.lang methods
get_installed and _lang_get_id are both ormcached and correctly check
the context

Retrieving a res.lang from a code is a frequent action that can be
achieved with _lang_get (cf previous commit).
Using _lang_get ensure the active_test in the context is correct and
is not poluted with another context propagation issue.
odoo/odoo#35490 discussion is an example of bad context propagation

closes odoo/odoo#35504

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-08-07 13:06:17 +00:00
Martin Trigaux f5cd483216 [IMP] base: no fallback on _lang_get_id
It was very misleading that
    self.env['res.lang']._lang_get('fr_FR')
used to return any language if fr_FR was not active or did not exited

There is a very frequent need to get a language from the code
There is rarely a need to get any language
2019-08-07 13:04:38 +00:00
Lucas Lefèvre 86dfe52eab [FIX] hr: Allow user to see fields in profile
Currently, a simple user no longer see fields protected
by groups in his profile.

When retreiving the view arch, `sudo()` is used to bypass
the group protection.
But since commit 1e6c3be, `.sudo()` no longer changes the user.
Hence, groups are still checked for the simple user.

To fix the problem, the view arch should be retrieved with
a user with all groups (SUPERUSER). This assumes that
SUPERUSER has effectively all groups.

closes odoo/odoo#35486

Signed-off-by: Romain Libert (rli) <rli@odoo.com>
2019-08-07 12:40:41 +00:00
Lucas Lefèvre 9419d171a8 [FIX] hr: Allow to access employee profile
The `private_email`, `last_check_in` and `last_check_in`
fields were added by e9d9898 to the
profile view but not in `SELF_READABLE_FIELDS`.
A simple user was therefore not able to read the field and
access his profile.

To avoid any similar oversight in the future, a test is added
to ensure a simple user is able to read all fields in
the profile view.
2019-08-07 12:37:52 +00:00
Simon Lejeune 58c14d0f9b [REF] stock_account: wording for additional layer
task-59011

closes odoo/odoo#35416

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-07 14:11:21 +00:00
Simon Lejeune b65d4d4ca0 [REF] stock, stock_account: no 'at date' on layers from picking
When accessing the stock valuation layers of a done picking through the
stat button "Valuation", do not display the inventory at date button. We
guard the visibility of this button through a context key named
"no_at_date".

task-59011
2019-08-07 14:11:21 +00:00
Simon Lejeune 90c055cd35 [REF] stock_landed_costs: create from vendor bill
Add a many2one on the landed cost to the vendor bill. Allow to create a
landed cost from a vendor bill if the product is a service. It will use
the price_subtotal of the account move line. Add a is_landed_costs_line
to separate products of landed costs on the account move line. It's a
checkbox. Ticking the checkbox will change the account of the account
move if the company is in anglo saxon accounting.

Tweak the accounts used by the landed costs so that everything is well
balanced (see the added tests). Auto reconcile AML when possible.

task-59011
2019-08-07 14:11:21 +00:00
Simon Lejeune 24bca8fd4a [REF] stock_landed_costs: landed cost special product
We remove the special views/actions/menuitems for the "landed cost type"
product. The user should now chose the split method on the landed costs
directly. We still keep the landed_cost_ok field that will be used in
the next commit integrating the landed costs with the vendor bill.

task-59011
2019-08-07 14:11:21 +00:00
Simon Lejeune 98f974cae3 [REF] stock_landed_costs: default journal id
Set a default journal on the company, use it on the landed costs form.
I was not able to directly set the value on the filed with a post init
hook because the stock journal is generated a while after the landed
costs installation in the l10n_generic_coa module.

task-59011
2019-08-07 14:11:21 +00:00
Simon Lejeune bc628b320d [REF] stock_landed_costs: usability changes
- update label for account_journal_id
- remove cost lines explanation
- label of the LC name
- remove former cost per unit
- auto compute cost line when validating
- rename former cost into original value
- remove additional landed cost form the tree view
- stock_landed_costs: rename cost line into additional costs
- add a final value field (Lucky day: the field I had to add was already
  defined but not used.)
- use monetary field
- make weight and volume optional
- journal entry visible only if posted
- landed costs wording in settings
- raise of no transfers are defined before validating

task-59011
2019-08-07 14:11:21 +00:00
Simon Lejeune b8f963a5e9 [REF] stock_landed_costs: cost and adjusment lines in a notebook
We do this in a separate commit so that the diff of the next ones will
still be readable.

task-59011
2019-08-07 14:11:21 +00:00
David Arnold aee0da7d53 [IMP] base: use en_US writing
While licence is technically correct, it is not used in America
Change only the label as the key is used at other places (e.g. app store)

closes odoo/odoo#35350

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-08-07 14:38:31 +00:00
Naglis Jonaitis 707f4673c7 [IMP] website_{event,forum,rating}: remove ignored attributes
Remove or move significant HTML attributes on <t> tags

`<t>` is not rendered, so we lose `class`, `role`, `itemprop`, `content`
etc. significant HTML attributes.

In other cases, the `<a>` tag can contain redundant HTML attributes,
which don't make sense (e.g. `href="#"`).

closes odoo/odoo#35391

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-08-07 12:31:32 +00:00
Robot Odoo 388b38af56 [ADD] sale/purchase : Product Matrix Configurator
This feature branch adds a new way to add products to SOs/POs: the grid (or matrix) entry.

When selecting a product template compatible with this mode, a dialog will open with a matrix of
available variants and a number input for each of those. Once all quantities are input, closing the
dialog will generate the lines for all the selected variants.

When more than 2 attributes are present, the matrix is organized by using the first attribute values
as X-coordinates and will then combine all other attribute combinations as Y-coordinates. This
allows to have potentially huge matrices, although this could be difficult to visually parse by users.

If the feature is enabled (the feature is installed independently in sale and/or purchase), this will be
the default entry mode for products in purchase orders when multiple variants are available - it's an
all or nothing situation. In sales orders, the product template can be configured to switch from the
product configurator mode (to select a single variant when adding the product) to the grid mode (to
select multiple variants at once).

The grid can be re-opened from an existing line (or by creating a new line with the same product)
and will repopulate with the current quantities of the order, allowing quick massive edition of the
complete set of lines for that product.

Task 1871560

closes odoo/odoo#34746

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-08-07 17:09:06 +02:00
Robot Odoo 33c3b4d67a [IMP] payment_authorize: integration with accept js
- Integrate authorize.net with new accept.js
- convert XML format requests to JSON

Task 2025821

closes odoo/odoo#34733

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-08-07 16:24:20 +02:00
Victor Feyens 3192419f64 [IMP] sale : consistent order for custom attributes values. 2019-08-07 12:50:09 +00:00