Issue:
The hr_referral application can not be installed with demo data.
Analyze:
The db is being auto locked. And transaction is not rollback due to the
xml failure.
Fix:
Add corresponding line into hr_demo.xml instead of hr_referral_demo.xml
Note:
It does not fix the root cause, but until the root cause is well defined
and fix, it is the best workaround.
Related ticket:
opw-3547638
Affected version:
16.0 and above
closesodoo/odoo#142928
X-original-commit: 436772ff0af5ae21043e4c0d60761c4f4149f7e7
Related: odoo/enterprise#51163
Signed-off-by: Benjamin Hanquin (beha) <beha@odoo.com>
Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
Steps to reproduce:
1. Create a database in demo mode with only Invoicing installed
2. Create a new company
3. Set any accounting localization package in Settings
4. Traceback because User doesn't have access rights on account.bank.statement
closesodoo/odoo#142915
Task-id: 3584244
X-original-commit: 7dd7fc9012a0738089c89a507dcd893e0ffdc09a
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Claire Bretton (clbr) <clbr@odoo.com>
Description:
Since 54857ec409 , the results of the
expensive recursive CTE on `res.partner` were never used. So the query
doesn't do anything at all, besides slowing down the whole process
for minutes on databases with a large volume of `res.partner` entries.
Fix:
Removing the dead code
Reference:
task-3601394
closesodoo/odoo#142914
X-original-commit: 29223533f625d579e424bdc133d0cfc472946b6b
Signed-off-by: Rémy Voet (ryv) <ryv@odoo.com>
Signed-off-by: Piryns Victor (pivi) <pivi@odoo.com>
Since the refactoring to owl, the stats in the left zone were not shown
anymore and the hover was missing.
This was because the method that fixes the xpath to match line by line
the qweb, was done on a getter and not on the data itself.
Now we replace in the prop value, from this way, in every place we use
the getter, we have fixed the data with the xpath.
/t/div -> /t[1]/div[1]
closesodoo/odoo#142912
X-original-commit: 2124057052255d86591b9f3345bf7e62fcd8d3b3
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Francois Georis (fge) <fge@odoo.com>
Before this commit, some tests of the SwitchCompanyMenu sometimes
failed:
- "companies can be logged in even if some toggled within delay"
- "can toggle multiple companies at once"
They failed because the debounce delay between the first click to
toggle a company and the moment the company service is notified to
actually select the companies was sometimes too short for the 2 or
3 clicks on the menu to toggle companies to occur, as those clicks
are separated by nextTick(), i.e. a mix of calls to setTimeout and
requestAnimationFrame.
In tests, we patch the debounce delay to 0 by default, and before
this commit we set a delay of 50 in the two faulty tests. This
commit fixes the issue by keeping the real delay in those tests (1s),
as they aim at testing the fact that the user has the time to do
multiple clicks before committing the company changes and reloading.
Fixes runbot error 29962
closesodoo/odoo#142904
X-original-commit: 2ec65691ac11cb4216d873dcab77a84e2c35ba17
Signed-off-by: Francois Georis (fge) <fge@odoo.com>
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
po_uom_id and uom_id should be from similar uom_group. It
was not the case by default using `'default_detailed_type': 'service'`.
This fix the issue
closesodoo/odoo#142887
X-original-commit: b557cc0831e2c6d0967c3d4420c1b89a0f5ce191
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
The test 'buttons with attr "special" in dialog close the dialog'
sometimes fail on runbot because it can't click on 'Create and edit...'
inside the many2one dropdown. Before this commit, the test edited
the many2one as follows:
1) edit input to write a new value (with editInput)
2) click on the input to open the dropdown
3) click on 'Create and edit...' in the input
But calling editInput opens the dropdown (even though the opening
is a bit debounced, which is why it only failed sometimes). So it
might happens, in rare cases, that the dropdown is already opened
when we click in the input (step 2), which closes it and makes
step 3 fail.
This commit changes the test to do something similar as what we do
in many2one_tests.js: we patch setTimeout to execute the callback
directly, and thus remove the opening delay. We call editInput
which triggers the opening of the dropdown, and we click inside
the dropdown.
Runbot issue 24739
closesodoo/odoo#142863
X-original-commit: 4a011149cba968585d5e74ee4f4fff7212c729e3
Signed-off-by: Francois Georis (fge) <fge@odoo.com>
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
When we save a many2one in a dialog opened by the external button, we
trigger a "read" of the "display_name" to update it if the changes made
in the dialog have had an impact on it.
Before this commit, the context used for this "read" was completely wrong,
it was an unevaluated string. This commit will therefore allow you to use
the evaluated context.
closesodoo/odoo#142862
X-original-commit: 7e9c8d41f5d035a00117198539ddebdbd8b4aa7c
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Francois Georis (fge) <fge@odoo.com>
Since commit 3d218e1, clicking outside
a popover closes the popover and performs a preventDefault on the event.
As a consequence, changes made in the property definition popover are no
longer applied when the popover is closed by clicking outside.
Problem:
The preventDefault has the consequence of cancelling the input change
event allowing the change to be applied to the property definition when
the popover is closed.
Solution:
Remove the preventDefault by default and only use it in the case of the
calendar view, which is the only use case that wants to prevent the click
event so as not to open a record creation dialog (see commit 3d218e1).
How to reproduce the PropertyField bug:
- Go to a form view with a properties field
- Click on the edit property button
- A popover opens so that you can edit the field definition
- Type a few characters in the label input
- Click outside the popover
Before this commit:
The value inserted in the popover is ignored
After this commit:
The value inserted in the popover is applied to the property.
It is not possible to write a test reproducing this native browser behaviour.
closesodoo/odoo#142842
Signed-off-by: Michaël Mattiello (mcm) <mcm@odoo.com>
Prior to this commit, the discount product was created at
the installation of the point_of_sale module which does not make sense
as this product is only used in the pos_discount module. We change this
in this commit to also prevent the discount product to be shown in the
frontend of the PoS when the user does not have the pos_discount module
installed and abling him to download demo data on the flight if he does
not have other products available.
closesodoo/odoo#142831
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
To reproduce:
1. on your windows computer, add a system environment variable with:
- Key: ODOO_RC
- Value: (path to any file except the `$INSTDIR\server\odoo.log`)
2. Install Odoo Windows version
Notice that the log are stored into the `$INSTDIR\server\odoo.log` file
3. Restart Odoo's service
=> Odoo's log file does not log anything anymore
Cause:
As odoo will use in priority the environment variable as the config file path.
This will save the config change into that file instead of the intended one at
`$INSTDIR\server\odoo.conf`.
Due to this, the config file remain the default one created by the previous commands
but the log_file information get save to the wrong config file.
On restart of the service, as the parameter is not present,
it does not log in the intended way
After this commit:
Logs are logged into the log file as intended
Was discovered accidentally while reviewing an IoT PR:
https://github.com/odoo/odoo/pull/137547closesodoo/odoo#142796
X-original-commit: bbd06814a7e42c22206087c0df1e06d14dbba74e
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
Signed-off-by: Loan Sens (lse) <lse@odoo.com>
Issue :
- When you check-in/out on a day of time off,
all the time is logged as extra hours.
- When you do the same on a public holiday, it's not.
_leave_intervals_batch is used to get all leave for an employee but
the domain for the search only find leaves related to given ressources.
Public Holiday Leaves are not related to any specific ressources
and thus where never found.
closesodoo/odoo#142728
Task-id: 3465686
X-original-commit: 8d7100d08ecabe72dc9aedb036d7908fcd7a35bb
Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
Steps to reproduce:
- Purchase -> Open any RFQ/PO.
- Click on the cell containing the "forecast" button, without clicking
on the button itself.
Following 28f2622, it will generate a traceback when clicking on a cell
list from a button column.
Since button columns don't have a `name`, no `record.fields` will match
and throw a traceback, as we try to access `type` from nothing.
closesodoo/odoo#142597
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Currently mounting an owl application using the Odoo web framework takes
a good bit of boilerplate. This is both annoying but also creates the
opportunity to misconfigure created applications. This commit exctracts
the application creation logic to a helper function which will make it
much easier to create Owl applications correctly.
task-3580007
closesodoo/odoo#142498
Related: odoo/documentation#6493
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Steps to reproduce
==================
- Enable the debug mode
- Use an odoo instance with the design-themes
- Click on the debug menu
- Click on Start tour
`OwlError: Got duplicate key in t-foreach: homepage`
Cause of the issue
==================
Website theme tours are registered here :
https://github.com/odoo/odoo/blob/5c01439cf20b2c0ca08d618df6f249617127e6d1/addons/website/static/src/js/tours/tour_utils.js#L348-L358
The saveAs option is used but since the owl refactor, it doesn't
override the previous tour.
There is a default homepage tour in the website addon and then one for
each theme.
There should only be one available at a time (same as in 16.2).
When selecting a new theme, the action button_choose_theme is called and
that ensures that only one theme can be installed at the same time.
opw-3595512
closesodoo/odoo#142350
X-original-commit: 69a361681c909cee5bf73a588dd4263bd49f1d5a
Related: odoo/design-themes#745
Signed-off-by: Francois Georis (fge) <fge@odoo.com>
Signed-off-by: Hubert Van De Walle <huvw@odoo.com>
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
If we have an analytic plan without analytic accounts, but with
subplans that do have analytic accounts, we do want them to
appear in the widget.
Also changed a search in a loop to a read_group
closesodoo/odoo#142222
Signed-off-by: William André (wan) <wan@odoo.com>
Before this commit, the width of the cells for many2many_tags was often
too small, so the tags were truncated. (e.g.: the tax_id column on the
sale order lines on the form view of the sale order)
After this commit, the column has a min-width of 150px
closesodoo/odoo#141415
Task-id: 3581756
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
This commit modifies the functioning of `ODOO.PIVOT.TABLE` formula when the
boolean `includeTotal` is set to 'false'.
Earlier, total values of both row and column were not displayed in this case.
But now, if a groupby is not applied on any of the two dimensions, it displays
total values of the dimension on which groupby has been applied.
Otherwise the formula serves no purpose since it doesn't display any
data.
For example, one row groupby and zero column groupbys are applied on pivot:
The formula `=ODOO.PIVOT.TABLE(1,,false)` would display all cells of pivot
(including the row totals), except the last row (i.e. the column total).
Task ID : 3580623
closesodoo/odoo#140970
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Before this commit, validating an order with the l10n_sa_pos module
installed resulted in a blank screen. Additionally, there was an issue
with the display of receipts when no rounding was applied.
opw-3594564
closesodoo/odoo#142510
Signed-off-by: Vlad Stroia (vlst) <vlst@odoo.com>
There was a condition in the `isBlock` util meant to bypass
`getComputedStyle` in the case that a node was not in the DOM. Rather
than doing that however, it was bypassing it in every case where the
node was in a document that was different from that of the window.
closesodoo/odoo#142803
X-original-commit: 04a9e97603806cb21cd90d991c0f94a225c326c5
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Link zws should not be applied on links that contain blocks so as to
avoid unfortunate side effects of zws on the dimensions of the link.
task-3596919
X-original-commit: 656fc7ca4d19311c679f6f3d3df6a4ea7e57c15c
Part-of: odoo/odoo#142803
Before this commit, the "add reaction" button was available even when
the thread is not persisted. This is wrong since those messages are only
temporary thus not known by the server: a crash would occur when trying
to add a reaction to such messages.
This commit disables reactions for temporary messages.
Steps to reproduce the issue:
- Go to the `/contactus` page
- Open a chat with the welcome bot
- Try to add a reaction to its first message
- An error modal appears
task-3603577
closesodoo/odoo#142718
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
If user tried to apply promotion that was targeting specific product
on a product that was 0 price, it would cause an error. Now discount
is no longer applied on free products.
opw-3562218
closesodoo/odoo#142724
X-original-commit: 2b8d580a8c081cdb57d6f08de106c4d7b1b4bb40
Signed-off-by: anko-odoo <anko@odoo.com>
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Customer should do it in two steps if that's really what they want to do.
This custom log was mainly intended to follow quantity changes on confirmed
orders, but it's plain wrong if the product is changed at the same time.
opw-3432715
closesodoo/odoo#142610
X-original-commit: dd526d049be27ac4852ac0eeaca04c3a2a36c39b
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
To reproduce the bug:
- create an accrual allocation with the seniority plan
- set the start date way in the past like in 2000
- validate the allocation
- go on the dashboard, the accrued amount should be broken
when setting the balance on a future date
- additional days accrued if the cron is run
Fix:
nextcall being unset upon creation by default, the allocation
would consider the start of the second level as the nextcall if
the allocation is created in the past. This commits sets nextcall
to a correct value if the lastcall is set in the past upon creation.
closesodoo/odoo#141006
Signed-off-by: Bertrand Dossogne (bedo) <bedo@odoo.com>
Steps to reproduce: (for small devices)
- install the sales app
- activate discounts in the sale setting
- create a sale order and add the product
- click on the discount button and check the pop-up
The full text cannot be displayed in one line due to the lack of space.
So, providing sufficient space for displaying the entire text
of the radio button in a single line.
task-3568058
closesodoo/odoo#140612
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
…vatar issue
Description of the issue/feature this PR addresses:
In project.task timesheet notebook mobile view, the alignment between employee
name and avatar is not proper. Name is display slightly down than to avatar.
Current behavior before PR:
Alignment is not proper between name and avatar.
Desired behavior after PR is merged:
Alignment is proper between name and avatar.
Fix:
add d-flex class in outer div of name and avatar so that both name and avatar
should display in same horizontal alignment.
task-32779779
closesodoo/odoo#142779
X-orignal-commit: d998f64a768cb0d00bb1df1543ae1bcb0cf273ff
X-original-commit: 967b2430308ce36d5e3de1fa22843d2665c8723a
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Steps to reproduce:
- Install Accounting and l10n_ch
- Switch to a Swiss company
- Go to Settings and make sure that DIN5008 is selected as Document Layout
- Go to Accounting settings and activate "QR Codes" option
- Create an invoice for an Swiss contact
- Print the invoice
=> The DIN5008 header is appearing on the QR code page.
No header should appear on the QR code page with DIN5008.
opw-3529963
closesodoo/odoo#142778
X-original-commit: c0511e88cf71fb99c6b43d7a2646e6c291e4b062
Signed-off-by: Olivier Colson (oco) <oco@odoo.com>
Signed-off-by: Anh Thao Pham (pta) <pta@odoo.com>
This commit adapts some steps to correctly select the elements as
before because some selectors no longer work due to changes done
in Framework JS code (web module).
closesodoo/odoo#142746
X-original-commit: 02bf97b44c76bd22a813e184bc5c42ab9716280f
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Steps:
- Open Field Service
- Go to gantt view
- Create new task
- Leave the title and customer field empty
- Save the form dialog
Issue:
- The customer required notification show in the gantt view instead of form view
dialog.
Cause:
- When we save the form 'saveRecord' method triggered and this doesn't return
anything.
Fix:
- Add the return statement in 'saveRecord' method.
task-3502839
closesodoo/odoo#142698
X-original-commit: e7d999429dcf91501b0803d32639a181277cb5f0
Signed-off-by: Francois Georis (fge) <fge@odoo.com>
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Steps to reproduce:
- Install the Events module
- Go to the General Settings and add French translation and make sure to check the website 1 option
- Go to the Events module and select an event
- Click on Go To Website smart button on the right top corner
- On the event page, Change the language and notice the start and end date format
Investigation
- The bug is more present in version 16.0 and above. This version has just small issue with formatting since the day and the rest of the date were separate block.
- By Using the option format: ‘full’, the date can be formatted correctly depending on the language used
opw-3569167
closesodoo/odoo#142425
Signed-off-by: Adrien Widart (awt) <awt@odoo.com>
Signed-off-by: Ali Hassan Youssef (alhy) <alhy@odoo.com>
Completely rewrite the 3 scroll hooks into a unified version that
doesn't have conflicting and overriding conditions.
- re-apply scroll (bottom in particular) when images are loaded
- restore auto-scrolling to newly posted message
- don't do any scroll save/restore before the thread is loaded
- don't snapshot before the thread is loaded
- don't snapshot after patch
- fix condition for detecting when to restore snapshot
- don't apply scroll multiple times for highlight
Follow up of https://github.com/odoo/odoo/pull/141999/
Only breaking after https://github.com/odoo/odoo/pull/136539
Also follow-up fix of https://github.com/odoo/odoo/pull/127889/
runbot-39172
closesodoo/odoo#142308
Related: odoo/enterprise#50931
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Prior to this commit, the positioning of the checkmark in the project
task state dropdown was slightly off, not optimally aligned.
This commit solves this alignment.
task-3575446
closesodoo/odoo#142725
X-original-commit: 539f156d480473cfd8bf31ed10aea427248fa3fc
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Avoid getting the following warning when validating an XRechnung on
https://erechnungsvalidator.service-bw.de/ :
"[BR-DE-21] Das Element "Specification identifier" (BT-24) soll
syntaktisch der Kennung des Standards XRechnung entsprechen."
issue-142127
closesodoo/odoo#142716
X-original-commit: 82d05070d1199a035d93f155580fbef5786dc030
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Signed-off-by: Julien Van Roy (juvr) <juvr@odoo.com>
cancel their SO
Steps:
Sales user (no purchasing permissions) create SO and confirm it, then
cancel it
Issue:
Sales user cannot cancel their SO without permissions in the purchasing
Analyze:
Because the method `_compute_display_purchase_orders_alert` has a read
the SO's purchase_order_count, it causes an error
Fix:
Add a group on the field to not display it in the view instead. Anyway
if the user doesn't have the right to correct it, he will probably just
ignore the warning and another mechanism should exist to warn the
purchase representative.
closesodoo/odoo#142602
X-original-commit: 77a614d63c64a075db009d8c3acaf19db0fc7cd0
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
When a product has been unbuilt and also (mistakenly) scrapped, it's
impossible to reuse the serial number in production again, even if the
product is unscrapped.
This fixes the sanity check in a similar way to the _check_sn_uniqueness
function, not just checking for removed stock move lines, but also unremoved
stock move lines. A test case is also added to check this scenario.
This is a similar fix to a previous commit we did
(4f07b260807053586ac6c01cf92ac3d5e37b1041) where we bumped into a
problem with the duplicate serial sanity check.
closesodoo/odoo#142574
X-original-commit: 1761b95d9fda5d5355f35effd1f345a25ded1197
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Before this commit, the user got a traceback saying:
```txt
TypeError: Cannot read properties of undefined (reading 'apply')
at EventAdditionalTourSteps._get_website_event_steps
```
the reason of that issue is because a [recent generic change reviews](#125716)
`patch` function and so `this._super` no longer exists and has to be
replace by `super` as we extend a method of a class extended.
This commit adapts the additional steps adding via `patch` function
to be able to add those steps and start the tour as expected.
closesodoo/odoo#142653
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
OpenPeppol released a new extension of its BIS 3 format for
international use: PINT BIS Billing. It serves as a base for per-country
specialization, while keeping a standard core for data being used across
countries. This is not meant to be used directly, but rather to be
extended by country-specific modules.
Japan has implementated PINT and published its specific rules:
https://docs.peppol.eu/poac/jp/pint-jp. A new module is created to add
this format.
task-3469718
closesodoo/odoo#136025
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Follow-up of https://github.com/odoo/odoo/pull/134277
This reverts commit 91b80fbb5c as it adds some unwanted visual
effect. In other words, the "block UI" is never unblocked when some
actions are triggered. this is specific to the mobile app when the
URL is outside of the webview scope ("/web" or "/pos"). Even if
the target is self, the mobile app forces a new tab because opening
something else that the backend in the webview could disturb users.
Steps to reproduce:
- Open "Field Service"
- Choose a task and start it
- Stop it and confirm time spent
- Sign report
=> A new tab is openened in the mobile app and the block UI is
never unblock in the app.
To fix this, we simply decided to avoid to use the block UI for
act_url actions. this is consistent with what we did previously:
See https://github.com/odoo/odoo/commit/ebe64aafacec8eaa69a5a1781fc159ff77bc884a
We will only use `BlockUI` when really necessary and not by default.
Note that this commit will also remove the block UI when you do
some operations on apps like installing it. For now, we consider
that is OK. This means that the user will be able to continue his
work during installation. Also note that if the user navigates to
another application during the process, the page will not be refreshed
at the end. He will have to do it himself by pressing "F5" to be able
to see the app in the home menu.
In the future, the idea should be to better notify the user at the end
of this king of background operations but we will see...
closesodoo/odoo#142656
Signed-off-by: Romain Estievenart (res) <res@odoo.com>
Steps to reproduce the bug:
- Create a storable product with two attribute “P1”:
- Color: Red and Blue
- Create a BoM:
- Product template: P1
- BoM lines:
- C1: 1 unit -> apply on variant P1 red
- C2: 1 unit -> apply on variant P1 blue
- Create a MO:
- 1 unit of P1 red
- Only the component C1 is added, which is correct.
- Change the product to P1 blue.
Problem:
The C1 component is not removed because to clear the move_raw_id,
we only check if the BoM is changed. However, in this case, it doesn't
change.
opw-3591800
closesodoo/odoo#142631
X-original-commit: 2a31cdb67338dd065b1aeb2d5e8c57724e8af236
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Djamel Touati (otd) <otd@odoo.com>
Issue:
======
When choosing product with attributes that have attributes which have
variant creation mode never it will not take into account the extra
price.
Steps to reproduce the issue:
=============================
- Install pos , restaurant
- Create a product which have `Size` attribute and add some values in
it, 'S' and 'M' for example , then add extra prices in each one of
them. Enable available in POS setting in Sales page of the product.
- Got to point of sala , click on 3 dots in restaurant and open mobile
menu.
- Added the created product to cart and click review.
- The price shown is the original price of the product and not taking
into account the extra price of the attribute.
Origin of the issue:
====================
This was not supported before
Solution:
=========
Using the attribute_value_ids value in the line we can calculate the
extra_price of those attributes and add it to the price_unit so we can
get taxed_amount and untaxed_amount correctly.
opw-3511374
closesodoo/odoo#142485
X-original-commit: a54fddd9270b3431a8cde0a6bf30349c5671b0ac
Signed-off-by: David Monnom (moda) <moda@odoo.com>
Signed-off-by: Mahdi Cheikh Rouhou (macr) <macr@odoo.com>
Steps:
- Open Projects
- Go to Tasks
- Create a SOL on the fly
- Create a new product on the fly (click on 'create', not on 'create and edit')
- There is a field for delivered quantity which is editable
Issue:
-The 'delivered quantity' is editable when it shouldn't be. It should only be
editable when Invoice policy is Based on Delivered quantity.
Cause:
- The readonly attribute was only given when delivered_quantity method is not manual.
Fix:
- By making delivered quantity field readonly for project task form view.
Task-3522113
closesodoo/odoo#142348
X-original-commit: 0b5d197e0690e49948b848b2addffeb0e57b5db7
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Co-authored-by: Prakash Prajapati <ppr@odoo.com>
In Odoo, incoming contracts are defined as having state == 'draft' and
kanban_state == 'done'.
Currently, the employee contract calendars are synced when incoming
contracts are created, and incoming contracts' calendars are changed.
However, in many cases the incoming contracts are made for the future
and do not reflect the current employee's working schedule. This causes
there to be a calendar mismatch whenever incoming contracts are
created/updated, despite being set only for the future.
This fix checks the contracts_count field on the employee before
syncing the calendar, since the only time an incoming contract should
reflect the *current* calendar is if it's the only contract for the
employee.
closesodoo/odoo#142142
X-original-commit: 885f554c80028539415c294120c379ded33cd9ae
Signed-off-by: Bertrand Dossogne (bedo) <bedo@odoo.com>
Steps to reproduce:
-------------------
- create several product categories on the ecommerce;
- do not add products to these categories
- go on a category;
- go on an other category;
Issue:
------
The message is the same for both categories:
```
No product defined in category "First Category".
```
Cause:
------
When we go to the first category, the template is cached
according to the existing `t-cache` key containing the products.
In this case, we have no products.
When we go to the second category, which has no products,
the current `t-cache` key doesn't detect changes and therefore
uses the cached template from the first category.
Solution:
---------
Remove the category name because adding `category` to existing
`t-cache` key to detect a difference between categories
that may have the same t-cache key would add
complexity to the key and have a cost in terms of performance.
opw-3572953
closesodoo/odoo#142595
X-original-commit: b1eba0972de2adbfcc0b6fe40252db5a7fcf74f9
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Signed-off-by: Thomas Lefebvre (thle) <thle@odoo.com>
Benjamin Hanquin (beha)