Commit Graph
120953 Commits
Author SHA1 Message Date
Denis Ledoux e48767fe65 [FIX] mass_mailing: force to not use a template for the rendering
If the user configures a default `template_id` for
the `mail.compose.message`,
this template was used by the mass mailing to render the email,
and, among others,
it therefore used the `email_to` of this email template,
to render the recipients,
and it was configured empty or something else than `object.id`,
it did not used the `active_ids` passed in the context to the
`mail.compose.message` `create` call to compute the correct
recipients

To reproduce:
 - In developer mode (?debug)
 - Open the full mail compose message
   e.g. in app sales, open a so, hit new message,
   and hit the button to open the full message composer
 - Set the template to the quotation template is not there already
 - In the debug menu of the dialog, View > Set defaults,
 - Click the radio button to all users, and the default to Use template = ...
 - Then, try to send a mass mailing. It will fail because it cannot
   compute the `email_to` values correctly because the `email_to`
   of the quotation template is empty.

opw-1840287
2018-05-14 16:48:20 +02:00
Christophe Simonis e70e5b6cf3 [MERGE] forward port branch 11.0 up to 2787de8c68 2018-05-14 16:46:11 +02:00
Christophe Simonis 2787de8c68 Revert "[FIX] web_editor: adapt test"
Was weirdly working in browser...

This reverts commit fb18de745c.
2018-05-14 15:55:53 +02:00
Christophe Simonis fb18de745c [FIX] web_editor: adapt test 2018-05-14 15:12:16 +02:00
Christophe Simonis b44c34865b [FIX] web_editor: correct js code.
Oversight of previous forward-port
2018-05-14 15:10:09 +02:00
Goffin Simon 1265839a07 [FIX] sale: Down payment in multi company
When creating a product "down payment" in multi company in function "create_invoices"
of the model "sale.advance.payment.inv", a default company was set on this product
and it could lead to access rights error when trying to invoice a SO from an other
company.

NB: The down payment product must be shared with all the companies, as this is
the only one that you can set in the ir.config_parameter.

opw:1841468
2018-05-14 14:44:31 +02:00
Christophe Simonis bd2de7ae78 [MERGE] forward port branch saas-15 up to d818b516c1 2018-05-14 14:37:08 +02:00
Nicolas Martinelli f88a05d18e [FIX] website_sale: do not copy last SO
- Create u1 as a portal user
- Connect as u1, add products to the cart
- Duplicate u1 (e.g. u2)
- Connect as u2

u2 retrieves the cart of u1.

opw-1847328
2018-05-14 13:35:49 +02:00
Denis Ledoux 5603b778f6 [FIX] point_of_sale: automatic selection of customer pricelist
When changing the customer to a customer with a different pricelist
than the pos default, the customer pricelist was not automatically selected.

This is because of an oversight in the below revision:
f76cc095b8

opw-1843709
fixes #24611
2018-05-14 12:45:52 +02:00
Christophe Simonis d818b516c1 [MERGE] forward port branch saas-14 up to 5274a62037 2018-05-14 12:28:37 +02:00
Raphael Collet 7f27992998 [FIX] fields: convert selection value to int
When a string value is assigned to a selection field expecting integers, the
value simply rejected.  In such a case, convert the value to an integer before
validating it.
2018-05-14 12:08:59 +02:00
len-odoo 8adb11a529 [FIX] calendar: fix recurring events rrule definition
Some versions of the datutil library crash when a 'Z' (specifying 'Zulu' time)
is appended at the end of an rrule.
This is because they decided to be stricter when comparing timezone aware/naive
datetimes with rrules.
This bug appears when trying to create a recurring event on the calendar,
defined with an "until" (a certain date) rule.
We explicitly add the timezone information if the 'Z' is in the rrule.

We also remove the rrule ffield from the view, since it is not used and could
only interfere with the logic of the rrule creation.

related to commit 35a4263f0a

opw 1841761
2018-05-14 12:08:28 +02:00
Christophe Simonis 5274a62037 [MERGE] forward port branch 10.0 up to 7b1362ac55 2018-05-14 11:51:18 +02:00
Thibault Delavallée 6639a6e74d [FIX] fleet: fix traceback when going to vehicle activities from systray
Default group by is required in order to correctly display a kanban view on
vehicles.

By the way activities fitlers were missing. This commit adds them.

This commit is related to a recent commit adding activities in fleet, see
7356c3b5b6 for more details.
2018-05-14 11:37:41 +02:00
Nicolas Martinelli 3579bd53be [FIX] hr_expense: account on expense
- Set a specific expense account on an expense product
- Send an email to the expense alias

The specific expense account is not used; a default account is used
instead.

opw-1838174
2018-05-14 11:37:32 +02:00
Christophe Simonis 7b1362ac55 [MERGE] forward port branch 9.0 up to 1dae7ea1d6 2018-05-14 11:29:57 +02:00
Nicolas Lempereur 5bb7ffa20e [FIX] web_editor: ignore range error on Restricted
In firefox, if we have a range on eg.:

  `<input type="file">`

and we tabulate to get to it, we have the range over:

  `<button type="button" tabindex="0">Browse…</button>`

which seems to be a "virtual" element inside the `<input/>` but this
magic element is "Restricted" and causes error such as:

  `Permission denied to access property "nodeName"`

So this fix ignore errors when getting a range from current selection on
keyup.

opw-1819279
closes #24524
2018-05-14 11:16:20 +02:00
Christophe Simonis aa7088bf0e [FIX] stock: correct tests 2018-05-14 11:14:20 +02:00
Thibault Delavallée 78c457e563 [IMP] mail: rename Todo activity into To Do
It seems better for people. . Related to task #1825295.
2018-05-14 10:40:51 +02:00
eco-odoo b19b9e756c [FIX] web: click on <a> with type="action" triggers the correct action
Without this fix, clicks on <a> with a sub html tag do not work.
2018-05-14 09:44:16 +02:00
Lucas Perais (lpe) 3416d4a798 [FIX] point_of_sale: user on invoice same as on order
Open a pos session with a user A
Change cashier to user B

Make an order with invoice

Before this commit, the salesman of the order was user B
but the salesman on the invoice was A

After this commit, both invoice and order have user B as salesman

OPW 1844175
closes #24642
2018-05-14 09:27:09 +02:00
Lucas Perais (lpe) 3a09c06f8c [FIX] point_of_sale: sale details report should display the internal ref of products
It seems that in v8 the internal reference (the code) of the product
was displayed in the sales details report of the pos

This commit put that field back on the report

OPW 1844776
closes #24641
2018-05-14 09:23:11 +02:00
Odoo Translation Bot 29207defbc [I18N] Update translation terms from Transifex 2018-05-13 07:04:36 +02:00
Odoo Translation Bot 2cd730998b [I18N] Update translation terms from Transifex 2018-05-13 04:12:31 +02:00
Odoo Translation Bot bc54fc47bd [I18N] Update translation terms from Transifex 2018-05-13 00:25:38 +02:00
Kishan Gajjar c1f04bef83 [IMP] hr_timesheet: make it easier to encode timesheets
In this commit, we do two small changes to make it easier to encode
timesheets.  The main issue is that we want to solve the following
situation: a user clicks on a cell in a timesheet grid view to open a
list view, then clicks on 'Create' to create a new timesheet. This will
open a form view, but some fields which could be prefilled are not
filled.

- do not reset task_id in some cases. This is important for the onchange
  call which comes after a default_get, when there is a default project
value set.
- do not set employee_id if there is default_employee_id in context
  This is useful when we open timesheets from the 'All Timesheets'
menu item, then add a new line, select a different employee, and open it
in the grid view (by clicking on the + icon from a cell).  This opens a
list view, which is editable, but when we create a new entry, it ignores
the employee value.

Note: a commit in enterprise adds support for properly passing contexts
in grid view, see
https://github.com/odoo/enterprise/commit/f23003917f18b52bb69483cdaac3cb2164230aa6

Task: #35414
2018-05-11 16:19:26 +02:00
Fabien Meghazi 02deb4a662 [FIX] server: fix typo introduced in 9ffb51e1c2 2018-05-11 15:42:29 +02:00
Viral Thakar d1c731e88c [IMP] pad: add mobile support for pad widget
In mobile devices, the pad widget did not behave in a satisfactory
manner.  Also, once it was in fullscreen mode, it was not possible to
come back to normal mode.

Task: #31545
PR: #15817
2018-05-11 14:36:57 +02:00
Nicolas Martinelli af41ab8010 [FIX] payment_adyen: bytes/str comparison
When returning from the Adyen payment website, SHA signature check fails
because of an inconsistent bytes vs string comparison. This is due to
`base64.b64encode` returning bytes in P3.

opw-1841103
2018-05-11 13:41:22 +02:00
Nicolas Martinelli 3c61cd0992 [FIX] sale_timesheet: set company currency
Make sure the compoany currency is USD, otherwise the tests fail.

opw-1841170
2018-05-11 13:34:46 +02:00
Nicolas Martinelli ed9dbffe07 [FIX] sale: All Channels Sales Orders
The 'All Channels Sales Orders' report should filter out canceled
orders.

opw-1839938
2018-05-11 13:32:48 +02:00
Nicolas Martinelli c9bdda2c68 [FIX] account: display negative value in portal
The residual amount of a customer invoice or a credit note is displayed
in the same way in the portal view. This can be confusing for the end
user since there is no way to distinguish both.

We display the residual amount as negative in case of a credit note.

opw-1841432
2018-05-11 13:30:04 +02:00
Nicolas Martinelli 9a450ac162 [FIX] account_payment: prevent payment of credit note
A credit note is not supposed to be paid by the customer, so do not
display the payment button in the portal view.

opw-1841432
2018-05-11 13:30:04 +02:00
Yoshi Tashiro c6df2fb1d7 [FIX] sale: Remove outdated comments
The comment "Note that once a Quotation becomes a Sales Order, it will be moved from
the Quotations list to the Sales Order list" isoutdated since 10.0 - sales
orders are also visible in the quotation list.
2018-05-11 12:02:28 +02:00
Ray Carnes 7ee2bfce9f [IMP] google_spreadsheet: Add widget="url" to the URL field on tree view
Users can now click this field, instead of having Odoo open the Form View to click it.

Benefits:
1. Saves the user from clicking TWICE (they only have to click ONCE with this PR)
2. Keeps the list view of all spreadsheets open (user has to GO BACK to see the list without this PR)
2018-05-11 11:55:05 +02:00
David f236b095cb [IMP] membership: Always display associate_member on members tree views
Whatever the state of the association the associate_member is
relevant in order to follow where the membership status of the partner
comes from.
2018-05-11 11:50:47 +02:00
Swapnesh Shah e293cdafb1 [IMP] project: Display tasks label on rating stat button
Added label_tasks in task form view for rating

closes #22895
2018-05-11 11:43:00 +02:00
Fabien Meghazi 9ffb51e1c2 [IMP] server: improve logging for ThreadedServer#server_bind 2018-05-11 11:37:16 +02:00
Nicolas Lempereur 1dae7ea1d6 [FIX] web_editor: inline space in source code
Backport of 57f7c68106
2018-05-11 11:06:05 +02:00
Jeremy Kersten 1fe1e51dd2 [IMP] website_event: add tooltip to explain online event.
opw-1845012
2018-05-11 09:56:16 +02:00
stefanorigano 9d0e0e9787 [FIX] *_portal: nav in title
Adapt modules' portal navbars according to ba38d22
2018-05-11 09:56:11 +02:00
stefanorigano ba38d22f9d [FIX] portal: nav in title
The commit fix an issue causing the portal navbar to overlap/inherit wrong style in customised websites.

The previous layout used to add the entire portal navbar inside an <h3>, causing inner elements to inherit the titles style.
According to WC3 standards, titles can have phrasing content only.
Titles reference > https://w3c.github.io/html-reference/h3.html
Phrasing content reference > https://w3c.github.io/html-reference/common-models.html#common.elem.phrasing

By chance this issue was not visible on runbot, but was severely affecting our website and probably clients ones too.
This commit wrap the portal navbar in a standard bootstrap navbar structure, fixing the title issue and provinding some imp. too:

- Search is now available for mobile
- Modules can inject a custom/botstrap class (eg. navbar-default) ot customize design if needed
2018-05-11 09:47:09 +02:00
len-odoo 6c6c4b89a0 [FIX] mail: parse eml/msg attachments
When parsing an email with some eml or dmg attachment, the parsing would
generate an attachment with empty content.
Since this content is later encoded in base64, it would crash trying to encode
None.
We simply do not process attachments without content.

We add a test to check that parsing mail with some empty attachment doesn't
crash, since the crash implies that the mail gets stuck on server
and is never fully processed by Odoo.

opw 1814014
2018-05-09 16:49:34 +02:00
Christophe Simonis 79cfc85b91 [FIX] stock: correct model name in new test 2018-05-09 16:47:14 +02:00
Goffin Simon dff1e96ed3 [FIX] purchase: Wrong property fields in multicompany
Steps to reproduce the bug:
- Enable multi companies and multi-currencies
- Multi company: Your Company and Test
- Users: Admin and Demo
- Login as admin user with the current company: Your Company
    - Allowed companies: Your Company, Test
- Login as Demo user with the current company: Test
    - Allowed companies: Test
- From the admin user with the current company: Test, do the following configuration in the product,
   - product: iPad mini, select vendor: Delta PC with price $100 with company: test, currency: USD
- Change the admin's company from Test to Your Company, do the following configuration in the vendor,
   - vendor: Delta PC, set supplier currency: EUR and payment terms: 30 Daya Net Payment
- Log in with the demo user
- Create SO for that product by selecting routes: Make to order and Confirm it.
- Open the PO which is generated from this SO

Bug:

The Currency and payment terms were set with the data set for Your Company

Excpected behavior:

Nothing is set for supplier currency and Payment terms as nothing is set for the company: Test

Closes #24564
opw:1841379
2018-05-09 16:21:23 +02:00
Goffin Simon 475027b988 [FIX] point_of_sale: Set the correct cashier
After reopening the session in the POS by another user,
the cashier was not correctly identified.

Back-port of this commit: a9caef0ebb

opw:784422
2018-05-09 16:06:51 +02:00
Christophe Simonis 5a751fa200 [MERGE] forward port branch saas-11.2 up to aae54ecc15 2018-05-09 15:45:20 +02:00
Josse Colpaert 0ca60a8d01 [FIX] delivery: delivery with carrier but not linked to so
When a delivery with free_over=True was not linked to a SO, it raised
an error.

opw:1843829
2018-05-09 15:39:34 +02:00
Romain Derie b65cb86697 [IMP] website: remove page creation in menu manager + menu container
This commit:
1. removed the possibility to create page from the menu manager.
   The usability of this feature wasn't great since create menu as a new page
   would redirect to that newly created page without saving the menu manager
   state.
   Plus, there is already the 'NEW' button on the navbar to create a new page,
   the menu manager should, as its name hint, only manage menus.
2. Handle a new case (officially at least) of menu: menu container.
   Those menu are simply menus with '#' as URL. It will be usefull to create a
   menu as a dropdown list container.
   Note: We should take care of a menu's URL being updated to '#' to avoid the
         menu's page URL to be also edited to '#'.

opw-1825883 & opw-1824263
2018-05-09 15:38:58 +02:00
Christophe Simonis aae54ecc15 [FIX] test_mail: bump expected query count 2018-05-09 14:51:11 +02:00