Commit Graph
102002 Commits
Author SHA1 Message Date
Goffin Simon a082ec6aea [FIX] sale: Expenses in multi currency
Steps to reproduce:

-Set your company in USD
-Create a SaleOrder with a pricelist in EUR
-Create an expense in USD, with the analytic account of the SO
-Confirm the expense and post journal entries.

Bug:

The unit price of the new SO line was wrong: it was stil in USD as in
the expense.

Expected behavior:

The price unit must be converted in EUR

opw:682378
2016-07-07 11:31:54 +02:00
Nicolas Martinelli a1c3fe1291 [FIX] crm: opportunities list view
When the lead step is activated (`group_use_lead` is true), 2 dinstinct
tree views can be selected to display the opportunities.

Indeed, when the action "Your Pipeline" is selected, the tree view
`crm_case_tree_view_oppor` is displayed thanks to the method
`action_your_pipeline`. However, when the page is reloaded or the tree
view is saved in the custom dashboard, the tree view
`crm_case_tree_view_leads` is selected instead.

The fix is to specify explicitly in the action which view should be
chosen, accordingly to what is done in method `action_your_pipeline`.

opw-681488
opw-681734
2016-07-06 17:25:15 +02:00
Goffin Simon d98eb32272 Revert "[FIX] product, website_sale: order by sequence product.template"
This reverts commit 0a13e5cb8e.

Changing the order of the products in stable version is not accepted.
2016-07-06 17:03:18 +02:00
Goffin Simon 0a13e5cb8e [FIX] product, website_sale: order by sequence product.template
The product.template must be ordered first by sequence if website_sale
is not installed.

opw:682395
2016-07-06 14:00:31 +02:00
Martin Trigaux 70011137ff [I18N] mrp: export terms for the new report 2016-07-06 10:34:30 +02:00
Josse Colpaert f719d76fed [ADD] BoM price report
In v8, we had a BoM price report in xsl format which was removed in v9.

As it is still needed, we added a report in the new qweb format, but this
time it is on the BoM instead of the product variant.

It also makes sense to have a similar report for v10 as the cost structure report
on the mo is for the real cost and not the standard cost.
2016-07-06 10:34:29 +02:00
qdp-odoo 3f3c30887c [FIX] account: bank statement reconciliation speed improvement.
Removed assertion statement that was making a useless browse on account.move. This single patch is enough to divide by 4 the time of preprocessing a bank statement when opening its reconciliation widget.

That removed assertion is now a supposed prerequisite when calling the function and should be tested first (on batch of records).
2016-07-06 09:55:28 +02:00
Denis Ledoux 489ea42859 [FIX] web: parsing of date with abbreviated month/day
When using the abbreviated month in the language
date format (`%b`),
e.g. `%d %b %Y`
in some languages, the parsing of the date
from this format to the database format (YYYY-mm-dd)
failed because of a dot `.` added from time to time
to the end of the abbreviated name
e.g., in French, `5 juil. 2016`

This is a bug of `moment.js` < 2.13.0,
handling badly this dot.
This is solved from `moment.js` 2.13.0,
thanks to the below revision
moment/moment@41fdb58572
moment/moment#3078

Unfortunately, we cannot update this library to its latest
release in stable release of Odoo (e.g. 9.0),
as this is seen as an unstable change
(if some API changes occured in the given library)

Instead, if the parsing of the date fails with the
strict mode (meaning the date must respect the format
exactly), we perform a second pass without the strict mode,
so this dot will be ignored,
and the date can be correctly parsed.

The issue can be reproduced by loading the French language,
and setting `%d %b %Y` as date format, and then performing
an advanced search on a date field. The value of the date
in the advanced search will be empty without this revision
(for the months having more than 4 chars,
other than `mars`, `mai`, `juin`, `aout`).

Fixes #11854
opw-682534
2016-07-05 18:04:22 +02:00
Josse Colpaert 3de53fa165 [FIX] stock: no rereservation needed in a lot of cases and make sure the moves passed to action_done are those from the recomputation
It is possible (in very rare cases) on rereservation that the new reservation will trigger other stock moves
than the first reservation.  In order to be sure to send the correct stock moves involved to done, it is better
to do the rereservation before the splitting of the moves on the total picking.

Also rereserve is optimized as it should only reserve for what is given by the pack operations,
as the backorder will be reserved later on anyways.
2016-07-05 17:26:06 +02:00
Damien Bouvy 60a7678b9d [FIX] sales_team: context-defined default should have priority
If you are in a view whose action defines a default team (for
example in a pipeline view), the default should take the context
into account instead of simply forcing the team of the current
user.

opw-682577
2016-07-05 15:22:34 +02:00
Goffin Simon 474d9dbf19 [FIX] l10n_es: Spanish Localization Module Error in Default COA
Tax Paid(Hacienda Pública. IVA soportado) and Tax Received(Hacienda Pública, deudora por IVA)
must be respectively under Current Asset and Current Liabilities in BS report.

opw:681998,681252
2016-07-05 15:21:21 +02:00
Nicolas Martinelli c4b82344d5 [FIX] account: traceback when getting counterparts
The compute method of the `counterpart` field only keeps a maximum of 2
account codes. However, it attempts to do [0:2] on a set, which is not
syntactically correct in Python.

opw-682373
2016-07-05 14:50:36 +02:00
Denis Ledoux da8c5d054e [FIX] web_settings_dashboard: email TLDs can be longer than 6 chars
This revision is similar to
7f29a23118

opw-682116
2016-07-05 14:27:11 +02:00
Nicolas Martinelli 11199d2cc2 [FIX] project_timesheet: task progress is no timesheet
If a project task with no linked timesheet is set to "Done", the working
time progress stays to zero.

opw-681622
2016-07-05 13:33:41 +02:00
Goffin Simon f7263dac30 [FIX] account: tax_line_move_line_get
The "else" has to be removed  because if a tax group named "X" is
the group of tax "A" and "B", the journal item corresponding to the invoice line
has the taxes "A", "B", and "X" set.

Introduced by 5a5ac1d7a5
2016-07-05 12:34:45 +02:00
qdp-odoo 549ea7a886 [FIX] account: cancelling a statement line that was reconciled with several already registered payment was crashing. Fixes opw 680128 2016-07-05 11:27:56 +02:00
Erwin van der Ploeg 06f75bf93d [FIX] l10n_nl: set sequences to have taxes not included in price by default.
Courtesy of Erwin van der Ploeg. Was PR #12273
2016-07-05 11:07:24 +02:00
qdp-odoo fb6a05d358 [FIX] account: fixed grouping of account.invoice.tax creation.
in details:
[FIX] added analytic account in grouping key of because we need to create different journal items for each of the lines having a different analytic account.
[REF] added a function on account.tax that returns the grouping key and that could be inherited in another (community) module
2016-07-05 10:22:35 +02:00
Goffin Simon 5a5ac1d7a5 [FIX] account: creation of an aml for an include base amount tax
When an account move line(aml) is created for an include base amount tax,
all the other taxes are impacted with this tax then the field tax_ids of
the created aml must contain the other taxes.

Example:
Considering an invoice line with:
 -A price=90
 -A fixed include base amount tax=10(incl_tax)
 -A 21% tax(called tax)

The base amount for the 21% tax is equal to:
100 = 90 + 10(incl_tax)

When the invoice is validated, three amls are created:

One for the product with:
 -Debit=90
 -Credit=0
 -Tax_ids=(incl_tax, tax)
 -Tax_line_id=()

One for the incl_tax with:
 -Debit=10
 -Credit=0
 -Tax_ids=(tax)
 -Tax_line_id=(incl_tax)

One for the tax with:
 -Debit=21
 -Credit=0
 -Tax_ids=()
 -Tax_line_id=(tax)

In this way, the base amount of 21% in the "Declaration periodique TVA"
report is the sum of all the amls balance(credit-debit) linked to tax with
the field Tax_ids.

opw:681102
2016-07-05 09:48:42 +02:00
Goffin Simon ffd30c5be2 [FIX] account: act_window to find Chart Templates
The act_window to search the chart templates must filter on category
"Localization" due to 692d41c686
2016-07-05 09:30:42 +02:00
Denis Ledoux 6c85d925c3 [FIX] web: dialog close with a reason
In the below revision:
c0db6aec56

The dialog close `reason` was introduced
to not reload the current form if the dialog
has been closed for a reason
(e.g. a window action was returned by the server).

This is to prevent the record reload, which:
 - Is useless, as another action has been launched
   and the user therefore redirected elsewhere
 - Can fail, in the case the initial action deleted
   the current record
   (e.g. when merging a lead in an opportunity, the
   lead is removed, and therefore this is not possible to reload
   it).

 opw-680180
2016-07-04 18:40:15 +02:00
Nicolas Martinelli faf3577896 [FIX] stock: receive product with lot
When a product is received in the lot reception view, a new lot is
created. If the user receives at least one lot, closes the lot selection
window, then reopens the window, he will not be able to create a lot
anymore, but only choose existing lot.

The fix is to make sure that the lot selection is available only in the
case of a returned product.

opw-681925
2016-07-04 17:53:05 +02:00
Philipp Hug 84daaa1658 [FIX] base: use correct address format for CH/LI
Closes #10911
2016-07-04 17:12:14 +02:00
Nicolas Martinelli d1407f9a09 [FIX] stock: returned product with lot number
Before this commit, the return of a delivered product with a lot number
is problematic because the user cannot select the lot from the list of
delivered lot numbers. Therefore, the user needs to create a new lot
number for the returned product since the combination product/lot must
be unique.

opw-681925
2016-07-04 16:24:03 +02:00
Denis Ledoux f7e4241a91 [FIX] l10n_fr_fec: exclude initial balance at 0
The FEC control check does not like rows
with debit = credit = 0

```
º Structure fichier incorrecte, débit/crédit ...
renseignés sur une même ligne ... , ou débit=crédit=0
```

opw-682365
2016-07-04 14:53:00 +02:00
Odoo Translation Bot e349692ede [I18N] Update translation terms from Transifex 2016-07-03 00:32:09 +02:00
Simon Lejeune 7f2e748a22 [REV] base: allow 'render' override with new api
Using a frozendict as context breaks the `t-lang` mechanism, as
the `loader` is not aware of the changes of a copied frozendict
and thus is still using the values from the original context,
including the lang one.

This reverts commit e1deae7eab.
2016-07-01 15:41:39 +02:00
Nicolas Martinelli 9a7ed7cabd [FIX] sale_mrp: COGS in case of kit
When a kit is sold, the unit price of the COGS recorded is the sum of
the unit prices of each component multiplies by the quantity sold.
Obviously, this is not correct since the unit price should not take into
account the quantity sold.

opw-681403
2016-07-01 11:05:28 +02:00
Olivier Dony 61a9cdc3f8 [FIX] account: fix unclear wording for Net EOM payment terms
The previous wording was inaccurate and made users think it
was impossible to setup "Net EOM" payment terms.

Updated POT file accordingly, but not PO files because this
requires a proper new translation.
2016-06-30 18:11:51 +02:00
Goffin Simon 31fb5275fd [FIX] product_extended: bom_count appeared twice in a view
The field bom_count appeared twice in product.template form view and
then the smart button for "Bill of Materials" always displayed 0 as
number of BoMs.

opw:681830
2016-06-30 15:28:04 +02:00
Goffin Simon bdec480434 [FIX] account: _compute_base_amount
When computing the base amount of a tax, all the include base amount
taxes must be considered.

Closed #12481

opw:681102
2016-06-30 15:12:13 +02:00
Yannick Tivisse 692d41c686 [IMP] Classified each module in its category to display them correctly on odoo/apps
To be displayed correctly on odoo app (In a given category and not only in all or hidden)
the module category in the __openerp__.py file should be one of these:

    "Accounting",
    "Discuss",
    "Document Management",
    "eCommerce",
    "Human Resources",
    "Industries",
    "Localization",
    "Manufacturing",
    "Marketing",
    "Point of Sale",
    "Productivity",
    "Project",
    "Purchases",
    "Sales",
    "Warehouse",
    "Website",
    "Extra Tools",

'Accounting & Finance' will not work, as 'Project Management', ...
2016-06-30 13:27:46 +02:00
Yannick Tivisse 2f020dc8b9 [IMP] Remove 'author' field in __openerp__.py files to user default value 2016-06-30 13:27:46 +02:00
Denis Ledoux 7c9ab02c53 [FIX] website_event: make Attendee # translatable
On the website,
when registering for an event with ticket,
the placeholder `Attendee #` could not be translated,
as `t-att` attributes are not translated.

An alternative is to put the string to translate
in a `t-set` node, which can be translated, and
to use the variable assigned in this `t-set`
in the `t-att` attribute.

opw-678758
2016-06-30 13:01:27 +02:00
Nicolas Martinelli a4e4881f4c [FIX] website_portal: missing kwargs
The route "/my/home" is missing kwargs, therefore switching to debug
mode or trying to translate leads to a traceback.

opw-681380
2016-06-29 16:39:51 +02:00
Nicolas Martinelli cef9759c31 [FIX] account_extra_reports: partner of other company
Printing the report "Sale/Purchase Journal" leads to an access error if
one of the partner of an account.move.line is from another company.

opw-681104
2016-06-29 11:34:44 +02:00
Nicolas Martinelli 4c4b0b6e1f [FIX] doc: RHEL-based installation
The instructions to install Enterprise version on RHEL-based
distributions are not correct.

opw-681767
2016-06-29 11:08:23 +02:00
Nicolas Martinelli dd233bd40e [FIX] mail: message order
It might happen that a transaction produces more than one message in the
chatter. In this case, the messages are created with the exact same
date, and they might appear in the wrong order in the chatter.

We therefore sort the messages by id, and not by date. Note that the
messages are already sorted when received from the server, but the web
client has its own management of the messages' order. Relying on the
server order might imply to change other parts of the code on client
side, which is something we want to avoid on a stable version.

opw-681049
2016-06-29 10:23:29 +02:00
Goffin Simon 1d843884e8 [FIX] account: Empty list with get_default function in "ir.values"
The function get_default in "ir.values" can return an empty list.
This is why checking that the result of this function is a list was not
enough.
2016-06-29 09:25:48 +02:00
Adrien Dieudonne 1ec2e4b22d [IMP] mail: limit number of messages fetched to 25 2016-06-29 08:36:41 +02:00
Nicolas Martinelli 506c161990 [FIX] stock: appropriate chatter log when picking done
Commit d349584 solved the state change tracking of pickings, and
moreover prevents unnecessary state changes to be recorded. However,
this also prevents the state "Done" to be recorded in the chatter.

Saving properly the state change for the picking might be quite tricky,
since the stock processes sometimes imply unreservation/rereservation of
quants, and therefore lead to several state changes inside the same
process.

opw-680343
2016-06-28 16:13:34 +02:00
Martin Trigaux 3e15b86428 [FIX] point_of_sale: do not insert related fields on one2many
fields ref, journal_id and date on account.move.line are all related fields on
the account.move.
Setting a value here is then useless and triggers write on the account.move
after the creation of the account.move.line (inverse values in write)
2016-06-28 13:23:41 +02:00
Martin Trigaux 5d9e4b7858 [FIX] account: performances of map_tax
break on first match instead of checking other Tax Source that will not match
anyway.
2016-06-28 13:23:41 +02:00
Martin Trigaux 173b76c7bb [FIX] point_of_sale: performance and invalidation
Function fields, old-api style, that are not stored do not have cache
invalidation mechanisms. This means that they are recomputed every time the
field is accessed.
Due to the way the cache behaves, the records that are present in the cache will
be included when the prefetching is done.

In the scenario of the a POS session being closed, this implies that the cache
will contains more and more account.move.line records and try to prefetch all
(hopefully max 1000) without ever relying on the computed result for the next
access. This makes the computation of fields `amount_total` and `price_subtotal`
very slow, even for orders with a very low number of lines.

Backport the new API migration of these computed field to benefit from depends
mechanism and keep the computed value into cache when needed.

In master these fields should be stored.
2016-06-28 13:23:41 +02:00
Christophe Simonis 10550aa5a5 [MERGE] forward port of branch saas-6 up to e68ed41 2016-06-28 13:11:35 +02:00
Christophe Simonis e68ed417b6 [MERGE] forward port of branch 8.0 up to 3e965ec 2016-06-28 12:23:54 +02:00
Martin Trigaux cbbc90fc2e [FIX] website_payment: access parent payment method
On the other routes (e.g. /my/, /my/contract/) payment information on the parent
contact are displayed but can not be access in the my payment route.
You get in a unconsistant situation where you can access the contract of the
company and its payment information but can not use this payment information.

opw-681491, opw-681502
2016-06-28 12:16:41 +02:00
Nicolas Martinelli 77212863b1 [FIX] stock, sale_stock, portal_stock: picking access
An access error occurs when a the delivery address of a SO is set to a
different partner than the SO partner. In this case, the picking
created is associated to the partner of the delivery address. This is an
issue when the SO partner tries to view the picking from the front-end
("My Account"), since he is not allowed to access it.

opw-681341
2016-06-28 09:10:55 +02:00
Martin Trigaux cc4f8df99f [FIX] account: compute total invoice in batch
The computation of the total_invoiced field did not work in batch mode.
When displaying a company in a form view (field invoice_total comptued), the
children of this company are present in the cache and the value of the field
invoice_total will be prefetched for these children as well (at least in 9.0).
Most of the time this is redudant information and the same value is computed
for each child while most of the invoices are on the parent.

Batching the computation per partner allows to make one global query for all
partners.

Add test to make sure the total increase correctly after a test invoice
confirmation.
2016-06-27 17:20:05 +02:00
Denis Ledoux 9062c01c02 [FIX] web: pager page on next/previous record
When browsing a form with a one2many / many2many field
with several pages, the one2many pager page was not reset
when going to the previous/next record, while the next/previous
record could not have multiple pages on its one2many/many2many,
and the page on which the user was on the former record could
not exist in the newly displayed record.

Besides, even if the page does exist, there is no reason
to display this new record X2many value from its first page.

It's the case anyway when you edit/save, it comes back to the first page.

opw-679092
2016-06-27 16:50:47 +02:00