Commit Graph
123525 Commits
Author SHA1 Message Date
Xavier Morel 9db74611de [IMP] web: action links from bits & pieces
Before this, the action manager only supported auto-triggering actions
from (model, method) or (action_name).

This adds support for providing all the action details via data
attributes:

* model (defaults to current action's)
* resid (defaults to none)
* views (defaults to list, form, unless resid is specified then
  defaults to just form)
* domain (defaults to [])
* context (defaults to {active_id, active_ids, active_model} from
  current action if the model has not changed, empty otherwise)

The action's name/title is either the link's title (?) or its textual
content.
2019-01-29 10:22:17 +00:00
Xavier Morel 42fbee83ad [IMP] qweb: stop requiring t-name-flagged sub-node
QWeb's rendering currently *requires* that when loading a document
instead of rendering the document itself it will render a sub-node
with a properly labeled t-name. If a view is invoked by id, ir.qweb
will look for a child with a t-name and fix up that t-name such that
the base qweb object will find and render it.

This feature mostly exists for JS compatibility (because a single
document can contain multiple cross-linkable templates, and it was
useful for cross-implementation tests though I'm not sue they're even
checked anymore), and the <template> tag kinda took care of it,
however with a more proper qweb view it becomes more of a liability /
pain in the ass.

Note: turns out there are bits of javascript which read server
templates (???) and need to be altered to correctly handle the lack of
<templates> wrapping.
2019-01-29 10:22:17 +00:00
Arnaud Baes bf4a8b3de8 [IMP] purchase: Email sent from PO sent by the current user.
When an email was sent from a PO, the sender was by default the user who created the PO.
The sender is now replaced by the current user.

TaskID: 1934477

closes odoo/odoo#30660
2019-01-29 15:04:59 +00:00
Antoine Guenet fa5c987c86 [FIX] web_editor: preserve image classes when replacing image
closes odoo/odoo#30661
2019-01-29 14:56:42 +00:00
Adrian Torres ee6dc40a60 [IMP] fields: forbid required m2o ondelete set null
A many2one field that is required means that its column cannot contain
null values, however the default ondelete policy for all m2o fields is
`set null`, which contradicts `required=True`.

This patch will, by default, apply the `restrict` policy to required m2o
fields unless the ondelete attribute is explicitly specified. However,
if the policy specified is `set null`, a ValueError will be raised
whenever the registry registers the field as this makes no sense.

The default ondelete policy remains unchanged for non-required m2o
fields (set null)

closes odoo/odoo#30122
2019-01-29 16:17:03 +00:00
qsm-odoo 9ea1eb7aa5 [REF] website_event: properly define and use country events snippet
The snippet was not using an XML template of his own and its code was
duplicated by the "Country Events" option.

closes odoo/odoo#30663
2019-01-29 16:30:35 +00:00
Antoine Guenet a27837a000 [FIX] web_editor: properly disable the toolbar on snippet removal
Update editor toolbar on each change to properly disable it when needed

closes odoo/odoo#30594
2019-01-29 07:54:58 +00:00
Thibault Delavallée 0598d975dc [FIX] survey: fix prefill
It seems page_id is now a string instead of an int.

closes odoo/odoo#30639
2019-01-29 09:12:49 +00:00
Thibault Delavallée c273e89d55 [REF] website_slides: introduce slide / user relationship and use it for vote
Purpose of this commit is to store a relationship between slides and users.
Indeed starting from now we will track more user interaction with the slides
module.

In this commit we introduce a model that is used to populate and decorate
the relationship between slides and users, slide.users. From slides or users
point of view it behaves like a many2many. It can also be used to store
more information about the user interaction with the slide.

We use it here to store the user vote. Like and dislike are not static
counters anymore but computed fields based on user votes. It is implemented
as a tristate field.

As it is a technical model no access on slide.users is granted. Controllers
and methods grant access to the relationship in order to avoid information
lead and keep technical details private.

Future commits improving the eLearning use of slides will notably store
information about user having read the slide, taken a quizz or gaining
karma depending on some actions performed on the slide.

This commit is linked to task ID 1934488 and PR #30620 .
2019-01-29 09:24:48 +00:00
Yenthe666 bf4427f682 [FIX] lunch: make lunch location name required
closes odoo/odoo#30627
2019-01-28 17:04:14 +00:00
Christophe Simonis cfd0147439 [FIX] website_{sale,slide}: remove duplicated field in view
Oversight of previous forward-port.

closes odoo/odoo#30626
2019-01-28 16:38:54 +00:00
Christophe Monniez 609c3ea573 [FIX] tests: avoid check document.readyState of about:blank
In an HttpCase test, when the browser_js method is used, an optional
javascript code can be used to check that the page is ready to execute
the test.

When no 'ready' code is given it defaults to check the
'document.readyState' status.

In some rare cases (discovered by @Xavier-Do) this status is checked on
the 'about:blank' page. As the page seems ready, the test code is
evaluated and fails.

With this commit, when no specific ready code is provided, the test will
wait for a chrome devtools event that ensure the page is fully loaded
before starting the test.

cherry-pick of 03a8819652

closes odoo/odoo#30609
2019-01-28 13:16:26 +00:00
David 60748a95e2 [FIX] point_of_sale: wrong tax in fp if unmapped
- If a fiscal position is set in the point of sale and a product tax
isn't mapped in it, it wasn't applying any tax at all. After this fix,
the tax defaults to the product one.

closes odoo/odoo#30556
2019-01-28 15:07:57 +00:00
Robot Odoo a0074af212 [MERGE][FIX] website_slides: fix various issues
Purpose of this merge it to merge various fixes and small improvements
related to slides module. As an update of this module is pending fixing
it before is quite helpful.

This merge is linked to task ID 1933820 and PR #30553.
2019-01-28 17:23:55 +01:00
Thibault Delavallée 088041f79d [FIX][IMP] channel: improve can_upload / can_see computation on channel
Purpose of this commit is to clean a bit interface of slides

 * separate can_see from can_upload;
 * correctly set can_see on partial visibility channels;
 * remove upload button for portal users as they have no rights to upload a
   document and this is not supported in any way;

This commit is linked to task ID 1933820 and PR #30553.
2019-01-28 15:37:14 +00:00
Thibault Delavallée f766653780 [FIX][IMP] slide: do not propose to create tags / category if no right
This commit is linked to task ID 1933820 and PR #30553.
2019-01-28 15:37:14 +00:00
Thibault Delavallée c5da7b8aeb [IMP] website_slides: improve like / dislike
Like / dislike of slides is fixed and improved to make a tri-state like
behavior. Future commit will change this implementation in order to use
a relationship table between users and slides as we are moving towards
the eLearning platform. Let us have this simple implementation currently
and rewrite it in a near future.

This commit is linked to task ID 1933820 and PR #30553.
2019-01-28 15:37:13 +00:00
Thibault Delavallée 2db50e5796 [FIX] website_slides: quickly fix pdf viewer not appearing
Pdf viewer does not display or is incorrectly displayed. This commit proposes
a minimal fix to at least display the iframe holding the pdf viewer.
This will be improved with eLearning improvements for slides.

This commit is linked to task ID 1933820 and PR #30553.
2019-01-28 15:36:30 +00:00
Thibault Delavallée d3e462b279 [FIX] website_slides: fix statistics computation
Statistics computation section is a bit broken as some variables are
incorrectly defined or propagated.

This commit is linked to task ID 1933820 and PR #30553.
2019-01-28 15:36:30 +00:00
Thibault Delavallée a912c09304 [FIX] website_slides: fix various calls undefined methods
Several places call 'this' whether it is not linked to the current object.
Use self instead.

This commit is linked to task ID 1933820 and PR #30553.
2019-01-28 15:36:30 +00:00
Sébastien Theys 130af96dc1 [IMP] portal,sale: improve signature widget and move it to portal
Purpose
=======

The goal is to avoid duplicate code between portal and sign (enterprise), and
also to allow the user to use the signature mode 'auto' and 'load' in portal
(before this commit only 'draw' was available in portal).

The sales order signature (currently the only portal signature) has been changed
to use this new code.

This signature widget has been improved:

Improved style:
 - better structure and use of BS classes
 - removed most of custom CSS
 - made it more responsive

Changed code to follow guidelines, added JSDoc.

Technically
===========

New widget NameAndSignature common to portal and sign (enterprise).

Reworked existing portal signature form to use new widget.

Related to enterprise PR https://github.com/odoo/enterprise/pull/3266

task-1894903

closes odoo/odoo#29453
2019-01-28 09:48:32 +00:00
Xavier Morel a0e05e2ab9 [IMP] fields: selection fields only use strings
closes odoo/odoo#29039
2019-01-26 14:25:44 +00:00
Darshil Trivedi c48c3e6155 [IMP] stock, purchase_stock: Stock move description
Display product picking,receipt or delivery description depending
the picking type. The purpose is to display usefull information/note at
the right place at the right moment.

This commit is related to task ID : 1880135

closes odoo/odoo#28175
2019-01-28 10:35:11 +00:00
Christophe Simonis cf52a04979 [MERGE] forward port branch saas-12.1 up to d3b8422c9c
closes odoo/odoo#30614
2019-01-28 13:58:11 +00:00
Nicolas Martinelli cd1f57e9de [FIX] website: misspellings
opw-1931844

closes odoo/odoo#30561
2019-01-28 07:13:21 +00:00
qha-odoo 5b563549fa [IMP] website_event, *: refactor website events layouts
* base, portal, website, website_event_sale, website_event_track

- The previous event registration form was not clear on mobile

- Review some layouts to match the new design general idea, using cards
  (see forum refactoring of https://github.com/odoo/odoo/pull/29235)

- Use correct bootstrap components (like a menu instead of a breadcrumb
  on event pages)

- Review options to be able to disable the left / right column and
  choose the exact options you want to appear in them

task-1858034

closes odoo/odoo#30559
2019-01-25 14:30:55 +00:00
Florent de Labarre 340bc5c42e [IMP] hr_holidays: archived leave type
Add a filter for archived leace types.

closes odoo/odoo#30279
2019-01-25 14:41:58 +00:00
Siddarth Gajjar b43fcd6700 [FIX] mass_mailing: restore email templates
Following the new editor's merge at https://github.com/odoo/odoo/pull/29775,
the classes 'o_mail_wrapper' and 'o_mail_wrapper_td' were renamed to
'o_mailWrapper' and 'o_mailWrapper_td' because of what appears to be a
JS-variable-search-replace fail. Strange enough, the scss was not
impacted which allowed to see the bug in master.

closes odoo/odoo#30544
2019-01-25 12:43:43 +00:00
Robot Odoo 26f828e6c9 [MERGE][REF] survey: further refine access mode
Purpose of this merge is to improve access mode and authentication management
introduced at 9771fdfe8f . Purpose of this cleaning is to simplify options and make
them clearer. Instead of a selection with 4 entries we propose to use two
fields on survey model :

 * access_mode: everyone with a public link can access and answer; or only
   invited people;
 * login required: whether people have to login to answer or not;

All main use cases are covered with combination of those two options.

In this merge we also refine survey routes now using an access token defined
on survey model instead of its ID. It allows to keep surveys somehow private
especially for surveys on invitation only.

Some fixes related to last changes are also done in this merge. Some
improvements in survey templates are also provided to ease their update.

This merge is linked to task ID 1932508 and PR #30508.
2019-01-25 15:57:41 +01:00
Thibault Delavallée 61bce6958c [IMP] survey: slightly improve result template
Purpose is to remove an unnecessary template by directly including the "no
result" inside the main result template. It eases understanding and updating
of templates.

This commit is linked to task ID 1932508 and PR #30508.
2019-01-25 13:13:30 +00:00
Thibault Delavallée 2e4ea7c49a [IMP] survey: improve token and answer management
Purpose of this commit is to improve a bit management of user input tokens
and state

 * allow to test closed surveys;
 * better management of answers already filled;

This commit is linked to task ID 1932508 and PR #30508.
2019-01-25 13:12:35 +00:00
Thibault Delavallée 82f5ec044b [IMP] survey: better manage login required and signup
Purpose of this commit is to provide a real signup URL and redirection when
login is required on survey. It depends correctly on current partner state
and auth signup parameters. Redirection is now correctly managed so that
customer will be back on survey with their token.

This commit is linked to task ID 1932508 and PR #30508.
2019-01-25 13:12:32 +00:00
Thibault Delavallée e65bcb24fd [IMP] survey: refine access mode option on survey
Purpose of this merge is to improve access mode and authentication management
introduced at 9771fdfe8f . Purpose of this cleaning is to simplify options and make
them clearer. Instead of a selection with 4 entries we propose to use two
fields on survey model :

 * access_mode: everyone with a public link can access and answer; or only
   invited people;
 * login required: whether people have to login to answer or not;

All main use cases are covered with combination of those two options.

This commit is linked to task ID 1932508 and PR #30508.
2019-01-25 13:12:22 +00:00
Thibault Delavallée c801eecf23 [IMP] survey: access survey through access tokens
Purpose of this commit is to use an access token to access survey instead
of their ID. Routes are updated to use that token instead of the survey ID.
Purpose is to have less discoverable routes and be able to control a bit more
survey access even if it is not really a security parameter.

Some renaming is performed to avoid confusion in terms. Survey token and
answer token are now clearly labeled differently in the code to know which
model we are working on.

Some templates are updated to directly use the answer as base record to
have access to token and test_entry fields instead of giving those parameter
values directly in the controller. It makes some more diff but also allow
easier edition and improvement in templates when having directly survey
and answer record available.

This commit is linked to task ID 1932508 and PR #30508.
2019-01-25 13:11:50 +00:00
Thibault Delavallée 970cb47f57 [IMP] auth_signup: allow direct URL redirection instead of action when computing signup URL
Purpose of this commit is to improve the redirection done after signup.
Currently everything is tailored to create an Odoo action (action, model,
res_id, ...). This action is used to forge an URL that is the redirection
URL after signup. In some cases you would like to directly give the redirection
URL when no Odoo standard action is involved.

An example of use is the redirection when subscribing to take a survey. We
want customers to be back on survey that is a frontend URL, not a backend
URL linked to an action.

This commit is linked to task ID 1932508 and PR #30508.
2019-01-25 13:11:46 +00:00
Pierre Paridans 9f7e6bb798 [IMP] web: Deactivate swipe between form view in mobile
The swipe between the form view is taking too long to load, and the pager is a
more clean option to switch between form view.
Moreover, the swipe on tabs is not clear anymore.

- Deactivate swipe between form view
- Swipe should only be available on tabs when tabs are too long to fit in one screen.

Was originally introduced by https://github.com/odoo/odoo/commit/f4ee61f950dc1eeb7b3653ca96ea72721512b5e5

Related task: 1924764

closes odoo/odoo#30413
2019-01-25 13:02:46 +00:00
David Beguin 3dac18f9e9 [IMP] sale_crm : review quotations and sales smart buttons on opportunity
various improvements and fixes:
    - View quotations was incorrect
        -> should be real quotation view and not SO view
    - Cotation count was incorrect
        -> Should only include Quotations with state='draft' or state='sent'
    - SO button should be visible if number of SO > 0 and not the total amount

Task ID : 1908622
Closes PR #29461
2019-01-23 16:08:35 +00:00
David Beguin 73e9647b06 [IMP] crm : prefill partner info based on opportunity info
If the user is creating a res.partner from the partner_id m2o on crm.lead,
prefill contact information from the opp in it
(email, phone, mobile, street, street2, etc.).

If 'contact_name' is set on crm.lead, the created res.partner should have:
    > is_company = False
    > name = contact_name (from crm.lead)
    > company_name = company_name (from crm.lead)

If 'contact_name' is not set on crm.lead, the created res.partner should have:
    > is_company = True
    > name = company_name (from crm.lead)

Task ID : 1908622
Closes PR #29461
2019-01-23 13:49:54 +00:00
qsm-odoo 04fcbc7b22 [REF] website, *: remove 'web_editor.ready'
* website_event

Following the new editor's merge at https://github.com/odoo/odoo/pull/29775,
'web_editor.ready' was moved to website without being renamed.

Following https://github.com/odoo/odoo/pull/30409, this will remove
that 'web_editor.ready' module.

See upcoming improvements with https://github.com/odoo/odoo/pull/29442

closes odoo/odoo#30548
2019-01-25 11:04:24 +00:00
sed-odoo 37e0c5787a [IMP] l10n_be_hr_payroll_fleet, fleet: Adapt CO2 Tax
Specification
=============

- Adapt the formula used in the code with the current legal value.
- Add the LPG fuel type in standard fleet module.
- Adapt the atn furmula in the code with the current legal value.

closes odoo/odoo#29833
2019-01-25 09:07:19 +00:00
Thibault Delavallée bde36a276e [FIX] survey: fix invite mail template
Purpose of this commit is to improve the recently-introduced mail template
used to invite people to surveys. Containing

 * fix the display of deadline that is not required;
 * correctly talk about survey, not apparaisal;

This commit is linked to task ID 1932508 (side-dish fix).

closes odoo/odoo#30537
2019-01-25 09:21:50 +00:00
Arnaud Baes db1c43649d [MOV] sale_mrp, mrp: compute quantities for kit
The quantities for kits were computed only if sale_mrp was installed.
That's why the override of the method 'compute_quantities' needs to be moved in MRP.

TaskID: 1929518

closes odoo/odoo#30271
2019-01-25 09:00:55 +00:00
Arnaud Baes 8298142574 [IMP] mrp, purchase_mrp: Quantity received for kits in a PO
This commit generalize the method made for computing the quantity delivered in a sale order
in order to be used for the quantity received for a kit in a purchase order.

TaskID: 1929518
2019-01-25 09:00:55 +00:00
Antoine Prieels fae4de5c34 [IMP] mrp: Plan WO in the future
Add possibility to set a Start Date on Manufacturing Orders. Once the user clicks on Plan, the Work Order are planned at the first time available from this date.
When clicking 'Unplan', Work orders are now completely deleted

TaskID: 1889399

closes odoo/odoo#30184
2019-01-25 09:24:09 +00:00
Antoine Prieels 2ad8ebc461 [IMP] mrp: Add test for planning of MO
Check that workorders are planned directly

TaskID: 1889399
2019-01-25 09:24:09 +00:00
Antoine Prieels 43a7087354 [MOV] mrp: Move code from mrp_workorder
Move code that fills in date start and date end on the Work Orders and that does the unplan from Enterprise

Linked to odoo/enterprise#3420
TaskID: 1889399
2019-01-14 13:49:01 +00:00
Dipalee Bhalodia 78ab56e797 [MOV] stock_zebra,stock: Move reports from stock_zebra to stock
All the reports and test file from stock_zebra to stock  and mrp_zebra to mrp

closes odoo/odoo#27676
2019-01-22 11:38:56 +00:00
Robot Odoo 0f6b38b2bc [MERGE][IMP] survey : add datetime format and various improvements
Purpose of this merge is to add support of both date and datetime questions
in survey. Validation and check is added accordingly to current survey
question type support.

In this merge we also add some various improvements

 * Change the default value of the Validation Error message on
   the Date : "The answer you entered is not valid."
 * If long page, click on next and one error, the page should go up
   to allow the visitor to see where the error is.

This merge is related to task ID 1911291 and closes PR #29054.
2019-01-25 10:23:10 +01:00
Antoine Prieels (ANP) 8f486db52d [IMP] mail, snailmail, snailmail_account: improve error management
When a letter is sent through snailmail and encounter an error, it used
to create an activity to the user to notify him that there was an error
with its letter.

When a user had this activity, he didn't have any clues of what was the
error and how to manage it. So we decided to better handle snailmail
errors and give the possibility to the user to easily fix the source of
the snailmail errors.

First to give a better feedback on the letters in errors, we've made
features similar to ones existing for emails:
 - We add a mail message on the document that sent the letter, and put a
   small paper plane icon, which is red when an error occurs (like the
   envelope for email)
 - As letters can be sent in batch, we've also added an entry in the
   systray to easily manage the different documents having snailmail
   errors like for emails.

Then we identified, the most common errors encountered with the
snailmail letters and give proper way to let the user fix them:
 - Missing Required Field:
    - The address is not complete, some of the fields are empty.
    - We open a wizard allowing the user to modify the partner address
      and we try to resend all letters having this error on the modified
      partner.
    - We also try to avoid this error, by opening the wizard before
      sending the letter, but it only works for single documents, not
      for batch.
 - Trial/Credit Error:
    - The user has not enough credits to send letters anymore.
    - We open a wizard that give a redirection lnk to add credits on its
      iap account.
 - No Price Available:
    - The destination country is not supported by any of our providers,
      and we cannot do anything to send this letter.
 - Format Error:
    - The format of the pdf report send by the user is refused by our
      providers, because some visual stuffs are not respected, for
      example blank zone to print barcode or margins.
    - We show a wizard to the user letting him check a setting option
      that add a cover page in the envelope and the documents will be
      send with this extra page containing the address.
 - Unknown Error:
    - This is not one of the listed error above.
    - A wizard suggesting the user to contact support is displayed.

The cron that try to resend letters on error, has been addapted to only
try to send the error of type Trial/No Credit, because the account might
have been reloaded, and other errors, won't change if they have not been
fixed locally.

closes odoo/odoo#29685
2019-01-24 13:36:51 +00:00
RomainLibert 7274c0aa74 [REF] l10n_be_hr_payroll: Replace computed fields
The double holidays and the thirteen months fields are used for the salary
package configurator. But these fields are computed as in a perfect world.

As these values are now available with a specific salary structure,
replace the computed values in the salary package and remove the fields

closes odoo/odoo#30516
2019-01-24 14:35:50 +00:00