Commit Graph
140385 Commits
Author SHA1 Message Date
Aaron Bohy 6ecf325769 [FIX] web: list: multi edit: do not create new row
...when validating last row by pressing ENTER.

In single edition, we automatically add a new row when the user
edits the last one and presses ENTER. This is something we don't
want in multi edition.

Task 2068280
2019-09-18 11:31:43 +00:00
Julien Mougenot 6a50a125f0 [FIX] web: readonly many2one in list views
Let's assume an editable list with a many2one and a char, the many2one
being readonly. Before this rev., if the user clicked on the many2one,
the row was switched in edit more, and the many2one link was given the
focus.

Now, in the same scenario, the focus is given to the char field which
can be edited (i.e. its input).

Task 2068280
2019-09-18 11:31:43 +00:00
Julien Mougenot f15c069906 [FIX] web: list: clicking discard doesn't trigger an onFieldChange
Fixes the way records are discarded in list views

Before this commit, clicking the "Discard changes" button in a list view
after editing a record triggered both the "field changed" and the "discard changes"
methods (resulting in 2 modals opening).

Now, all fieldChanges are prevented when trying to click "Discard changes",
and are re-applied if the click was unsuccessful (lifted left mouse button somewhere else).

Task 2068280
2019-09-18 11:28:03 +00:00
Aaron Bohy 2cdd46b566 [FIX] web: list: multi edition: force write same value
Let's assume an editable list view with a many2one field and 2
records: the first one has value 1, the second value 2. The user
selects all records and wants to set their many2one to value 1. It
edits the first one, sets 1 and validates the confirm dialog.

Before this rev., it didn't save anything because the 'reference'
record (the one used to edit), didn't actually changed, as we reset
the same value.

This rev. forces the write the new value on all selected records in
that case.

Task 2068280
2019-09-18 11:28:03 +00:00
Julien Mougenot f58f177626 [IMP] web: added increments to the minutes in daterange
Minutes can now be chosen by increments of 5 instead of 10.

Task 2068164
2019-09-17 12:35:57 +00:00
Julien Mougenot 4985f6a1ae [IMP] web: datetime picker style
Changed the style of the "Close" button to match the one on the "primary buttons".

Task 2068164
2019-09-17 12:35:57 +00:00
Martin Trigaux 63289fa06a [FIX] *: typos, wording
Courtesy of translators

closes odoo/odoo#36984

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-09-17 08:39:02 +00:00
MaxLarue 22d9556ae4 [IMP] project: allow to filter on task name in reporting
task-2047389         closes-5388

closes odoo/odoo#36360

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
2019-09-18 12:05:19 +00:00
MaxLarue a40e734ac3 [IMP] sale_timesheet: update product type onchange to avoid a empty invoice policy
task-2047389         closes-5388
2019-09-18 12:05:19 +00:00
MaxLarue 740d2f2617 [FIX] industry_fsm: fix sale order issue when adding product without timesheet on tasks
The link between a sale_order and a task relied on a sale_line between the sale order and the tasks. This was working when allow timesheet and allow material were true, as we had a timesheet_product_id and the sale_line was created empty. But when we create a project with material but no timesheet, the sale line would crash.

Now the sale order and the sale line creation are split, and we write the sale order id on the tasks. This works because with the new ORM, we can write on a stored compute field, and if we take care of not overwriting it in the compute, it stays at what we wrote.

task-2047389		closes-5388
2019-09-18 12:05:19 +00:00
MaxLarue 8ed94a11f4 [IMP] wysiwig widget: fix wysiwig widget autofocusing
When clicking on edit in a form with a wysiwig widget inside, that widget would gain focus. It is not the expected behaviour (focusing the first field) and is really an issue on mobile, where the screen would scroll and the keyboard open.

The mouseup event was there to force summernote refreshing the editor toolbar (which will not display which buttons were active until the editor is focused). So removing it still has drawbacks (the toolbar is not up-to-date), but with chm it was decided to remove it as the issue with focus is worse.

Task-2047389      Closes #36360
2019-09-18 12:05:19 +00:00
MaxLarue 438194fa9d [IMP] sale_timesheet: prevent copying the sale order line when duplicating task
This would lead to a strange situation, where two tasks share the same sale order which means change on one would be reflected on the other.

Task-2047389      Closes #36360
2019-09-18 12:05:19 +00:00
MaxLarue c22a2c729e [IMP] project: fix typo in constraint message
Task-2047389      Closes #36360
2019-09-18 12:05:19 +00:00
Geoffroy Larue e2e85cb93a [IMP] project: project form view
Move and relabel the Privacy field and its various options to improve usability.

Task-2047389      Closes #36360
2019-09-18 12:05:19 +00:00
MaxLarue f5596bb8fe [IMP] sale: fix action_view_invoice in batch
action_view_invoice is made to work on empty/single/multi records, but there are context keys used to provide defaults when creating invoices in the next view. However when those fields are different among the origin sale orders, we get an error, because the record set's values is accessed like in a single record.

In this record we add the default_* context keys only if the recordset is of length 1, so it keep working as before for single/no records. And it doesn't crash when coming from multiple sale orders with different fields.

related task 2047389
2019-09-18 12:05:19 +00:00
MaxLarue 48f3bb8ee9 [FIX] project: fix project overview filter
Project overview was broken since the display name field on project search view was renamed into simply name, but a context key was used to enable it, which was not updated

related task 2047389
2019-09-18 12:05:19 +00:00
MaxLarue ecd8d38fdc [FIX] sale_timesheet: fix action_timesheet_from_invoice
The action_timesheet_from_invoice was not working anymore, it was redirecting to a list of all timesheet instead of only those linked to the actual invoice. It seems like the action was using a filter since it passed a search_default_* key in the context, but that filter is nowhere to be found. In order to fix the action, it was converted int a python method which gave access to the active move id.

related task 2047389
2019-09-18 12:05:19 +00:00
MaxLarue 8291fae0ef [IMP] hr_timesheet: rename allow timesheet into timesheet
Since this settings widget is a check-box it is already obvious that this field turn on or off a feature. Plus it makes the field easier to translate and the form view a little bit lighter.

related task 2047389
2019-09-18 12:05:19 +00:00
MaxLarue 5c03820f87 [IMP] industry_fsm: change date displaying on kanban cards
This commit changes the display of dates on kanban cards. It is now conditional.
Depending on the date versus actual date we conditionally set the color.
Depending if the record are grouped by date, we format the date as a date or as a time.
If the task is an fsm task we show the planned date begin otherwise we display the deadline.

From which App            |         project          |           fsm          |
-------------------------------------------------------------------------------
task.is_fsm               |     y      |     n       |     y      |     n     |
-------------------------------------------------------------------------------
task.fsm_state == 'done'  |  y  |  n   |  y  |   n   |  y  |   n  |  y  |  n  |
-------------------------------------------------------------------------------
-------------------------------------------------------------------------------
display deadline          |  n  |  n   |  y  |   y   |  n  |   n  |  y  |  y  |
-------------------------------------------------------------------------------
should it be colored?     |  n  |  y   |  y  |   y   |  n  |   y  |  y  |  y  |
-------------------------------------------------------------------------------
display city   ?          |  n  |  n   |  n  |   n   |  y  |   y  |  y  |  y  |

extra case: in fsm, if the records are grouped by date, we display time only in red, if the task is late, taking the time into account.

Task-2047389      Closes #5388
2019-09-18 12:05:19 +00:00
Raphael Collet b3bc7af0ea [FIX] point_of_sale: multiple installs inside a single request
The modification of a helpdesk team may trigger the installation of some
modules.  The code was calling multiple times the installation of
modules (once per module to install), and this was triggering cache
misses on computed fields (probably because of a completely inconsistent
cache/registry).  We have grouped all the modules to install into a
single installation, and this fixes the issue.

Co-authored with Samuel Degueldre <sad@odoo.com>

closes odoo/odoo#37059

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
2019-09-18 09:27:52 +00:00
Kevin Baptiste 520ebd3c89 [FIX] hr_org_chart: reduce width on public profile
Prior to this commit, the org chart was taking 2/3 of the available
width. This commit aims at reducing the space used and to be consistent
with the private employee profile.

closes odoo/odoo#37052

Taskid: 2073361
Signed-off-by: Romain Libert (rli) <rli@odoo.com>
2019-09-18 08:21:38 +00:00
Adrien Dieudonne 29bbdc9aa5 [IMP] web: PivotView: display grouped columns on mobile
Before this commit, only "Total" column was shown on mobile and
it wasn't possible to add another one.

(1) Now, we let the user to add it even if he probably will have to
scroll horizontally.

(2) The "Flip" button has been reintroduced like in desktop.

(3) By default, the old behavior will remain the same (only one
colum will be displayed) but to avoid frustrating for users
who always have to add manually columns to see the same information
as in desktop; you can use favorite filters.
In this case, all columns will be displayed.

Task ID : 1945893
opw-1935645

closes odoo/odoo#37057

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
2019-09-18 09:09:13 +00:00
qsm-odoo 371daf1682 [REF] website_blog: review cover saving method
Use a simple write RPC instead of a dedicated controller route.

closes odoo/odoo#37030

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-09-17 14:58:52 +00:00
Martin Trigaux f4d5a7fe8b [IMP] base: improve test coverage
The forbidden cases were not tested, making it harder to detect

closes odoo/odoo#36846

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-09-18 08:40:12 +00:00
Cedric Snauwaert b0ddc0fda1 [FIX] account: fix css of pencil to edit tax on vendor bill
Before when creating a vendor bill with a tax 15% and a price unit less than 87, the widget to edit the tax amount was wrongly displayed, the pencil and amount was broken into two lines. This fixes this behavior by ensuring that the all block stays together using the css property white-space: nowrap

closes odoo/odoo#37049

Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
2019-09-18 08:09:38 +00:00
Meghna Jaswani 2ac5f8b21f [FIX] product: remove strong tag from errors
Validation and user errors do not support
html tags anymore.
This commit removes the last strong tags present in
such errors.

Task ID: 2061442

closes odoo/odoo#36231

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
2019-09-18 08:06:44 +00:00
Simon Lejeune d1814891fe [REF] mrp_subcontracting: manage backorder
closes odoo/odoo#37046

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-09-18 07:15:32 +00:00
Simon Lejeune deeb17cef0 [REF] mrp: improve error message in run_manufacture 2019-09-18 07:14:53 +00:00
Arnold Moyaux 167fd934a8 [FIX] mrp_subcontracting: empty BoM if no subcontractor
_bom_subcontract_find return a BoM of typer subcontractor for
any partners if the subcontractor is not set. The real behavior is
to not create a subcontracting order if the partner is not set.
2019-09-18 07:14:53 +00:00
Arnold Moyaux 93c53265ed [FIX] mrp_subcontracting: multi company 2019-09-18 07:14:53 +00:00
Arnold Moyaux 186b512023 [FIX] mrp_subcontracting: allow to return to subcontractor 2019-09-18 07:14:53 +00:00
laa 69b3b4bcd6 [FIX] mass_mailing: edit text content and transform the form tag view
- correct some errors in the text field
- transform the utm.tag.view.form view to utm.tag.view.tree view to allow direct tag editing

closes odoo/odoo#37008

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-09-17 12:01:11 +00:00
Antoine Prieels 7cb540b485 [REM] hw_drivers: Remove printers list from status
The status returned bby PrinterDriver contained a list of connected
printers to be used in Enterprise, to determine if the printer that was
selected in POS Config was used in the POS. We now read this status
from the db and we therefore don't need this anymore.

In Community the user only needs to know if there's a printer connected
to the Box. We just have to know if any printer is present.

TaskID: 1970884
2019-09-17 08:31:32 +00:00
Antoine Prieels 88c91a1e88 [IMP] point_of_sale: Show message on proxy icon
Add the possibility to show a message on the proxy status icon in the
PoS. The message will be the same color than the status icon.
2019-09-17 08:31:32 +00:00
Antoine Prieels 75ee93a9b6 [IMP] point_of_sale: Small changes to the POS Config view
Add a class on the list of IoT Devices to override it easily in pos_iot
and increase the width of the labels.
2019-09-17 08:31:32 +00:00
Antoine Prieels 7ba83df6f4 [FIX] point_of_sale: remove unused field
An "iface_payment_terminal" field was present but never used. We
remove it.
2019-09-17 08:31:32 +00:00
Robin Heinz 1a3dcfeae6 [FIX] point_of_sale: default global discount
Change the default value of the miscellaneous product to a discount product. When the module pos_discount is installed, the default value will now be the discount product.

closes odoo/odoo#36665

Task: bug fix
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-09-13 13:45:51 +00:00
Christophe Simonis 58a83d1222 [MERGE] forward port branch saas-12.4 up to 4a1321bc99
closes odoo/odoo#37127

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-09-20 14:33:54 +00:00
svs-odoo f6da4d57bc [FIX] stock: display generate serial number
Before this commit, the field to generate serial numbers in the
detailed operation move view wasn't displayed.

closes odoo/odoo#37197

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-09-20 11:00:50 +00:00
Hetal Dhanak 921c48bdb0 [IMP] base: update demo data(address) for partner.
Purpose of the commit is to adapt demo data for the maps view
as we currently have a cluster of pins, which doesn't showcase the feature.

So updated the address of the main partners.

Task-2041896

closes odoo/odoo#36179

Closes: #36179
Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
2019-09-20 09:40:47 +00:00
Christophe Simonis ae1cabdd34 [FIX] account: correct tests amounts to reflect reality
closes odoo/odoo#37183

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-09-20 09:03:30 +00:00
Christophe Simonis 38ac47f578 [FIX] core: correct record values comparison in tests
Do not consider the whole record as matching the expected values once a
float match.
2019-09-20 09:03:30 +00:00
RomainLibert d5276ad10a [FIX] hr_holidays: do not show the title in edit mode
We should avoid showing the title in edit mode as it doesn't get updated
automatically.

closes odoo/odoo#37193

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-09-20 09:58:14 +00:00
Mathieu Duckerts-Antoine 149d2a3d60 [FIX] web: always show the graph view button "Stacked"
With the actual code, some computations are done
in the graph renderer to determine if it is worth
to show the "Stacked" button in the graph view control
panel for the data on hand. It turns out that that
problem is not satisfactorily addressed and is quite
hard from a usability perspective. We prefer to restore
the old behavior as long as we don't have better ideas.

closes odoo/odoo#37188

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
2019-09-20 09:23:24 +00:00
RomainLibert d0c1db764c [FIX] hr_holidays: change constraint message
The message for the validity of the leave type was not clear enough,
this commit makes it clearer.

closes odoo/odoo#37191

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-09-20 09:46:52 +00:00
RomainLibert 51ace5d1a5 [FIX] hr_contract: some information should not be copied
closes odoo/odoo#37186

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-09-20 09:19:28 +00:00
jbm-odoo 2acff81c83 [FIX] hr_holidays: Avoid too long number in header dashboard
In time off dashbord, due to python precision computation we can
have amount of days like 9.9999998. This commit make a rounding
after 2 digits and doesn't add new 0 at the end.
For example:
3 -> 3
3.1 -> 3.1
3.14 -> 3.14
3.141 -> 3.14

closes odoo/odoo#37182

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-09-20 08:59:45 +00:00
Florent Lejoly 397f86b962 [FIX] website_slides: remove creation of quizz in reporting
Currently in the slide.question view it is possible to open a form
to create new questions for quizzes, but it is impossible to fill the form with
the required information to create a new question. So the create button has no purpose.
This as "slide_id" is required but can't be set in the form.
Now the option to add question from the reporting tab 'Quizzes'
is removed as the questions (with the answers) are added in the form from
slide.slide.

closes odoo/odoo#37117

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-09-19 08:36:46 +00:00
wan 978f9ce2c6 [FIX] account: onchange in reconcile model
The onchange on tax_ids and second_tax_ids was only recomputed when
tax_ids changes (duh) so the variables show_force_tax_included and
show_second_force_tax_included were not set when coming back to the
formm after having saved a line with one tax.

closes odoo/odoo#37111

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-09-19 08:12:32 +00:00
Krunal Trivedi 78c0934f76 [FIX] website_slides: display bug after submitting quiz
After submitting the quiz, buttons and validation content was rendering  on top
of the quiz instead of under it. This display bug is fixed in this commit.

Task-2072564

closes odoo/odoo#37040

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-09-18 06:00:01 +00:00