Commit Graph
2976 Commits
Author SHA1 Message Date
Thanh Dodeur 418934c476 [FIX] mail: adapt mail notification
Before this commit, some notifications in mail were not following the
changes made in odoo/odoo#52826 .

task-2278579

closes odoo/odoo#63741

X-original-commit: eabab5f20fe3ba79b3117b83af5c62453edc84a4
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-23 13:03:40 +00:00
Sébastien Theys 7a5e08bdd3 [FIX] mail: speed up render of Message by inserting content manually
`t-raw` is too slow due to parsing the HTML in JS, converting it to VDOM and
comparing to existing VDOM. Here we can make a custom comparison based on actual
string, and directly replace in DOM if needed.

Part of task-2399731

closes odoo/odoo#63539

X-original-commit: cc531a07002fd8642f53e77c0fa52a49753e9df8
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-12-17 13:15:27 +00:00
Alexandre Kühn 6e8488caa4 [FIX] mail: inconsistency of new message style
The style of discuss new message (+) and chat window new message
should be consistent, as they both cover the exact same feature.

closes odoo/odoo#63530

X-original-commit: d8e816f95e2c51071415a3d4a9171d7014bb7b1c
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-12-17 12:24:20 +00:00
Hardik Prajapati 1a58bcce08 [FIX] mail: Update the kanban record on activity creation/updation
Currently, scheduling the activity from the document chatter does not
appear on the kanban record on activity button.
and the 'onchange' action receives the ID of the activity that was
marked as done and thus the 'Missing record' error

So in this commit, on creation and done of activity reload the view to
update the record on kanban card.

The opportunity is taken to make a pass on all of the "reload" to add the
`keepChanges` flag to prevent from losing pending changes on reload, especially
useful in form view.

closes odoo/odoo#63464

Taskid: 2362964
X-original-commit: 6d75304604687d873b296c630b87bc184e221018
Related: odoo/enterprise#15345
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-16 15:04:06 +00:00
Didier (did) 7e0c645d37 [FIX] mail: mark all needaction as read when opening the thread
This was the case before the refactoring.

task-2411114

closes odoo/odoo#63461

X-original-commit: bcb32beb49e5d86ea0d6307cbeeb7e85a22d18b0
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-16 14:42:21 +00:00
Thanh Dodeur d1919017b5 [FIX] mail: prevents image loading errors
Before this commit, an event listener was still active after the removal
of the attachment viewer, which caused the the onLoad function to be
called on an removed component if the component was unmounted before
the image was loaded. This commit fixes this issue by adding the
eventListener through the owl template.

Additionally, when a new image was loading, the old image was kept in
the dom until the end of the loading of the new image, this commit
also fixes this issue by adding a t-key on the image element.

part of task-2363522

closes odoo/odoo#63452

X-original-commit: 31f71f500b88aa3eb0688ab990d0c5f00676c71e
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-16 13:52:55 +00:00
Thanh Dodeur cdb469bce5 [FIX] mail: prevents traceback when clicking attachment unlink button
Before this commit, quickly clicking on the unlink button of an
attachment could result in a traceback if the click happened right
after the deletion of attachment but before the rendering of the DOM.

part of task-2363522

closes odoo/odoo#63447

X-original-commit: 1858184394342f24f5456728c4255f9980220c20
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-16 13:04:51 +00:00
Sébastien Theys bd7aeae189 [FIX] mail: prevent messaging menu from hiding home menu in mobile
task-2330277

closes odoo/odoo#63405

X-original-commit: db7f4437a644b93a5227f663fa19dda00817c13c
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-15 14:33:23 +00:00
Julien Giannone 0286a46c96 [IMP] mail: Rename temporary to uploading in attachments related content
This commit renames "temporary" into "uploading" in attachments content

task-2337268

closes odoo/odoo#62526

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-15 12:48:21 +00:00
Sébastien Theys 4816c7bf03 [FIX] mail: fix display of chatter topbar in multiline
When the topbar goes to multiple line due to too much text content to fit its
currently available space (depending for example on length of text after
translations), it will look bad before this commit because the "send message"
and "log note" have a visual effect when they are open that requires them to be
directly above the composer to look good.

Part of task-2413814

closes odoo/odoo#63351

X-original-commit: 008def3f878b63cb49e0b5ef09a2cc22c784c0a9
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-14 16:55:17 +00:00
Mathias Markl abea29fcd2 [FIX] mail: use correct badge color for messaging and activity menu
closes odoo/odoo#63323

X-original-commit: 8b419521124c47ac8eaf860fe70f6c0095fa8231
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-14 12:00:14 +00:00
Adrien Widart 9faef60b2b [Fix] mail: incorrect activity creation date
After an activity creation, if a user checks the activity's information,
the creation date will be the current date.

To reproduce the error:
1. Add an activity (e.g. a TODO activity)
2. In log notes, click on the activity's information icon

=> The "Created" field is actually the current date and not the
activity's creation date.

OPW-2412967

closes odoo/odoo#63233

X-original-commit: f25da5fef15d10b184d744bf5533b90364a35a81
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-11 11:52:03 +00:00
Sébastien Theys 171b0b9f69 [FIX] mail: prevent autofollow when using mentions in notes
task-2415579

closes odoo/odoo#63215

X-original-commit: e5c3d63375bf314f6748fd3f8b95eba313b154ac
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-12-11 09:53:23 +00:00
Thanh Dodeur 4f4ff204da [FIX] mail: handles unlink button spam on attachments
Before this commit, attempting to delete attachments multiple times
could result in errors, especially on slow networks.

This commit fixes this issue.

task-2363522

closes odoo/odoo#63189

X-original-commit: 528adfb313ab3c8d4aeb3309aa7371301ab8085e
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-10 16:06:25 +00:00
Ipsita Borisagar 4299d2233c [IMP] bus,mail: improve discuss notification design
PURPOSE

Discuss notification needs to be changed for better UI.

SPECIFICATION

Improving design of discuss notification by using bg-info instead of bg-warning.

LINKS

PR https://github.com/odoo/odoo/pull/55542
Task-2308799

closes odoo/odoo#55542

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-10 15:20:45 +00:00
Thanh Dodeur c53b798267 [FIX] mail: prevents traceback on attachment delete during upload
Before this commit, removing attachments that are being uploaded
could lead to a traceback if the removed attachment was still
awaiting for the upload of another attachment.

part of task-2363522

closes odoo/odoo#63164

X-original-commit: d345ab808d1261953ee9c588d1cb5fe2571d3e69
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-10 13:26:14 +00:00
Sébastien Theys fb7b32dbcb [FIX] mail: only highlight needaction on their origin thread
task-2391170

closes odoo/odoo#63163

X-original-commit: 2752d961922a3527f3c919d4578a33b8e87eeffb
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-10 13:14:22 +00:00
Didier (did) 626db2b2d3 [FIX] mail: disable multiline channel
This avoid text flickering when a multiline channel name is hovered in the
discuss sidebar.

task-2274991

closes odoo/odoo#63100

X-original-commit: 6a3d8982a657fc4e124f6bebe457289297efdabe
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-12-09 14:27:21 +00:00
Didier (did) 4a85802852 [FIX] mail: fix unfedined record when pressing "end" key in mentions
task-2411756

closes odoo/odoo#63099

X-original-commit: 4b5cfee6726fed4918deecba2237d948f9e416f0
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-12-09 14:26:53 +00:00
Ivan Yelizariev 1b502a4ec7 [FIX] mail: turn tagged name with special characters into links
STEPS:
* Created partner with following name: Putin's spokesman
* Tag the partner in a message: @Putin's spokesman

BEFORE: tag is not converted into a link
AFTER: the link is created

WHY: _generateMentionsLinks uses ``owl.utils.escape`` which is different from ``_.escape``

https://github.com/odoo/odoo/blob/880555b38dee0c3e3b364c19bb6b0db983bf8aa0/addons/mail/static/src/models/composer/composer.js#L659

So following replace didn't work:

https://github.com/odoo/odoo/blob/880555b38dee0c3e3b364c19bb6b0db983bf8aa0/addons/mail/static/src/models/composer/composer.js#L667

---

opw-2408863

closes odoo/odoo#63056

X-original-commit: 5b62b40713d28cc905fd4c54de13cf2de39d988d
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-08 17:58:09 +00:00
Prakash Prajapati 10b57a0606 [FIX] mail: Fix traceback on immediate onchage after mark activity done
Currently, there is traceback when we make the activity as done and
directly fire the onchange.
Reproduce step:
1) Create an appraisal
2) Create an activity
3) Refresh the Page
4) Done the activity
5) Unpublished the Manager Feedback

The 'onchange' action receives the ID of the activity that was marked as done
and thus the 'Missing record' error.

So in this commit, on done of the activity trigger refesh to reload the
activity ID.

closes odoo/odoo#63034

Task-id: 2357760
X-original-commit: 23d9bd0b7e43dcb431450664172fbcd409c9d62c
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2020-12-08 14:51:48 +00:00
Sébastien Theys fe93fc28eb [FIX] mail, im_livechat: properly handle multiple public partners
task-2391334

closes odoo/odoo#63002

X-original-commit: 9fbea9f8ee193e672c855c73ad29de187f27cef1
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-08 11:28:38 +00:00
Alexandre Kühn 8209076b1f [FIX] mail: ignore partner notification with unsupported type
Task-2411800

closes odoo/odoo#62825

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-03 13:32:55 +00:00
Alexandre Kühn 4efb465f6a [FIX] mail: prevent Safari from indefinitely focusing composer
`setSelectionRange()` on Safari has side-effect to focusing the
input element, which is not the case in Chrome and Firefox.

Task-2410311

closes odoo/odoo#62886

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-04 12:54:14 +00:00
Didier (did) acb09f799a [FIX] mail: wrong top value in composer css
closes odoo/odoo#62890

X-original-commit: 329b00365e7b7702eb4923443c99ddac13340ae8
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-04 13:36:16 +00:00
Alexandre Kühn 62a2ca4c14 [FIX] mail: make messaging menu header visible in Safari
Task-2389455

closes odoo/odoo#62885

X-original-commit: 759ddc180a7fa186d9ad36583ebd1f4857f584e7
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-04 12:48:54 +00:00
Xavier Dubuc cf31cd7946 [FIX] mail: split attachments list to improve style
There is now two lists of attachments : first one with images and second
one with non-images. Attachment viewer allows to navigate through
previews of all viewable attachments in the order they're shown.

task-2272587
task-2401325

closes odoo/odoo#62719

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-04 09:16:32 +00:00
Xavier Dubuc 1797835051 [IMP] mail: replace selectedMessageLocalId prop by value from store
task-2282218

closes odoo/odoo#61768

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-02 10:26:46 +00:00
Xavier Dubuc bdff0f6d28 [FIX] mail: fix partner seen infos wrongly set as readonly
task-2391981

closes odoo/odoo#62239

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-12-04 09:06:49 +00:00
Didier (did) 3f100568b5 [FIX] mail: increase chatter max-height.
We go back to the fake textarea to avoid a flickering created by the
`this._textareaRef.el.style.height = "0px";`.
This height reset create an unwanted scrollbar jump that could hide the content
of the textarea (not aside mode).

task-2390354

closes odoo/odoo#62828

X-original-commit: 52f3db8ef61d4284d8ea624022bc1355f7f8cf00
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-03 13:51:29 +00:00
Sébastien Theys 0cf14852a3 [FIX] mail: remove html from new message notification
task-2388659

closes odoo/odoo#62756

X-original-commit: 8af59b95b477b2eeddec118663e21b00a4e48801
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-12-02 15:51:27 +00:00
Didier (did) a57d4377fb [FIX] mail: set href on notification link.
This allow the user to open link in new tabs with middle click

task-2387837

closes odoo/odoo#62738

X-original-commit: 7a57cf0b68b3a1dce4276c6456a94b05eec20f28
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-12-02 12:35:42 +00:00
Nicolas Galler 25728bea74 [FIX] mail: when adding an attachment, do not discard edits
Behavior prior to this commit:

- edit an existing invoice
- add a line, but do not save
- add an attachment - the attachment uploads and the new line stays visible
- save the record: the line now disappears

Behavior after this commit:

- changes are not discarded when uploading an attachment

opw-2369162

closes odoo/odoo#62727

X-original-commit: abf1982d4ec09b5e87c1d7573158257f91961214
Signed-off-by: Nicolas Galler <ngaller@users.noreply.github.com>
2020-12-02 11:03:14 +00:00
Xavier Dubuc de638c3f18 [FIX] hr_holidays: bring back the out of office panel in threads
task-2277511

closes odoo/odoo#62638

X-original-commit: d9aa362914945e6cb095b04fa94cfb3469abd907
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-12-02 11:03:39 +00:00
Sébastien Theys 8ee21a9cd0 [FIX] mail: fix mention suggestion order and skip intermediate rpc
task-2387825

closes odoo/odoo#62639

X-original-commit: 661f687256995452756d6396308bcc167a5dcb9f
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-11-30 17:14:07 +00:00
Sébastien Theys 5cfc62cb33 [FIX] mail: prevent from closing an already deleted chat window
task-2394789

closes odoo/odoo#62626

X-original-commit: c32a3e9cbe0323e0b1fcc70b1438e9a56185493c
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-11-30 15:26:02 +00:00
Didier (did) 31e015f80f [FIX] mail: mark document as read when open
task-2387820

closes odoo/odoo#62429

X-original-commit: fe3dbfb77eb403bb6eb69cd9d667fd8baa714ff7
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-11-26 15:29:28 +00:00
Didier (did) e68ccce1c2 [FIX] mail: attach the dropzone to the chatter
Before this commit the dropzone was relative to div.content. This would create
some bad position where the dropzone was covering the form view but not the
chatter.

task-2389929

closes odoo/odoo#62402

X-original-commit: bb650a9a1f4ff8280bd1e3467624991bc87517b9
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-11-26 13:06:42 +00:00
Didier (did) 756e3daa00 [FIX] mail: avoid notification if the channel is not a chat.
task-2387822

closes odoo/odoo#62348

X-original-commit: 8ad230ad64557798df09e28677f05a9f41773ead
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-11-25 16:37:14 +00:00
Sébastien Theys 2522a7b35e [FIX] mail: remove illegitimate followers from chats
task-2392114

closes odoo/odoo#62349

X-original-commit: 26a76f81590ae92f5bec51be1441d6779b1afe85
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-11-25 16:37:40 +00:00
Didier (did) 1df1e39139 [FIX] mail: refresh activity list after editing and activity.
It's possible to create a new activity when editing a existing activity (done
and schedule next). In this case, we must refresh the activity list, otherwise
they wont be in the chatter.

task-2389961

closes odoo/odoo#62333

X-original-commit: 26a2c047a2757c600b3128fe753fa1328043a245
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-11-25 14:13:18 +00:00
Xavier Dubuc 5987bb14e1 [FIX] mail: fix chat window shift operations titles
They are now language direction dependent.

task-2314205

closes odoo/odoo#61713

Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-11-25 11:00:59 +00:00
Julien Giannone 01b5bf1442 [FIX] mail: fix text selection in composer using SHIFT and arrow keys
This commit corrects the faulty SHIFT + ArrowKey selection behavior.

task-2388650

closes odoo/odoo#62251

X-original-commit: d498f899aa2ef81acbcd035896b9fcc912e4d52b
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-11-24 14:24:48 +00:00
Sébastien Theys 5ab794cf30 [FIX] mail: avoid adding non-members on mention in channels
task-2392010

closes odoo/odoo#62242

X-original-commit: 0a3fe0a513abbde8f74d59de522a216035cdcd98
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-11-24 12:52:37 +00:00
Priyanka Kakadiya f285907c7d [FIX] mail: added test for no suggested recipient in lognote
LINKS

Task - 2371744
PR - https://github.com/odoo/odoo/pull/61388

closes odoo/odoo#62180

X-original-commit: 9cfb82dd4a9f3bef94960abd40c648373eff4ea9
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-11-23 13:18:59 +00:00
Priyanka Kakadiya 8b525d01a8 [FIX] mail: focus should be on composer after post message
PURPOSE

When sending a message by clicking on the "send" button manually, the focus
should stay on the text input (and the mobile keyboard should stay open), so
that it is possible to quickly send another message afterward without having to
re-click manually on the text input

SPECIFICATION

the focus should be set to composer automatically after sending a message

LINKS

closes odoo/odoo#62179

Taskid: 2372546
Pr: https://github.com/odoo/odoo/pull/61226
X-original-commit: 6cc5d4ae9ed2d7dbbad51ae720365730c8a416ac
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-11-23 13:18:32 +00:00
Sébastien Theys 5f42a13bfa [FIX] mail: prevent crash when initializing many failures
The test highlighting the current issue has been posted in PR
https://github.com/odoo/odoo/pull/62076

But it is not included as part of the current PR because it is too slow to
execute, while it is unlikely we will break this fix as it is not influenced by
anything else in the code.

The reason why we need this change is because on some database, including ours,
we have users who have more than 1000 failures still unresolved and they are
all returned at init.

closes odoo/odoo#62173

X-original-commit: 32ed8125aeb356e568d3c49ef7a04c0ff9e36169
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-11-23 12:28:54 +00:00
Sébastien Theys 385a776a1f [FIX] mail: avoid empty seen indicator
`MessageSeenIndicator` sub-component should not be rendered if the thread does
not support seen indicators.

The issue is manifesting because the otherwise empty indicator has a margin,
which is adding more space than expected before the following element.

closes odoo/odoo#62172

X-original-commit: 4e0e8a415ae2175cd68e514cff33b2bffeb99db7
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-11-23 12:28:26 +00:00
Julien Giannone 225ae4d53e [FIX] mail: Sidebar channel find shows all channels
When searching for a channel in Discuss, the search results include
all matching channels even those user is already member of

task-2347837

closes odoo/odoo#62161

X-original-commit: 884bebb0f549dc4385cec9542f74e0bba64ccb08
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-11-23 11:39:50 +00:00
Didier (did) 831a83f273 [IMP] mail: implement read only field
Fields can now be marqued as read only.
```
stringifiedDomain: attr({
    default: '[]',
    readonly: true,
}),
```

closes odoo/odoo#60086

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-11-23 09:17:40 +00:00