Commit Graph
2976 Commits
Author SHA1 Message Date
Xavier Dubuc 06aef5e05f [FIX] mail: allow temporary attachment to be canceled
task-2324065

closes odoo/odoo#57623

X-original-commit: 9f774d4fb512017ab5f99981255afc8d2c35113c
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-09-14 10:08:50 +00:00
Didier (did) 6c54a5c6d2 [FIX] mail: avoid star flicker when hovering a message
task-2278441

closes odoo/odoo#57575

X-original-commit: 35e1a675803e64eda0fdae402cbddb56d5c0b1d8
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-09-11 16:55:29 +00:00
Didier (did) 9bc4d91960 [FIX] mail: fix image ratio on composer and thread preview
task-2318662

closes odoo/odoo#57522

X-original-commit: 1cd5712ff7f04b2fdb185f4fe78dbd3f4f75b801
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-09-11 11:52:19 +00:00
Alexandre Kühn 8be77ece37 [FIX] im_livechat, mail, website_livechat: invite button in livechats
Task-2334724

closes odoo/odoo#57511

X-original-commit: 5316c91c27e48bfaa3ebf3fb97e35220fabc986e
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-09-11 11:07:12 +00:00
Didier (did) 7352aa6e26 [FIX] mail: move attachment icon on the right (chatter top bar)
task-2333122

closes odoo/odoo#57453

X-original-commit: 0708b38d2512900d3456a9560673171c1286e571
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-09-10 15:38:12 +00:00
Xavier Dubuc 48bce60f02 [FIX] mail: remove no more needed root div node in moderation dialogs
task-2310610

closes odoo/odoo#57448

X-original-commit: 76c2eb1590b360a874ef5ccb0df7edf0f1b84bab
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-09-10 15:02:33 +00:00
Didier (did) 2559787fc9 [FIX] mail: allow overflow on the chatter
task-2333128

closes odoo/odoo#57447

X-original-commit: d04d2933d72376c80ceb2f1e6769d4a5785f08dc
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-09-10 15:02:07 +00:00
Sébastien Theys 618c77259b [FIX] mail: allow tests to await specific events
task-2333915

closes odoo/odoo#57187

X-original-commit: 699106ce65a87f7a24f04e1d8f232b5a6b4e210a
Related: odoo/enterprise#13018
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-09-07 13:16:18 +00:00
Didier (did) 0cde1189c6 [FIX] mail: chatwindow scroll to the last message when posting
Before this commit, when a user posted a message from a chatwindow, the scroll
did not move to the last message.

task-2314409

closes odoo/odoo#57183

X-original-commit: 8e4f133890b08e7e9a909abbc97b89bb5409119a
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-09-07 12:17:39 +00:00
Xavier Dubuc 8d96bfd080 [FIX] mail, sms, snailmail: prevent message_fetch for hidden threads
Automatically load messages from a thread cache only if the thread cache is used
in at least one thread view.

Ensure thread viewer don't keep thread view records alive when they are not
displayed.

This change is particularly important for performance, to avoid spamming RPC at
init if many threads are opened in chat windows.

task-2310623

closes odoo/odoo#57121

X-original-commit: 8d3413ff647de8d98c6858062dd07dde4160af95
Related: odoo/enterprise#12979
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-09-04 17:01:43 +00:00
Alexandre Kühn f20adc19d2 [FIX] mail:tests: "Timeout: the render didn't stop."
These tests assert that some user interactions didn't do something.
The user interactions were mistakenly expecting to trigger some
re-render.

Task-2333810

closes odoo/odoo#57091

X-original-commit: b4c4086104d815442ff6f2e92f80513f2ffad5ab
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-09-04 12:08:18 +00:00
Xavier Dubuc 09c77f6c89 [FIX] mail: allow composer text input to send message with ctrl+enter
Also allow meta+enter

task-2296863

closes odoo/odoo#57050

X-original-commit: 6bad3666be3d3631eaadae409d0cabcdd02661a8
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-09-03 15:01:39 +00:00
Sébastien Theys e338dc82a6 [FIX] mail: add open chat when clicking on author im status icon
task-2329538

closes odoo/odoo#57015

X-original-commit: bfb8d99baaadedb2d0492b6f378b13b3330d496a
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-09-03 10:00:23 +00:00
Sébastien Theys c4c1f20862 [FIX] mail: prevent crash when switching mailbox in discuss mobile
task-2327203

closes odoo/odoo#56939

X-original-commit: 612a8f7edf3d01ec2b854839ee60be418cb141a7
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-09-02 11:36:05 +00:00
Sébastien Theys a0c7b35237 [FIX] mail: display subject of mailing channels in italic
task-2321974

closes odoo/odoo#56928

X-original-commit: 7b06b094bd4ee4008fa29dd8d3db79275d4cde1f
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-09-02 09:38:06 +00:00
Alexandre Kühn de57a2db14 [FIX] mail: message/activity link with dataset oe-id and oe-model
Task-2328718

closes odoo/odoo#56872

X-original-commit: 430aa0c2ffe242992fb935733d81f6e05a6d2458
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-09-01 11:28:05 +00:00
Sébastien Theys 590a088750 [FIX] mail, *: fix opens and redirects, adapt messaging menu close
task-2244279
task-2262862
task-2274993
task-2277537
task-2282238

closes odoo/odoo#56755

X-original-commit: 17611f4adc5e950b0a75a2a6615b1da3c956387f
Related: odoo/enterprise#12769
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-08-28 17:34:13 +00:00
Sébastien Theys 6d9499fcce [FIX] mail, *: rename thread viewer to thread view
The "viewer" should be the "parent" not the view itself. This distinction will
become important in a future commit to allow viewers to not display the view in
some situations.

Rename done as a standalone commit to ease diff readability.

Part of task-2310623

closes odoo/odoo#56751

X-original-commit: f9ee1cf5f904116e4d1d70a8eaf4ee1d58b18a3a
Related: odoo/enterprise#12764
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-08-28 15:34:40 +00:00
Sébastien Theys 9965e35490 [FIX] mail: prevent "record created" from being twice in the chatter
task-2280184

closes odoo/odoo#56694

X-original-commit: 1af2cc1b2190623739085de83870fb415cbdccf1
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-08-27 17:14:52 +00:00
Alexandre Kühn b18ec3b024 [FIX] mail: 'Cannot read messagingMenu of undefined' traceback
Before this commit, on page reload, sometimes web client crashed with
`Cannot read 'messagingMenu' of undefined`.

This happens due to messaging components making use of `messaging` in
`env` as if it was always set. In some rare cases, this is false,
hence the crash. This happens on root components of messaging such as
the messaging menu.

Creation of `env.messaging` has to be async, in other to ensure all
JS module that patches messaging are applied. The mounting of
messaging root components depends on other parts of the web client
like the SystrayMenu. So the proper fix is to guard `env.messaging`
on these root components.

Task-2238245

closes odoo/odoo#56684

X-original-commit: d1483ff3c83bb3146e80e5d65a27915c5b2a2bf9
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-08-27 15:53:02 +00:00
Didier (did) bc5654f0a4 [IMP] mail, mail_bot: move notif request and OdooBot name into mail
task-2282334

closes odoo/odoo#56616

X-original-commit: bde23b82029507e525cf55d11b050af5f820a06b
Related: odoo/upgrade#1705
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-08-26 15:49:21 +00:00
Didier (did) 14d6393594 [FIX] mail: fix margin issue when an activity is marked done
task-2280172

closes odoo/odoo#56538

X-original-commit: 16f705d8c9434bbbdf8a8987edb2ba325aa9f307
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-08-25 16:21:51 +00:00
Didier (did) db0e95e368 [FIX] mail: reduce vertical spacing for tracking messages
task-2282385

closes odoo/odoo#56492

X-original-commit: c80ed69bb5b06d3df18a6491c1b889fcdb0de741
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-08-25 10:31:52 +00:00
Didier (did) 3b4d26e9b8 [FIX] mail: reduce space in activity
The Wysiwyg editor put `<p><br></p>` even without a note on the activity. To
reduce the size in the UI, We compute the note to replace these almost empty
note by an actual empty value.

task-2282324

closes odoo/odoo#56481

X-original-commit: bf441dbc66439137c3a19093a6b524545ae94cee
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-08-25 09:49:36 +00:00
Xavier Dubuc ef7aebe1c7 [FIX] mail: fix activity box title arrows orientation
task-2323230

closes odoo/odoo#56471

X-original-commit: bc00dfcf197aa3b57ed76ef086c0802f4416de14
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-08-25 09:10:50 +00:00
Xavier Dubuc 61b876f962 [FIX] mail: fix tracking value alignment in notification
task-2321970

closes odoo/odoo#56470

X-original-commit: 016e36959337bf81ccf1d00733250af563bd605f
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-08-25 09:10:24 +00:00
Sébastien Theys efb66e8e7f [FIX] mail, im_livechat: make livechat work properly
- fix traceback on receiving first livechat message due to bad computation of
  correspondent
- fix missing [0] in return of country name_get in channel_info
- fix visitor/correspondent computation to work when chatting with oneself
- reintroduce livechat ordered by last message in discuss sidebar
- improve mock server to make these fixes possible to test
- introduce corresponding tests

PR: #56243
task-2323670

closes odoo/odoo#56423

X-original-commit: f623bfd2c8819604c709bc723153c071dca6e3cc
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-08-24 13:47:01 +00:00
Sébastien Theys 7bec33f578 [FIX] mail: ignore broadcast notifications targeting another user
This is typically not the case in production code, but it doesn't hurt to be
safe. The main reason for the change however is that it causes issues in tests
due to the easiest way to simulate notifications being to send them directly on
the bus which is "listened to" no matter the target user.

PR: #56243
Part of task-2323670

X-original-commit: 62e1e7fe39a7bed6ce70466a0aec645c7a0f299d
2020-08-24 13:47:00 +00:00
Sébastien Theys 4ab5c2a48b [FIX] mail, im_livechat: ignore notifications for unknown channels
Inserting channels and handling notifications for channels that have not been
properly initialized through the `channel_info` leads to issues due to
incomplete data that is not properly handled, such as bad correspondent, missing
uuid, inconsistent name, etc.

Moreover it doesn't make sense functionally to handle notifications such as
typing status if the channel isn't going to be displayed.

PR: #56243
Part of task-2323670

X-original-commit: 75070665060d64fe7b532aac4fc8e8410381b083
2020-08-24 13:47:00 +00:00
Sébastien Theys ef873e0c29 [FIX] mail: introduce findFromIdentifyingData
This is necessary to check the existence of a record based on identifying data
without having to use `insert` (or the inefficient `find`).

PR: #56243
Part of task-2323670

X-original-commit: c4bbfc5e2a8d236e5fc79a63c13575de146afbd7
2020-08-24 13:46:59 +00:00
Sébastien Theys a0e918796f [FIX] mail: remove JS record proxy in favor of accessors
- accessors are defined only once on the model
- they work per field which avoids having to check if target param is in fields
  at every read/write on record

Also store fields as list in `__fieldList` to quickly iterate them without
`Object.values`.

`__combinedFields` are now renamed to `__fieldMap` instead of just `fields` to
avoid confusion with fields definition, and to have a naming similar to
`__fieldList`.

Part of task-2308312

closes odoo/odoo#56314

X-original-commit: 42a94d49b9e8333cf91807c96f0ddd740782915e
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-08-21 14:16:34 +00:00
Sébastien Theys 79f6b15c74 [FIX] mail: avoid unnecessary update of inverse in JS models
Part of task-2308312

X-original-commit: 0e08e43decf18108d25d051ad76c093bcdf434db
2020-08-21 14:16:33 +00:00
Xavier Dubuc 0263acee7f [FIX] mail: prevent composer to send message if pending uploads
task-2317862

closes odoo/odoo#56303

X-original-commit: 3b5cd048f1dfa18869e95b173b4232b4bb189025
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-08-21 12:57:44 +00:00
Xavier Dubuc 4b879490dc [FIX] mail: fix some CSS in chat window and attachments
Also make rounded style for composer tool buttons.

task-2282342

closes odoo/odoo#56282

X-original-commit: 307fa6877ad72fe0afb10f1b4e67ec573422b732
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-08-21 10:45:54 +00:00
Hardik Prajapati a98f062116 [FIX] web: list: list_activity widget popover not visible
In edit mode, the list_activity widget popover is not fully visible
(most of it is cut). The reason is that at some point the rule
specifying that the containing list cell should have the property
'overflow: visible' became less important than another global
rule imposing the property 'overflow: hidden'.

The present commit makes sure that 'overflow: visible' is applied on all
list cells containing a list_activity widget.

Task ID: 2305805

closes odoo/odoo#56166

X-original-commit: 115fedf30da2ca016a2e435949a18561a389d37f
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
2020-08-19 16:59:56 +00:00
Xavier Dubuc 26147e5378 [FIX] mail: fix zoom out icon of attachment viewer
task-2321975

closes odoo/odoo#56109

X-original-commit: a36be26565e91aa9c6296eb45f8c9cb25eb4adee
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-08-19 09:18:07 +00:00
Xavier Dubuc 36cf229dce [FIX] mail: use right chatter field for chatter prop value
task-2319706

closes odoo/odoo#56108

X-original-commit: 8955626b0f08be7364e715f0fdb91ef72a31f757
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-08-19 09:29:42 +00:00
Aymane (ayt) cef57b930b [FIX] mail: fix activity scheduling dropdown overflow
The dropdown for scheduling the next activity was overflowing inside the
container div.

After this commit, the dropdown is now attached to body element.
In other terms, the pop-in window to schedule an activity in the web kanban
activity widget is now visible (and not displayed anymore under previous line
in the widget tree view).

Task ID:2301262

closes odoo/odoo#56072

X-original-commit: 5ca624605571f79d1bca27c9a40286722c2a801b
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2020-08-18 14:24:28 +00:00
Priyanka Kakadiya 2b06be6860 [IMP] mail: improve followers refreshed on thread
PURPOSE

Currently it does two RPCs to refresh followers on thread:
1) To get follower ids
2) To get followers detail

SPECIFICATION

While refreshing followers on the thread, perform only one RPC call.

LINKS

Task-2243180
PR https://github.com/odoo/odoo/pull/54437

closes odoo/odoo#55989

X-original-commit: 1fd445fb55810b97ed7a6dfe694e471891c6a3bc
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-08-17 11:56:46 +00:00
Francois (fge) c06bb52f57 [IMP]hr_recruitment: Back2Basic - Improve Recruitment usability
Added a new tour for the module hr_recruitment

Hr.job:
Form view:
- Using a notebook view for increased clarity
Kanban view:
- Added a toggle button to publish/unpublish a job offer.
- In the menu, added the « Create Interview Form » button to create an interview form.

Hr.applicant:
Generale:
- Use of the "Applicant: Acknowledgement" template by default when an application is moved to the "First Interview" stage.
Form view:
- Possibility to consult an interview after this one and not before
- The "CREATE EMPLOYEE" button no longer directly creates an employee. The employee will be created if the "SAVE" button is pressed.

Hr.employee:
Generale:
- Added of two new certifications.
And some other minor style and name changes.

closes odoo/odoo#55928

Related: odoo/enterprise#12420
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2020-08-14 14:51:41 +00:00
Sébastien Theys c2918c139b [IMP] web, *: improve mock server and replace most mail mockRPC
Improve mock server:

- add support for mocked `fetch`
- add support for `active_test`
- add support for x2m `in` in domains
- add support for default values computed from a function
- implement a more natural "next id" compute
- allow initial data without ids
- ensure write and x2m commands integrity
- improve bad data/bad commands error messages
- always warn for failing RPC, not only in debug mode
- fix all existing tests that had inconsistency data

Other changes done in mail (or dependents) that are not just related to tests:

- remove `direct_partner` from formatter result
  ->`correspondent` can be computed from other keys, especially `members`

- fix `livechat_visitor` convertData
  -> only process if there is value

- add `current_partner` and `current_user_id` as `init_messaging` result
  -> easier to mock than session

- remove usage of `need_moderation`
  -> that was just a search indirection to `moderation_status`

- adapt `partner_id` -> `res_partner_id` key in `_notification_format`
  -> to be consistent with field name

- add name in result of `mail_partner_format`
  -> sometimes display_name is not the same

- remove usage of `is_moderator`
  -> that was just an indirection to `moderation_channel_ids`

Enterprise counterpart: https://github.com/odoo/enterprise/pull/11523
task-2287171

closes odoo/odoo#55854

X-original-commit: 7ba3fecb3377a720d1eb70e7515a0c45da73836d
Related: odoo/enterprise#12391
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-08-13 16:26:35 +00:00
Xavier Dubuc a17725e998 [FIX] mail: fix full composer opening with attachments
task-2307201

closes odoo/odoo#55678

X-original-commit: 9c47bb0b0034a3419a0c6e3267d90cb520a59535
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-08-13 10:23:25 +00:00
Xavier Dubuc 7386a2b1ac [FIX] mail: fix activity mark done popover buttons alignment
task-2280166

closes odoo/odoo#55802

X-original-commit: e6eda62f8355de0adcc5f323347526d4124b68e2
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-08-12 11:02:49 +00:00
Xavier Dubuc 8e9e917bde [FIX] mail: fix activity box title alignment
task-2280179

closes odoo/odoo#55763

X-original-commit: a0a585da947dc3d26d5311317099c2469df9e13b
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-08-11 14:40:25 +00:00
Thibault Delavallée 7a253beab2 [REF] mail: split emoji files to ease inheritance
Purpose is to clearly distinguish

  * common: holding common code for emojis-enabled fields;
  * text emoji field: support of emojis in text fields;
  * char emoji field: support of emojis in char fields;

Task ID-2224393
PR #49096
2020-08-11 14:38:32 +00:00
xO-Tx 6b7e20da3f [IMP] mail : improve emoji widget code to ease overrides
This commit attempts to improve emoji widget css and code to make it easily
overridable by other modules. This is done in preparation for extension by the
SmsWidget that will enable the emojis support.

To improve the emoji widget, the following changes have been made

  * remove the spacing after emoji fields by setting widget dropdown height to
    0 (emoji dropdown has relative position + (height > 0) which leaves an
    empty space after widget fields);
  * hide Emoji widget when field has "invisible modifier";
  * move the code that adds the emoji dropdown to another method, allowing to
    better understand code organization;

Task ID-2224393
PR #49096
2020-08-11 14:38:32 +00:00
Xavier Dubuc 2be6e37aca [FIX] mail: tweak activity mark done popover
- focus feedback textarea on open
- close popover on ESCAPE

task-2250472

closes odoo/odoo#55683

X-original-commit: 63c77139828ff029d76ff4237dcdb5a3aff5265d
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-08-10 10:30:13 +00:00
Xavier Dubuc 62aad0ff66 [FIX] mail: avoid activities handling on view without activity_ids field
task-2314240

closes odoo/odoo#55679

X-original-commit: 7f626587bd7024e8141662fcc7b9f3cb1ac9485b
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-08-10 09:52:54 +00:00
Hiral Bhavsar 8bf5381d13 [FIX] mail: traceback while going to close dialog
Before this commit:

Traceback appearing while going to close subtypes dialog from followers or
closing the attachment viewer dialog.

This is happening because the dialog manager doesn't have a close function
after https://github.com/odoo/odoo/commit/9216bdcb6f0bbb20900a33bbf7283e6e4fda1b2c

After this commit:

Able to close the dialog without any traceback as fix it by call the delete
function.

LINKS

Task-2314898

closes odoo/odoo#55636

X-original-commit: f2186ceefe23cd1a45adc72089c8e828e9b75cc8
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2020-08-07 14:34:35 +00:00
Xavier Dubuc c9e25aab34 [FIX] mail: allow folded chat windows to be shifted
task-2313414

closes odoo/odoo#55593

X-original-commit: 609dab84c6085af1ab27ee142c6ee674d7d321e9
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2020-08-06 21:27:15 +00:00