Commit Graph
100425 Commits
Author SHA1 Message Date
Martin Trigaux 917f4e73c1 [FIX] calendar: do not try to escape empty date
display_start may be False and crash
2016-01-20 19:42:47 +05:30
Martin Trigaux 889e556403 [FIX] calendar: missing terms in calendar view 2016-01-20 19:40:37 +05:30
Stefano Rigano 5d393ba067 [FIX] web: typo on less mixin declaration 2016-01-20 15:01:01 +01:00
Géry Debongnie 8af3841cb2 [FIX] mail: prevent mail to rejoin a channel that we just left
sometimes, the web client receives unsubscribe notification and an extra
notification on that channel.  This is then followed by an attempt to
rejoin the channel that we just left.  This commit prevents that
situation to occur.

For that, it needs to know the notifications received by the bus in one
batch, not one at a time.
2016-01-20 14:41:34 +01:00
Nicolas Lempereur b395ade078 [IMP] *: unnecessary safe filter for subject template
With 6dde919 email subject field are not autoescaped by default, thus
using safe is not necessary.

closes #10547
2016-01-20 14:14:38 +01:00
Nicolas Lempereur 6dde919bb9 [FIX] mail: don't autoescape mail subject
The mail template rendering system use "autoescape" for subject, body,
email_to, ...

Using autoescape is good for the body, but for the subject it means
variables insertions have to be marked as safe.

This commit add another environment without autoescaping enabled for the
subject field.

From https://tools.ietf.org/html/rfc2822:

  The "Subject:" and "Comments:" fields are unstructured fields as defined
  in section 2.2.1, and therefore may contain text or folding white space.

  2.2.1. Unstructured Header Field Bodies

  Some field bodies in this standard are defined simply as "unstructured"
  (which is specified below as any US-ASCII characters, except for CR and
  LF) with no further restrictions.

closes #10547

opw-659231
opw-666801
opw-665863
2016-01-20 14:13:56 +01:00
Nicolas Lempereur 4bfc2799bd [FIX] web: don't print nothing when something is there
In most backend views using CTRL+P to use browser printing would only
print an header without the content.

stumbled-uppon-when-checking: opw-659430 opw-660763
2016-01-20 13:48:37 +01:00
Christophe Matthieu 3de1b4a4ac [FIX] web_editor: reduce the min-size of the html preview
opw-660810
2016-01-20 13:23:24 +01:00
Christophe Matthieu f93e03c4c7 [FIX] web_editor: can indent table cell (with button and tab)
issue: the user select some line and keypress tab without indent, and the button indent doesn't work in table cell
2016-01-20 13:23:24 +01:00
Christophe Matthieu 6e47472486 [FIX] web_editor: firefox can have undefined value for style and broke inliner feature 2016-01-20 13:23:23 +01:00
Christophe Matthieu 2ef6e249d0 [FIX] web_editor: merge span when paste, only if no content between tags
opw-667263
2016-01-20 13:23:23 +01:00
Christophe Matthieu 86b80689d7 [FIX] web_editor: remove empty table ligne when paste content 2016-01-20 13:23:23 +01:00
Goffin Simon 366980e550 [FIX] account: _prepare_analytic_line
In function _compute_expense_totals, the debit and credit of an account
move is computed in the right currency rate according to the date.
Then in function _prepare_analytic_line, the amount of an analytic line
must also be computed in the right currency according to the date.

opw:666538
2016-01-20 12:58:32 +01:00
Martin Trigaux e381b7e31a [FIX] web: technical translations menu
The action "Technical Translations" was not retrieving the correct translations.
Since 9.0, the translations names no longer contains the name of the model (in
the form "field:<model>,<name>") but are records on ir.model.fields (in the form
"model:ir.model.fields,field_description:<model>_<name>").
The translations of type selection are style a different type (type 'selection').

Create a method that will find the linked fields and retrieve the correct
translations.

Fixes tw:reis_pt/status/687419541199187969
2016-01-20 16:42:18 +05:30
Martin Trigaux 8c8c02598d [FIX] web: untranslated term 2016-01-20 16:41:58 +05:30
Nicolas Lempereur 6b791c20b8 [FIX] web: don't print nothing when something is there
In most backend views using CTRL+P to use browser printing would only
print an header without the content.

stumbled-uppon-when-checking: opw-659430 opw-660763
2016-01-20 11:54:46 +01:00
Christophe Matthieu e5112ee00b [FIX] web_editor: use iframe only for html widget with style-inline mode 2016-01-20 00:15:10 +01:00
Géry Debongnie 44ac7903cc [FIX] mail: prevent crash when interacting with inactive partner
when a user is disaninactivated, it makes sense to disaninactivate his/her
corresponding res_partner.  This had the unfortunate effect of changing
the result of the channel_slot call for the direct messages with this
user.  As a result, the discuss interface was not happy.  This commit
does what it needs to keep the discuss interface happy.  That's what we
want, right?
2016-01-19 16:25:35 +01:00
Aaron Bohy 5b338b665e [FIX] im_livechat: external loader: server_url undefined
Since rev. 100d604, the web.session module is always loaded in external pages,
even if no operator is available. Thus, server_url should always be computed.
2016-01-19 15:20:38 +01:00
Aaron Bohy de9c2135a6 [FIX] im_livechat,mail: external lib: missing dependency
@navbar-height was used in chat_window.less since rev. 8397abd but wasn't
defined in the external_lib bundle (light bundle to embed im_livechat in
external pages).

This rev. also fixes some glitches of the chat window due to missing
font-awesome, and global rule 'box-sizing: border-box' on all elements.
2016-01-19 15:20:37 +01:00
Nicolas Martinelli 205037736f [FIX] web_kanban, *: missing translated term
The progress bar in the web kanban module uses the option 'title' in
order to display the title of the gauge. However, this option is not
taken into account when it comes to translation, because the translation
of such option is not accessible at the JS level.

The fix defines the title of the gauge as the parameter `title` of the
widget. Indeed, such a parameter is in the list of parameters translated
and made accessible in the JS layer (see variable TRANSLATED_ATTRS in
translate.py). With such a modification, the translation is accessible
on the node.

opw-666577
2016-01-19 15:10:23 +01:00
Nicolas Martinelli b01e24b6af [FIX] account: company currency in payment
The company currency should be the company currency of the invoice, not
the company currency of the account journal linked to the payment.

The following use case causes an issue:
- invoice in GBP
- journal of the invoice in AED
- journal of the payment in CHF

In this case, residual_company_signed will be considered to be in CHF
while it was recorded in AED.

opw-666595
2016-01-19 14:57:32 +01:00
qsm-odoo c81e2720b2 [FIX] web,calendar: m2m attendee tag color
The colors for attendee tags were not used and were reset for all tags
each time the color was changed for a single tag.
2016-01-19 14:37:51 +01:00
Martin Geubelle 667909ae4a [FIX] web_kanban: duplicated tags on load more
When clicking on 'load more', the kanban view only needs to add tags
for new records displayed by load more ; the existing records already
have their tags so one duplicates them.
2016-01-19 14:28:09 +01:00
Géry Debongnie e0ea7c04f9 [FIX] mail: fix issue with disappearing filters in some cases
The client action had a weird issue: going back from a breadcrumb to the
client action made the searchview (filters/favorites) buttons disappear.  This
is caused by a weird behavior of the control panel.  This fix is the safest
for now, but working on the control panel behavior would be a better long term
solution.
2016-01-19 14:23:01 +01:00
Christophe Matthieu ab9a0cb679 [FIX] website_links: don't show the label on the pie chart
The label is already display just before the pie and the label are display one over the other preventing visibility.
opw-666405
2016-01-19 14:18:13 +01:00
Christophe Matthieu 40a9991ba8 [FIX] website_links: update the chart when user change tab or resize
Issue: On the front-end try to see the statistics and change tab, the graph is very messy.
(The chart width equal 5px when the bootstrap tab is closed)
Use trigger resize to update graph but use trigger is an error, must call all update directly.

opw-666405
2016-01-19 14:18:13 +01:00
qsm-odoo 09b1cdcea5 [FIX] gamification: colspan in badge form view 2016-01-19 13:16:09 +01:00
qsm-odoo 30480c5732 [FIX] website_blog: do not tweet in edit mode
When selecting a sentence on a blog, a popup appears to suggest to
tweet the sentence. In edit mode, the user do not want that to happen.
2016-01-19 12:25:11 +01:00
Denis Ledoux e079382d4b [FIX] website_event: events located time
Basically, this apply what was done in 87090c1b8b
everywhere where the events begin & end dates are displayed,
so all the events dates displayed in the front-end are the same,
so they are all within the event own timezone instead of the
user browser time zone.

opw-667065
2016-01-19 12:14:32 +01:00
Denis Ledoux b52467afb2 [FIX] product: pricelist applied on product categories
This is related to revision 2ebbcba33a

The above revision introduces a regression: the ability
to configure pricelist items applied on product categories.

If you configured a pricelist with items applied
on products categories, then the first item with a product
category matched all products, even if the products were
not in the according category.

This is because the condition checking that the product
is within the pricelist item product category has been
completely removed, by the above commit.

opw-666059
2016-01-19 12:14:32 +01:00
Christophe Matthieu 365e298fb1 [FIX] web_editor: inliner don't apply color when background-color 2016-01-18 17:09:02 +01:00
Christophe Matthieu 57fe8147f3 [FIX] web_editor: don't add double p tag at the begin of the document 2016-01-18 17:09:02 +01:00
Christophe Matthieu 958656d7e6 [FIX] web_editor: inliner take in care the '!important' attributes 2016-01-18 17:09:01 +01:00
Christophe Matthieu b27d24bfe9 [FIX] web_editor: don't limit the css inliner to the class but for all tag
(can reduce the performances)
2016-01-18 17:09:01 +01:00
Christophe Matthieu da880a48db [FIX] web_editor: don't insert css inline for readonly html frame
The preview is not equal to the real email rendering because inline.css is present.
2016-01-18 17:09:01 +01:00
Christophe Matthieu 4e0e376b0a [FIX] web_editor: use iframe instead of direct content for preview
The preview is not equal to the real email rendering because the backend css is present.
2016-01-18 17:09:01 +01:00
Géry Debongnie 990597ba1c [FIX] web_kanban: use default_order if defined in view
in saas6, the kanban view used the default_order parameter if defined in
the view, but this was lost in the kanban view rewrite last year

Now, this commit makes it work. As an added bonus, it should also now
work for grouped kanban view (unlike before)
2016-01-18 16:30:19 +01:00
Géry Debongnie d2cb04c7a5 [FIX] web_kanban: fix race conditions on do_search
The do_search method was clearly written by someone who doesn't
understand how asynchronous code works.  If several do_search are
quickly called in succession, there is no guarantee that the do_load
calls will return in the chronological order, so it could happen that
the kanban view render an inconsistent state.

This commit makes sure that only the last search entered is rendered.
2016-01-18 16:30:19 +01:00
Olivier Dony 24c41e3d31 [FIX] website_event_sale: test updated for pricelist fix
Rev. f9ee454d42 fixed the pricelist
application in website_event_sale in 8.0, but the 9.0 test
contained a hardcoded price matching the old computation.
The test failed when the fix was forward-ported to 9.0.
2016-01-18 16:18:03 +01:00
Raphael Collet d5fbf9a1e8 [FIX] ir_translation: avoid introducing duplicate translations
The commit d6b26c68 introduced this duplication to deal with missing
translations in qweb views (with name="website").  Those translations are now
gone in favor of translations of the field `ir.ui.view,arch_db`.
2016-01-18 15:58:04 +01:00
qdp-odoo 5393638610 [FIX] account: when changing the number of digits for the account on the company settings, change all accounts. Was PR #10334
Previously we only changed the accounts of type liquidity and that had the prefix/suffix defined on the company settings.
We added to that the other accounts with the following heuristic:
    if #digits > len(account.code):
        add 0 after account.code,
    if #digits < len(account.code):
        remove 0 from end of account.code (if possible).

Behaviour for the accounts of type liquidity that start with prefix/suffix defined on the company settings does not change,
except for a bug correction that did not remove 0 when we set a smaller number of digits.
2016-01-18 15:12:06 +01:00
Aaron Bohy fc8a4b5ede [FIX] web: view manager: overlapping switches between views
The problem occured when the user quickly clicked several times on the view
switcher or the breadcrumbs. The function switch_mode() of the view manager
was called once per click. This function's role is to prepare the requested
view, and once it is ready, to remove the former one from the DOM and insert
the new one instead. It is thus asynchronous as it waits for the
fields_view_get and search_read RPCs' response.

Unfortunately, when those calls to switch_mode() overlapped, the former view
reference was lost and it was thus never removed, producing a weird situation
where two views were displayed one above the other. This may happen when a
view takes a while to load, or simply when the user double-clicks on the
breadcrumbs or view switcher.

This rev. makes sure that calls to switch_mode() can never overlap by refusing
any other call when there is still one processing.
We also added a protection against breadcrumbs and view switcher double-clicks.

opw 658924
2016-01-18 14:01:21 +01:00
Aaron Bohy 206cc91a63 [FIX] web: view_manager: restore internal state on switch view failure
When an error occured when switching from a view to another (e.g. switching
to a form view for an id that doesn't exist, by editing the url), active_view
and view_stack were updated even though the switch failed. The view manager
thus lost the reference to the real current active view, which couldn't be
detached anymore. This resulted in two views being displayed at the same time
if the user kept navigating through this view manager.

This is a backport of odoo/enterprise@0b1aafa6b and odoo/enterprise@8e691be.
2016-01-18 14:01:21 +01:00
Damien Bouvy 93075b6b4b [FIX] sale_service: show complete SO view when coming from task
To view the complete SO form view (including delivered quantities),
you need to specifiy the "show_sale" key in the context.
2016-01-18 13:53:53 +01:00
pvy ab800b4ea2 [FIX] account: internal_type should be read_only so that it's not in the 'create' vals and does not trigger the _compute_matched_percentage() function 2016-01-18 13:35:16 +01:00
Damien Bouvy 40f298726a [FIX] sale_service: add missing link between task and SO 2016-01-18 11:36:48 +01:00
Christophe Simonis 0a2300318a [MERGE] forward port of branch saas-6 up to 12d9a34 2016-01-18 10:44:50 +01:00
Christophe Simonis 12d9a34cf4 [MERGE] forward port of branch 8.0 up to 1812b8f 2016-01-18 10:40:09 +01:00
Christophe Combelles 1812b8f337 [FIX] sale: copy of possibly None context
closes #10488
2016-01-18 09:46:25 +01:00