Commit Graph
132495 Commits
Author SHA1 Message Date
Sébastien Theys 905eed0de1 [FIX] web: introduce format for many2one_reference for form view
The format of `many2one_reference` was not introduced when the new field type
was created, which leads to empty values when the web client is trying to
display the value of such fields in form views.

Since the value of this field is an ID, it is decided to display it like an
integer, which is consistent with previous behavior: the fields that are now
`many2one_reference` are still stored as integer and they were already displayed
as integer before.

This was fixed in list views in commit d0c852f50e
and the current commit fixes it for form views.

opw-2127010
closes #38009

closes odoo/odoo#41666

X-original-commit: c37a16c9dfd09038925034b90ab49e1ab674e714
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2019-12-10 14:46:30 +00:00
Romain Derie 1559750620 [FIX] web_editor, website: better handling of invisible title entry
Using `Title` as invisible entry had the benefit of being translatable
but has the issue to be displayed on mouse over which we don't want.
Using `string` will fix it and will still be translatable.

closes odoo/odoo#41646

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-12-10 15:15:17 +00:00
Hardik Prajapati 907c61bc63 [IMP] l10n_it_edi: shown payment terms in electronic invoice
shown payment information along with bank details in exported
electronic invoice XML file

closes odoo/odoo#41656

Task: 1948158
X-original-commit: 7d2cf514a2443accbb9455553f27bbe2185e47a4
Signed-off-by: Josse Colpaert <jco@openerp.com>
2019-12-10 13:38:43 +00:00
Robin Heinz 97914cc081 [FIX] point_of_sale: fix indentation Account Cash Rounding.
closes odoo/odoo#41655

X-original-commit: 03125ee8162e32ea91534a5fe8df9b597b9df5a7
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-12-10 14:03:23 +00:00
Jorge Pinna Puissant d821999025 [FIX] mail: restore "pencil" icon behaviour in Followers widget
When editing the followers, the "pencil" icon that leads to the edition
of subtypes should be always be displayed, and not only when "debug"
mode is activated. This commit restores this behaviour, as it was not
the case any more.

opw-2144399

closes odoo/odoo#41643

X-original-commit: fd65f85e755eb0b732e0876c1849a0f4806968f1
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
2019-12-09 13:57:47 +00:00
ryv-odoo b5e24e9760 [IMP] stock: readd include exhausted product option
In the inventory adjustment form, readd (remove in 13.0)
the option to include exhausted product.

task-2115194

closes odoo/odoo#41239

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-12-10 14:51:33 +00:00
ryv-odoo 68518afe33 [REF] stock: remove and refactor quantities fetching
In order to clean the fetching of quantities for a inventory,
replace SQL query by a read_group. Also, the _computed_outdated
and _get_inventory_lines_values use the same read_group to be
consistent.

task-2115194
2019-12-10 14:33:16 +00:00
ryv-odoo 04f09a5a17 [REM] stock: remove dead code
In views of stock inventory line,
the view with the id "stock_inventory_line_tree" was not used.
Then remove it, and rename the "stock_inventory_line_tree2"
into "stock_inventory_line_tree".

task-2115194
2019-12-10 14:33:16 +00:00
Victor Feyens 17fbb9428a [IMP] stock: little context cleanup
closes odoo/odoo#41636

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-12-10 13:34:50 +00:00
Victor Feyens c278d99f89 [FIX] stock: traceback when trying to update quantity on hand
When accessing the quantities on hand of a product, `_get_quants_action`
is called to specify the action returned.

In some cases, the action context may be updated.  This led to a
traceback because the context of the action isn't a copy of the current
context but a link to the current context frozendict, which cannot be
updated.
2019-12-10 13:26:47 +00:00
Obay Abdelgadir 6d6b3479cf [IMP] doc: remove deprecated class oe_no_button
Related to issue: #41517
The class has no effect but was still referenced in the documenation

closes odoo/odoo#41629

X-original-commit: 063098bdf3414ffa1db12d3bfc5999506c109329
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-12-10 10:26:04 +00:00
Martin Trigaux b7d91ba25b [I18N] *: remove es_AR translations
Followup of a425695e
The terms were back in 12.0
Courtesy of Juan José Scarafía

closes odoo/odoo#41624

X-original-commit: 85d0c7001a997748d7691205bbb8d066597591a5
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-12-10 10:00:18 +00:00
Simon Lejeune 80b55624c8 [FIX] uom: _check_category_reference_uniqueness
Edit the liters uom (default in its category) and change its category to
unit. You now have two references uom in the unit category. Try to set a
third one and now it fails.

This was because the constraint is implemented with an sql query but
since the new ORM the update in database are delayed. We force a
database update with flush so that the query gant get all the
informations it needs.

closes odoo/odoo#41621

X-original-commit: 68ced7972db64b22a4ff031bba0f78c06a88372d
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-12-10 09:02:53 +00:00
snd 1492e1a644 [FIX] Account journal dashboard bar graph
Fix _get_bar_graph_select_query to correctly compute the residual
amount when calculating the values for the graph of a bill or invoice
journal.

closes odoo/odoo#41592

X-original-commit: 73d28be404901378dc06e756868e5a1ef6cf7b0b
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-12-09 12:15:41 +00:00
Julien Castiaux c999d98421 [FIX] website_slides: image no more available
[Nighly Runbot #730241](http://runbot.odoo.com/runbot/build/730241)

closes odoo/odoo#41571

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2019-12-10 10:46:05 +00:00
Julien Castiaux ffeea439ca [FIX] website_slides: move tours under /static/
All assets have to be loadable directly from the browser, /tests/ is not
accessible, /static/ is.
2019-12-10 10:46:00 +00:00
MaxLarue 028768f288 [IMP] hr_timesheet,helpdesk: Display remaining hours on a task
Show the remaining hours to timesheet on tasks. Allows to quickly evaluate
task's state.

This  is done in the name_get of a task through a context key, because we
need this different name on some views, not all.

related task #1856139

closes odoo/odoo#33586

Related: odoo/enterprise#4400
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-12-10 09:15:17 +00:00
Prakash Prajapati 824b6cf02e [FIX] calendar: fix archive ribbon on private event
When the event is private and some other user going to
see the event at that time it was going to display the
archived ribbon because the active field was not in the list
of public fields(readable field).

so added an active field to the readable list so it will display the
propper archive ribbon on a private event.

Task-2144553

closes odoo/odoo#41589

Closes: #41157
X-original-commit: c1b89567ca3fdd6f4004389aad345ad3e52248c3
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-12-03 06:45:10 +00:00
Prakash Prajapati 9ab4f99db3 [FIX] calendar: fix traceback for calendar private event
Currently when other users view the private event of
another user it display the name of the private event as
'false' instead of 'busy' and onclick of event it generates
traceback.

so to fix it added display_name in condition of read because
the event name displayed in calendar view(previously name) is
replace by display_name in commit 369c20a99b

Task-2144553

Closes: #41157
X-original-commit: 1ec853751bd995449619585db8e17f582ba5e5bc
2019-12-03 06:45:10 +00:00
Nicolas Lempereur 172b69c050 [FIX] web: control panel date filter ok in arabic
The date filters sent to servers were being computed in current locale,
so in arabic we would get things like this:

- "٢٠١٩-١٢-٠٩" instead of "2019-12-09"
- "٢٠١٩-١٢-٠٩ ١٦:١٦:١٥" instead of "2019-12-09 16:16:15"

which would cause a traceback in backend.

opw-2122333
closes #41570

closes odoo/odoo#41596

X-original-commit: da778afc24b048244467649dfa4af4e6f4a78e44
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2019-12-09 15:19:15 +00:00
laa 9cfb6c05a4 [FIX] Portal : missing url args
on the portal:
- in Timesheets, when search something, the text of the search must remain displayed
- in Tasks, when search something, the text of the search must remain displayed
- in Purchase Orders, "Sort By" and "Filter By" selectors shouldn't change when going to next page
- in Timesheets, the "Group By" selector shouldn't change when going to next page

closes odoo/odoo#40278

Related: odoo/enterprise#6787
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-11-28 15:39:03 +00:00
laa cbc93d0d11 [IMP] project: Add a group by stage for tasks on the portal
A group by stage on the portal would allow the customer to have an overview of his tasks' progress, which is especially useful in a multi-project setting.

- add a "Project" column
- rearrange columns in the order: Ref -> Task -> Project -> Stage

- add a group by stage for Tasks on the portal
- hide "Stage" column when group by stage is selected
- hide "Project" column when group by project is selected

- add a sort by project for Tasks on the portal
- when sort by Stage sub-sort by Project
- when sort by Project sub-sort by Stage

- add a 'Search in Project' for Tasks on the portal

- the "Group By" selector shouldn't change when going to next pages
2019-11-28 09:54:12 +00:00
Nicolas Lempereur 98bba5fa0b [FIX] account: invoice report fallback company currency
In 13.0 if currency_id is not set, we are fallbacking on
company_currency_id.

This was not taken into account in account.invoice.report view and so
when grouping by currency, we would get an "Undefined" grouping which
meant "company currency".

Now we fallback on company_currency in the view, and if we displayed
data for several companies with different currency, this should also
remove the amalgamation of different currency in "Undefined" group.

opw-2151492
closes #41491

closes odoo/odoo#41593

X-original-commit: ee2858c9c9eec5121b63bd8565980d93846bcade
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2019-12-09 13:15:43 +00:00
oco-odoo 145bd8c49f [FIX] account: when changing the country of a tax report, only delete the tags if they are not linked to any other report
Before that, we deleted all the tags and removed them from the repartition lines all the time; we only want to do that if the tags are not shared with another report, so we use == instead of 'in'.

closes odoo/odoo#41579

X-original-commit: 5f147681c721f5de609622f2cf80b3919eaf49bf
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2019-12-09 12:57:41 +00:00
oco-odoo b2465a48bb [FIX] account: don't delete the tags on taxes when upgrading a tax report
Before that, upgrading a l10n_* module with a tax report removed all the tags from the tax repartition lines.

X-original-commit: a1364bde860266154298034bbae3693161834f49
2019-12-09 12:46:57 +00:00
qsm-odoo 56f6d62324 [FIX] website: restore parallax design
Commit https://github.com/odoo/odoo/commit/cf5b3e1db5d312133eb1af7ff0d5471db47987e5
fixed a problem by creating another one: the parallax with a given speed
appeared broken on page load (which is even more visible in 13.0 with
lazy loading).

This commit restores the design and solves the original problem.

closes odoo/odoo#41594

X-original-commit: a9aa72ecb5350cc0e9fa5b6a17d4db8d2f1895fd
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-12-09 12:24:00 +00:00
Jorge Pinna Puissant 67da6d664f [FIX] account: convert amount in currency into debit/credit
— Enabled multi currency;
— Create new journal entry;
— Add a new line;
— Add the column 'amount in currency';
— Select a different currency than the company currency;
— Set an amount in 'amount in currency'.

Before this commit, the amount in currency is not converted into debit
or credit fields.

Now, the amount is correctly converted into debit or credit fields.

opw-2129294

closes odoo/odoo#41580

X-original-commit: ae3d7aeb706dc1bc3216fd63c6a943e5d9cb56e7
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
2019-12-09 09:26:01 +00:00
lejeune quentin ef09a4f44e [FIX] hw_drivers: Fix printer unknow in PrinterDriver
We add a condition to add printer.
Printer, for protocol DNSSD and LPD, must have a "model"

closes odoo/odoo#41591

X-original-commit: a07f118fc7182fa96344fad4a0164ed86c446352
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-12-09 12:47:59 +00:00
Adrien Dieudonne 6b9197244e [IMP] web: Chart.js update to 2.9.3
Update of Chart.js library to the latest version.

Before this commit, we weren't able to see all
x-axis dates labels like in Accounting Overview.
Tick label rotation on mobile has been fixed in
https://github.com/chartjs/Chart.js/pull/5961.

closes odoo/odoo#41582

X-original-commit: 24d8ae59e08143dc0ca7e05be37a3cd607d58a4a
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
2019-12-09 14:15:05 +00:00
Simon Lejeune 782b5a347c [FIX] stock_account: value of return
When returning a delivery where the value was taken from different
receipt, the last receipt's unit cost was wrongly used when returning
the delivery.

Now we use the `unit_cost` of the delivery when returning it.

task-2150889

closes odoo/odoo#41564

X-original-commit: 468ab4f23c8212e1aba21197b3f83afe741b3d9e
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-12-09 10:20:06 +00:00
lejeune quentin 4bb7fa19f1 [FIX] hw_drivers: Fix detction method for printer
Actual IoT Box not detect correctly Epson TM-T88v.
Now we can detect printer even if name is 'Unknow'

closes odoo/odoo#41563

Taskid: 2153108
X-original-commit: 4c7a1d7a9ba2ad0fbdd92b3a73b0d6294cb6e4a3
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-12-09 09:56:47 +00:00
Jason Van Malder 453e7ab3d5 [FIX] website_form: fix missing currency field in form builder
Issue

    - Install CRM & Website
    - Edit the website contact form
    - Add "Expected revenue" field

    Traceback

Cause

    Monetary fields are not handled by the form builder

Solution

    Add the monetary field in the form builder core

OPW-2150986

closes odoo/odoo#41558

X-original-commit: 6c27c3abf4907e1faac670ea8ef006992ec96063
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2019-12-09 09:58:36 +00:00
Vishnu Thuletiya edf04f317c [IMP] project: improve the project kanban and task breadcrumb
Purpose of the task is, when some one remove the default filter
at that time kanban view is really a mess so when go though the
project always apply the domain of current project instead
of filter.

The breadcrumb should be the name of the project instead of name
of the action(tasks) so pass display_name from method to change the
breadcrum when view the task from kanban view.

closes odoo/odoo#40922

Task: 2124377
Closes: #40922
Related: odoo/enterprise#6903
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-12-09 13:12:32 +00:00
Damien Bouvy 8f0d1f1462 [IMP] web: allow custom state in action mixin
Sometimes, it might be useful for an action (e.g. a client action,
although this may be used by standard views as well) to include custom
values in its state. Since the state of a 'fullscreen' action is pushed
in the URL, this means that it is possible for the action to resume its
state properly upon refresh of the page (before this commit, only some
standard information were pushed to the state - action_id, menu_id, etc.
for window actions and action's name, active_id, active_ids for client
actions).

By implementing the `getState` method, an extension of the action mixin
can thus push any state it wishes to the URL.

closes odoo/odoo#39529

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-10-31 11:26:44 +00:00
Nans Lefebvre 8e4a55fb81 [FIX] ir_translation: correct rights check in _set_ids
Suppose you have a record rA of model A, and a record rB of model B
which has a related B.v on field A.x, that is stored and translatable.
Suppose also that user U can write on A, but not on B because of ACLs.

Let U write on rA.x. Then it recomputes the value of rB.v.
Since this directly calls the _write, we check the record rules but not
the ACLs, so U wrote rA.x and rB.v successfully.

Now let U be in another language L.
This means that we go trough translations, which calls _set_ids.
If the translation already exists, then the update is done in SQL so no
access rights are checked.
However if translations do not exist, the translations are created via
the ORM and thus check both record rules and ACLs.
Therefore the operation is forbidden, since by hypothesis U cannot write
on B.

We can skip the check in this case, since we come from either a create
or a write, so the ACLs should already be checked on the original models
as intended (in the case of B, not fully).
Furthermore it removes the incoherency with the update case.

opw 2145738

closes odoo/odoo#41546

X-original-commit: 19d18e81dd9d3dcce1281f662abdaf941c0c357a
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
2019-12-09 07:22:07 +00:00
qsm-odoo 1f218f831c [FIX] website: disable graph animation in edit mode
Especially important since all animations are restarted on any change of
a snippet.

closes odoo/odoo#41541

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-12-09 12:48:07 +00:00
qsm-odoo 90c672cd22 [FIX] web_editor: prevent widgets with no method to auto-update $target 2019-12-09 12:48:07 +00:00
qsm-odoo 2521578033 [REF] website, *: automatically refresh widgets on option change
* website, website_mass_mailing

Now, when any option method is called (editor left panel), the widgets
related to the targeted DOM is automatically updated. This is possible
to disable for a specific widget with `data-no-widget-refresh="true"`.

This commit also makes the `_refreshPublicWidget` method better handle
its async component: it is now "fully async" so the caller should wait
for its resolution before executing some other related code.
2019-12-09 12:48:02 +00:00
qsm-odoo 255be177e9 [IMP] web_editor, *: make option methods async
* website

Now, the option methods can be async. All the option methods are still
executed sequentially thanks to a Mutex at the snippet menu level.
2019-12-09 12:43:26 +00:00
Pierre RousseauandVincentSchippefilt 46cf65d68e [REF] web: rewrite pivot view renderer with OWL
Because the webclient and other higher level components such as the
actionManager are not yet rewritten in OWL, we cannot make a complete
migration of the controller and the model to a more OWL-ish code.

We have rewritten the renderer completely in OWL, it uses more
extensively a template and manages its own state and its sub-components.

We did not rewrite the controller, however we have made it inherit from
`web.ControllerAdapter` which is a thin compatibility layer used when a
odoo controller uses a OWL renderer.

In the tests, the only changes are that all the events triggered by the
test and handled by OWL must be triggered on DOM nodes directly and not
on JQuery elements.

closes odoo/odoo#39491

Related: odoo/enterprise#7135
Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
Co-authored-by: VincentSchippefilt <vsc@odoo.com>
Co-authored-by: pro-odoo <pro@odoo.com>
2019-12-09 12:53:24 +00:00
Pierre Rousseau eef10097ae [IMP] web: no content helper
Duplicate the template of no content helper so it is available both in
Odoo legacy QWeb and in OWL QWeb templates
2019-12-09 12:53:24 +00:00
Julien Mougenot 242f8840c8 [IMP] web: custom hooks
Add custom hooks file to put the generic (low level) hooks used by Odoo
2019-12-09 12:53:24 +00:00
Vincent SchippefiltandPierre Rousseau d06e67e748 [IMP] web: add Odoo view compatibility for OWL
Add a base class for a complete OWL renderer
Add a compatibility layer for a Odoo controller that uses a OWL renderer.

Co-authored-by: Pierre Rousseau <pro@odoo.com>
2019-12-09 11:09:10 +00:00
Julien Mougenot 2cfa68b571 [IMP] web_tour: tour utils
Changed the triggering of some events to dispatch native events instead of
jQuery ones and extended the api of the keydown helper to support text keys.
2019-12-09 11:09:10 +00:00
b0941d19a0 [FIX] web,*: fix all tests and test utils to use native events
In this commit:
- transformed test_utils helpers to always trigger native events
- introduced new test_utils_create helper: prepareTarget
- updated qunit asserts to support Owl Components
- updated all misused helpers that would crash with the updated test_utils

Co-authored-by: Julien Mougenot <jum@odoo.com>
Co-authored-by: Mathieu Duckerts-Antoine <dam@odoo.com>
Co-authored-by: Pierre Rousseau <pro@odoo.com>
2019-12-09 11:09:10 +00:00
29726e8fd0 [ADD] web: add owl 1.0.0-beta1 to odoo
With this commit, we properly introduce the Owl library into our beloved
codebase. More information on the Owl library can be found in the project
repository: https://github.com/odoo/owl/

Co-authored-by: Aaron Bohy <aab@odoo.com>
Co-authored-by: Julien Mougenot <jum@odoo.com>
Co-authored-by: Mathieu Duckerts-Antoine <dam@odoo.com>
2019-12-09 11:09:10 +00:00
Ravi Gohil 3b4592acfc [IMP] account_check_printing: make check printing generic
Now, if user intends to add a check layout for it's own country then he/she
will need to define a layout template and a report action associated to it.
The xmlID(s) of this report action(s) needs to set as key of
'account_check_printing_layout' selection field after redifining
it in it's own module.

Refer l10n_{ca/us}_check_printing modules.

closes odoo/odoo#35438

Task: 2030714
Closes: 35438
Related: odoo/enterprise#5007
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-12-03 05:44:04 +00:00
Alexandre Kühn 42de9e129f [REV] mail: prevent message loss during connection issue
This reverts commit e5479fcfdb.

This commit prevented an issue of losing messages on post in case
of connectivity loss. The implementation consists of keeping the
content in the composer until the server acknowledges handling the
message.

However, this solution introduces significant issues. For instance,
sending messages in quick succession will likely loose or duplicate
some content, based on how fast/slow the RPC `message_post` is
resolved. Plus, there was an issue on mobile because the input focus
was lost during the RPC. As a consequence, the virtual keyboard
flickered.

The intent was to fix a rare issue, and since the problems of this
solution clearly outweigh the gain, we decided to revert.

closes odoo/odoo#41544

X-original-commit: 36b2e99e08bfc6d92a821d0346e783695580abf9
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2019-12-09 09:26:25 +00:00
Yannick Tivisse 4efe0e3b16 [IMP] hr_timesheet, project, hr_expense: Introduce multi-edit lists
closes odoo/odoo#40048

Taskid: 2078161
Related: odoo/enterprise#6633
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-12-09 11:29:18 +00:00
Kevin Baptiste 6cbe824871 [REV] web: reverts update to fontawesome 5.11.2
This reverts commit ff1c35513a.

closes odoo/odoo#41480

X-original-commit: 116057b26e71db4692280463669f3e80d813ddcc
Related: odoo/enterprise#7110
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-12-09 10:33:36 +00:00