Commit Graph
131002 Commits
Author SHA1 Message Date
Josse Colpaert 8ba449ccdd [FIX] account: pos receivable account might be only set on the parent
On installation of the CoA the company's pos
receivable account is set, but it is possible that
the account is not set on the chart template itself,
but on its parent.

closes odoo/odoo#37761

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-10-02 10:16:26 +00:00
Nans Lefebvre d46befdf25 [FIX] account: add a test on settings change
Because of f206714af0 and subsequent commits, adding groups may raise.
We ensure that switching between tax included and tax excluded keeps working.

Closes #37481

closes odoo/odoo#37633

Forward-port-of: #37517
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
2019-10-02 09:28:17 +00:00
Nans Lefebvre a22939532c [FIX] base: remove all groups before adding any groups in settings
Because of f206714af0 and subsequent commits, adding groups may raise.
Thus, it is always safer to first remove groups and then add new groups.
The converse could raise, making settings save impossible.

Closes #37481
Forward-Port-Of: #37517
2019-10-02 07:38:50 +00:00
mreficent 114f883e3b [FIX] base: typo in an UserError
closes odoo/odoo#37086

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-10-02 10:40:23 +00:00
Jigar Vaghela 21cccf9d72 [IMP] l10n_in: Remove GST tax column from invoice PDF
closes odoo/odoo#37759

X-original-commit: 0b04219514fc312b185d74d1512d11debfd2bae2
Signed-off-by: Josse Colpaert <jco@openerp.com>
2019-10-02 10:13:30 +00:00
Kishan Gajjar 083c5bddb7 [IMP] social_media, website_*: remove google+ mention
Google+ was shut down for business use and consumers.

closes odoo/odoo#36271

See: https://plus.google.com/
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-10-02 10:14:12 +00:00
Kishan Gajjar f96d6a9911 [CLA] signs the CLA for kig-odoo
Done at odoo/odoo#36271
2019-10-02 10:14:01 +00:00
mreficent c67f6d8794 [FIX] pos_mercury: revert of 48b3893b84
The previous change was done to solve a case of duplicated xmlids in
v12. By some confusion, both xmlids were changed in separated
commits. This new commit returns the original xmlid of one and assures
to avoid more confusions by adding 'settings' to the other.

Closes odoo/odoo#36885

closes odoo/odoo#37755

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-10-02 09:32:22 +00:00
Pierre Paridans 245ef4b0fd [FIX] website: check uid on request.env
Without this commit, connection with mobile app crash
since there are no uid set on the env.

_is_public_user expecting singleton.

closes odoo/odoo#37756

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-10-02 09:32:58 +00:00
Florent de Labarre 2e8307b5f1 [IMP] point_of_sale: add pos_order pivot view
Add a pivot view mode to the pos_order model.

closes odoo/odoo#37613

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-10-01 08:57:32 +00:00
Simon Lejeune 61fa590e67 [REV] stock: remove move 'without package' properly
This reverts commit 3431d7b1cd.
Due to recent changes in the orm, editing a draft move crashes. We
revert this commit while we find a proper fix.

closes odoo/odoo#37752

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-10-02 06:56:43 +00:00
Lucas Perais (lpe) acde911e44 [FIX] account: invoice, refund in foreign; payment, writeoff in domestic reconcile
Have an exchange rate of 1.1106

Have an invoice and a refund in a foreign currency
(amounts: 800 and 400)

Have a payment and a writeoff in domestic currency
(amounts: 200 and 160.16))

Before this commit, the invoice was not fully reconciled
even though the whole chain was
This was because, when checking if we should fully reconcile
we did so by forgetting that some members of the reconciliation
chain has a foreign currency
So, the exchange rate difference was never posted
(which amounts to 0.01 in foreign currency, and 0.00 in domestic)

After this commit, all the chain is reconciled, including the invoice

OPW 2057845

closes odoo/odoo#37738

X-original-commit: 74fb177c292c156a20818a12b47c53c40f37a2ee
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
2019-10-01 17:17:02 +00:00
Lucas Perais (lpe) 2721dd522c [FIX] base, account, product, hr_holidays: document layout save and print
In an onboarding situation, the company doesn't have a logo
make an invoice, send and print, print

The document layout editor's layout opens, because nothing is set up
on the company

Click Save

Before this commit, it was impossible to make the invoice print
because each time the document layout was displayed

After this commit, the invoice prints when clicking on Save
There is no default external layout for main_company

Also, the heuristic used to evaluate whether a company
has been set up, onboardingly speaking, has changed.
Before we used the existence of the logo, after we check if
a layout has been setup. When saving the document layout
modal, a report layout is written on the company

So, practically, the document layout modal only appears once
when trying to print invoices (or other documents)

closes odoo/odoo#37137

Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
2019-10-01 14:32:43 +00:00
fja-odoo 423402f1e5 [IMP] http_routing, *: move error pages to http_routing
* = portal, website, test_website, account, sms

Portal an Survey error pages were ugly default pages.
Now the error pages will be the same as the website ones.

Also fixing single module builds tests

task-2059969

closes odoo/odoo#35535

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-10-02 06:59:15 +00:00
Andrii Skrypka 92db71ccc4 [CLA] signature for kos94ok-3D
closes odoo/odoo#37746

X-original-commit: fa70ceb4a438cc773ad8c8c7f60959b1861c16aa
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-10-01 19:12:05 +00:00
Muhammad Awais 0c1dbed1bc [FIX] doc: add missing ">"
Unclosed tag

closes odoo/odoo#37744

X-original-commit: a0612f5a17e08e13362034203995944756a7c0be
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-10-01 18:28:57 +00:00
Nicolas Lempereur 8decc3dc56 [FIX] web_editor: ol in ol have first number hidden
In the case of an <ol> in an <ol> we would have something like:

1.
2. 1.
   2.
3.

With this changeset we get back what we had in 12.0:

1.
   1.
   2.
3.

which is not perfect but the same as 12.0 version.

opw-2073751
closes #37163

closes odoo/odoo#37706

X-original-commit: 479db16fdb86c6925a7f94a24f2821f3a5c047b5
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2019-10-01 12:55:44 +00:00
Danuel WIlliams 8c945a8bdf [FIX] doc: Update Kanban Exercise code
Field name was incorrecty spelt. Replace 'openacad.session.kanban'
with 'openacademy.session.kanban'

closes odoo/odoo#37736

X-original-commit: 1043d1622947614d2d4e7f237c73e1b92191d099
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-10-01 16:52:01 +00:00
Danuel WIlliams 0fa9fcbd1b [CLA] signature for joeycodinja
Done at odoo/odoo#31609

X-original-commit: 26c2ee717f0f81649100bd7b5b271a219aa3054a
2019-10-01 16:52:01 +00:00
fw-botandRomain Derie b77d8a0974 [FIX] website_theme_install: properly attach new views to specific views
When a theme declares a view (a 'theme.ir.ui.view') with an inherit_id,
on installation, a view (a 'ir.ui.view') will be created with the
corresponding inherit_id. The problem is that this inherit_id may
reference a view that has been cow'ed at some point and thus the new
theme view will be attached to the non specific view by mistake.

Part of https://github.com/odoo/odoo/pull/37142

closes odoo/odoo#37750

X-original-commit: https://github.com/odoo/odoo/commit/f30b4dfdb90515bc54e691302f894184c9b1c55b
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: Romain Derie <rde@odoo.com>
2019-10-02 01:02:56 +00:00
Jeremy Kersten eded0294ab [FIX] base, website: fix routing redirect
Redirect_type was renamed from 3xx to redirect_3xx, but name is used as http
status code. It is better a redirect(301) instead of redirect(redirect_301)

Re-add the bind_to_environ, it was removed because it seems not useful, but
once you are behind a proxy, werkzeug need the environ to find the correct
hostname and more ... Transformed relative url into absolute by werkzeug was
wrong.

closes odoo/odoo#37733

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-10-01 15:53:04 +00:00
Christophe Simonis 0467cab225 [FIX] l10n_*: accurate module version
closes odoo/odoo#37732

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-10-01 16:03:59 +00:00
Ravi Gohil 84629a03fa [IMP] l10n_lu: few improvements
- updated tax name/description
- shown code as per official tax report in tax report lines
- changed types of few account
- set 17-S-S as default sales tax
- added a new account with code 703001

closes odoo/odoo#37731

Signed-off-by: Josse Colpaert <jco@openerp.com>
2019-10-01 15:23:44 +00:00
Meghna Jaswani 5e240146aa [FIX] sale: correctly set default fiscal position on invoice
default fiscal position of previously selected partner is not getting
cleared up when current selected partner doesn't have a default one

task: 2071608
closes: #37231

$XX

closes odoo/odoo#37728

X-original-commit: bce4bcc61196bbeafb41f77b7a95051b225faea6
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-10-01 15:59:59 +00:00
Romeo Fragomeli ce879f2be4 web: kanban more menu is cropped on mobile
This commit removes some historical overflow-x properties needed
for old kanban views.

Steps to reproduce:
* Open Project App
* In kanban view and with one element, click on "more button" (3 dots)
* This menu will be truncated at the end. (BUG)

Task ID: 2058510

closes odoo/odoo#37727

Original-signed-off-by: Romeo Fragomeli <rfr@odoo.com>
X-original-commit: f4031c62f97fa170b74b0d13a0856b7d58ed4da6
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
2019-10-01 15:59:38 +00:00
Romeo Fragomeli 6b847c543a [FIX] web: calendar some operation enable swipe in mobile
This commit avoids the swipe feature when we are moving/resizing an event.

Task ID: 2071605

closes odoo/odoo#37715

Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
2019-10-01 14:10:53 +00:00
Xavier Morel 18e3f8405a [FIX] core: compatibility with Werkzeug 0.15 ProxyFix
Werkzeug 0.15 modified ProxyFix such that by default it only forwards
the REMOTE_ADDR when enabled, whereas before 0.15 it would also
forward scheme and host. This breaks proxied odoo as the base url
becomes incorrect (cf #34412).

Use properly configured ProxyFix when running with werkzeug 0.15, old
configuration otherwise.

Backport of 4057227def which was merged
in master, because many people apparently run 0.15 now.

Closes #35085
closes odoo/odoo#36212

closes odoo/odoo#37708

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-10-01 13:26:34 +00:00
Hugo Adan 780c857184 [FIX] mail: use correct template attribute
Custom CSS should be in style attribute

Closes odoo/odoo#37638

closes odoo/odoo#37707

X-original-commit: c1254cca7aae54982d270227d58aad8bdf0a7804
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-10-01 13:10:24 +00:00
Victor Feyens e153047d41 [FIX] base: country csv
A warning was raised during documentation build because of encoding inconsistency.

closes odoo/odoo#37682

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2019-10-01 15:09:47 +00:00
Victor Feyens cbb921329f [FIX] product: currency computation depends on the product company_id. 2019-10-01 15:09:47 +00:00
fja-odoo 950f252ba6 [FIX] website: rename user_partner_id -> partner_id
It is just a partner_id not a user related field

task-2072877

closes odoo/odoo#37102

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-10-01 19:50:00 +00:00
fja-odoo 7d6479e175 [IMP] website, website_sale: Improve website tracking
The update of visit_count now uses website_track instead of
website_visitor_lastconnection for less complex query and better
precision.

The name of a visitor is now changed only if it has no partner linked
and the # is removed

The cookie was not reset when a new partner connects or if a partner
disconnects. Now a check is performed to ensure the cookie belongs to
the partner/public user.

Now website visitors that log in will be added to the previous
website visitor of the partner. This way we have a full history and only
one visitor per partner.

Now a partner is able to delete a recently viewed product from his
recently viewed product list.

task-2072877
2019-10-01 19:50:00 +00:00
fja-odoo fe1dddb1ec [FIX] website: allow visitor sort by last visit time
A visitor needs to be sorted by last visit datetime, to do so we need to
remove the temp table and ignore concurrent updates.

task-2072877
2019-10-01 19:49:46 +00:00
fja-odooandqsm-odoo 75014ffba4 [FIX] website_form: fix website form snippet
The modal of the website_form snippet was broken. Now it uses Dialog.
Hidden inputs were not aligned with there labels.

task-2078138

closes odoo/odoo#37545

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>
2019-10-01 17:35:39 +00:00
Romain Derie 15e3646b4f [FIX] website_theme_install,*: redirect to frontend after theme install
*: theme_bootswatch, theme_default

Before this commit, the first time a website was loading a theme, it would
not be redirected to the frontend afterward (even if that theme was already
installed on another website).
Any other theme installation on that website would redirect to frontend as it
should.

Indeed, the first time it would use the `act_url` returned by `next()` which
would only be called during the first time installation on the website.

All the `ir.action.todo` related to themes can be removed anyway, as you can't
install directly a theme. It can only be installed through website settings >
load a theme.
In which case we will always want to redirect to frontend.

task-2070463

closes odoo/odoo#37306

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-10-01 16:14:57 +00:00
0987ab4bfd [MERGE] website_forum, *: revamp design
* portal, website, website_event, website_sale, website_mail,
  website_slides_forum, web_editor, website_profile

See sub-commits for details.

task-2024197

closes odoo/odoo#35749

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: sri-odoo <sri@odoo.com>
Co-authored-by: Jérémy Kersten <jke@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>
Co-authored-by: fja-odoo <fja@odoo.com>
2019-10-02 00:29:26 +02:00
sri-odooandqsm-odoo 0b97db74f7 [IMP] website_forum, *: review forum listing page
* website_slides_forum

In particular: add a specific design for forum with description and
separate the 'course' forum from the rest of them.

Part of https://github.com/odoo/odoo/pull/35749
task-2024197

Co-authored-by: qsm-odoo <qsm@odoo.com>
2019-10-01 16:52:20 +00:00
c8c8eb3d56 [IMP] website_forum, *: revamp design
* web_editor, website_profile

Part of https://github.com/odoo/odoo/pull/35749
task-2024197

Co-authored-by: Jérémy Kersten <jke@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>
Co-authored-by: fja-odoo <fja@odoo.com>
2019-10-01 16:52:20 +00:00
fja-odooandqsm-odoo 83284a962c [IMP] website_forum: make the user auto-follow the posts he favorites
Part of https://github.com/odoo/odoo/pull/35749
task-2024197

Co-authored-by: qsm-odoo <qsm@odoo.com>
2019-10-01 16:52:20 +00:00
sri-odoo 75e64d63cd [FIX] website_forum, *: review header nav layout
* website_slides_forum

Move the '.container' inside the navbar in order to avoid unnecessary
horizontal padding.

Part of https://github.com/odoo/odoo/pull/35749
task-2024197
2019-10-01 16:39:05 +00:00
sri-odoo da3cb117ea [IMP] website_mail: allow two different designs for the follow button
Part of https://github.com/odoo/odoo/pull/35749
task-2024197
2019-10-01 16:39:05 +00:00
sri-odooandqsm-odoo 2aa77b10f4 [REF] website, *: allow classes injection in search-box
* website_event, website_sale

Part of https://github.com/odoo/odoo/pull/35749
task-2024197

Co-authored-by: qsm-odoo <qsm@odoo.com>
2019-10-01 16:39:05 +00:00
sri-odoo 48b4459a5b [REF] portal: change website default bg color
Part of https://github.com/odoo/odoo/pull/35749
task-2024197
2019-10-01 16:39:05 +00:00
Thibault Delavallée e558c80d81 [FIX] crm_sms: fix class inheritance
closes odoo/odoo#37686

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-10-01 16:08:51 +00:00
Thibault Delavallée ec329190c0 [IMP] website: allow custom classes in publish short button
Purpose is to be able to somehow control the display of publish buttons.
Indeed in some bases you want for example to display small buttons that
takes less place than current standard bootstrap button.
2019-10-01 16:08:51 +00:00
Florian Gilbert 8d99d63bee [IMP] base: Add VAT field as optional field on partner tree view.
closes odoo/odoo#37670

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-10-01 14:42:41 +00:00
Florian Gilbert 0098865627 [FIX] account: Fix tax group edit on account move.
Fix problems about multi currency on account move
when you modify tax group via tax group widget.
2019-10-01 14:42:06 +00:00
qsm-odoo 6991f300cd [FIX] web, *: review Bootstrap tooltip/popover sanitization
* website_sale_comparison

The Bootstrap sanitization introduced with BS 4.3.1 was disabled with
https://github.com/odoo/odoo/commit/36caf5fc16b5a95a0bf37f08f0caf974683b2df6
https://github.com/odoo/odoo/commit/ee94decd30c4514d5bc410b1652bc6464bb600aa

This commit re-enables it by default but extends it to accept more
common tag names like tables and buttons. If a specific tooltip or
popover must accept custom tags or attributes (such as data-* attributes
required by a related JS), they must be supplied through the whitelist
BS parameter explicitely (see example with website_sale_comparison in
this commit).

Note: data-oe-* attributes are also whiteListed by default.

We cannot disable sanitization because bootstrap uses tooltip/popover
DOM attributes in an "unsafe" way.

closes odoo/odoo#37631

Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
2019-10-01 15:33:28 +00:00
Arnaud Joset 28931034c0 [IMP] account_payment,Sale: rename button Pay now to Pay Now
task-2052537

closes odoo/odoo#37625

Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-10-01 15:24:28 +00:00
Arnaud Joset 5713d891f5 [IMP] Portal : UI
Align Accept & sign button to the right

task-2052537
2019-10-01 15:24:28 +00:00