Commit Graph
132214 Commits
Author SHA1 Message Date
qsm-odoo 8686ef0fb6 [FIX] web: fix wrong convertion of 8-digit hex to RGBA color
closes odoo/odoo#40991

X-original-commit: fdfce09ea5312d42379c58b334ea0ed22b8ddbfa
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-11-27 13:59:33 +00:00
fw-bot cfbeed761a [FIX] mrp: unit_factor computation
Updating the quantity to produce in a production order will recompute
each raw move's unit factor. The issue was this computation did not
take care of the previously product quantity. The unit factor was wrong
and so the next created workorder lines get the wrong quantity.

Example:
  - 1 components for 1 finished product (unit_factor = 1)
  - Create a production for 2 finished product -> quantity to consume = 2
  - Produce 1 then change quantity to produce to 3 -> quantity to consume = 3
    and quantity done = 1 but unit factor became 1.5

closes odoo/odoo#40990

X-original-commit: 79976600df45afc6150150734eef405fd41a70a3
Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>
2019-11-27 14:05:26 +00:00
Victor Feyens 0b8eb71d71 [FIX] sale_margin: recompute purchase_price on product_id_change.
When creating sale order lines from the matrix (sale_product_matrix),
the purchase_price weren't computed

No cleaner change has been found to ensure the cost is computed.

Triggering all onchanges from the server side is quite tricky and dirty
to do...

closes odoo/odoo#40986

X-original-commit: 5c15b1310729129e390b455b0d1e0ac367f8dd69
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2019-11-14 09:55:14 +00:00
Victor Feyens 7581097779 [FIX] sale_product_matrix: typo
X-original-commit: 47693e8da777429585cf258dd1e23557a82c91a0
2019-11-13 10:05:20 +00:00
Victor Feyens 1a99a47fac [FIX] stock: wrong stored attribute, replaced by store
closes odoo/odoo#40979

Related: odoo/enterprise#6924
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2019-11-27 15:54:00 +00:00
Victor Feyens c32e9a4788 [ADD] (*_)_product_matrix: test tours
closes odoo/odoo#40971

X-original-commit: d729460f5fc72aa70e0a024e1dff281299eed0e3
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2019-11-27 15:49:57 +00:00
Victor Feyens 6c80003208 [ADD] purchase_product_matrix: tests
as we cannot do the test in product_matrix, add the purchase equivalent
in purchase_product_matrix to also test the matrix in this case.

X-original-commit: 9d7024a5327939de3c145928782936000d26bd33
2019-11-21 15:31:30 +00:00
Victor Feyens 60c50d16a5 [FIX] *_product_matrix: use correct record for comparison.
X-original-commit: a1d2893f8bdd05ad277b4129932849865a48b1d6
2019-11-21 15:31:30 +00:00
Victor Feyens d0d52743b7 [FIX] web,product_matrix: Do not trigger event on parents.
X-original-commit: 127a75ed5c746291f9b0b7466d8935c83abc32a0
2019-11-21 15:31:30 +00:00
Victor Feyens 21bcafc053 [FIX] product_matrix: ensure the data is taken from a targeted widget.
X-original-commit: 44462e11ddba648d64fb75997e3f87a877c642eb
2019-11-21 15:31:30 +00:00
Antoine Prieels 53bc9dcdc6 [FIX] hw_drivers: Print status ESC/POS printers
The status ticket contains ESC/POS commands but was printed on all
printers connected in USB. Plugging a printer that doesn't support
ESC/POS resulted in undefined behaviors.

We now only print this status ticket on ESC/POS printers.

closes odoo/odoo#40972

X-original-commit: c6a28b627cbe6f8bd1da4321c1329cbc1bde498d
Signed-off-by: Antoine Prieëls <aprieels@users.noreply.github.com>
2019-11-27 09:18:33 +00:00
Jigar Vaghela 441759a5f1 [FIX] l10n_ch: avoid warning about not stored of l10n_ch_isr_number_spaced
two compute field have same method but one is store and other one is non store
so we split compute method for both fields(l10n_ch_isr_number,l10n_ch_isr_number_spaced)

closes odoo/odoo#40970

X-original-commit: d7a2d4aca37647ae568a5bb9f515ce2138245878
Signed-off-by: Josse Colpaert <jco@openerp.com>
2019-11-27 12:56:04 +00:00
Josse Colpaert 0940bfcfd5 [FIX] l10n_cl: avoid warnings on module install
X-original-commit: c6a00ff1c29481e826c81f551cacf60f054c15f8
2019-11-27 12:55:56 +00:00
lejeune quentin 194e49a902 [IMP] point_of_sale: Refactoring the "build" of the IoT Box
The use of an emulator (qemu) for the IoT Box build posed compatibility and performance issues.
So we have the Raspbian filesystem to install and configure packages.

closes odoo/odoo#40967

Task: 2145445
X-original-commit: 9c4e23a656bfd7b2f0c40feafadbce1b8d651aa8
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-11-26 13:36:38 +00:00
Juan Carlos Montoya 46ea06816c [FIX] payment_paypal: no transaction found
The paypal payment flow was crashing because no transaction was found
when the client wasn't connected.

closes odoo/odoo#40966

X-original-commit: 48f02f32fc3c32812a391d1fa37d561a8ae55e74
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-11-27 12:22:09 +00:00
Xavier Morel c15f81e2e1 [REM] sale_management: dynamic domains
The static domains were already added in
65613f5f83, it's just that the dynamic
ones were missed / left over.

closes odoo/odoo#40960

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-11-27 13:59:37 +00:00
Xavier Morel 1881999b89 [REM] l10n_ar: dynamic domain
closes odoo/odoo#40954

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-11-27 10:00:31 +00:00
Nicolas Martinelli 7ae118a20b [FIX] mail: reply to note
- Handle the notifications in Odoo
- On any object, e.g. a SO, user A a note and ping user B
- As user B, go to Discuss and reply to the note

The reply is sent a regular message.

Actually, everything is available to reply with the right message type
in:

https://github.com/odoo/odoo/blob/bae8ab7d93143e082e1d1a9cbe20a350c2d34d07/addons/mail/static/src/js/discuss.js#L1327

It is simply unset.

opw-2088619

closes odoo/odoo#40946

X-original-commit: 84c8221c60e3483aa637abad057253424236af83
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-11-27 08:44:56 +00:00
jvm-odoo 5ff3bec51b [FIX] sale_crm: fix crm quotation context
Reproduce the issue

    - Install CRM & sale_crm
    - Create an opportunity
    - Create a quotation from the opportunity

    The name of the draft is the opportunity's name instead of "New"

    - Add a "Storage Box" to the quotation, for instance
    - Confirm the quotation
    - Check the delivery note

    The name of the delivery note is the opportunity's name instead of
    WH/OUT/...

Cause

    This issue is caused by 4c9c249c. It seems that we pass an extra
    default_name in the context.

This commit removes the extra default_name from the context.

OPW-2122928

closes odoo/odoo#40943

X-original-commit: e8d91e4a7037d6c05991debb91072de162f0cf56
Signed-off-by: Jason Van Malder <jasonvanmalder@users.noreply.github.com>
2019-11-22 08:00:23 +00:00
Kevin Baptiste 82df1dfccc [IMP] fleet: model cleanup, dashboard
Purpose
=======

It is currently difficult to know exactly what is used for costs
and services on the contracts.

Hence it make it difficult to evolve the fleet application
We should clean the models in order to have something that is clearer

Specification
=============

Cleanup of models: removed Fuel and Cost. Contract and Services are no
longer inheriting Cost and are seperate models simplifying the use of
Fleet. A contract now has included services and they are no longer
generating cost.

closes odoo/odoo#34090

Taskid: 1931775
Related: odoo/enterprise#4572
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-11-27 11:54:51 +00:00
Victor Feyens c5398bd4bc [IMP] doc : group_operator field attribute
closes odoo/odoo#40944

X-original-commit: 7cbad14e28c50d51c14683d2548ea32ebc58907f
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2019-11-27 10:06:36 +00:00
Xavier Morel 7b75571fe8 [FIX] crm: remove onchange domain
closes odoo/odoo#40939

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-11-27 09:59:57 +00:00
Xavier Morel 17ad6be46a [FIX] base: returning a domain from an onchange
Turns out we've got an operator just for the pattern of "match value
if there's one, otherwise match everything".

Also remove an example of domain in onchange doc.

closes odoo/odoo#40938

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-11-27 09:59:51 +00:00
Laurent Smet 5426960e54 [FIX] account: Fix reconciliation access rights with Invoicing
As the group_account_invoice doesn't have the access rights to unlink the
account.partial.reconcile/account.full.reconcile, there was impossible for
the user to undo a reconciliation.

closes odoo/odoo#40934

X-original-commit: 0288adb0c315a1da63fe7e2d9b1f586ad6c9555b
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2019-11-27 08:16:57 +00:00
Nicolas Martinelli e3954db697 [FIX] stock: confusing error message
In case of a picking type where stock move lines are not shown, clicking
on 'Put in Pack' without 'Done' quantitites set shows a confusing error
message.

closes odoo/odoo#40928

X-original-commit: 76b72ab5953c1fc72e3c06464fd1c65e6420a4b3
Related: odoo/enterprise#6906
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-11-27 07:52:58 +00:00
Nicolas Martinelli 4dfa4e2c06 [FIX] stock_barcode: put in pack in receipt
- Activate product packing
- Create a PO for a stockable product, validate
- In the barcode interface, go to the created picking
- Set the product quantity
- Click on 'Put in Pack'

An error is raised: 'All the products currently reserved in the picking
are already in a pack...'

In the regular interface, the procedure is to create the move lines
manually, therefore setting a quantity done. However, this is not
possible in the barcode, and `move_line_nosuggest_ids` is always empty.

We introduce a special use case to bypass this in the case of the
barcode view.

opw-2127637

X-original-commit: d3a7b0e1b1dffd73b9ff31f1ec9fa4f6bbf478d2
2019-11-27 07:02:11 +00:00
Nans Lefebvre f3dec5d0ae [FIX] hr_holidays: allow request unlink because of typo in group name
opw 2144639

closes odoo/odoo#40927

X-original-commit: 82de73f421885e76aae81e2e6d8ec7bb585ad3f4
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
2019-11-26 12:52:33 +00:00
Lucas Lefèvre b51be7fa02 [FIX] lunch: Disable vendor creation from grouped products
fixes #38014

closes odoo/odoo#40926

X-original-commit: dbd532894783fc8aeb0b5c72b2dd88d8afdb1ccb
Signed-off-by: lul-odoo <LucasLefevre@users.noreply.github.com>
2019-11-26 08:27:49 +00:00
qsm-odoo fbdc541f9c [FIX] web_editor: read both color and bg-color to find custom ones
This was broken during the recent colorpicker refactoring.

closes odoo/odoo#40925

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-11-27 09:36:27 +00:00
Lucas Lefèvre 25dc18bb09 [IMP] hr: Add empty header for view inheritance
Some modules might want to add buttons in the form header of the employee public
(e.g. hr_appraisal).
This commit adds an empty header to easily allow view inheritance.

Note: this empty header is not displayed if no buttons are indide.

Task 2028794
PR odoo/enterprise#6495

closes odoo/odoo#39565

Related: odoo/enterprise#6495
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-11-25 15:46:38 +00:00
Nicolas Lempereur 1c47f2070b [FIX] web_editor: update attribute of edition container
In most use case, when we edit the website we have a situation such as:

```
<div id="wrap" branding-attributes="...">
    <section class="mycontent">hi!</section>
</div>
```

When we modify a part, we replace all child nodes of the branded
element.

But if we had more complex content such as:

```
<div id="wrap">
    <section class="mycontent" branding-attributes="...">ho!</section>
    <t t-call-assets="web.assets_common" t-js="false" t-css="false"/>
</div>
```

we have a t-call inside the div#wrap, so branding is distributed to
child that could have attribute modified (eg. changing background).

Then if `<section/>` node is saved, the possibly modified attributes
are lost.

Without the change, the added test fails with:

 '<div class="nice">hoi</div>' not found in '...<div>hoi</div>...' :
 saved element attributes are saved excluding branding ones

opw-2122947
closes #40345

closes odoo/odoo#40830

X-original-commit: 71b20a24c40ae9daa10076ab0fd656b043819cff
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2019-11-25 18:10:30 +00:00
Nicolas Martinelli 70d856f2c7 [FIX] hr_recruitment: newly hired
The current 'Newly Hired' filter is incorrect in several ways:
- the compute method doesn't assign the value correctly
- the search method mixes `hr.applicant` IDs with `hr.employee` IDs

Moreover, it relies on the fact that the job position is closed. Some
positions might always be opened, so the result is inaccurate.

We make the simpler assumption that the newly hired people are employees
created less than 90 days ago.

opw-2125861

closes odoo/odoo#40899

X-original-commit: ee928babbe433285883f1e878d83392d7199a37d
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-11-26 11:54:15 +00:00
Victor Feyens 4f226e7893 [FIX] base: consider advanced cases for automatic check_company domain.
Those cases are already checked in models._check_company() but not considered
when defining the default domain on `check_company=True` fields.

* Consider res_users relational field
	Companies allowed for user = user.company_ids
* Consider company-dependent fields
	Companies allowed = self.env.company

closes odoo/odoo#40906

X-original-commit: a8de9509823c213dad2f5e8ff44ceb670f81ea70
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2019-11-26 15:39:13 +00:00
Victor Feyens 7d9136185b [FIX] base: a user needs to have allowed companies set.
X-original-commit: 4205cb2728041487bd026bf5c6bac590e0ace1e9
2019-11-26 15:39:13 +00:00
Nicolas Lempereur 31a18fa6ea [FIX] crm,hr_recruitment: highlight and show others
When clicking on stat button "Meetings" on a partner, just highlight the
partner meetings as is done for similar stat button instead of having
a domain that hides other event (so when creating meeting, we can take
into account other existing meetings).

A similar change with same reasoning has been done for "Meetings" stat
button of hr.applicant records.

opw-2131494
closes #40812

closes odoo/odoo#40900

X-original-commit: 957e7eb77ed18e4a1c14ef4ef55bd54503c56f44
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2019-11-25 16:59:46 +00:00
Damien 8eb4c0d20f [CLA] signature for Kontrolix
closes odoo/odoo#40905

X-original-commit: 1b2df29ed43b1ab465eec6c579e926804b950338
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-11-26 12:49:27 +00:00
Yenthe666 d05e5bef32 [FIX] lunch: fix typo in widget definition
closes odoo/odoo#40902

X-original-commit: cf7017ea92c34a98bc670860ba89677bb8697c0b
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-11-26 13:50:13 +00:00
pawa2007 f9412ef3c0 [FIX] doc: update URL to the right article
A second edition is being written but not published yet

closes odoo/odoo#40405

X-Forwardport-of 2b99e0cb59616a0006ef615bbfbc

closes odoo/odoo#40901

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-11-26 16:30:50 +00:00
Laurent Smet 2dc2c20fe5 [FIX] account: Fix missing dependencies of _check_duplicate_supplier_reference
- Create a vendor bill for partner A with reference 'AAAAA'
- Create another vendor bill for partner A with the same reference:
=> Constraint is triggered.
- Create another vendor bill without partner with the same reference.
- Edit the vendor bill and set a partner:
=> Constraint not triggered.

closes odoo/odoo#40897

X-original-commit: 3f6254c8faa7dfb2484f4ac18d4c0fd717149e4b
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2019-11-26 09:54:17 +00:00
Kishan Gajjar c428e0aa68 [FIX] website_mass_mailing: restore newsletter subscribe notification
closes odoo/odoo#40888

X-original-commit: fcbe95642850ccda049ef504fb41c45b45c7597a
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-11-26 12:17:39 +00:00
Jeremy Kersten 56b4764b18 [IMP] website: allow to don't show specific view in name
and uses it in customize_show.

closes odoo/odoo#40887

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-11-26 14:39:28 +00:00
David Beguin 1832d17d21 [FIX] im_livechat, website_livechat: fix use visitor name in livechat session
im_livechat main controller was referring to website.visitor but this module is
not depending on website. The usage of website visitor's name should have been
done in website_livechat module.

This commit fix this issue.

Task ID: 2116715
PR #40732

closes odoo/odoo#40884

X-original-commit: defb98c1083e55ff02f290c3c6257a4ca8dc7d1f
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-11-22 16:32:19 +00:00
wan 2106dd3cd1 [IMP] account: clean entry/move reversal
Task 2085023
* Add a field that replaces the context to get the ids of the
entries/invoices
* Remove move_id, we can use move_ids instead
* Add text to explain invioces/bills will create refunds

closes odoo/odoo#38857

Related: odoo/enterprise#6263
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-11-15 14:05:30 +00:00
Varun Raval 3fe9402de4 [IMP] im_livechat: improve demo data for livechat summary for digest statistics
In order to see the added value of digest in demo mode some demo data about
livechat conversations are added. Rating is also added.

Task ID 1883428
closes #29764

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-11-26 14:24:49 +00:00
Varun Raval 72f907f32a [IMP] im_livechat: add livechat summary in digest
Purpose of the task is to add a Live Chat section in the weekly digest email
template. Following value related to livechat are therefore added in digest
emails:

  * hit % of ratings;
  * amount of conversations he handled;
  * hit time to answer;

Task ID 1883428
closes #29764
2019-11-26 14:21:45 +00:00
Xavier Morel 6044782aef [IMP] base: logging conf & logging of partner merge wizard
* root the base.partner.merge wizard's logger in odoo.addons so the
  "odoo" logger configuration properly applies to it
* update the default logging configuration to set the root logger
  rather than independently set the odoo and werkzeug loggers

closes odoo/odoo#40872

Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2019-11-26 12:48:05 +00:00
Aurélien Warnon 34b1ceb942 [FIX] website_slides: fix slide.slide statistics compute method triggers
The slide.slide "_compute_slides_statistics" method is missing the 'slide_ids.sequence' trigger.
It should be specified for cases when one of the slide_ids changes category (determined by the
sequence).

This can cause some CacheMiss and seem related to nondeterministic errors on the runbot.

PR #40705
Task#2123711
Runbot build error ID 247

closes odoo/odoo#40867

X-original-commit: 1994f544694051a767ecda88a12dee5c5579add2
Signed-off-by: awa-odoo <awa-odoo@users.noreply.github.com>
2019-11-25 08:38:03 +00:00
fw-bot a561e4cb56 [FIX] web_unsplash: traceback on saving the product
before this commit:
when creating a product from frontend and editing the product and
delete image, it doesn't get any url thus generating the traceback.

after this commit: if url is not defined then return None from
ir.qweb.field.image field converter

task-2063293

closes odoo/odoo#40866

X-original-commit: 2efad751e66931fd25a41c1b7d46865bccbc774a
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-11-22 09:19:35 +00:00
Barad Mahendra 525ed1125f [FIX] digest: force recompute of all kpis each time-based run
Before this commit, the computation of kpi for last week, last 30 days and
previous period comparison was wrong due to cache. Indeed as first value
was in cache, other values were taken directly from cache itself instead
of recomputing each value based on start_date and end_date of the computation
timeframe.

As digest fields are computed fields used a bit off-side, let us manually
invalidate the cache before computing a kpi so that it correctly computes
the timeframe values.

Task ID 1883428

closes odoo/odoo#40861

Closes: #40834
X-original-commit: 2966ee59cabc2bbae91e4ac4701fc393bc3770ae
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-11-26 09:32:09 +00:00
mightyjol (jhk) 74111d1fbf [FIX]product:change pricelist fixed_price field from float to monetary
steps to reproduce:
-change decimal accuracy for "Product Price"
-create a price list with fixed price
-the fixed price field does not takes the decimal accuracy into account

this was working in V11 and V12
fixed_price was a float field like other price fields

previous behavior:
fixed_price is a monetary field
when setting up a fixed price for a pricelist, it takes into account
the precision from the current currency

current behavior:
fixed_price is a float field
when setting up a fixed price for a pricelist, it takes into account
the proper decimal accuracy setting ("Product Price")

opw-2121964

closes odoo/odoo#40807

X-original-commit: 27b90fc7389cfc7fe4a9f4f17dea74283a45af44
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
2019-11-25 12:44:05 +00:00