Before this commit several history steps were added when picking a color
and history steps were added when previewing a color.
After this commit history is only updated on color selection and not
during color preview: applying the color relies on execCommand which
adds an history step => no need to add another step upon picking a color
but must be prevented during preview.
task-2599771
closesodoo/odoo#76417
X-original-commit: 4c1956d697a52e4d561e93930bb9e9f5c61e8a35
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: Benoit Socias (bso) <bso-odoo@users.noreply.github.com>
The configurator's palette selection screen didn't support
SVG logo. On SVG upload primary and secondary colors couldn't
be extracted and no palette was recommended. It comes from the
fact that Python PIL library does not support SVG. We therefore
had to convert SVG to PNG before trying to extract primary and
secondary colors. A file format checking has been added. If the
uplodad file is not an image, a notification is displayed to
the user.
task-2602521
closesodoo/odoo#76400
X-original-commit: 33f43618f727bdc1239c52c66b73f0f436035774
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Issue: When resequencing an account_move, the chatter showed the
resequencing but also a ghost change of state from draft to posted
Steps to reproduce :
1) Create an invoice and post it
2) Look up the journal entry for the invoice and resequence it to some
arbitrary other name
3) Check the chatter for that invoice, it shows a change from draft to
posted
Why is that a bug:
The state isn't changed so it shouldn't be logged
Side-Note: I don't understand why in the code until this commit we had
to force change the state to draft to change the name of the move, when
I tested, we can change the name of a posted move without any issue
opw-2581248
closesodoo/odoo#76394
X-original-commit: e4f5c0d13fb5b04c4a334758c26e442efbb247d4
Signed-off-by: William André (wan) <wan@odoo.com>
This commit fixes two bugs:
1) When the user changes the tracking of a product template with
variants, they get a traceback.
2) When the user changes the tracking of a product with quantity
available, the warning is not shown.
For the 1), it was due to reading `tracking` and `qty_available` fields
on a record set (happens when the template has variants).
For the 2), it was due to the `qty_available` who is wrongly computed in
the onchange because of the records having a "new-id" instead of their
usual id.
How to reproduce:
- Create a new product with some variants, no tracking;
- Add quantities for those product variants;
- Edit the product and change its tracking -> Traceback.
task-2618203
closesodoo/odoo#76071
Co-authored: svs-odoo < svs@odoo.com >
X-original-commit: 75572da12b3ad5d0f930e7e2f5dbac067a350b3c
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
Signed-off-by: Rémy Voet <ryv-odoo@users.noreply.github.com>
Before this commit. The move splitting was not considering _split return
a list of values.
This commit also add a bunche of missing tests
Task : 2411102
closesodoo/odoo#76371
X-original-commit: 49164aa65f4eea0e46fff207c841beb94154f636
Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>
Tests now check for the 'error' field in Pingen repsonse
snailmail_external_layout.js now targets the right div
closesodoo/odoo#76288
Task: 2588145 & 2583718
X-original-commit: 64ba95bc847f9db661d0e348f8bca1249da0b960
Signed-off-by: Florian Daloze (fda) <fda@odoo.com>
Bug
===
Open a website page and click on "New" to create a new course from the
frontend. Then create a new tag from this view, a traceback is raised.
Since odoo/odoo@51ff8b09db the code has been refactored to use the new
JS import, but the way we import doesn't work with the "default export" used
in "slides_course_tag_add".
Task-2636073
closesodoo/odoo#76367
X-original-commit: 5838a2622d7798ce832939a05c0482f8dac01b3c
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
It was previously decided that double clicking on a link shouldn't do anything
other than opening the popover (which happen on single click).
It was recently decided that we should actually open the right panel link tool
on double click.
Adding double click behavior, it was needed to refactor the way the popover is
opening/closing -> We now use `focus` as trigger instead of `click`.
Side effect, it will also fix 2641448 (part about double click on word)
Courtesy of SAD for debugging the double click issue (with trigger click)
task-2618494
closesodoo/odoo#76372
X-original-commit: 4eff35ab31bfc45b4c8dca8392e9da4f4e2a7afd
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Before this commit, when requesting the link tool in the right panel, it would
always focus its input.
This commit adds an option to not focus the input when link tool is requested.
It will be used by next commit.
task-2618494
X-original-commit: ad13055d58b6cd92d56f483bce17ab2e19216809
Part-of: odoo/odoo#76372
Since the recent time off B2B, time off validity has been moved from the
time off type to the time off allocation. Meaning that a company may use
the same time off type every year for their yearly time off.
This means that the dashboard must display currently valid data.
Remaining leaves and taken leaves will now be computed in function of
that data aswell in the dashboard.
This commit also fixes being able to take a leave if the current
allocation does not permit it if an expired one would have made it
possible.
TaskId-2636405
closesodoo/odoo#76366
X-original-commit: eeccd682124fe83d2c2342be0d8804aa2ca21146
Signed-off-by: Kevin Baptiste <kba@odoo.com>
Signed-off-by: William Braeckman (wbr) <Williambraecky@users.noreply.github.com>
Before this commit if the text selection was lost while the color
palette was used, the color selection was not applied on anything.
After this commit if the text selection was lost, it is restored to the
last selection known in history before applying (or previewing) the
color selection.
Also avoid to remember selections that are not part of the editable.
task-2599771
closesodoo/odoo#76357
X-original-commit: 0e706d508d6e747cff566c33d34b794a321eef5c
Signed-off-by: Antoine Guenet <Zinston@users.noreply.github.com>
The search param "domains" of type Array was not satisfactory for
several reasons:
- useless for non reporting views
- too close from the search param "domain"
- a key "fieldName" was put on the value (resulting in a loss of
information in case of stringification)
We change it for a search param "comparison" of type null or Object.
closesodoo/odoo#76340
X-original-commit: 4f867099846c4214a74a7b0222ac0941537bbe29
Related: odoo/enterprise#20772
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
When the name of a production order changes, we should update the name
and the reference of the analytic accounting lines of its work orders.
Task-2638896
closesodoo/odoo#76090
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
Both mo_analytic_account_line_id and wc_analytic_account_line_id are
copied when duplicate the workorder. This is not correct.
Task-2638896
Part-of: odoo/odoo#76090
Since commit bbb1a8f151, module's upgrade script can also be added
into special 'upgrades' folder as an alternative to the old 'migrations'
folder.
As those upgrade scripts are not maintained from version to version, we
should not count them as maintenance.
OPW-2536046
closesodoo/odoo#76334
X-original-commit: 28a303a67935dc5566cc0d1fe2be157736691968
Signed-off-by: Xavier Alt (xal) <xal@odoo.com>
Before this commit, the context given to the client action report was incorrect
and produced a crash server-side.
After this commit the context is correctly given to the ReportAction and to the print
closesodoo/odoo#76319
X-original-commit: 43d0ed37cfd1a6a09e7d21976816f4216e94fa6a
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
Before this commit, the task_count field displayed in the 'Tasks'
stat button shows the number of open tasks, that is all tasks with
either no stage linked or stage not folded or not closed.
The problem is when the user clicks on this stat button (displayed in
project form view or in project update), he sees all active tasks in
the project.
This commit changes the count to display the number of active tasks
instead of the number of open tasks in the project.
task-2633229
closes#76167
X-original-commit: f6ace36d7f61c005f324559d02436f7ff69eb40a
Part-of: odoo/odoo#76263
Since the addition of guests, it isn't enough to rely on the
`partner_id` of the record to get the name.
This commit adds an override of `name_get` so that the `display_name` of
the record remains consistent for both partners and guests.
closesodoo/odoo#76329
X-original-commit: 48d3f78ee3fd796907e17319607f19b8c97ba9c3
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Before this commit, the callViewer model was re instantiated in cases
when the amount of RTC session would change, which was not necessary
if the call viewer was already present.
This could cause tracebacks accessing deleted callViewers.
closesodoo/odoo#76328
X-original-commit: d2c9cc55bbabd21cbbbc8a0e77f6935fdafddeea
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
This commits adds a proper event listener removal for `onbeforeunload`
to facilitate testing and cleans up the join/leave rpc button locking.
closesodoo/odoo#76327
X-original-commit: 28d4c80b0dd2f30fb6aab46099a3c64d18f8d3b9
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Commit cd12293386 introduced an
optimization in the way that models and their inheritances are loaded,
with this commit we defer the setting of each model class' bases
from the _build_model method to the _prepare_setup method.
This has the advantage of setting any given model class' `__bases__`
attribute only once, but it also means that when _add_manual_models is
called, the __bases__ for ir.model are not yet set (only the default
implementation exists), therefore any module overrides to ir.model do
not take effect when creating the custom models.
This meant that if one creates a custom model with chatter support (i.e.
custom ir.model behaviour implemented in mail) and one restarted the
server, the registry would not properly setup ir.model before creating
the custom model (yielding warnings about tracking and such not being
valid fields) and when creating a record of the custom model, the
registry would crash.
With this commit, ir.model's _prepare_setup is explicitly called before
_add_manual_models to ensure that all overrides to ir.model are taken
into account.
closesodoo/odoo#76325
X-original-commit: f3afb23cdf21f395855771a037c721e977dc93c8
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Signed-off-by: Adrian Torres (adt) <adt@odoo.com>
Before this commit, leaving the call before the request for the audio
stream was complete would lead to a traceback as the following
operations were no longer relevant when a call is ended.
closesodoo/odoo#76318
X-original-commit: 80dcb4a14c6732794676a48fbc91d43618147414
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Before this commit, ending the call on mobile when on fullScreen
would lead to a traceback as the callViewer was updated asynchronously
because it relies on the browser fullScreen promises.
This commit fixes this issue by ensuring that the callViewer still
exists when the fullScreen promise is resolved.
closesodoo/odoo#76317
X-original-commit: cfadf792ecb471d6a717e6cb899db39e0af9005c
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Thanh Dodeur <ThanhDodeurOdoo@users.noreply.github.com>
Before this commit, safari mobile would immediately launch new videos
as fullScreen, while safari would prevent the autoplay of videos, as
the play request didn't originate from a user input.
This commit fixes those issues.
closesodoo/odoo#76316
X-original-commit: d1a74a1f180f5a6963355ae7e402d42351d1d16c
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
`fields.Date.today` doesn't give date based on TZ which might be wrong
in some cases as it doesn't respect TZ.
With this commit, we are using `fields.Date.context_today` as default date.
closesodoo/odoo#76241
X-original-commit: addd4ae73ca4fa7a7046a88dd1310361dd895f15
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Actually we can't gie more one barcode for a product
In inventory we can make "package" with various quantity
So with this commit we add the possibility to add a package
of product (1-n) with a specific barcode
closesodoo/odoo#76307
Task: 2610279
X-original-commit: e0021567403231684bc763c110c34366697a8613
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
- Go to any graph view (i.e. in CRM)
- Change "Group By" 2 times very very quickly
(In Chrome, you can set Throttling to "Slow 3G" in Network tab of devtools)
Data from first groupby will be mixed with data from the second one.
A graph reload is performing the following steps:
* clean previous data
* fetch data
* set data
The issue happens when a second reload is performed while the previous one
has not set its data yet and the cleaning step of the second one is performed
before the setting step of the first one.
The solution will be to ignore the setting step of all previous reloads if
there is a more recent one.
opw-2460145
closesodoo/odoo#76304
X-original-commit: 79335d298126b523f6ff9768e219822789d99620
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Anh Thao PHAM <kitan191@users.noreply.github.com>
Calling the xml action directly in the view make it miss the filling
context done in _get_action().
closesodoo/odoo#76294
X-original-commit: b818927898e42e8837230b7d1f089d4d822d7d76
Signed-off-by: William Henrotin <Whenrow@users.noreply.github.com>
Commit 04f3cac527 makes picking_type_id compute on stock_move_line to
get the picking type of either the picking or the manufacturing order.
Right after, commit dd53f5323f set picking_type_id related of the
picking one to be able to search on it. (in this later scope,
manufacturing part was not needed, hence the related instead of compute.
This commit mix the two idea by having a new search function on the
computed fields to filter stock move line depending on their picking
type.
X-original-commit: d535108f96d62f217dda7cbb676f9d60b7477f4f
Part-of: odoo/odoo#76294
context:
Connected in /fr on a website with /en as default lang.
Before this commit,
/web/session/logout?redirect=/
/
/fr_FR/
/fr_FR
Now
/web/session/logout?redirect=/
/fr_FR
Part 1 -> to say that we are in multilang context and use url_lang.
multilang=False to avoid /web/session -> /fr/web/session
website=True to have url_lang done in the request.redirect.
Part 2 -> to remove the trailing '/' that will be only useful for '/'
closesodoo/odoo#76290
X-original-commit: ae35117ee1e019c3c0c333f291478825a5722706
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Be safe when we check if data have has_dicounted_price set or not.
In case of sample e.g. in product snippet, it could be missing.
task-2641360
X-original-commit: 0e1d1d519b962476113ae8553f10f85b22561824
Part-of: odoo/odoo#76290
This warning is never displayed due to typo in condition:
show_availibility vs show_availability
X-original-commit: f6bcd01fd34c3bdd3530afc1a0d5a557d45a8eac
Part-of: odoo/odoo#76290
Remove this code that seems useless.
opw-2244843 is no more present reverting this patch.
Now translations will be loaded with same url than owl i10n service
withtout url in lang, and using multilang redirect as 'distinct' key.
X-original-commit: 00e6b87c9d16af1bfb3e63b9b857fbaad90e620a
Part-of: odoo/odoo#76290
Momentjs has no config for en_US so this rpc will return nothing in all case.
It avoid an (cached) rpc on first load.
X-original-commit: bf7456403634ce4c2eef07cc31e47c3c8a524c52
Part-of: odoo/odoo#76290
Also, remove the duplicated 'edi_document_ids' field inside the view.
'edi_document_ids' is now in debug mode for payments.
closesodoo/odoo#76123
X-original-commit: ad346eec9fd06e430b9b5859578b00e0b28cc443
Signed-off-by: Florian Gilbert <FlorianGilbert@users.noreply.github.com>
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
options="{'no_open': '1'}" is managed for many2one fields.
This commit aims to do the same for x2many fields.
Note: A test will be added later
X-original-commit: dadaccbe6658d7f3c75db48d7961ff116b25dbc8
Part-of: odoo/odoo#76123
Currently, when there is a YouTube URL configured on the track, we
automatically set the layout of the track page as "widescreen".
This implies that we hide some menus and adapt the layout to display the full
video player.
However, in the XML template of the track view, we only display the video
player if there is a YouTube URL configured AND one or more of those conditions
is respected:
- The track is configured as a "YouTube Replay"
- The track is "coming soon" (< 30 minutes)
- The track is live
- The track is done
This is done to match the two behaviors and get a consistent display.
Task-2643147
closesodoo/odoo#76296
X-original-commit: bfb692dd5c6480841d5c6fb1e54dba1b4bd928ab
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
- Create a product with Category configured with:
* Costing Method: First In First Out (FIFO)
* Inventory Valuation: Automated
- Create a PO to buy 1 unit and receive the product
- Create a SO to sell 1 unit and deliver the product
- Return the product
- Re-deliver the product
- Create invoice for SO but don't post it
- Connect with an user with "Accounting: Accountant" rights only
- Post the invoice
An access error will be triggered when trying to access stock valuation layer.
opw-2623376
closesodoo/odoo#76289
X-original-commit: cc76e76ef2d1cc5a16778bd9440911fd6ec73c9b
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
Signed-off-by: Anh Thao PHAM <kitan191@users.noreply.github.com>
This reverts commit odoo/odoo@3d72a6a4d2 . This code is not used
as finally Kanban ribbon as a widget has not been added after review. Moreover
current use of ribbon classes in kanban is broken.
closesodoo/odoo#76292
X-original-commit: 4b853ad321d89075ef6151c64160a6e9db15c2e6
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Following commit 637684fb50 which improved
the conditions under which the ComponentWrapper compatibility layer
should trigger owl's `__callMounted` on all the owl children of a Legacy Widget.
One case was forgotten though: when the current component (wherever it is in the hierarchy)
is rendered BUT another rendering has been initiated meanwhile.
In that case, we shouldn't mark the component as mounted. The owl's fiber.complete algorithm
will take care of calling __callMounted when it finishes.
closesodoo/odoo#76281
X-original-commit: 7ca2adb1d946590df0caf3aea135601794851894
Signed-off-by: Simon Genin (ges@odoo) <ges@odoo.com>
The notification sent when starting a meeting used `partner.name` to
display the name of the one who started the meeting. Therefore, it
did not work properly with guests, for whom no partner is defined,
resulting in `False started a live conference` being displayed.
This commit fixes the issue by using `guest.name` instead of
`partner.name` when no partner is defined.
Also change some quotes to stick to the guidelines.
closesodoo/odoo#76264
X-original-commit: e00f30f8e0c9344bc81653357c16783f3e1d2511
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Clientside, the only key got from an `ir.actions.act_window_close` type
action is 'infos'. But this key isn't a part of the whitelisted
readable fields server side, which means you will get a warning if you
use it.
closesodoo/odoo#76109
Signed-off-by: Steve Van Essche <svs-odoo@users.noreply.github.com>
Before this commit, Inventory Admin was not able to create new /edit picking type
as Non-admin users doesn't have rights to create/edit sequence.
With this commit, we are creating/editing `sequence_id` with sudo
closesodoo/odoo#76258
X-original-commit: c5de12310be023e1048f8a1174f87582c13a9160
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
no need to make rounding during computing qty_available
STEPS (see the test):
* create product with uom dozens
* create product with uom units
* create bom kit to convert one to another
* set qty on hand to 1 for product dozens
* check qty for product units
BEFORE: qty=11
AFTER: qty=12
---
opw-2632782
closesodoo/odoo#76242
X-original-commit: 26b28408d8970baa8cbf59ffaff90cab1e579410
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
Steps to reproduce the issue:
- Let's log in Odoo with a user U1
- Create a lead with user U2 as salesperson
- Click on New quotation
Bug:
A SO was suggested with U1 as salesperson instead of U2
opw:2520827
closesodoo/odoo#76214
X-original-commit: a5e78d47ec475ec310573632f2b105b6247539d5
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
* order lines are now not grouped anymore by account. That allows a more detailed label on the accrual entry line, as it's now directly related to a single order line
* we now create a single accrual entry counterpart, instead of one per order previously. That reduces the 'noise' in the accrual entry, at the cost of not having the sum per ordre anymore easilly but it doesn't seem to be important to audit that account
closesodoo/odoo#76037
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
Benoit Socias