Commit Graph
143929 Commits
Author SHA1 Message Date
Cedric Prieels (cpr) 6ed20e3489 [IMP] project: improve the UX of the app
Generic UX improvements for the project app.

task-2501760
See odoo/enterprise#18819

closes odoo/odoo#71232

Signed-off-by: LTU-Odoo <IT-Ideas@users.noreply.github.com>
2021-07-23 06:45:50 +00:00
Michael Mattiello (mcm) 0864034f45 [FIX] web: fix quick edit text selection test
Before this commit, it could happen that the test fails.
We may be waiting too long on the second click in the test and so
the form switches to edit mode too early.
Now, we don't await the click to keep sync.

closes odoo/odoo#74157

X-original-commit: 01708583777cf33e9b505a494fdc5cdb66db86b5
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2021-07-23 11:04:29 +00:00
Francois (fge) b3de6f43d5 [FIX] web: display commands in the palette command
This commit avoids displaying commands associated with the wrong active
element in the palette command.

closes odoo/odoo#74149

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2021-07-23 09:50:28 +00:00
William Braeckman ddef148260 [FIX] hr_holidays: half day outside of working hours
Fixes taking a hald day outside of working hours counting as half a day
instead of nothing.

See odoo/odoo#68977

closes odoo/odoo#74147

X-original-commit: 35a7308188d069465ad624d4199ec26b6d25d651
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Signed-off-by: William Braeckman (wbr) <Williambraecky@users.noreply.github.com>
2021-07-23 09:29:23 +00:00
Benoit Socias 6f34f85c66 [FIX] base: remove branding on t-out nodes
Before this commit branding was removed only from nodes using t-esc and
t-raw.
This caused problems such as the ribbon preview rendering being
propagated across all products because the oe-model/id/xpath fields were
referencing the product card view itself.
This appeared because of the conversion from t-esc/t-raw to t-out.
The branding used to be removed from nodes using t-esc and t-raw, but it
was not removed for t-out.

After this commit the branding is also removed from nodes using t-out.
This restores the old way the ribbon preview was rendered, and therefore
also fixes the issue described in the related task.

task-2527056

closes odoo/odoo#74145

X-original-commit: 9e83dd83a39b542ec0e0d3045bcffcf24406c94b
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2021-07-23 09:12:51 +00:00
Jeremy Kersten f0a484f7ae [FIX] wesbite: fix wrong encoding from page generated by configurator
Before this commit, some snippets that contains special charactere like –
was wrongly displayed, since we removed the call to pycompat that did a
decode('utf-8') in previous version.

closes odoo/odoo#74041

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2021-07-20 13:14:06 +00:00
Julien Banken 58dc01a9a0 [IMP] contact: Add a color picker on the 'Contact Tags' sections
PURPOSE

This commit aims to improve the 'Contact Tags' sections of the 'Contact'
module by adding a color picker (on the list and the form view).

SPECS

- Add a color picker on the 'Contact Tags' sections (i.e: list and form view)
- Add a placeholder for the 'name' field of the form view.
- Update the label of the 'color' field.

LINKS

Task id: 2608410

closes odoo/odoo#74033

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2021-07-20 11:34:40 +00:00
Sébastien Theys 4f07d86026 [IMP] mail: remove search in discuss messages
It is a feature we would like to have, but it currently doesn't work well.

- Search is text based, but messages are HTML based, which means a lot of result
  make no sense because they match HTML tags, attributes, ... Inversely when
  searching for multiple words that do exist together but are separated by tags,
  it will fail to find them.
- Content of messages is actually not indexed, which means the search doesn't
  scale in big channel or with long messages. Indexing it is not trivial and has
  a huge cost in terms of storage and dependencies (trigram index for example).
- The search of the control panel is great for business documents but it does
  not fit the kind of searching UI that we would like inside discussions.

It is therefore decided to remove the feature until we are able to do it well.

Part of task-2369636
More information also on task-2359037

closes odoo/odoo#73903

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2021-07-23 08:21:14 +00:00
prro-odoo 7af4feb078 [FW][FIX] sale_project,sale_timesheet: display Sale Order button w/o need for Billable
Previously, the button Sale Order in a Project form could only be seen when the sale_timesheet module (installed automatically with the Timesheet, Sales and Project apps) is installed.
Now, only the Sales and Project apps are needed to be able to display the Sale Order button.

opw-2530161

closes odoo/odoo#74048

X-original-commit: 42fcb59373fda8c82b2402b5524160215553df68
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Signed-off-by: prro-odoo <proose@users.noreply.github.com>
2021-07-22 15:52:42 +00:00
stefanorigano (SRI) d570c7eba5 [FIX] website: apps switcher dropdown, allow vertical scroll
odoo/odoo#73748
task-2604186

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2021-07-15 08:27:54 +00:00
stefanorigano (SRI) 7084223134 [FIX] web: form view's stat_button design, remove entries double border
odoo/odoo#73748
task-2604186
2021-07-15 08:27:54 +00:00
Leonardo Pavan Rocha f33f305807 [FIX] web: fixes reports not scrolling
task-2355704 introduced a bug which prevented scrolling in reports, instead of only in report preview.
This PR fixes this bug.

task-2586245

closes odoo/odoo#73496

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2021-07-09 12:59:09 +00:00
Barad Mahendraandbbh-odoo 5f04da4cc5 [IMP] project: add the demo data for the burndown chart of project
Purpose of the task is to give a preview of what the Burndown chart
will look like once there is data.

So in this commit added the demo data for the burndown chart.

closes odoo/odoo#73426

Taskid: 2504119
Related: odoo/enterprise#19788
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Co-authored-by: bbh-odoo <bbh@odoo.com>
2021-07-22 10:20:54 +00:00
stefanorigano (SRI) 468b38472c [FIX] project: adjust project's control-panel status message design
Fix vertical alignment and style the message as a badge (clickable for
project managers).

task-2579123

closes odoo/odoo#73210

Related: odoo/enterprise#19437
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2021-07-23 06:54:18 +00:00
stefanorigano (SRI) 23fcc67a24 [FIX] web: adjust 'o_status' design
Solve an issue causing the background to be always 'bg-200' for Apps
that don't use bootstrap default 'bg-x' classes.

task-2579123
2021-07-23 06:54:18 +00:00
stefanorigano (SRI) 05d9d3ff65 [FIX] web: review 'o_dropdown' component scss code
This commit will simplify css output removing @extend(s) that are not
strictly necessary.

Moreover it will remove a deprecated compound-selector extension (good
catch @xmo-odoo).

task-2579123
2021-07-23 06:54:18 +00:00
stefanorigano (SRI) 8058beb19b [FIX] sale_timesheet: progress-bars, adapt design
Fix an issue causing bars' border-radius to mismatch their
container. Ensure text readability over custom badges.
Design minors.

task-2579123
2021-07-23 06:54:18 +00:00
stefanorigano (SRI) 6ef27067f4 [FIX] web, mrp: remove old decoration classes occurrences
Custom text decoration classes have been dropped with d9a0877096
in favor bootstrap default ones.

This commit will adapt the list-view generation code ans some mrp
translations that were mistakenly omitted.

task-2579123
2021-07-23 06:54:18 +00:00
stefanorigano (SRI) f7efa256fb [FIX] web, calendar: many2many avatar-tags field alignment
Prior to this commit the avatar status element was touching the badge
border.

task-2579123
2021-07-23 06:54:18 +00:00
stefanorigano (SRI) b49cd9fa55 [FIX] web: pivot cp, add missing caret
task-2579123
2021-07-23 06:54:18 +00:00
stefanorigano (SRI) 8a90d9288e [FIX] web: remove dropdown-menu minimum width
This line was initially introduced to handle legacy dropdowns
inconsistencies, but it's no longer necessary.

task-2579123
2021-07-23 06:54:18 +00:00
stefanorigano (SRI) a10089523f [FIX] web, account: review dashboard dropdown design
task-2579123
2021-07-23 06:54:18 +00:00
stefanorigano (SRI) beea3b1777 [FIX] web: solve inputs' caret inconsistencies
Before this commit input carets appeared different in color and size.
Moreover, since '$caret-width' was set using 'em' units, the caret was
sometimes cropped due to inconsistencies on how browsers handle decimal
border-width values.

This commit will uniform the way how input carets are achieved for
both versions and introduces caret's contextual variations (:focus /
required / invalid).

The caret color will now always matches the '--o-input-border-color' css
variable that changes according its the context.

task-2579123
2021-07-23 06:54:18 +00:00
stefanorigano (SRI) 2955883b94 [REF] web: o_input border color
This commit will change how states' border-colors are achieved for both
versions, extending enterprise's focus/disabled/invalid behaviors to
community.

Rather than (re)define each time the border-color with different css
lines, we'll set it to be equal to the '--o-input-border-color' css
variable once.
Than we'll change the variable's value according to its context.

This approach allows to define contextual border-colors without creating
complex selector and without the need of applying '!important' rules on
nested inputs.

task-2579123
2021-07-23 06:54:18 +00:00
stefanorigano (SRI) 4edfe4b45c [MOV] web, web_editor: move 'print-variable' mixin in utils.scss
Allows to use 'print-variable' mixin in any bundle.

task-2579123
2021-07-23 06:54:18 +00:00
stefanorigano (SRI) 803c945084 [FIX] web, calendar: fields vertical misalignment
task-2579123
2021-07-23 06:54:18 +00:00
stefanorigano (SRI) 0fd07a82ca [FIX] web: datepicker, show box arrow + minor design adjustments
task-2579123
2021-07-23 06:54:18 +00:00
stefanorigano (SRI) a2ec00a231 [FIX] web: highlight '.active' dropdown entries on :focus/:hover
Previous to this commit our custom bg-color for '.active' dropdown
entries (transparent) was overriding the default :focus/:hover highlight
behavior.

This is normal in bootstrap default, 'cause the framework uses accent
colors (eg $primary) for .active' entries bg.
Since these colors are normally more catchy than the :focus/:hover
ones, we can assume that the behavior is intentional but it doesn't
match our design chooses.

This commit will reinforce :focus/:hover rules for '.active' entries too
, allowing keyboard navigation and making it clear to the user that an
'.active' entry may be eventually toggled.

task-2579123
2021-07-23 06:54:18 +00:00
stefanorigano (SRI) dfc0c15cfb [FIX] web: settings view, remove unnecessary gap
This gap was initially introduced to increase space between section but
was not triggered correctly and, ultimately, not strictly necessary.

task-2579123
2021-07-23 06:54:18 +00:00
stefanorigano (SRI) a2ee6b923c [FIX] web: correctly target 'o_dropdown_item' child
Partially revert 47acba560a removing rules defining '<a>' children as
exceptions. Having an element (either <a> or a <span>) wrapping the
entry content is indeed now considered the norm.

This commit will extend bootstrap 'dropdown-item' design to any
'o_dropdown_item' first-child rather than on element itself.

task-2579123
2021-07-23 06:54:18 +00:00
Mohammed Shekha 4e40979099 [IMP] web: o_form_label_empty on standalone label
Before this commit: when standalone label is rendered in form view class
o_form_label_empty is not added due to which label text is not muted.

After this commit: when standalone label is rendered, label is sometime
rendered before field widget is rendered due to which o_form_label_empty class
is not added to label, with this commit we postprocess labels so that
o_form_label_empty is added on all field labels.

Also with commit, signature widget's isSet method will return true if value is
set in signature widget, this will make label of signature widget muted if it
is empty and form view mode is readonly.

task-2523197

closes odoo/odoo#71322

Signed-off-by: Simon Genin (ges@odoo) <ges@odoo.com>
2021-07-07 08:29:28 +00:00
Goffin Simon 1e430dc614 [FIX] account: Wrong currency symbol in payment receipt report
Steps to reproduce the bug:

Enable Multi Currency > Accounting > Create Customer Invoice in USD > Pay Invoice in EUR > click on payment and print payment receipt

Bug:

The currency symbol next to "Amount Paid" was in $ instead €

opw:2506868

closes odoo/odoo#73998

X-original-commit: f08bcbf90257d632f7258251059a5390bf3eafa4
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2021-07-19 19:10:06 +00:00
Sergey Shebanin 4440484c80 [IMP] hotkey_service add Delete & Tab to list of allowed keys
closes odoo/odoo#73555

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
2021-07-12 10:25:26 +00:00
Sergey Shebanin 4ed7217a9e [CLA] Sergey Shebanin 2021-07-12 10:23:42 +00:00
Xavier Morel b4bfb2a0d2 [ADD] base: missing raw preprocessing
makes raw a bit more expensive than necessary on creation

closes odoo/odoo#74132

X-original-commit: f9b12a59ea618fa598f0ffb6869f027c6a39bc2d
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
2021-07-22 15:56:08 +00:00
Martin Trigaux 24f2812652 [I18N] l10n_de*: translate CoA in German
closes odoo/odoo#74123

X-original-commit: f8c44798d58ce86390b1eba7c21c57632909bbdc
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2021-07-22 13:59:21 +00:00
Munaf Khan 7a2e286e12 [FIX] crm_iap_lead: allow to edit 'contact_number' for failed requests
Right now, for the lead mining request, `contact_number` field is only
editable when the request is in draft state. However, like the most
other fields, this one should be editable for the failed request so
that user can decide how many contacts should be fetched before
submitting the request again.

This commit fixes the behavior by making `contact_number` field
readonly for the successfully completed mining request only.

TaskID-2605708

closes odoo/odoo#74121

X-original-commit: 479a6492f9d2a6991e880f4fc4ac425ea1a7e72a
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2021-07-22 13:41:22 +00:00
Achraf (abz) dec5b354bb [FIX] mrp: Close workorder form view on button clik
This PR reverts this one https://github.com/odoo/odoo/pull/54364

because it introduces the following problem:
It is no longer possible to close the dialog when it is opened from a gantt view, because the buttons are overridden and they no longer close the window after the action.

In addition to the fact that this fix no longer makes sense at the moment

opw-2591597

closes odoo/odoo#74105

X-original-commit: ed09c16234f240fd52a5cc516465767b736fb40d
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
Signed-off-by: Achraf <abz-odoo@users.noreply.github.com>
2021-07-22 10:53:17 +00:00
Samuel Degueldre cfe079221c [FIX] web, web_editor: restore media upload progress toast
In odoo/odoo#72675 the new services were made available in the frontend,
and calls to the legacy notification services were redirected to the new
notification service. However, some of the behaviour of the legacy
notification service was not replicated in the new one, like the ability
to pass an HTML element to use inside the notification.

While html content can be passed, it is cloned, meaning that the DOM of
the element cannot be manipulated by the caller, which is what was being
done to show progress during media upload.

Although the upload progress toast looks like a notification, it's
hardly a standard notification and adds a lot of behaviour, because
manipulating DOM directly when it is managed by owl cannot be done
safely, it has been decided to simply make it its own widget separate
from the notification service, which can manipulate its own DOM freely.

task-2607393

closes odoo/odoo#74027

Signed-off-by: Romain Derie <rdeodoo@users.noreply.github.com>
2021-07-20 13:13:03 +00:00
Mohammed Shekha 33c2615359 [IMP] web: remaining_days widget editable in edit mode
Before this commit: remaining_days widget is not editable and it just shows
information based on value like, Today, Yesterday, Tommorrow etc, when we
change mode to edit it should have date/datetime picker so that user can change
value of the widget.

After this commit: remaining_days widget will display date/datetime picker in
edit mode and in readonly mode it will display delta between the value of the
field and today, it will also support edition of date/datetime value in multi
edit mode.

task-2507961

closes odoo/odoo#70578

Signed-off-by: Simon Genin (ges@odoo) <ges@odoo.com>
2021-07-16 07:18:16 +00:00
Pierre Masereel 3e7c9c67e8 [FIX] web: hexadecimal color in 8 digits not supported
Some scss compilers are not supporting the colors written in hexadecimal
with 8 digits.

So to keep the the color and transparency, we have re-written the color
in rgba.

Issue introduced in: https://github.com/odoo/odoo/commit/a1c983250e9547c383ef677fb411b0bc589efa89

closes odoo/odoo#74112

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2021-07-22 12:00:56 +00:00
Pedro M. Baeza 9489040b7e [FIX] l10n_es: Make non deductible taxes to propagate analytic
When you are using non deductible taxes, the tax amount is handled as
an expense increase, using the same expense account than the invoice
line. But not having the analytic option, this expense increase is not
classified in the same analytic account.

Thus, a sane default for the initial chart of accounts is to set it to
True.

TT31062

closes odoo/odoo#74111

X-original-commit: 3abf349e995f5fbdc0af6288425f7383d5b89a92
Signed-off-by: William André (wan) <wan@odoo.com>
2021-07-22 11:53:06 +00:00
Nasreddin Boulif (bon) 919a441178 [FIX] payment_stripe: display clearer customer description
Issue:

  Payouts reference on Stripe are display as:
  `SUB123 - ODOO_PARTNER_456789`.

Cause:

  When making a Stripe request to create new customer, the description
  is formated as : `ODOO_PARTNER_456789` .

Solution:

  Replace customer description format as :
  `Partner: Mitchel Admin (id:456789)` .
  Inspired by: https://github.com/odoo/odoo/commit/3bc1e0175d85a70806999109e928c234e8cc2ca4

opw-2593621

closes odoo/odoo#74109

X-original-commit: 07033a07ca49923a1c5095c371302fb894363c07
Signed-off-by: bon-odoo <nboulif@users.noreply.github.com>
2021-07-22 11:05:05 +00:00
Barad Mahendra e4967653be [FIX] web: fix the display of the time in year view popover
Currently, the time in popover of the year view does not appear
with the title due to record.allday is undefined instead of false

So in this commit, check if record.allday is not exist then display
the time infront of the title instead of after the title.

Related enterprise PR: https://github.com/odoo/enterprise/pull/19134

closes odoo/odoo#72440

Closes: #72440
Taskid: 2502339
Related: odoo/enterprise#19134
Signed-off-by: LTU-Odoo <IT-Ideas@users.noreply.github.com>
2021-07-21 04:44:28 +00:00
Barad Mahendra 639a3d0fcc [IMP] project,hr: generic improvement for the project
Purpose of the commit is to improve the ui of the project and task

So in this comit, project_id and tag_ids should be always visible
in fsm mode too. also re-sequence the task form view buttons and
added class for the proper xpath.

also move the common for for get_unusual_days on employee so it
can be reused.

Related enterprise PR: https://github.com/odoo/enterprise/pull/19134
Closes: #72440
TaskID: 2502339
2021-07-21 04:44:27 +00:00
Stephan Keller d8706cde99 [CLA] Signature for skeller1
closes odoo/odoo#73739

Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2021-07-15 09:34:09 +00:00
Stephan Keller 58dd5fc2b2 [IMP] product: validate date_start and date_end for pricelist items 2021-07-15 09:31:44 +00:00
Mitali Patel 8a585c0739 [IMP] sale_(project), hr_timesheet: improve task analysis report
Purpose of the commit is to improve the task analysis report
of the project app.

So in this commit, done the below changes:
- removed the # of tasks measure
- added the following measures: Rating Value (/5), Working Hours to Assign, Working Hours to Close
- removed the # from the labels of the following measures: Days to Deadline, Working Days to Assign,Working Days to Close
- renamed 'task title' into 'task'
- added a search on tag_ids and sale_order_id
- added the following filters:
   -My Projects + My Team's Projects
   -My Tasks + My Team's Tasks (rename 'Unassigned' into 'Unassigned Tasks')
   -Starred
   -Tasks Late + Tasks in Overtime
- added the following group bys: task, customer, kanban state, assignment date, creation date, deadline, last stage update

closes odoo/odoo#72587

Taskid: 2508645
Signed-off-by: LTU-Odoo <IT-Ideas@users.noreply.github.com>
2021-07-22 09:09:49 +00:00
Achraf (abz) ad7e6c19bf [FIX] web_editor: Allow internal users to copy/paste
On windows when you copy paste text in and into Odoo (for example in the description when creating a ticket) a traceback occurs.
There is an isWhitelist function which verifies that a node is indeed in the authorized items via the following instruction

`item.matches (CLIPBOARD_WHITELISTS.nodes.join (','))`

But on windows there is a comment node containing `<--StartFragment-->`

Here is the clipboard data on linux and on windows for the same copied text (Hello):

- Linux

```
  <meta http-equiv=\"content-type\" content=\"text/html; charset=utf-8\">
  <span style=\"color: rgb(102, 102, 102); font-family: &quot;Lucida Grande&quot;, Helvetica, Verdana, Arial, sans-serif; font-size: 13px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: left; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;\">Hello</span>
```

- Windows

```
	<html>
		<body>
			<!--StartFragment--><span style="color: rgb(102, 102, 102); font-family: &quot;Lucida Grande&quot;, Helvetica, Verdana, Arial, sans-serif; font-size: 13px; font-style: normal; font-variant-ligatures: normal; font-variant-caps: normal; font-weight: 400; letter-spacing: normal; orphans: 2; text-align: left; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-stroke-width: 0px; background-color: rgb(255, 255, 255); text-decoration-thickness: initial; text-decoration-style: initial; text-decoration-color: initial; display: inline !important; float: none;">Hello</span><!--EndFragment-->
		</body>
	</html>
```
Except for this additional comment on Windows, the `.matches()` method does not exist.

This PR uses the `Array.includes` function on the item's `nodeName`, which should work in all cases while keeping the same behavior.

opw-2591597

closes odoo/odoo#74029

X-original-commit: 41802bc518b4bcd1c71d8659ac560cb748befd95
Signed-off-by: Achraf <abz-odoo@users.noreply.github.com>
2021-07-20 11:22:21 +00:00
Thibault Delavallée e579e86b4d [FIX] crm_iap_lead_website: correctly support industry tags
Followup of odoo/odoo@edf729c09e where reveal_id was changed to
a reveal_ids on industry model (comma separated list of IDs). This was changed
in IAP Mining but not here.

Task ID-2608702

closes odoo/odoo#74051

X-original-commit: 99d1f09a7284bfa7f1bead42cb20e8122e800544
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2021-07-20 15:43:29 +00:00