Steps:
- Publish Standard method and Mondial relay shipping methods.
- Empty rules and countries on mondial relay shipping method.
- Go to shop, add a product and checkout.
- On the final checkout page, click on mondial relay and cancel the popup without choosing the location.
- Refresh the page.
- Click on Standard delivery then click on Mondial relay.
Issue:
We get an error(Null value of a variable) or the popup doesn't pop.
Reason:
When selecting the mondial relay method without location info, the ``SaleOrder.carrier_id`` of the order is set
but ``SaleOrder.delivery_rating_sucess`` is set to False(we didn't enter the location information). Because of that
when refreshing and calling ``_get_shop_payment_values()``, delivery line is removed from the order. Here we just
add the default delivery method.
opw-3468202
closesodoo/odoo#137418
X-original-commit: 686244ded63748196bbbea5773e55585015782f2
Signed-off-by: Eteil Junior Djoumatchoua (etdj) <etdj@odoo.com>
Steps to reproduce:
- Create a component C (automated/FIFO)
- Create and confirm two PO for C
qty: 1, price: 10
qty: 1, price: 20
- Make an MO with C as a component
- Unbuild that MO
Bug:
The valuation of the new component C is wrong, the new move in is valued
at the current product cost instead of its original value.
Fix:
create moves as a return to get the correct value
opw-3379457
closesodoo/odoo#137353
X-original-commit: d42238cc75fe6621c1eb893395856870c8bfbafb
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>
Step to reproduce:
- Install `digest` module and configure mail setup
- Sent the digest mail
- Go to inbox and open mail
- Click on the link of `Choose the metrics you care about`
Issue:
Redirected to main menu on Odoo.
Cause:
The link is broken because we escape `&` twice: escaped directly in
the URL string, then with `Markup`.
Solution:
Use only Markup to escape `&`.
opw-3470958
closesodoo/odoo#137352
X-original-commit: e3e6d1970df192e6629b9a9caf2d6cf36c64723b
Signed-off-by: Nasreddin Boulif (bon) <bon@odoo.com>
This significantly eases processing command data on relational field
received from server.
closesodoo/odoo#137341
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
This field contained 2 sets with partner and channel ids.
It's easier and safer to reason in terms of records rather
than properties on records.
Part-of: odoo/odoo#137341
Prior to this commit, the online payment portal was using the default
Odoo checkout layout when a user tried to pay for their order on the POS
self-order.
This commit enhances the UI and layout of the payment page (excluding
the o_payment_checkout form) as well as the confirmation page.
task-3433949
closesodoo/odoo#137090
X-original-commit: 046295b4a1651ba9ad3bfd8a9184154bde0ae1e2
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
We align how the date is computed on exchange differences on
how it already works when unreconciling. See _get_accounting_date().
closesodoo/odoo#136911
Task-id: 3516687
Related: odoo/enterprise#48058
Signed-off-by: Laurent Smet (las) <las@odoo.com>
This commit adds a popup to show product information when clicking on an
info button in the product card in the self order app. The popup shows
the ecommerce description and the name of the product.
The ecommerce description field has thus been moved from website_sale to
the product module so that the pos_self_order module can use it.
closesodoo/odoo#136906
Task-id: 3524272
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
The cookie service was replaced by a utils file in core. This was done
to be able to use the cookies without the need of environment.
"Om Nom Nom Nom" - Cookie Monster
part-of task-id 3439226
closesodoo/odoo#136782
Related: odoo/enterprise#48005
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Previously, when creating the public root, we would patch the rpc
service and the browser.fetch function so that they would rewrite the
relative URLs that they fetched to target the Odoo server. This is
useful when the public root is mounted on pages that are hosted on a
different server than the Odoo server, in particular, this was
historically useful for embeding the livechat widget in a website not
hosted by Odoo.
In odoo/odoo#122834 the livechat was refactored and got its own boot
code that does the same thing, making this code no longer useful. In
addition, in odoo/odoo#133153 the baseUrl we use no longer refers to the
session prefix which was configured by the livechat previously, but
simply refers to the origin of the page where the code is hosted, making
it a no-op.
These factors mean that the code removed by this commit is now
completely useless, which is why this commit removes it.
closesodoo/odoo#136672
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
This PR makes several actions available for the embed livechat
such as:
- calls
- message edition
- message reactions
- link previews
task-3523930
closesodoo/odoo#136618
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Before this commit there were two regexes for matching http(s) URLs,
being the only difference between them the presence of a capturing group
for the protocol/scheme. The need for a nearly duplicated version of the
same regex was its use in `_onPaste` as delimiter for String.split(), in
which capturing groups are returned in the resulting array, and the
protocol/scheme was not desired.
This commmit removes the need for two different regexes to match http(s)
URLs, adapting `_onPaste`'s code to work with the presence of the
referred capturing group.
task-3520513
closesodoo/odoo#136497
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
pos*: point_of_sale, pos_sale_product_configurator, pos_self_order
This commit removes the product info button and put a button on each
product card to open the product info popup.
The commit also adds a new field on the product template model to
track the availability of a product to the self ordering mode. This
field can be changed from the product form view or from the product
info popup directly in the POS. If the field is set to false,
the product will not be shown in the self ordering mode.
The commit also adds new filter and search fields on the product
list view in the backend.
closesodoo/odoo#136467
Task-id: 3515881
Signed-off-by: David Monnom (moda) <moda@odoo.com>
With this commit we added the ability to use the real height of the
element as the height of the placeholder when we move an item when use
the DnD like jQuery NestedSortable did.
task-3439226
Part-of: odoo/odoo#136375
Like the jQuery NestedSortable, we implement the function `isAllowed`.
When you use the NestedSortable hooks, you can now specify a custom
function to verify if a drop location is allowed. By default, this
function is always true
task-3439226
Part-of: odoo/odoo#136375
Add a maxLevels param like the jQuery.nestedSortable has. The goal of
this param is to set the maximum depth of nested items the list can
accept. If set to '0' the levels are unlimited, it's the default value.
task-3439226
Part-of: odoo/odoo#136375
Update the description of the Brazilian localization to reflect the
most recent changes that happened here. Also fix some wrong formatting
that made some parts render as quoted text.
closesodoo/odoo#135959
Signed-off-by: Josse Colpaert <jco@odoo.com>
Co-authored-by: Rubi Navarro (ren) <ren@odoo.com>
This implements common Brazilian document types and adds a
government-assigned Series field used to identify each journal.
Sequence names in the same journal must have their own, independent
numbering. Because of this _get_last_sequence_domain() was extended.
A non-stored related l10n_br_invoice_serial field was added to
account.move to allow a user in the Bookkeeper access
group (group_account_user) without access to journals to see the
number.
task-3507518
Part-of: odoo/odoo#135959
For BR the same document type can be used for credit notes, debit
notes and regular invoices. There was no way to indicate that in the
internal_type field of the document type, so we wanted to add it in
the main module for simplicity.
Part-of: odoo/odoo#135959
Before this commit, in the form view of todo the title was light grey and there
was a small flicker when hovering the title.
In this commit, the color of the title is changed to dark grey and flicker is
eliminated.
Task-347920
closesodoo/odoo#135247
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Problem
---------
In master, XML attributes have been modifed from attrs={'invisible':...}
to invisible=. During the conversion, the condition where not properly
cleaned up.
Objective
---------
Clean up the XML attributes.
Solution
---------
Reduce conditions by removing unecessary elements:
- `fiscal_country_codes` always returns at least an empty string.
- All country codes are in capital letters, no need to `lower` them.
task-3493124
closesodoo/odoo#134329
Related: odoo/enterprise#46920
Signed-off-by: Josse Colpaert <jco@odoo.com>
When enable, this new feature adds the possibility to set a PDF header, footer and some product
documents to the quotation report.
These PDF can contains forms that'll then be filled using Odoo database.
This replace the previous sale quotation builder feature.
task-3249142
closesodoo/odoo#133773
Related: odoo/upgrade#5168
Related: odoo/documentation#5863
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Co-authored-by: Victor Feyens <vfe@odoo.com>
Co-authored-by: Morgane Demesmaeker <edm@odoo.com>
The value provided by the sale quotation builder feature is small due to many problems, and the
technical debt behind is high. For instance:
- The feature is nice but hidden: not visible on quotation, the most visible part is the button
"Design Template" on the quotation template (if you did activate the feature), it requires to have
eCommerce installed...
- The feature relies on fields that are shared with eCommerce which leads to unwanted behavior:
e.g. updating the bottom of the product page in eCommerce will impact quotation html description on
the portal
- The feature works as template but it is unclear for users: updating the HTML description on a
specific quotation will only impact that quotation. Updating the HTML page of a quotation only
update this quotation
- The feature is technically complex
As we want to keep most of the value of the feature but reduce its complexity, we remove the
quotation builder feature that'll get replace with the PDF quote builder feature.
task-3249142
Part-of: odoo/odoo#133773
Co-authored-by: Victor Feyens <vfe@odoo.com>
Co-authored-by: Morgane Demesmaeker <edm@odoo.com>
*: board, website
This commit simplifies the UX of the 'Custom Group by' menu. Before this
commit, many clicks were needed to apply another filter, from an accordion
menu.
Now, a select element is used instead, allowing a better user experience, by
enabling such group by directly, when an option is selected.
Some tests have been adapted to the new selectors and behaviors, and the
applyGroup and toggleAddCustomGroup has been removed, since groups are applied
when selected, and the value can be modified directly with selectGroup.
task-3458519
closesodoo/odoo#132006
Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
PURPOSE
Slightly modify various apps to improve the user experience. Changes include
notably labels and views fine tuning, roundings, and small css fixes.
SPECIFICATIONS
- Remove the decorator from the event list view as it's a bit confusing
- Ensure mailing KPIs are now shown with 2 decimal places
- Re-order the mailing stat buttons
- Improve the background / font colors of the cover block
- Improve the labels of:
- Title and confirm button of the /button and /link modals
- Confirm button when archiving a record
Task-3204554
closesodoo/odoo#128108
Related: odoo/enterprise#43937
Signed-off-by: Warnon Aurélien (awa) <awa@odoo.com>
users who create products from the website are intended to make it visible immediately for customers
task-3234684
closesodoo/odoo#117884
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Currently, in the survey for single/multiple choice questions, the layout is
not consistent. For example, if there are four choices available, the
layout is 3-1 (3 small options in the first row, 1 full-width option in the last
row). Apart from that, if the string for options is long, the radio/check
box comes at the bottom right corner, which should always be at the
top right corner.
This commit does the following improvements:
1/ Improve the choices layout to make it beautiful. now there will be only one
answer per row similar to the 'One Page Per Question' layout.
2/ The radio / check-box icon will be displayed in the top right corner
regardless of the length of the option strings.
3/ If there is one or more image(s) in the answers then we will follow 2x2
layout instead of one row per answer.
TaskID-2712296
closesodoo/odoo#99229
Signed-off-by: Florian Charlier (flch) <flch@odoo.com>
Before this commit, when we set the activity type to 'todo' in our project, the
default action was set to 'none.' This configuration made the 'todo' category
type less intuitive and less useful.
In this commit, we have improved the default behavior. Now, when you select the
'todo' category type, it will automatically have the 'reminder' action assigned
by default. This change enhances user experience and ensures that 'todo' items
have a meaningful default action.
task-3500700
closesodoo/odoo#135767
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
When the user tries to find the 'qty_available' of a product but gives
a string value instead of a float value in domain then the user will face error.
Steps to produce:
- Install `stocks`.
- Create a record rule for model `product.template`. In the domain of record
rule keep [('qty_available', '<', '10')] as a domain,
you can give any integral value in the domain but that value should be
enterred as strings (with quotes).
- Inventory > Products > Products
Error: `TypeError: '<' not supported between instances of 'str' and 'float' `
After applying our commit, if the domain is Invalid then the user will face
`UserError`. There is a function named `_search_product_quantity` which
initially checks if the domain is valid or not :
https://github.com/odoo/odoo/blob/5f1ad0c1e4c1e8ed41337ccd4c12e70c9c760c85/addons/stock/models/product.py#L342-L350
It will filter out all the invalid domain and clear search methods.
So now whenever `_search_qty_available` is called first the validity of domain
and operands of the expression will be checked.
sentry-4399815131
closesodoo/odoo#137367
X-original-commit: 92c232cca15517bd9a33a5100e7cdc42c3c25397
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
The text should be update, since we do not review applications anymore.
Also, currently if a user types a random text in the settings' search bar,
Peppol setting appears. Peppol settings should be enclosed in `block` tags as all other settings.
task-3525510
closesodoo/odoo#137355
X-original-commit: 156b0c94c2c9cf26b1168864c723e2ad2d720311
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Signed-off-by: Aliya Tastemirova (alta) <alta@odoo.com>
The `partner_gid` key isn't part of the response of the Autocomplete API
of Clearbit anymore, so we can't rely on its presence to know if the
suggestion comes from Clearbit or not.
Ticket #3321391closesodoo/odoo#137354
X-original-commit: 63b8aa6b69d917c5c1cc83e11c530cd2fd665f25
Signed-off-by: Francois Georis (fge) <fge@odoo.com>
Signed-off-by: Louis Baudoux (lba) <lba@odoo.com>
We made it depend on the partner country, but it is better to
identify it through the tax being used. E.g. it is only the
exportation of goods that is needed to change the regimen
and not the services.
We also needed to change the test, because we used E2 with
a Belgian partner.
opw-3514270
closesodoo/odoo#137184
X-original-commit: 14d5be171e238d7aa12f513659929b5b940eea78
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Josse Colpaert <jco@odoo.com>
We use the casilla 10 and 11 of the modelo 303 to identify intra-community
instead.
This way, the tax defines the regime that should be used.
opw-3514270
X-original-commit: eb287e911afc652c122b44c39af4b6d6b11bf618
Part-of: odoo/odoo#137184
This commit brings a simple improvement.
There is no need to reposition an element while
you are scrolling inside of it.
closesodoo/odoo#137139
Signed-off-by: Michaël Mattiello (mcm) <mcm@odoo.com>
**Before this commit**
The tour_service make use of a custom
main component TourPointerContainer.
But there is really no good reason it does.
**After this commit**
The tour_service now make use of the overlay service.
Advangates:
- same place in DOM for all piece of UI that overlays
the other elements.
- should avoid potential stacking context issues
- removal of a useless component, less code to maintain
Part-of: odoo/odoo#137139
Previously, attributes had to be selected one by one on different pages.
For each choice, you had to click on the next button.
Now, all product attributes are on the same page, simplifying selection.
closesodoo/odoo#137107
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
This commit adapts the hover style of the editable fields elements to
match the new overlay style.
task-3368793
closesodoo/odoo#132653
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Prior to this commit, the first drop zone at the top and the last one at
the bottom were half hidden.
This commit adapts their position in order to be fully visible.
task-3368793
Part-of: odoo/odoo#132653
Prior to this commit, the area of top and bottom handles overlapped the
content according to the size of the overlay border.
This commit changes the way height is calculated to remove this overlap.
task-3368793
Part-of: odoo/odoo#132653
This commit adapts the draggable icon in the overlay button to improve
the readability.
This commit also adapts the "danger" background color of
`oe_snippet_remove` button to maintain consistency with the web editor.
task-3368793
Part-of: odoo/odoo#132653
Eteil Djoumatchoua(etdj)