Before this PR, a websocket would wait for the server to close
it with a `SessionExpired` close code to be refreshed after the user
logged in/out. Indeed, the server is responsible to check for outdated
sessions on incoming/outgoing messages.
This is problematic: a user logging in with more than one tab opened,
would have to wait to receive its messages. This PR solves this issue
by refreshing the connection immediately in this scenario.
closesodoo/odoo#102420
X-original-commit: 225f80882a130ae63af193adef412e6b993f2c11
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Stockbauer Matthieu (tsm) <tsm@odoo.com>
When 2e8647bf16 converted the browser
runner to a more reactive / evented system, one bit was missed in
"wait_code_ok": concurrent.futures.Future raises exceptions on various
events, such as tour timeouts. Because those exceptions were not
caught (or just ignored) the code which takes screenshots was
bypassed, leading to a lack of screenshots on tour timeouts (and a few
other rarer errors), making debugging more complicated.
The error reporting was also not ideal as `wait_code_ok` would raise
an unexpected (by its caller) `TimeoutError` rather than
`ChromeBrowserException`.
Fix those two issues, should hopefully makes these occurrences clearer
and easier to diagnose.
closesodoo/odoo#102403
X-original-commit: 974217968ea970330946c5184bd3b3550ec3cde3
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
A value was set as 0 instead of false, causing a traceback.
closesodoo/odoo#102402
X-original-commit: d5a684fb562011875ec472c0263c2022de1656d5
Signed-off-by: Kevin Baptiste <kba@odoo.com>
The status badge on workorder kanban card was hidden behind a dropdown
widget because of a wrongly used class.
X-original-commit: 491546a5c3ce6203763a7d829b44107e66ff3f42
Part-of: odoo/odoo#102398
When validating a batch containing both fully done pickings and
partially done pickings, if we select "No backorder" it will remove the
partially done pickings from the batch.
This is because only the partially done pickings will be considered as
"pickings not to backorder", while the fully done will be considered as
"pickings to backorder".
Then validation is splitted between the two groups of pickings, and
since by the end of the first validation, the batch is not fully done
(since the other group will be validated afterwards), those pickings are
removed from the batch.
This fix aim to consider all pickings that are fully/partially done as
"not to backorder" if this option is selected.
opw-2971574
closesodoo/odoo#102382
X-original-commit: a98b3ff73d1c3d5fda7da3433caf83d58acc2f3c
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
When checking if the picking is auto-batchable, calling
`_is_auto_batchable()` with `picking` having it's default value `None`,
it would raise an error as it would try to access the `weight` property
from a NoneType.
Part of task-2985735
X-original-commit: 574ff569e5b9a043d29b7113f8bfe3a549a74d72
Part-of: odoo/odoo#102382
When creating a Purchase Order with multi-step reception, the pickings
created by the push rules won't get confirmed as they should be (like in
the sales multi-step flow).
This creates issues further down with auto-batch as created pickings
don't get auto-batched even if the picking type is set to do it.
Task-2971346
X-original-commit: dc517bbe7ffbae8a8774f705c9431dce45c461ba
Part-of: odoo/odoo#102382
When a backorder was created and the auto_batch was activated for this
picking_type, no batch was assigned to the created backorder, even if it
matched the auto-batch criterias.
Now when a picking is done, we check if backorders were created. If they
are eligible for auto-batchs (given their picking_type, etc.), they also
get the auto_batch done for them.
We can't simply use the previous picking's batch, because if this batch
is now done, then introducing a non-done picking into the batch would
raise an inconsistency between the pickings' states and raise an error.
Removes the old override of backorder confirmation as now batch
dissociation is done in the picking's 'action_done()' override.
Allows the validation of a batch that has pickings 'waiting for another
operation', as they now will get removed from the batch in the process,
no longer blocking the batch's validation.
Finally, makes that pickings that had no quantities done when validating
a batch aren't cancelled when selecting 'No backorder' in the
confirmation wizard, but are instead removed from the batch.
Task-2971346
X-original-commit: 1720840b7bd9b3e3e90f7cf860f60f1d0746ce63
Part-of: odoo/odoo#102382
Move the sanity check from the `button_validate()` outside so it can be
run premptively in a different context.
Basically it allows batches to run the santiy_check as a whole. This
means that when the function checks if there is at least one quantity
done to check only those move_lines for the lot/serial numbers, it is
now able to check the pickings independantly from each others like
before, but also as if they were a single entity.
This can avoid this weird behavior in the following batch :
Picking | product_name | qty | done_qty
--------|----------------|-----|---------
Pick_1 | product_1 | 2 | 0
Pick_1 | product_serial | 1 | 0
Pick_2 | product_2 | 2 | 0
Setting a done_qty on product_1 would be fine to validate the batch,
since at least one done_qty would be found within Pick_1. But setting a
done_qty on product_2 would raise an error for missing serial numbers
since then no done_qty would be found within Pick_1.
This commit evens the behavior of the sanitizer in this case. While
keeping the way it works outside of a batch validation.
Task-2971346
X-original-commit: 3a3b5d90d58339f65b1db0b52a2c81e02b5a3f17
Part-of: odoo/odoo#102382
**Current behavior before PR:**
When changing the focus with keyboard (keyboard navigation),
the background of the active row is grey, we don't like grey.
**Desired behavior after PR is merged:**
We want the plain old white background.
X-original-commit: bb70c3c289a3b6222bd991f0426c4e5e63359872
Part-of: odoo/odoo#102381
Both implementations of `set_cookie` in `http.py` and the one of
`setCookie` in `cookie_utils.js` are slightly different.
This commit unifies both Python implementations and replicates the same
behavior in JS:
- default the cookie type to "required"
- if setting that type is not allowed, delete that cookie if it was
previously set
task-2800976
closesodoo/odoo#102380
X-original-commit: fa8fdab2894607f1f89cdd195f62ec37af7b0342
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
In [1] the padding of the discrete cookies bar template was moved from
the column to the row.
This prevents editing the padding per column using the website editor.
This commit moves this padding back onto the columns and wraps the text
inside a paragraph so that it does not get closer to the bottom border
of the screen.
[1]: https://github.com/odoo/odoo/commit/2ca91a90d0aa61405547349d5cd366179bc3f419
task-2800976
X-original-commit: c50e2adf592a336d1f991e9a461eeeb21a2a64f0
Part-of: odoo/odoo#102380
When computing the edi_formats on a journal, keep the ones
that are already checked (if they are compatible with this journal).
The bug occurs when migrating a DB: if a new edi_format is created,
the `create` will call the `_compute_edi_format_ids` on all journals.
Thus, all edi_formats will be reset since nothing keeps track of the
already checked edi_formats. This PR fixes this.
closesodoo/odoo#102368
X-original-commit: 166aaeef1ca69399581714b61ea77db7c3e04f31
Signed-off-by: Laurent Smet <las@odoo.com>
Signed-off-by: Julien Van Roy <juvr@odoo.com>
Previously, in form views without a sheet (eg in wizards), there would
be a scrollbar on the content. This is caused by the fact that
outer groups have gutters of size 5 in desktop which creates negative
margins on the row of 1.5rem which is 18px with the default size, but
the nosheet form view only has 16px of padding on the sides, causing the
groups to be 4 pixels too wide.
This commit fixes this by adding the correct padding classes on the
form view when it doesn't have a sheet.
closesodoo/odoo#102357
X-original-commit: 8d7bcc8eee7a333e8e463469177a1a86f9928254
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Signed-off-by: Samuel Degueldre <sad@odoo.com>
The column `location_dest_id` ends up squished to almost nothing and
need to be dragged open to be able to read what's in it.
This sets the width of this column back to its default size.
Part of task-2985735
closesodoo/odoo#102356
X-original-commit: bbcb3744386c1e01cb1bd57c0e2aa3f02e2c47a0
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Signed-off-by: Quentin Wolfs (quwo) <quwo@odoo.com>
The "Reporting" title was not properly displayed (stuck to the left of
the dropdown) and the Timesheets entry was not displayed as a proper
dropdown item.
task-3001445
closesodoo/odoo#102351
X-original-commit: 250809a201386cfb1d2ba52d3911bd765a2c910a
Signed-off-by: Kevin Baptiste <kba@odoo.com>
The following PR - odoo/odoo#98914 introduced changes in
accounting analytic.
The changes were applied to 'hr.expense' but they were not applied to 'hr.expense.split'.
Which lead to traceback.
task - 2997510
closesodoo/odoo#101997
X-original-commit: 4f5c531b854271284238b5a13f95d66eb2e12f93
Signed-off-by: Kevin Baptiste <kba@odoo.com>
Steps:
- New invoice
- Select a partner that has no invoices yet
- Create a new line
- The default account is quite random
Fix:
Only use the most frequent account for the set partner if there are existing invoices for that partner.
Otherwise we fallback on the default account of the invoice's journal (instead of the suspense account).
closesodoo/odoo#102350
Task-id: 2972993
X-original-commit: 471924c0d0e2647a25aa38507224f8321b598211
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Signed-off-by: Ricardo Gomes Rodrigues (rigr) <rigr@odoo.com>
When loading a registry from route with auth="none" and where module
'website' is set as 'to install', request.env will be None and install
will crash as follows:
```
Traceback (most recent call last):
...
File "/home/odoo/src/odoo/saas-15.3/odoo/modules/registry.py", line 88, in new
odoo.modules.load_modules(registry, force_demo, status, update_module)
File "/home/odoo/src/odoo/saas-15.3/odoo/modules/loading.py", line 482, in load_modules
processed_modules += load_marked_modules(cr, graph,
File "/home/odoo/src/odoo/saas-15.3/odoo/modules/loading.py", line 371, in load_marked_modules
loaded, processed = load_module_graph(
File "/home/odoo/src/odoo/saas-15.3/odoo/modules/loading.py", line 303, in load_module_graph
module.write({'state': 'installed', 'latest_version': ver})
File "/home/odoo/src/odoo/saas-15.3/addons/website/models/ir_module_module.py", line 78, in write
if request and request.context.get('apply_new_theme'):
File "/usr/lib/python3/dist-packages/werkzeug/local.py", line 348, in __getattr__
return getattr(self._get_current_object(), name)
File "/home/odoo/src/odoo/saas-15.3/odoo/http.py", line 1029, in context
return self.env.context
AttributeError: 'NoneType' object has no attribute 'context'
```
closesodoo/odoo#102343
X-original-commit: fcf6e462e116d13533014e31d4191763354811cf
Signed-off-by: Xavier Alt (xal) <xal@odoo.com>
Purpose: restore edit access to body when creating a new template.
Likely introduced by 2bb148f9.
Task-3002242
closesodoo/odoo#102326
X-original-commit: 506e6cc8383236432947045afdcea7bc3555bc16
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Before this commit, on project sharing chatter attachment delete
icon is displayed on the middle of attachment thumbnail instead it
should be displayed on right top corner of thumbnail when we hover
on attachment.
So in this commit, added a class for project sharing view so delete
icon should be displayed properly
task-2904015
closesodoo/odoo#102298
X-original-commit: c9609c62efe163901f8c2b1a30355b60dd34ad51
Signed-off-by: Xavier <xbo@odoo.com>
Currently, when using the quick invoice encoding feature, we do not create the invoice line if no partner is set.
This commit fixes by falling back on the default values of the account and the tax.
closesodoo/odoo#102297
X-original-commit: a387b3b07b806eb82f359767e01be8555c79ee9f
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Signed-off-by: Ricardo Gomes Rodrigues (rigr) <rigr@odoo.com>
keep the +/- before the price, to correctly highlight the fact that it's
an additional price.
closesodoo/odoo#102245
X-original-commit: 32a2379b34b8646b681d3e42412bbc1ce2a045f1
Related: odoo/enterprise#32319
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
t-esc directive has been deprecated.
This commit replaces remaining occurrences in the modules under our
responsiblity.
Was only noticed recently during runs in dev mode because the
deprecation warnings are only posted when odoo is launched in dev mode.
"Found deprecated directive @t-esc=%r in template %r. Replace by @t-out"
in base/models/ir_qweb.py
X-original-commit: 7083b65e31626acc826c47d1d450f12b7d1c2d4a
Part-of: odoo/odoo#102245
class o_edit_product_configuration was removed during owl conversion and
its css logic is not needed anymore.
X-original-commit: 9b40bb011ae5430b8a082bc6ddd24ca9ec8fdcf1
Part-of: odoo/odoo#102245
Currently when creating a composer in mass mode
the composer always shows the 'mass mailing name' option
even when a mailing cannot be created.
This silently creates a regular mass mail.
This hides that option when selecting records of models
that do not inherit from thread. So that users do not falsly
believe a mailing will be created.
task #2990447closesodoo/odoo#102105
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
+ Turn props on component into fields on PersonImStatusIconView model
+ Move handler from component methods to model record methods
Task-3004188.
closesodoo/odoo#101943
Signed-off-by: Louis Wicket (wil) <wil@odoo.com>
Recently, the chatter was migrated to owl. When doing this, it lost its
flex-grow property, whereas the attachment preview has kept it, which
causes layout shift when moving from a record without an attachment
preview to another with one and vice versa. This commit fixes that.
closesodoo/odoo#102323
X-original-commit: 6228500a3f3cdb17286d50f2662f3e7b0226f667
Signed-off-by: Géry Debongnie <ged@odoo.com>
It was missing the bootstrap form-check class
closesodoo/odoo#102321
X-original-commit: 4218a3ed6022032577c2764deefa7923db32cf89
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Since the usage of the `CSS Grid` some view are broken.
The new form view system is less tolerant to missing colspan.
This commit, change the colspan when needed (e.g. no label) and in some
case extract the label outside the `DIV` to use `GRID` layout.
Steps to reproduce:
* Go to survey
* Select a survey
* Select the Option notebook, fields are not aligned => BUG
* OR
* Click on Add a question
* list view in Answers notebook are not aligned => BUG
closesodoo/odoo#102319
X-original-commit: 51c1f6ed300e3dd185c45e14dff1ee9250f6e562
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
Signed-off-by: Romeo Fragomeli (rfr) <rfr@odoo.com>
When [1] introduced the website edition using an iframe, it did not
correctly adapt url attachments redirections.
Following this flow, in the Website Builder:
- From the Media Dialog, click on the "add document" top right button,
- Paste a google doc url and save,
- Click on the inserted document icon,
=> The google doc is opened inside the iframe (it leads to tracebacks).
This commit fixes the way these documents are opened from the
Website Preview iframe: '/web/content/...' links are always opened in
the top window, as they can be external redirections.
[1]: https://github.com/odoo/odoo/commit/31cc10b91dc7762e23b4bde9b945be0c4ce3fe3b
task-2172311
closesodoo/odoo#102318
X-original-commit: c05f7de22600b5719117a188ab105e4140b6a3de
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Signed-off-by: Younn Olivier (yol) <yol@odoo.com>
The accounts setting allows to have default taxes on accounts, but
they are not used when changing the account on an account_move_line.
closesodoo/odoo#102313
X-original-commit: ed40e71aa879b9f42e7acbe35647a88388afc107
Signed-off-by: William André (wan) <wan@odoo.com>
tsm-odoo