Commit Graph
112576 Commits
Author SHA1 Message Date
Raphael Collet 69161ed69c [FIX] mail: performance, replace filter() by condition in domain 2017-09-20 13:30:56 +02:00
Raphael Collet 8ffe241bee [FIX] *: incorrect many2many commands
Those cases worked by chance until the former commit.
2017-09-20 13:30:56 +02:00
Raphael Collet 49f6a1b544 [FIX] fields: improve performance of many2many fields
An update by a list of commands is now guaranteed to have at most three SQL
queries to update the relation, whatever the number of commands and records.
2017-09-20 13:30:56 +02:00
Raphael Collet 87970ea344 [FIX] mail: add cached method to retrieve message subtypes
This saves queries to retrieve message subtypes for a given model.
2017-09-20 13:30:56 +02:00
Raphael Collet 38193456d4 [FIX] test_performance: log when number of queries is less than expected 2017-09-20 13:30:56 +02:00
qsm-odoo 09c35696a3 [FIX] *: dashboards automatic colors
* account, hr, hr_recruitment, maintenance, mrp, sales_team, stock

Adaptation of https://github.com/odoo/odoo/commit/a79d83e436e5e965d59663d4a06a0f8a62d8f694 for saas-18 new colors.

Also change back all color defaults to 0 instead of 1 (see
mentioned commit: they were changed from 0 to 1 as in saas-16
the color was applied to kanban headers which had to be gray
(the old color 1) by default).

Also add default violet color for 'Customer Invoices' and 'Vendor Bills'
dashboards.
2017-09-20 12:32:48 +02:00
qsm-odoo d7bc8877bd [FIX] account: allow to click on dashboard header's "done" buttons
A design commit thought that "done" buttons should not be able to be
clicked anymore and forced this with LESS code.
(see https://github.com/odoo/odoo/commit/38a1a452cfd59ad8e7f7359f43ee779e8a3f8329)
2017-09-20 12:32:48 +02:00
qsm-odoo c798f0f744 [FIX] web: style only one kanban hovered link at a time
Hovering a link in a kanban record was adding an hover effect on all the
links which were in the same <div/> parent.
2017-09-20 12:32:48 +02:00
Martin Trigaux 27ca297e64 [FIX] tools: python3 compatibility for export terms
Avoid error in babel getting the wrong source file
TypeError: startswith first arg must be str or a tuple of str, not bytes
2017-09-20 11:15:20 +02:00
Martin Trigaux 3dad91aa19 [FIX] pad: avoid changing dictionnary size during iteration
In python3, items() and keys() returns iterators.
Modifying a dictionnary while iterating on it may trigger an error:
    dictionary changed size during iteration
2017-09-20 11:15:20 +02:00
Deep Patel 9b9fcfe628 [FIX] web,base: document template widget in settings
Go to General Settings, click on 'Change Document Template', and
in the opened dialog, click on a template.

Before this rev., it automatically closed the dialog, which was
not really convenient.

This rev. introduces a new field widget (image_selection) for
this use case, and ensures that the dialog doesn't close when
a template is selected.

Test written by @mba-odoo
2017-09-20 10:56:57 +02:00
Géry Debongnie 48b8be29fa [FIX] web: update x2manys when onchange add new line
In this commit, we make sure that if an onchange in a x2many modifies
another line, then the new data is properly shown.  This is quite
tricky, because the field x2many ignores the full extent of the changes.
Also, we obviously want to preserve the editing state (focused field,
...)

So, what we actually do is to rerender the full x2many (minus the new
line) to make sure that we preserve the correct row order.

Note: thanks to MGE for the test and some preliminary work.
2017-09-20 10:05:13 +02:00
Martin Geubelle 3136fc1643 [FIX] web: reuse datapoint with onchange one one2many
Since the rev. https://github.com/odoo/odoo/commit/2728fe1ec1ac7e99819d0f30f29a1814b00c82a4 the onchange create
command (0) send the virtual id as second argument. This argument is sent
back from the server and can then be used by the client.

As the client knows the virtual id, it can easily reuse the datapoint created
for this record and thus avoid creating a new one.

Creating a new datapoint can potentially lead to problems if the record has
for example specialData, that won't be kept.
2017-09-20 10:05:13 +02:00
Raphael Collet 3069734d4f [FIX] models: in method onchange, filter out pseudo-fields 2017-09-19 17:06:04 +02:00
amoyaux d547f63cb7 [REF] stock: merge quants
In a situation where one transaction is updating a quant via
`_update_available_quantity`and another concurrent one calls
this function with the same argument, we’ll create a new quant
in order for these transactions to not rollback.

This commit adds a method to deduplicate these quants.
2017-09-19 15:55:53 +02:00
Yannick Tivisse 8514df36e9 [IMP] sale_timesheet: Remove commented pdb 2017-09-19 15:48:20 +02:00
Yannick Tivisse a99a0c827a [FIX] sale: Compute correctly is a quote is expired in portal
Purpose
=======

We shouldn't compare the validity date with the begin date of the pager to determine whether a quoation is expired or not
Furthermore we shouldn't let the template compute these kind of things.

Specification
=============

Add a computed field is_expired. Use it in the template.
2017-09-19 15:46:06 +02:00
Christophe Simonis d15a31ae6d [MERGE] forward port branch saas-17 up to 2a343d7c9c 2017-09-19 11:58:01 +02:00
Kirti Choudhary 63ebdd0869 [FIX] web: Display 'Favorites' filters list with a scrollbar when too long 2017-09-19 11:37:01 +02:00
Christophe Simonis 2a343d7c9c [MERGE] forward port branch saas-16 up to c3a48da767 2017-09-19 11:06:46 +02:00
Yannick Tivisse 70ea155a96 [FIX] stock: Define correctly the filter 2017-09-19 11:04:57 +02:00
Prakash Prajapati 4afdc57c88 [FIX] mail: Open simple partner form when email is requested on actions
Purpose
=======

When you want to send an email to a contact without an email address set, you get a wizard to enter the contact email.

In master, you get the full contact form

You should get the simplified form view (like in 10.0)
2017-09-19 10:50:51 +02:00
Hardik Patel c3a48da767 [FIX] web: FormView button box: position of More dropdown
Before this rev., the dropdown was positioned in the bottom left
corner of the form view.
2017-09-19 10:14:24 +02:00
Pratima Gupta de48daf53a [FIX] web: FieldDomain: don't open record from selection
The FieldDomain allows to open a list in a dialog to display the
records matching the current domain. In this dialog, clicking on
a record should do nothing (this was the behavior before the new
views).

Before this rev., it actually tried to open the record and it
produced a crash.
2017-09-19 10:14:24 +02:00
Hardik Patel 116aa22685 [FIX] web: reset offset to 0 when searching for records
Scenario: Go to any list or kanban view: go to next page and set a
filter that matches less that 'limit' record (e.g. less than 40),
but at least one. No record will be displayed, because the offset
is kept for the search_read.

This rev. ensures to reset the offset to 0 when a search is done
using the searchview.
2017-09-19 10:14:24 +02:00
Darshan Kalola 8ba10a3b9a [FIX] web: FormView: invisible='True' on x2many fields
Before this rev., it crashed if an x2many field had the
attr invisible set to 'True' in a form view.
2017-09-19 10:14:24 +02:00
fwi-odoo 43e412ccab [FIX] mail: fix due to the changes for the app switcher whitelist
The app switcher in the enterprise branch introduces a new way to whitelist the
element in the app switcher. This commit apply this mechanism to the mail windows.
2017-09-19 10:12:28 +02:00
Christophe Simonis a8d20e6804 [FIX] point_of_sale: correctly format date 2017-09-18 23:06:58 +02:00
Foram Katharotiya 2b3c8e6ca9 [IMP] l10n_in: GST introduced as new legal requirements.
aka 'Indian localization out of the box'.

Details:
     GST introduced, module refactored.
     Update GST chart of account, tags and SGST, CGST & IGST taxes.
     Replace vat label with GSTIN in reports & views.
     Added HSN Code field and display it on invoice form view & report.
     Added pin number field in res_country_state.
     Show the total amount in words based on Indian numbering system on form view of customer/supplier invoice/refund.
     Arrange address format of India country.
     l10n_in_schedule6: Introduce new GST taxes, chart of accounts & account tags.
     l10n_in_sale, l10n_in_purchase, l10n_in_stock: added modules to add hsn code and replace vat with gstin in sale, purchase & stock reports

Was task: 33241. Was PR #18952
2017-09-18 22:17:43 +02:00
qdp-odoo 194c38f09d [REF] account, sale: some minor refactoring
that would allow to easily overwrite the printed report name and invoice/sale reports
2017-09-18 22:00:37 +02:00
qdp-odoo ec96c0b3c2 [IMP] base: add vat_label on res.country
That allows to display the 'vat' field under the right label in reports.
2017-09-18 21:57:48 +02:00
Christophe Simonis b3d1a7f7cf [FIX] point_of_sale: format date correctly
Oversight of previous forward-port
2017-09-18 19:00:54 +02:00
Christophe Simonis 14145fe285 [MERGE] forward port branch saas-15 up to 50a440237a 2017-09-18 18:06:21 +02:00
Monish Soni 09e44c02f2 [FIX] mail: Fix typo in mail chatter 2017-09-18 17:57:07 +02:00
Christophe Simonis 50a440237a [MERGE] forward port branch saas-14 up to b407d84401 2017-09-18 17:39:16 +02:00
Hetashree Chauhan 860ed1c7f9 [IMP] rating: typo on stat button 2017-09-18 17:16:59 +02:00
Hardik Patel a8f1adc29a [FIX] rating: correctly encode base64 image
Fixed a typo from commit 3824b5dcc1
2017-09-18 16:51:18 +02:00
Christophe Simonis b407d84401 [MERGE] forward port branch 10.0 up to 58c5b1cfd8 2017-09-18 16:27:42 +02:00
Jaykishan Solanki ae2a64ab63 [FIX] hr_attendance: use getSession() to retrieve user_has_group property 2017-09-18 16:27:02 +02:00
qsm-odoo 97138a1eae [FIX] website_theme_install: fix several design issues
- Useless horizontal scrollbar
- Misalignments
- Broken mobile layout
2017-09-18 16:25:45 +02:00
Jérome Maes 245f259561 [FIX] hr_recruitement: avoid crash when no res_model_id is given 2017-09-18 16:25:15 +02:00
Stéphane Bidoul (ACSONE) 8bf06adc8d [FIX] namespace packages: move from pkg_resources-style to pkg_util
Deprecates the previous pkg_resources-style packages. Our use was
not entirely spec compliant, and it broke with setuptools 31.
More information in https://github.com/odoo/odoo/pull/15718

Instead, use the pkgutil-style namespace packages.
This is spec compliant as long as all other distributions providing
odoo.addons use PEP 420 namespace packages (i.e. no __init__.py).
So this mechanism fully works on Python 3 only, but does not break
anything on Python 2.

See also:
https://packaging.python.org/guides/packaging-namespace-packages/#pkgutil-style-namespace-packages

Closes #19517
Fixes #15718
2017-09-18 16:05:31 +02:00
Dhawal Limbuwala 596e88f05d [FIX] mail: restore background color of notes in chatter
It had been removed by the new design of v11, but it is necessary
to easily make the distinction between internal notes and messages.
2017-09-18 15:56:14 +02:00
Géry Debongnie cebbee8929 [FIX] mail: prevent pos tour from sometimes failing
Here is what could (sometimes) happen in community:
- the point of sale tour is started by the runbot
- it loads the '/web' url
- this instantiate the mail client action (init)
- the tour sees that the POS link is in the dom and clicks on it
- the action manager destroys the discuss client action (before its
  start method is called)
- the destroy method from the client action is called, this.$buttons
  is not set, the destroy method causes a traceback
2017-09-18 15:39:06 +02:00
amoyaux 57c4dd8b62 [FIX] stock: priority on new move compare bool and str
Since python3 compare boolean and string is not
possible anymore. Priority field on stock move line is
not required and thus it happens that we compare a set
priority with an unset one.

In order to correct it this commit only compares move line
that have priority and if tey are not use the default priority
1.
2017-09-18 15:04:14 +02:00
amoyaux 48671620b7 [FIX] stock: orderpoint should not have been remove on product
Orderpoint has been removed by this commit 0e4f3bb959
However it was still used in the overide of product write in
order to avoid archive a product that still have active orderpoint.

This commit readd the field orderpoint_ids
2017-09-18 15:04:14 +02:00
amoyaux 5d7e6dfad5 [IMP] stock: merge moves
The rationale for the need of a merge move mechanism is that, with the new default view,
having multiple stock move for the same products is confusing. The idea is that if a move
is confirmed in a picking already having a move with the same characteristics, we update
the existing move and unlink the new one. That’s why it’s done at the end of `_action_confirm`.

In some cases, merging moves is unwanted (backordered moves for examples). Therefore, we chose
to add a kwarg to `_action_confirm` in order do control the mechanism.
2017-09-18 15:04:14 +02:00
amoyaux ccea0b788d [REF] stock: move compute_state logic to stock move file
Before when comuting state picking there was a computation
among all moves in order to guess the picking state.

However this code could be reuse in other scenario for
example in merge moves.

In order to avoid code duplication this commit move the
part responsible for the state computation among moves
in a specific method inside stock move file.
2017-09-18 15:04:14 +02:00
Géry Debongnie 8f02b16c27 [FIX] web: tests: mockserver should crash instead of log
When the mockserver handles an unimplemented route, it just log an
error.  This is annoying because it does not break the QUnit suite, so
if the developer does not look at the console, it will look like the
test suite pass.  However, the runbot will see that as an error.

With this commit, we throw an error to force the test suite to fail in
that case.
2017-09-18 13:48:51 +02:00
Géry Debongnie b3aa323919 [FIX] web: prevent crash sometimes when sorting one2many
Before this commit, there was a crash when sorting a one2many in a form view.
This is due to the fact that the event from the one2many bubbled up to
the main form view, which basically assumed that it was supposed to sort
some sub one2many.

It could be seen for example when editing a 'attribute' in a product
form view (need to activate variants), then sorting the 'attribute
values' sub one2many.

With this commit, we simply stop the event propagation at the correct
level.
2017-09-18 13:48:50 +02:00