With only the module appointment installed, go to Calendar App,
Online Appointments and click on "Create". In the form view displayed a
stat button "Customer Preview" is visible but is badly styled. This is
due to the fact that "Customer Preview" is no longer wrap by a span since
the rewriting of the form view (see odoo/odoo@48ef812a63).
We fix the problem by making the default slot content of ViewButton be a
span wrapping the prop string (if any).
Part-of: odoo/odoo#98072
By adding features to the web editor for the product page we only
increased the amount of possible categories we might have for our page.
This commit unifies all of those categories into a single one that is
enabled for the editor on the whole page.
TaskId-2925690
closesodoo/odoo#97917
Signed-off-by: William Braeckman (wbr) <wbr@odoo.com>
To reproduce
============
Enable "Qr Codes" under Accounting Settinsgs > Create Invoice > set "Payment QR-code" method (tab "More Info")
> issue Credit Note > try to "Send and Print" credit note > Error:
` The chosen QR-code type is not eligible for this invoice. `
Specification
=============
Generating QR code on Credit Note doesn't make sense, so the field `qr_code_method` is set to `False`
when creating a Credit Note.
opw-2900112
closesodoo/odoo#97889
X-original-commit: cdc564d8b31d7691bb1a6faaef940bc5fd3eb8f0
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: abla001 <abla@odoo.com>
There were 2 problems before this commit:
1. When switching view and coming back from the breadcrumbs: the
previous view props (such as the pager props) were lost;
2. When paging to the next record, switching view and coming back from
the breadcrumb, the view was reverted to the first selected record,
effectively ignoring the paging step.
This commit fixes both of these issues by keeping the controller's
props during a "restore" action, and by also updating the current
controller's props when using the pager.
closesodoo/odoo#97395
Signed-off-by: Samuel Degueldre <sad@odoo.com>
This commit fixes the style of the field broken
since the introduction of the "display: contents"
rule in css.
closesodoo/odoo#97906
Related: odoo/enterprise#30073
Signed-off-by: Samuel Degueldre <sad@odoo.com>
Before Commit :
- Sometimes user breaks their Mail/SMS templates and have no way to go back to the
original one easily. They don't have any option to reset the template.
After Commit :
- Added new "Reset Template" button
- now user can reset the Mail/SMS template to its first version.
- also it will update the translation of the template
- added New "Reset Mail Templates/Reset SMS Templates" action to edit multiple templates
task- 2231977
closesodoo/odoo#83759
Related: odoo/upgrade#3674
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
This function was used to check the presence of the new module
`account_edi_ubl_cii`. The purpose was to use this module to render the xmls
for the existing modules: l10n_be_edi, l10n_no_edi, l10n_nl_edi... which used
outdated qweb templates (see https://github.com/odoo/odoo/commit/72c4972efd3f31bd86d100f160a530cc70400617).
After version saas-15.4, these old modules were removed and `account_edi_ubl_cii`
is used instead. Thus, `_is_account_edi_ubl_cii_available` is no longer used.
closesodoo/odoo#98208
Signed-off-by: Laurent Smet <las@odoo.com>
The field style was broken in form views since it
uses the display: contents rule. This commit
fixes the style of the field as it is now correctly
displayed inline.
It also changes the css selector to set the
style appropriately inside product views.
closesodoo/odoo#98185
Signed-off-by: Samuel Degueldre <sad@odoo.com>
Steps:
- Go to Employees/Reporting/skills
The first group has a Level Progress of `0.84444` which is not a valid
percentage, it should be `84.44%`
This fix calls the correct format function to display correctly the
aggregate values depending on their widget or type instead of just
displaying the raw aggregate value.
(https://pad.odoo.com/p/wowl_views:
[GMF] Employee : Skills report, group sum should be % https://tinyurl.com/262ec37z)
closesodoo/odoo#98207
Signed-off-by: FrancoisGe <fge@odoo.com>
This adds commands to convert the current text into 2, 3 or 4 columns,
and to remove said columns.
task-2901585
closesodoo/odoo#95359
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Allow the user to select multiple languages in the website creation modal.
task-2745347
closesodoo/odoo#86541
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
With the new kanban view, we have altered the structure of the DOM
slightly, and the kanban record is now a wrapper around the kanban
vignette. To restore the previous layout, some css rules need to apply
to the vignette. This commit adds those rules.
closesodoo/odoo#98188
Signed-off-by: Mathieu Duckerts-Antoine <dam@odoo.com>
For the product categories, the default income and expense accounts
should only contain the income/expense accounts.
Such that the dropdown menu in the product view only lists the possible
income or expense accounts.
task-2835541
closesodoo/odoo#98184
X-original-commit: 526f44f3d1c5eaa0484ca96e491b7746d384522b
Signed-off-by: Laurent Smet <las@odoo.com>
Signed-off-by: Julien Van Roy <juvr@odoo.com>
Purpose
=======
Make it easier to navigate between an expense report and the sales orders it impacted.
closesodoo/odoo#98169
Taskid: 2948615
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Inside a res.config.settings form view have a label with a string on it placed
before the field it is linked to.
i.e.:
```
<label for="myField" string="myString" />
<field name="myField" />
````
Before this commit, the string was not taken into account to build the HTML label.
After this commit, it is.
closesodoo/odoo#98109
Signed-off-by: Mathieu Duckerts-Antoine <dam@odoo.com>
When adding list of transfers to batch from transfer tree view,
if transfers belong to two or more batches an error traceback pops.
To reproduce:
1-Create Transfer 1, go to Transfer list view and add it to batch under Action, choose
add to a new batch transfer and confirm.
2-Create Transfer 2 and do the same.
3-Now that we have two transfer belonging to two different batches,
Under Inventory->Operations->Transfers, select the two transfers
in the tree view and choose add to batch under Action, choose add to new batch
and confirm, error popsup
Bug originated from: #89815
Discovered while working on TaskId:2871679
closesodoo/odoo#97998
X-original-commit: 82580b0ba9dbbfb244ede233a251b059e2c233ba
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Ahmed Khalaf <ahkh@odoo.com>
This commit removes a needless `ensure_one` in batch `action_cancel`
X-original-commit: cf6013fff67441f67800df56349877c820873110
Part-of: odoo/odoo#97998
This commit fixes the recently converted color_picker field
widget. It is now always opened in a list as in legacy,
no longer togglable and many style issues have been fixed.
In form views, we still toggle the opened state because
always edit is coming and it would bloat the UI to
keep it always open.
Tests has been added/modified to assert those desired
behaviors.
closesodoo/odoo#97872
Signed-off-by: Simon Genin (ges@odoo) <ges@odoo.com>
Have a domain declared somewhere in the XML as:
`("&", ("field", "=", "value"), ("field2", "=", "value2"))`
Before this commit, that expression made the Domain algorithm crash, because tuples
were not allowed.
After this commit, only tuples containing at least one other tuple and some optional strings are accepted.
closesodoo/odoo#97850
Signed-off-by: Mathieu Duckerts-Antoine <dam@odoo.com>
Since updating page properties means updating fields on the
'website.page' record, a 'page form view' was used to replace the
frontend page properties dialog at [1].
The goal of this commit is to update the fields used for website page to
work with the new OWL form views.
Follows the merge of the "website in backend" task at [1].
[1]: https://github.com/odoo/odoo/commit/31cc10b91dc7762e23b4bde9b945be0c4ce3fe3b
task-2687506
Part-of: odoo/odoo#97343
After [1], the frontend 'page properties' dialog was replaced by a 'form
view dialog' of the current 'website.page'.
The dialog structure in [1] was based on a 'PagePropertiesDialogWrapper'
component that handles a 'legacy formViewDialog' widget of the page.
Since 'FormViewDialog' is available as OWL component (starting from [2]),
we can now simplify the current code from:
A- 'PagePropertiesDialogWrapper': creates & opens a legacy FormViewDialog.
to:
B- 'PagePropertiesDialog' (the page formViewDialog): can simply be added
using 'dialog service'.
Remark: a wrapper ('PagePropertiesDialogManager' component) is used
temporarily by the legacy 'website.page' listView to add
'PagePropertiesDialog','DuplicatePageDialog' & 'DeletePageDialog'.
This component should be removed after the update of the listView to OWL
and components will be added using 'dialog service' as in the website
navbar menu code.
Follows the merge of the 'website in backend' task at [1].
[1]: https://github.com/odoo/odoo/commit/31cc10b91dc7762e23b4bde9b945be0c4ce3fe3b
[2]: https://github.com/odoo/odoo/commit/48ef812a635f70571b395f82ffdb2969ce99da9e
task-2687506
Part-of: odoo/odoo#97343
Currently, when we change the event template, all the communication
lines linked with are added to the event. That means, even if some of
the lines are sent, and if the new templates lines that has exact same
configuration than the sent ones, they are still added to the event,
which means the same mails will be sent again to the attendees.
With this commit, we check that the communication line being added
(as a result of template change) has the same configuration against
any of the already sent one, it is skipped. As a result, attendees
will not be spammed with the same emails.
taskID-2811310
closesodoo/odoo#89961
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Whenever an error happens during the website creation after the last
step of the website configurator, it is displayed as an notification
popup, but it keeps the UI blocked, preventing the user from retrying
the operation.
The usually observed error is about not being able to install the module
or theme because a cron is in progress. The message actually asks the
user to retry later.
This commit does the following upon errors happening during the website
creation:
- silently retry after 5 seconds, up to 3 times
- after all attempts failed, display the error and release the UI and
allow for manual retry.
task-2809434
closesodoo/odoo#98124
X-original-commit: 2afdbc7181de3c87c1021f1e06d059ffe059ede0
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Signed-off-by: Benoit Socias (bso) <bso@odoo.com>
Issue:
- Rounding should be done at the unit's place for New Taiwan dollar.
Solution:
- Round TWD at unit's place
closesodoo/odoo#98116
X-origianl-commit: f9638a7
X-original-commit: b36689fea400f56f1c6a1b473ac9ceb793456f5b
Signed-off-by: Laurent Smet <las@odoo.com>
this fixes the domain of document types for vendor bills, (was failing since it included
invoices as a document type as option for
credit notes in the wizard and also fixes the opposite (credit notes in invoices generation)
closesodoo/odoo#98002
X-original-commit: 1a8a6c369b257bef87bc3efe62fc9b764a02ebf1
Related: odoo/enterprise#30368
Signed-off-by: Josse Colpaert <jco@odoo.com>
The URL to the Spanish tax agency Agencia Tributaria's test server was
changed. The one currently used does not exist anymore. This causes an
error when trying to access the server.
opw-2888531
closesodoo/odoo#98114
X-original-commit: 2d8407b0dae262199c1bea3a3437e1175f76a630
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Nshimiyimana Serge Séna (sesn) <sesn@odoo.com>
Steps to reproduce the bug:
- Go to Inventory→ Configuration→ Warehouse Management →Operations Types
- Go inside “Receipts”, and enable the checkbox “Create New Lots/Serial
Numbers for Components” and `Use Existing Lots/Serial Numbers`under the
traceability section
- Create a receipt transfers with a traceable product
- Mark as to do the transfer
- Try to add a SN for the product
Problem:
Traceback is triggered: “key error: raw_material_production_id”
because we use this field to add it in the context from the parent in
the `stock.move.line` view:
https://github.com/odoo/odoo/blob/15.0/addons/mrp/views/stock_move_views .xml#L53
But this field is not present in all views of the `stock.move` model
Solution:
To avoid adding this field in all the `stock.move` views, it is better
to add it in the context from the `python` code
closesodoo/odoo#98110
X-original-commit: 545713ae0a559e7f2747dd3cb4211ab752e1ef0c
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Signed-off-by: Adrien Widart <awt@odoo.com>
We deprecated all those in 14.0, so 16.0 seems like a good time to
remove them.
`getppid` was not deprecated but it doesn't seem useful to keep
closesodoo/odoo#97987
Around: windows support was added to getppid in Python 3.2.
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
Before this commit, the pager was on the left or centered.
Now, it is always centered regardless of the website pages (portal or
not).
closesodoo/odoo#97967
Related: odoo/enterprise#30343
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
# Purpose
Take into account the current company when creating a new lead if not defined
earlier.
# Specifications
If there is no company provided by the sales team and the user belongs
to several companies and several companies are allowed by context,
we preferentially take the current company over the user's company if allowed.
# Additional considerations
This commit
* builds on the multi-company fix brought by e5f35a60 avoiding the restricted
access error when setting to the user's base company if not allowed by context,
but will also allow to first preferentially use the current company instead of None.
* Complete tests
Task-2824913
X-original-commit: ce62780153183545ba423a7a8d945d9665cdc50e
Part-of: odoo/odoo#97136
Co-authored-by: Florian Charlier <flch@odoo.com>
Co-authored-by: Fabio Barbero <faba@odoo.com>
Purpose
=======
Avoid having too many search for, lead the end user to use the main one.
closesodoo/odoo#98096
Taskid: 2937036
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
- When trying to delete tasks with an user who does not have read access on model account.analytic.line,
an access error will be raised.
closesodoo/odoo#98123
X-original-commit: d849cc75844d8efd7bc78941b1a10e4dbf6e1c97
Signed-off-by: Xavier <xbo@odoo.com>
Steps to reproduce:
- Install l10n_ar module (or any l10n_* module that depends on
l10n_latam_invoice_document)
- Go to Accounting -> Vendors -> Bills
- Click on Upload and select a bill file
- Open draft bill
- Click on `Send For Digitalization`
Issue:
Digitalization don't start and a warning message is diplayed saying
that some required fields are invalid.
Cause:
When clicking on the button to digitalize the invoice, we try
to save the form first before executing the action.
By doing so, if some fields are required and empty, a warning message
will be displayed.
In this case, the issue is with the fields `Document Type` and
`Document Number`.
Solution:
Set `Document Type` and `Document Number` to not required if there is
no partner_id set on the bill.
opw-2797444
closesodoo/odoo#98115
X-original-commit: b95473e3edf79796c7915afcdec5b4aa9addf273
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Nasreddin Boulif (bon) <bon@odoo.com>
Steps to reproduce:
- Install l10n_ar_website_sale
- Go to shop and add a product to cart
- Go to cart and click on `Checkout`
- Ensure `AFIP Responsibility` is not field
- Click on `Next`
Issue:
Traceback raised.
Cause:
During the validation of the form, even if the pre-validation (by
calling super) returns an error for the afip fields because there
are empty while they are required, we still try to get the code
of the afip responsibility.
Solution:
Return errors (from pre-validation) if any of the required afip fields
are in errors before continuing the validation.
opw-2941199
closesodoo/odoo#98097
X-original-commit: b692f6e442f03d118bbb88d28ea215283e455254
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Nasreddin Boulif (bon) <bon@odoo.com>
If images are lazy loaded in mass_mailing they risk not being converted
properly. This removes the loading attribute from all previously added
images when the editor loads.
opw-2850967
closesodoo/odoo#98107
X-original-commit: 3cb0f466cfa982aeb802e08ded8bdbf7b8f01220
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
Signed-off-by: Antoine Guenet (age) <age@odoo.com>
Card dimensions were not properly preserved on mailing conversion.
opw-2850967
X-original-commit: 1be80cc83bec6a08abf6a3e8493d22f44350d038
Part-of: odoo/odoo#98107
If you delete a tag, but still have some link to this one, you arrive on
a 404 /blog/tag/.
We decide to redirect to the blog post without tag instead.
What is probably the expected behaviour for most customers.
closesodoo/odoo#98087
X-original-commit: 041ad20824e57b0850d7c74ca2ddbeab7f38990b
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Signed-off-by: Jérémy Kersten <jke@odoo.com>
Add Australia and Singapore codes in the EAS list, enabling
the UBL Bis 3 format on the journals of these companies.
Also map the EAS codes to the correct Odoo fields:
* Australia uses the ABN, corresponding to the Odoo vat field
* Singapore uses the UEN, which has a custom Odoo field 'l10n_sg_unique_entity_number'
Fix the missing tax category codes for suppliers not in the european
economic area (e.g. Australian company invoicing a Singaporian one)
closesodoo/odoo#98073
X-original-commit: 8c6ed9386f2c1d29c903fd45d7d716b45eb9d47b
Signed-off-by: Laurent Smet <las@odoo.com>
Signed-off-by: Julien Van Roy <juvr@odoo.com>
The bus tests rely to heavily on the underlying technology (polling).
In order to keep the test intact in the PR introducing the websockets
in Odoo, let's convert the test to be less technical.
task-2053917
closesodoo/odoo#97975
Related: odoo/enterprise#30360
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Mathieu Duckerts-Antoine