Commit Graph
106555 Commits
Author SHA1 Message Date
Christophe Simonis 639421e8a5 [MERGE] forward port branch 10.0 up to fb77309 2016-11-17 18:13:45 +01:00
Christophe Simonis fb773091d8 [FIX] project: Correct tour
Remove useless step as we are already in edit mode after clicking on
edit action link
2016-11-17 17:50:06 +01:00
qsm-odoo 18e1ecd019 [FIX] website: stop making parallax content disappear on save
Depending on the context, the s_parallax snippet content was not
showing after save. This was because the HTML is prettyfied on save
and so spaces are inserted around the .oe_structure, making it break
over the next line.

This commit removed the vertical middle alignment of the .oe_structure
block (so back like it was before v10.0), allowing to fix the problem.
2016-11-17 17:24:08 +01:00
Devendra Kavthekar 8872800e75 [IMP] sql_db: Improve error message logging on database querries
Purpose:

When we have a SQL error, it's not very easy to identify the root of the crash. For example if a mandatory field is not set on a row creation, it difficult to see which field isn't correctly set as a lot of fields are not required and a lot a NULL values are present in the INSERT querry.

Specification:

Show a proper log message, with the reason (cause) of the sql error.

Behavior Modification Examples:
Some sample log after applied fix. The new line are those beginning by '+'

2016-10-25 09:59:40,208 21161 INFO ent_master odoo.sql_db: bad query: INSERT INTO "res_partner_category" ("id", "active", "color", "create_uid", "write_uid", "create_date", "write_date") VALUES(nextval('res_partner_category_id_seq'), true, 10, 1, 1, (now() at time zone 'UTC'), (now() at time zone 'UTC')) RETURNING id
+REASON: null value in column "name" violates not-null constraint
+DETAIL:  Failing row contains (27, null, null, 1, null, 10, 1, null, 2016-10-25 09:59:40.207202, t, 2016-10-25 09:59:40.207202).

2016-10-25 10:00:29,710 21161 INFO ent_master odoo.sql_db: bad query: UPDATE "res_partner" SET "parent_id"=1001,"type"='contact',"name"='Course Script',"company_name"=NULL,"write_uid"=1,"write_date"=(now() at time zone 'UTC') WHERE id IN (1)
+REASON: insert or update on table "res_partner" violates foreign key constraint "res_partner_parent_id_fkey"
+DETAIL:  Key (parent_id)=(1001) is not present in table "res_partner".

2016-10-25 10:23:28,690 21336 INFO ent_master odoo.sql_db: bad query: DELETE FROM res_country WHERE id IN (235)
+REASON: null value in column "country_id" violates not-null constraint
+DETAIL:  Failing row contains (9, 1, AL, Alabama, null, 1, 2016-10-24 10:19:58.765552, 2016-10-21 09:32:26.939607).
+CONTEXT:  SQL statement "UPDATE ONLY "public"."res_country_state" SET "country_id" = NULL WHERE $1 OPERATOR(pg_catalog.=) "country_id""
2016-11-17 16:33:57 +01:00
Yannick Tivisse 34a5258534 [FIX] web: Consider currency_fields with other names than 'currency_id'
To filter the columns to aggregate, we check that the currency_fields on the column is 'currency_id'.

In fact, this is only the default field name. Sometimes it could be an another name, for example 'company_currency_id'
2016-11-17 16:08:00 +01:00
Yannick Tivisse 915bfeaf1f [FIX] web: Fix traceback for list views without any records
Comes from https://github.com/odoo/odoo/commit/df69b5bb846fda29a397bb43f74f73f795b28eea

In JS, Boolean([]) is equal true

It is always a pleasure to work with JS when you're used to python
2016-11-17 16:08:00 +01:00
Kinjal Mehta c3094640e0 [IMP] procurement,stock: Use a handle widget on procurement rules
- Hide the field in the form views
- Order by sequence then by name
- Display a handle widget on list views
2016-11-17 15:41:09 +01:00
Christophe Simonis e2fcace05e [MERGE] forward port branch 10.0 up to 13dc704 2016-11-17 15:27:29 +01:00
Christophe Simonis 13dc7041a6 [MERGE] forward port branch saas-12 up to 1ef4061 2016-11-17 15:24:36 +01:00
Christophe Simonis 1ef4061e68 [MERGE] forward port branch saas-11 up to 3b2f4e2 2016-11-17 14:48:43 +01:00
Christophe Simonis 3b2f4e244f [MERGE] forward port branch 9.0 up to 7ee09ed 2016-11-17 14:37:19 +01:00
Fabien Pinckaers 41cebc4637 [IMP] sale: quotation email template small fix 2016-11-17 13:42:42 +01:00
Christophe Simonis bcddba4e4b [FIX] fields: set attributes before accessing them
If renamed attributes are used, a warning is emit with `repr` of the
culprit field, which need attributes to be set.

Fixes #14036
2016-11-17 13:40:24 +01:00
Christophe Simonis 7ee09ed0c1 [MERGE] forward port branch saas-6 up to 6d8d7a5 2016-11-17 13:11:04 +01:00
Christophe Simonis 6d8d7a5970 [MERGE] forward port branch 8.0 up to 8e8b792 2016-11-17 12:41:45 +01:00
fwi-odoo 25888f4195 [FIX] web: Deleting items in list view does not reset min to 1
When all the items of the first list view page were deleted,
the list view was not reloaded correctly and no records were displayed.
2016-11-17 11:31:35 +01:00
qsm-odoo 48d5420d7f [FIX] mass_mailing: remove unsubscribe link from test mailing
When using the "Test Mailing" button, a sample mail was sent to a
particular mail address and a text-like unsubscribe link was added
below the mail body. This link was ugly, ununderstandable and useless
as it is test mailing anyway.

To add unsubscribe links to your mail body, use the footer blocks
which contain this kind of link (note: they are inserted by default
in all mail templates).
2016-11-17 11:06:09 +01:00
Goffin Simon 84d5216a73 [FIX] sale: vendor bill with a SO reference
If the PO and SO have the same sequence, the source document of
vendor bills and customer invoices could be the same.

opw:693991
2016-11-17 09:21:41 +01:00
Jeremy Kersten e01837d2f4 [IMP] web: remove monokai in form widget aceEditor
Keep return line in ViewMode.

Courtesy of @odony
2016-11-16 19:15:08 +01:00
Jeremy Kersten 9a8975be46 [FIX] base: add record, records in context of ir.actions
Purpose is to remove old variables in next version:
    - obj
    - object
    - cr
    - user
    - uid
    - context
    - pool
    - workflow

record = model.browse(env.context['active_id'])
records = model.browse(env.context['active_ids'])

obj, object => record
user => env.user
cr => env.cr
uid => env.user.id
context => env.context
pool => env
workflow => record.signal_workflow()
2016-11-16 18:46:01 +01:00
Denis Ledoux 483024d122 [FIX] product: _compute_currency_id multi-company
By default, the multi-company record rule on
`product.template` is disabled, meaning the products
are shared between the companies.
https://github.com/odoo/odoo/blob/10.0/addons/product/security/product_security.xml#L48

Nevertheless, the multi-company record rule on
`res.company` is well activated, and therefore
this might happen that you can see a `product.template`
for which you are not allowed to read the company.

If you attempt to read something from this company, you must
therefore do it as sudo :)

opw-693209
2016-11-16 18:38:46 +01:00
Denis Ledoux 232b0d18ac [FIX] account: oversight in forward-port.
The revision
a1d6c2d631
has been ported with an oversight:
except_orm is no longer imported in this file,
besides, the new way to raise these warnings is to
use "UserError" instead.

opw-693779
2016-11-16 17:38:06 +01:00
qsm-odoo 8625242884 [FIX] web: properly destroy nvtooltips when switching views
If the graph view was left while a nvtooltip was shown (thanks to
keyboard shortcuts or during loading time), the nvtooltip remained
and was only destroyed when leaving the action.

Now they are automatically removed with the view as they are now
placed inside of them instead of inside the body element.
2016-11-16 17:27:40 +01:00
Goffin Simon 164b8ed01a [FIX] website_sale: Set the selected state in the visible select tag
When there is a shipping address, this is the second select tag which
is used(defined in website_same_delivery/views/website_same_delivery.xml)

opw:693127
2016-11-16 17:11:10 +01:00
qsm-odoo a2d05a7087 [FIX] mass_mailing: initialize theme images on re-edition
The mass_mailing editor has a feature which switches the images of the
content and/or the droppable snippets according to the theme.
Unfortunately, this images were only initialized on theme choice and
not when entering in edit mode. So when reediting an already edited
mass mailing (or when duplicating one), the theme images were not
initialized.
2016-11-16 17:06:40 +01:00
Denis Ledoux 4ea356110e [FIX] base: crons Work Days option
As you can see from the code,
choosing "Work days" or "days" as internval
has exactly the same behavior.

Users might nevertheless expect the interval
"work days" option to avoid running the
action on non-working days, such as
Saturdays and Sundays.

It may have been intended, but it never
worked, since revision 1:
https://github.com/odoo/odoo/blob/004a0b996ff8f269451e07346f71a129a1f3fbaf/bin/addons/base/ir/ir_cron.py#L49-L50

opw-693882
2016-11-16 17:05:14 +01:00
Denis Ledoux 51882ea70c [FIX] account: force to choose a refund sequence
On an accounting journal, when checking "Dedicated refund sequence",
choosing the refund sequence is mandatory. This is the subject of the
below revision:
d94c449547

Since the refund sequence field was available only for with the debug
mode, the user was not forced to choose the sequence, while he must be.

This is not possible to use the dedicated refund sequence if you do not
choose it there.

opw-693955
2016-11-16 16:26:29 +01:00
Jérome Maes e91ecc89de [FIX] rating: use correct method name 2016-11-16 16:13:08 +01:00
Jérome Maes 75d3121c9c [FIX] im_livechat: correct rating smiley and value for bad rating 2016-11-16 16:13:00 +01:00
Jérome Maes 8cac9d664c [FIX] im_livechat: stop using unsecure controller
Loading history can contains sensitive informations.
You can load the history of a public conversation if
you have its uuid.

This commit stops using unsecure controller when a
secure one for this case exists !
2016-11-16 16:12:52 +01:00
hbh 110737b985 [IMP] sale_timesheet: Delivered quantity updated on locked Sales Order while timesheet filled by user 2016-11-16 15:13:29 +01:00
Olivier Dony 8e8b7925d2 [FIX] hw_escpos: auto-detect endpoint address
Instead of hardcoding the IN & OUT endpoint
addresses for the ESC/POS printers, we now
attempt to auto-detect them.

This should increase compatibility with many
compatible thermal printers that are simply
using a different address, such as the
- STMicroelectronics POS58 Printer USB
- HU HAI SUNCSW Receipt Printer Co.,Ltd. Gprinter USB Printer

Fixes #12890
2016-11-16 14:52:34 +01:00
Mansi Trivedi cbb0d472f5 [IMP] sale: Added string for Quotation and Sales orders list view
- Replaced order date by confirmation date in sales order list view
- Added confirmation date in Sales order PDF report when it is not in 'draft' or 'sent' state
- Calculation of expected delivery date should be based on sale order date
2016-11-16 14:44:59 +01:00
Nicolas Lempereur 897290dd3f [IMP] web_editor: don't lose modified code view content
The scenario when using the code view is the following :

- click on code view button to use code view
- make changes
- click on code view button to get back to wysiwyg view
- save from the wysiwyg view

If the 3rd step is not done:

- for the inline editor, we lose the changes that have been done in code
  view,
- for the iframe editor, we lose the entirety of the content.

At one time the user was forced to go back to wysiwyg before being able
to save, but this have been removed hence the present usability issue.

With this fix, when the editor content is saved, if the user is in code
view he is automatically set back to wysiwyg view.

closes #14339
opw-693052
2016-11-16 14:06:01 +01:00
qsm-odoo 2e0a300016 [FIX] web_calendar, web_kanban: open form view in edit mode after edit button
Some buttons in kanban records or event records allowed to open a form
view in edit mode. The feature was lost with commit
https://github.com/odoo/odoo/commit/46857d26#diff-fc48ba68abe25af0106d66b6ea2ec73eL116

Indeed the "do_switch_view" method signature changed but some calls
still used three arguments instead of two, losing the options param.
2016-11-16 13:40:37 +01:00
Josse Colpaert 1de37862d6 [FIX] stock: when matching moves with pack operations through quants, it did not match the packages correctly. Courtesy of Pedro Baeza
Before, it did a search to see if the package existed,
but the only thing it needs to do is see if the package
on the pack operation corresponds to that of the quant.  (no need to check children also)

There is a test added:
A picking with 120 pieces incoming, 120 in pack 1, 80 in pack2
When we deliver those in a picking out, with product pack operations: (by taking them out of the pack)

120 from pack 1 and 80 from pack2,
we should only have 2 quants and links between moves in the end

And before, it generated 3 because it matched the wrong quants and made the wrong links.

opw 693760 closes #13836
2016-11-16 11:26:20 +01:00
Jeremy Kersten 87184d0894 [FIX] crm: fix tour since kanban state color has been updated
The commit c544aa298 change the color for kanban state, but tour has been
not updated.
2016-11-16 10:53:48 +01:00
Goffin Simon 8b7a4676dc [FIX] account: Communication in register payment from tree view
When using the tree view to pay invoices the reference was never added to the payment as memo.
The memo is filled when directly paying the invoice using the button(Register payment).
Now the same behaviour is done from the tree view and from the form view.

opw:691986
2016-11-16 09:23:16 +01:00
Denis Ledoux c81a63393d [FIX] sale_order_dates: infinite recurssion in effective_date computation
This is due to the below revision
c1cfbf6436

Which used the `write` method on the `order` instead of assigning
the value in the variable `order.effective_date` to set the value,
as it should be done in the new API

opw-693800
2016-11-15 19:51:05 +01:00
Fabrice Henrion 0c0037a398 [IMP] rating_project: grammar wording 2016-11-15 14:59:30 +01:00
Raphael Collet 51680426a6 [FIX] fields: convert_to_cache() on cached values for relational fields (#14328) 2016-11-15 14:45:46 +01:00
Jeremy Kersten d7004d7dc0 [IMP] base: ir_filter - allow to get the domain evaluated 2016-11-15 14:33:06 +01:00
Christophe Simonis dece72d010 [MERGE] forward port branch saas-12 up to ca20038 2016-11-15 13:58:55 +01:00
Christophe Simonis ca2003839a [MERGE] forward port branch saas-11 up to 58f68cc 2016-11-15 13:19:55 +01:00
qsm-odoo 669336baa9 [REF] web_planner, *: refactor planner code
* Share code between website and backend
* Do not do a [100ms - 500ms] RPC on each app change in the backend
but do it only if the planner is asked to be opened
* Use the Dialog class so that the planner is not broken
* Simplify/optimize code, use standard conventions, lint files, ...
2016-11-15 13:08:59 +01:00
Christophe Simonis 58f68ccb72 [MERGE] forward port branch 9.0 up to 3bad13d 2016-11-15 11:06:15 +01:00
Martin Trigaux 22d7be5b73 [FIX] account_voucher: bad onchange return format
The product_id_change returns a 'value' key, not 'values'

Closes #14274
2016-11-15 11:00:08 +01:00
Leonardo Donelli 814c2e83cc [FIX] hr_timesheet: AccessError editing timesheets
Make department_id of account_analytic_line readonly, so that when the field is written it is not also propagated to the employee, which
may fail when the user has write access to timesheets but not to employees.

Fixes #14084
2016-11-15 10:56:23 +01:00
Kumar Aberer 9f172a61e0 [FIX] Check accounting lock date before cancel account moves
Error message is shown when trying to cancel account moves that are
prior to the accounting lock date.

opw:693083
2016-11-15 10:15:24 +01:00
Goffin Simon 3bad13d650 [FIX] point_of_sale: closing balance access rights
In 9.0 when the pos user was not at least in the group Accountant
(group_account_user), he was not allow to close or open the balance
when the pos session was configured in cash control.

ps:be carefull with the old rule: Point Of Sale Cashbox Line POS User
deleted with a26b805f5e

opw:69251
2016-11-15 09:30:10 +01:00