Currently, when updating a review on a course, the feedback field is not
updated on the rating model. Therefore, the backend view for rating is
always displaying the first feedback posted
Task ID 2184038
closesodoo/odoo#48382
X-original-commit: f2d04753be9f1feb75e575b0598b3520caa4744d
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Finetuning of
https://github.com/odoo/odoo/commit/b30e280b2d676f16873ac0fd1279c4870d994dec
:
self.user_id is always an empty recordset in a default function call,
use self.env.user instead, it is the default value for user_id.
The _init_column override is needed to ensure the new property field on
res_users isn't read at module installation, because its ir.model.fields
doesn't exist already, leading to a wrong sql query in ir_property.
closesodoo/odoo#48378
X-original-commit: 6c6bd018c761535f973781319090116d7eea60ad
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Issue
- Go on Runbot V13
- eLearning
- In a course, try to delete a question
You can't
Cause
The linked answer is not deleted
If you want to delete the answer you should
add an extra menu
Solution
Add ondelete='cascade' on answer's question_id
Prevent course deletion if there are attendees
OPW-2210096
closesodoo/odoo#48372
X-original-commit: 799ee72facbca7a7eaf348938ed312a6d723854e
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Before this commit, the `kanban_state` field on the form view was not
positioned correctly in community edition, making it impossible to read
possible values. This commit fixes that by ensuring it is on the right.
Due to some CSS differences enterprise was not affected.
Fixes#38567closesodoo/odoo#48370
X-original-commit: 2f89951a17762c05e17a247fa795e9f96703018d
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Currently there are several limitations in visitor email and phone
computation, notably phone of partner is not taken into account (only mobile)
and computation does not work in website_crm if there are no leads.
In this commit we
* support both mobile and phone fields of partner. Indeed generally all
SMS flows check for those two fields and not only for mobile;
* replace the SQL by standard ORM computation. As those fields are not stored
and displayed in list views ORM should be capable of managing them;
* avoid crash when creating visitors through the UI (no ids -> don't go
into raw SQL);
* correctly keep partner-based values when no lead is linked to the visitor;
Tests are also added in order to ensure behavior.
Task ID 2196869
closesodoo/odoo#48369
X-original-commit: 02ceb42e204be2b40b334b4e554eef6dfaffd228
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Message post with template has to be called with a notif_layout parameter in
order to have a layouting correctly set through the call chain.
closesodoo/odoo#48359
X-original-commit: 077f58027e29a50cd9a9bf455b5ca5c482503686
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Keep the same images order as the other modes in the gallery snippet
with masonry mode. Before this commit, the images order was reversed
with masonry mode.
task-2162952
closesodoo/odoo#44486
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Purpose of the task is, when the accrual is selected, the field for
duration is hidden but the feature allows to use it.
So in this commit,when accrual is selected, display number of days
(duration) to provide an intial allocation while accrual is selected.
Also change label and tooltip according to allocation type.
closes odoo/odoo#48354
Taskid: 2199324
Closes: #47598
X-original-commit: 74df5cbaf37d3cc6da0b15efa9d7f4a4ec265ec5
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
in helpers 'get_odoo_server_url()' return the server string or False.
In steps by steps config wizard we display this value.
So in server input it display 'False' and with this value we can't submit the form
Now we set a empty string if the return is 'False'
closesodoo/odoo#48346
X-original-commit: 57283f213ee3d1dd4f59c83cc34fbdd3545c4533
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
- Create and validate an invoice in a date (near the end of the fiscal
year for example: 20.12.2019) in a foreign currency;
- Pays the invoice in a different date (23.12.2019), the invoice is
settled and a currency exchange is created;
- In the new fiscal year (for example: 03.01.2020), amends the invoice
(a description change for instance): cancel the invoice, change the
invoice into draft, made the amends, re-validate the invoice and
re-settle the invoice (a new currency exchange reversal is created).
Before this commit, when cancelling the invoice, a currency exchange
reversal is created at the current date (03.01.2020) to revert the first
currency exchange reversal. When the invoice is re-settle, a new
currency exchange is created a date of the payment (23.12.2019).
This means that, in the fiscal year of 2019 two currency exchanges were
created, and in the new fiscal year of 2020 a currency exchange revert
is created. To avoid this erroneous situation, the date of a currency
exchange reversal should be the creation date of the currency exchange.
Now the currency exchange reversal entries has the same date as the
initial currency exchange entry.
opw-2209675
closesodoo/odoo#48344
X-original-commit: cedfbd0379a907650db9b23f6c5203522d4ced95
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
If we start a self flash and we refresh the page
we are able to start again the upgrade.
So now we check if a upgrade is not already started
closesodoo/odoo#48340
X-original-commit: 7189111a73b689af919cdfa4712f04108b7931e6
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
A commit merged very recently added 1 more base query to both users, but because
the count of that particular test is non deterministic, the issue is only
spotted later on runbot, and it has to be fixed now.
closesodoo/odoo#48331
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
Steps to reproduce the bug:
- Lets consider two companies C1 in € and C2 in $
- Let's consider two customer invoices I1 in C1 and I2 in C2
- Select these two invoices in the list view of invoies and print it
Bug:
A traceback was raised because the function _convert expects a singleton
opw:2222140
closesodoo/odoo#48323
X-original-commit: b66bcfe96dfdc62a1faa26ccf9c6adfa2b8929a4
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Before this commit the demo delivery WH/OUT/0005 is plan then validated.
But as this delivery is the one used as example in the barcode PDF, it
could be usefull for demonstration to keep it as to process.
So, this commit keeps it only as ready, and also increases the stock
amount of Desk Combination to be able to process this delivery without
any issue.
task-2199747
closesodoo/odoo#48320
X-original-commit: 652ee46e8adc35bae4f89bf9802f12bd1c424c8d
Related: odoo/enterprise#9474
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
As a barcode for this location was created into the barcode pdf
(enterprise), it seems logical this location has actually a barcode.
task-2199747
X-original-commit: 661bfffca9ad2aa1357ef031ca983104200d5d1f
Issue
- Be in multicompany
- Have a company with a long name
- Install Accounting
- Settings > Currencies > Dollars
- Click on the smart button "Rates"
- Group by company
Company name and rate overlap
Cause
In `_computeDefaultWidths`, we use the method
`_getColumnWidth` which returns a width depending on the
field type.
When you use group by, the fields order doesn't change
so the company name in the group line have the width
of the date field (92px) and there is nothing that
limits the place that the string can takes so there
is overflow.
Solution
As it seems to be something very accurate, I think the
safest solution would be to use the `o-text-overflow`
saas mixin.
OPW-2218143
closesodoo/odoo#48318
X-original-commit: 2898dd4577e12326cbe83dce9fdbdef0e32d51e6
Signed-off-by: Jason Van Malder (jvm) <jvm@odoo.com>
Some elements contain superfluous `aria-label` attributes, which
overrides any default useful information. For instance, some dropdown
menus contain the `aria-label` "Dropdown menu" (e.g. the company
switcher), which doesn't add any useful information, as dropdown menus
are already labelled correctly using `aria-expanded`.
This change applies on the following buttons:
- Schedule an activity
- View attachments
- View followers
- Switch company
- Open user options from systray
- The widget `state_selection`
closesodoo/odoo#48317
X-original-commit: e3c7f66e89d7be39dfa4cc3d6b038c6f4a114aa5
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Before this fix, when default debit and credit account where not
set on the journal, there was a simple error message saying
that an account was missing on an invoice line:
"Missing required account on accountable invoice line."
Now, the error message tells on which journal the accounts are missing,
giving better insight to the user.
Update addons/account/i18n/account.pot
Update addons/account/models/account_bank_statement.py
closesodoo/odoo#48312
X-original-commit: bb4b707fbcafa54a2e8b8a6e73fbe102b8b13811
Signed-off-by: jev <jev-odoo@users.noreply.github.com>
Co-authored-by: Richard Mathot <rim@odoo.com>
Co-authored-by: Richard Mathot <rim@odoo.com>
The http request to odoo.com could lead to a timeout.
Avoid it in a testing environment, to avoid tests like
test_20_crawl_demo to crash.
closesodoo/odoo#48307
Taskid: 2222797
X-original-commit: 873699142f3427ecf486cf4319e158768a4e1336
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
In this commit, domain has been put in the action_account_moves_all in order
to exclude the totally cancelled journal entries
task:2028813
closesodoo/odoo#48161
X-original-commit: d50eae4c76ad280fe4480fea06d612fbfe349614
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
Purpose
=======
If a user specifies a language on a company (res.partner), chances are children
of said company will speak the same language. It is at least most likely than
having them speak the default DB language.
Specifications
==============
If a language is set on the parent, the child contact created from the o2m
should have by default the same language.
Before this commit, we set lang in the context of the o2m field but it not
taken into account and is overriden by the default DB lang.
After this commit, the default lang value is forced in the default get to
be the same than the parent, if any. Else, we fallback to the default DB lang.
Link
====
Task ID: 2210350
PR #48077
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Display the kanban view for the `picking_ids` field in the picking batch
form when user is on mobile mode.
closesodoo/odoo#48313
X-original-commit: 2c022a285fde3ccc34398c94e331ae3473d79559
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Display the operations (`stock.move`) in the picking form view as
kanban view when the user is in mobile mode.
X-original-commit: c3488d625a5e939de6a5b2d41b5029640e0790f5
This module define same `export.integer` model that is in `test_impex`
module, but do not define model access.
So if you only install `test_xlsx_export` the test will work but you
will get a warning over "The model export.integer has no access rules,
consider adding one".
opw-2204111
closes#48293closesodoo/odoo#48308
X-original-commit: 92761b7877d63e2432cb246f5078c22b1b0f24ea
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Commit abef168389 adds the fields
'product_description_variant' on mrp.production and purchase.requisition
models. This text is taken from the product variant.
This commit make them invisible in case they are empty.
closesodoo/odoo#47716
Related: odoo/upgrade#948
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Sales Order notes were not passed in when generating the invoices.
* [IMP] When generating an Invoice from several SO's the lines sequences
were copied from the SO's. Because of that the resulting Invoice
could have lines mixed-up between the different SO's which could
be confusing, especially as notes are now passed in too.
* [IMP] Down payments where not sent into a separated section on invoices.
This could confuse the user, especially when the down payment was
included in a section created that was created in a previous SO
line.
Closes odoo#47279
Task ID #2206228closesodoo/odoo#47279
Related: odoo/enterprise#9465
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
+ Add helper method to retrieve the contract wage.
Those methods are supposed to be overriden in some cases.
closesodoo/odoo#48258
Taskid: 2222984
Related: odoo/enterprise#9454
Related: odoo/upgrade#980
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Fixes#47147
Followup on 39e2dfca0a4a2cf641a50ee9af510180fff6eb9c and 737eaf9333
Before this commit, Accounts with single character code was setting non-existing `root_id` which crashes on Grouping by using that field. (and also Accounts were not visible search panel)
With this commit we support computing `root_id` with Single Character.
closesodoo/odoo#48261
X-original-commit: d93ccdc5a25c061468870359ad8f749496140d19
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Context:
Since 7593b887df an entry of ir.model.fields.selection is created
for each entry in a selection field. This allow a more modular
approach of tagging entries with an external id and translating
selections in the module that defined the selection (and not the one
that defined the field)
Problem:
When removing a selection, every record that used this selection is
updated with a 'set null'.
This was also intented on abstract models that do not have a table.
To reproduce:
1. create two models:
class ModelA(models.Abstract):
_name = 'abstract.a'
select = fields.Selection([
('foo', 'Foo'),
('bar', 'Bar'),
])
class ModelB(models.Model):
_name = 'model.b'
_inherit = 'abstract.a'
2. update code and removes the key 'foo'
3. update the module
-> error
psycopg2.errors.UndefinedTable: relation "abstract_a" does not exist
LINE 1: UPDATE "abstract_a" SET "select"=NULL WHERE "re...
When updating the values in db, only update on real models
closesodoo/odoo#48288
X-original-commit: 6b20a8241300ebfc185500eb64e210db755574a8
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
Add position top in popup snippet and cookie bar.
Properly center content when full size and position center because
before this commit the content was at the top and not centered.
Part of https://github.com/odoo/odoo/pull/46503
task-2194309
closesodoo/odoo#46503
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Add an input field to define the value of the progress bar instead of
the previous system by mousedown. Disable animated by default.
Part of https://github.com/odoo/odoo/pull/46503
task-2194309
Copy the absolute path in the clipboard instead of the relative for
anchor links. So the link still works if it is pasted on another page.
Part of https://github.com/odoo/odoo/pull/46503
task-2194309
Removes option to move card to the right/left from the left panel
and add this option on the element overlay.
Makes the snippet responsive and other improvements.
Part of https://github.com/odoo/odoo/pull/46503
task-2194309
Add a wrap div around overlay options so we are able too add more
specific options that are separate from the move options.
Part of https://github.com/odoo/odoo/pull/46503
task-2194309
Before, only accounts, fiscal position, tags and taxes were
translatable, now account groups are too.
X-original-commit: da571b354293e852c1c4828f758eace8e6ededa4
PURPOSE
Merge rendering tools used in mail and sms templates and move them
directly in mail.render.mixin
SPECIFICATIONS
Clean rendering methods API and calls. Ensure they are private. Improve
naming and docstrings to ease understanding.
Move rendering methods on mail.render.mixin. It makes no senss to have to
create a void mail.template recordset just to invoke jinjna rendering engine.
Now rendering will be available
* either directly through inherit;
* either by calling env['mail.render.mixin']._render_template();
Move local to global links convertion as well as links shortening tool methods
on mail.render.mixin . That way this mixin holds tools related to rendering
and its post-processing.
This impacts mail.template, sms.template and mailing.mailing as side effect
without any functional change.
LINKS
Task ID 1963529
Community PR odoo/odoo#32397
Enterprise PR odoo/enterprise#8634
Upgrade PR odoo/upgrade#911
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
RVE-odoo