Commit Graph
119736 Commits
Author SHA1 Message Date
Fabien Pinckaers 3dcc6d78bb [IMP] project: reducing tour to avoid asking for invitations
We already ask to create a user when creating the first task, going
to the Settings to invite more people is too much.
2018-08-18 13:53:06 +02:00
Fabien Pinckaers 2c61a3514c [IMP] project: show link of empty list 2018-08-18 11:42:24 +02:00
Fabien Pinckaers 686075e838 [IMP] mail: chat copy 2018-08-18 10:44:02 +02:00
Dharmraj JhalaandMohammed Shekha a105e5f208 [IMP] web,various: Add 'Remove' button to view dialogs opened from x2m fields
Currently, to remove link of x2m field from any record, sometimes there's no way.
For example, if we are on mobile and open any Quotation, it's linked quotation lines
are automatically converted in kanban, and there is no way to delete a line from
that quotation. However, in some of the manually designed kanban, there is special 'x'
for removing / unlinking x2m record, for example, Contacts of Partner.

This commit makes the behavior more consistent. During edition (mobile and desktop), if
a view dialog is opened on click of x2m field, it will have one 'Remove' button (based
on user rights) on right side of dialog footer, allowing users to delete / unlink the
record. Moreover, in mobile, the modal is opened fullscreen, with sticky header and
footer.

Related Task# : 31641
Closes PR #15857

Co-authored-by: Mohammed Shekha <msh@openerp.com>
2018-08-17 18:18:53 +02:00
qdp-odoo 858893494f [IMP] account: remove '/' in invoice's journal entries
Fixes #25938
2018-08-17 17:35:39 +02:00
Laurent Smet 380f1c09ce [ADD] account_facturx: add import/export invoice using the Factur-x standard
Factur-x is the e-invoicing standard in vigor in FR & DE and, by extension, it will probably become the standard in Europe. Thus this will be used as default e-invoicing standard by Odoo.

The idea is simple:
  * when printing your customer invoice report (not in draft ofc), a Factur-x xml file is generated and embedded inside the PDF.
  * when importing supplier bills in the form of PDF files, we detect if any Factur-x xml file is attached and complete the data of the draft vendor bill accordingly. This is done during the message_post() function.

/!\ To be compliant with the Factur-x standard, the PDF should be PDF/A-3b compliant. (See: http://fnfe-mpe.org/wp-content/uploads/2018/07/1.-FACTUR-X-V1.1-2018-07-24-FR.pdf chapter 6)
    However, wkhtmltopdf is not PDF/A compliant and then, the generated PDF report are not fully compliant with the Factur-x standard.

Was task: 1859277
Was PR #25508
2018-08-17 17:35:39 +02:00
Laurent Smet b0a29c9bad [IMP] account, bank statement reconciliation widget: improve suggestions
Suggestions made to reconcile bank statement lines are now more accurate (based on communication and amount)
There's no automatic mode anymore (button + <CTRL+ENTER> shortcut removed)
Partners are set automatically when selecting a line in the widget (that will help the creation of a res.partner.bank for him, for a better partner detection next time)

Was task: 1847703
Was PR #25438
2018-08-17 17:35:39 +02:00
Alexandre Kühn 6d53cd3201 [REF] mail,im_livechat,digest: rename 'chat_client_action' to 'Discuss'
Revision on https://github.com/odoo/odoo/commit/02ec09cb1c3e2d7bc7968f40c18f2208d7f3f498#diff-6d76770b1b7cf716d60a4d76a1555c1d

The commit above mostly renamed 'Client Action' to 'Discuss',
but there were some leftovers.
2018-08-17 16:28:39 +02:00
Fabien Pinckaers 11b24b42d3 [IMP] base: UX of partner creation with ro address 2018-08-17 16:25:32 +02:00
XavierDo 830f31e433 [FIX] mail: correct computation of date_deadline
The indentation of the computation of date_deadline was incorect
leading to a deadline only getting compute when the base date was
depending on a previous activity.
2018-08-17 16:22:48 +02:00
Alexandre Kühn ccd94a1588 [REV] "[FIX] web:tests: do not rely on testUtils.patch in tests"
This reverts commit f1a0a32e46.

This utility function has been fixed with commit 1edea9326c
2018-08-17 16:21:39 +02:00
Alexandre Kühn 1edea9326c [FIX] web: tests: correctly unpatch classes
Before this commit, `testUtils.unpatch` was incorrectly
unpatching a class' properties.

That is caused by restoring the properties on the class
function itself, instead of the prototype of the class
function.

This commit fixes this issue by restoring properties on the
prototype function of the class on `testUtils.unpatch`.
2018-08-17 16:20:06 +02:00
Luis González bb5a9a6ae6 [IMP] mail: Add some missing aria attributes
Some aria HTML attributes were missing, and are desirable to provide a
better experience for screen reader users.

The following attributes are included:
- `aria-pressed`: Used in buttons whose function is toggled when
  pressed. In this case, it is added on the button to follow/unfollow
  a record.
- `role`: used to improve given information about what elements are for.
  In this case, it is added in the following cases:
  1. Buttons to apply filters (e.g. to filter conversations) are set
     to  role="tab". These buttons have the class `o_filter_button`.
  2. Elements who are not buttons but have the class `dropdown-menu`
     are set to role="button".

Closes #25667
2018-08-17 16:12:04 +02:00
Martin Trigaux d2fd2f2083 [IMP] base: avoid creating new module
The field module_id is only informative

Fixes #25705

Courtesy of Swapnesh Shah and Pedro M. Baeza
2018-08-17 15:54:41 +02:00
Christophe Monniez c6fa1796af [FIX] tests: clean the browser even on failure
When a Chrome headless test fails the browser is not cleaned and could
lead to a mix with other tests when the same method is called.

Also, the multiline assertions gives an unreadable message when the
assertion fails.
Finally, it happens that a thread does not have an 'url' attribute and lead to a crash when the logger tries to show the thread url.

With this commit, the browser is cleaned, even on failure and the
assertions are now one line.

Closes:  #26432
2018-08-17 14:49:53 +02:00
Alexandre Kühn 0eab8f6e0b [FIX] mail: correct meaning for ASC/DESC thread ordering
Revision on https://github.com/odoo/odoo/commit/f2302dfb27dd7f6a0dee7c65ab75b62a01706264

The commit above improved the rendering of thread.
However, it wrongly defined ASC and DESC.

This commit fixes this issue by re-arranging so that their
definitions match the meaning of 'ascending' and
'descending'.

Orders are defined from top to bottom. Visually:

                _____________            _____________
               |             |          |             |
               |  message 1  |          |  message n  |
               |  message 2  |          |  ...        |
               |  ...        |          |  message 2  |
               |  message n  |          |  message 1  |
               |_____________|          |_____________|

    ORDER:           ASC                     DESC
2018-08-17 14:10:46 +02:00
Alexandre Kühn 1337465c51 [REF] mail: reorder Discuss handler function alphabetically 2018-08-17 14:10:32 +02:00
Yannick Tivisse b10841d615 [IMP] auth_signup: Set self created users as customers
Since https://github.com/odoo/odoo/commit/9aaa32b6f62a95f58d11c17aefb4da4027371223
newly created users are not customers anymore.

But users created from frontend (like in the ecommerce) should be customers.

Specification
=============

Portal users created from auth_signup should be customers.
2018-08-17 14:05:59 +02:00
Martin Trigaux d97e69ff02 [FIX] mail: schedule activity with user's today
The activity was incorrectly scheduled with a deadline as the now in UTC while
the state was computed using "today" in the user's timezone.
This made the nightly test fail (run at 23:30 UTC with the user in UTC+2).

Use context_today instead of today for all activity_schedule calls
To make it easier, use on the context_today default value instead of setting
context_today everywhere (which is more error prone in the future)

Never use datetime, only date objects
add a warning to detect potential errors when passing a datetime

Closes #26411
2018-08-17 13:46:39 +02:00
Martin Trigaux c51cfbc58b [FIX] purchase: use date everywhere in report
account_invoice.date is a date field
purchase_order.date_order is a datetime field
2018-08-17 13:14:51 +02:00
XavierDo f83c313631 [IMP] mail_bot: improve answers, initialisation and others
1. Odoobot shouldn't talk to admin when demo data are installed
Odoobot will talk to a user on it's first connection, meaning that
a dev will see this chat window a lot. The state disabled is not a
real state but is explicit, the odoobot wont be initialized in this
case. It is still possible to test odoobot flow with demo user.

2. remove old odoobot image and update link

3. small improvements in odoobot answers
2018-08-17 13:06:43 +02:00
Mehul Patel dc5462db51 [FIX] web, google_spreadsheet: BS4, fix arrow issue in search filters 2018-08-17 12:46:14 +02:00
Hiral Bhavsar b0c4245df7 [FIX] web: BS4, restore calendar view's sidebar filters checkbox
Currently cross sign not appearing inline to checkbox while hovering
sidebar filters and checkbox tick/untick not working properly.
2018-08-17 12:46:14 +02:00
qsm-odoo 4895b542e4 [FIX] website_links: restore filter buttons (useless breaking rules)
Revealed with BS4.
2018-08-17 12:46:14 +02:00
mgh-odoo d187f37563 [FIX] base: use proper info alert for new team member message
Bug revealed with BS4.
2018-08-17 12:46:14 +02:00
Anshuman Sharma 13ebe69747 [FIX] website_forum: BS4, set a spacing between cards 2018-08-17 12:46:14 +02:00
Kishan Gajjar 9056e5a3cb [FIX] web_editor: BS4, mark proper active img-padding option 2018-08-17 12:46:14 +02:00
Deep Patel 0bcd71a54a [FIX] web: BS4, fix stat button color issue 2018-08-17 12:46:14 +02:00
Vandan Shah e31048f6a4 [FIX] mrp: BS4, restore report's links design 2018-08-17 12:46:14 +02:00
qsm-odoo 9d30113356 [FIX] web: BS4, restore dropdown active colors 2018-08-17 12:46:14 +02:00
qsm-odoo ed031d9085 [FIX] mail: BS4, restore discuss badge design 2018-08-17 12:46:14 +02:00
qsm-odoo 3bf3a40606 [FIX] website: BS4, restore facebook snippet UI
+ solve JS error introduced by a recent commit

Thanks to @kig-odoo for original fix
2018-08-17 12:46:14 +02:00
Alexandre Kühn ff4901e429 [DOC] web:tests: add docstring for testUtils.patchDate 2018-08-17 12:37:36 +02:00
Alexandre Kühn 75aef0106e [FIX] mail: misplaced translatable string
`_t()` must surround a static string in order to become a
translatable string.
2018-08-17 12:37:25 +02:00
RomainLibert 2d738f8563 [FIX] product_form: remove hs code and duplicate internal note
The hs code was only used in a single view, hence it was decided that we
wouldn't keep it
2018-08-17 11:47:28 +02:00
Simon Lejeune 3fa2ca0779 [FIX] web: no_open in field options no longer working
example: <field name="product_id" options="{'no_open': True}" readonly="1"/>

This has been broken by rev. 43d21dd9c due to misplaced parentheses
(an empty object in javascript being truthy).
2018-08-17 11:24:27 +02:00
Sébastien Theys 82a46db2de [FIX] portal,sale,sale_management: raise if no document
Before this commit, the method _document_check_access would succeed if it was called with a non-existing id.

Now it will raise a MissingError.

PR: none
Task: none
2018-08-17 10:40:07 +02:00
Sébastien Theys 02a73ed62c [IMP] sale,sale_management: fix minor bugs and rename strings
Sales Order report:
- fix Total table alignment (to the right)
- remove misplaced /> characters
- remove page-break before optional products

Sales assets:
- fix duplicate ID preventing assets files from being loaded

My Home:
- fix link to sales orders

Optional Products:
- renamed various strings
- made product_id required to prevent a traceback

PR: none
Task: 1838924, 1876864
2018-08-17 10:40:07 +02:00
Mathieu Duckerts-Antoine 3ec6624754 [FIX] web: time range menu flickering
The search view always instantiates a time range menu but hides it
when it is not used.

Now, when the time range menu is not used, every time the search view
facets are rendered, the time range menu is also rendered entirely
and becomes visible shortly before being hide again. This caused
a bad screen flickering.

This commit fixes that problem by avoidind the unnecessary rendering of
the time range menu.
2018-08-17 10:26:31 +02:00
Alexandre Kühn c995aa2cfd [FIX] mail: tests: remove phantomjs hack with discuss
Revision on https://github.com/odoo/odoo/commit/e0a51edd856b36bfdf1cacb4d7e8d70fad7884fa

In the commit above, we added an option to Discuss widget
to render threads specifically for PhantomJS. The reason
for this is that a test was failing, because it needs full
support of CSS flexbox to pass.

However, PhantomJS does not support flexbox very well. As
a result, it was messing with the rendering of threads.
We couldn't make the hack just in the test itself, because
it is already at the moment of rendering the thread that
PhantomJS messes the whole process of the test.

PhantomJS has been replaced with Chrome headless [1], So
the hack is no longer be necessary, as Chrome headless
fully supports CSS flexbox.

[1] https://github.com/odoo/odoo/commit/de84ad9c1f4853cb8a748ee1d0c880081dae9fe2
2018-08-16 22:26:50 +02:00
Rémi Rahir dd00a3d9f9 [FIX] snailmail: added missing dependency 2018-08-16 18:45:53 +02:00
Alexandre Kühn f1a0a32e46 [FIX] web:tests: do not rely on testUtils.patch in tests
Revision on https://github.com/odoo/odoo/commit/10f43955d81ff3e7b5ab050656b312ec19f927c5

Commit above uses `testUtils.patch` in the test.
However, this utility function does not seem to work.

That sucks...
2018-08-16 18:38:49 +02:00
Thomas Binsfeld f9644a7674 [IMP] purchase: split compute methods
No advantage to group a search on purchase.order and another one on
account.invoice.
Avoid potential access errors if a user has access to one model but not the
other one.

Closes #25761
2018-08-16 17:34:23 +02:00
Gustavo Valverde 89273f8d72 [IMP] hr_payroll: order salary rules by sequence
The most important part of building salary rules is having them in the right
sequence. Unsure all the rules are evaluated in a deterministic order.

This also makes it easier to know how the payslip will show the order of the
salary rules.

Closes #25756
2018-08-16 17:30:03 +02:00
qsm-odoo 8a85cb9ea4 [REF] website_sale, *: organize JS to use new system
* website_sale_comparison, website_sale_wishlist, website_sale_options
2018-08-16 16:59:25 +02:00
Alexandre Kühn 10f43955d8 [FIX] web: render JournalDashboardGraph when in DOM
The lib 'nvd3' renders graph when they are attached to the
DOM. However, widgets are rendered in fragments and
appended to the DOM when ready (to prevent flickering).

Before this commit, we used a `setTimeout(0)` and cross
fingers that the widget was attached to the DOM when the
`render` method was called.

With this commit, the render method is called when it is
attached to the DOM.

Task-ID 1868252

Closes #26410
2018-08-16 16:52:56 +02:00
Raphael Collet 2a2ff6eb5c [FIX] tools: serialize lazy to json 2018-08-16 16:39:20 +02:00
Christophe Monniez 49fb7a4682 [FIX] tests: avoid traceback when websocket-client is not installed
The account module needs to import Form from "tests.common" causing a
traceback when websocket-client module is not installed.

As this module is only required for the tests, there is no reason to add
it to the "requirements.txt" file.

With this commit, Odoo account can be installed even when
websocket-client is not installed, in that case, the HttpCase tests that
needs to run Chrome headless will be skipped with a warning.

Closes: #26404
2018-08-16 15:07:43 +02:00
Simon Lejeune f57bc96d32 [REF] stock: add a group to display/hide the lot name on the delivery
initial work by Alexandre Moens <mao@odoo.com>
task 1832574
closes #24299
2018-08-16 15:01:25 +02:00
Arnold Moyaux 6671725c3b [FIX] mrp: manufacture to resupply archive pbm/sam rules and routes.
Usecase to reproduce:
- Check manufacture to resupply and manufacture in 2 or 3 steps
- Uncheck manufacture to resupply
pbm and sam rules in global route(mto/manufacture) are still active

It happens because the condition to archive the rules was not complete
the check on manufacture to resupply was missing
2018-08-16 14:45:14 +02:00