Install l10n_it_edi, try to import an italian e-invoice (xml). Odoo will create
2 invoices, one draft with the attachment but empty, and another one
with the parsed content of the file.
This happen because the module responsible for the import systematically
create a new invoice instead of reusing the open one.
opw-2089521
closesodoo/odoo#39115
X-original-commit: 45984f8d83a2aa97714ffcca32f690a58cc6328f
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Fine tuning of c351f00
In the POS module there is the possibility to print receipts.
Before this commit:
- The currency symbol appears in the receipts but not in sublines
and discount
After this commit:
- The currency symbol appears in the receipts but not in sublines
OPW-2083188
closesodoo/odoo#39114
X-original-commit: 6a22bb1e4e917a27b41290824fec86718935d864
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
At the moment the weight is read from all scales automatically. The
problem is that Adam scales beep every time we read the weight, making
them almost unusable in a shop. We set the manufacturer on the IoT
Device to be able to identify those scales and get the weight manually
instead of reading it automatically.
closesodoo/odoo#39107
Taskid: 2089995
X-original-commit: 5bde93951b29c18d8361bd5ca759a8b2e190573a
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
Lets say we have 2 payment references on our invoices:
* `45 RE34Y U0000 00000 02019 00014`
* `45 RE34Y U0000 00000 02019 00022`
A customer pays with the communication: `45 RE34Y U0000 00000 02019 00014`
Before this commit, the query in _get_invoice_matching_query was looking
at the invoice number, the invoice line label, and the vendor reference
all the same way; it was never looking specifically at the payment reference
(which is copied on the receivable line).
This was an issue because the matching was done by keeping only the
digits, grouped by word. If at least one group of digit matched, then
the statement matched with the line.
In our example, both invoices were proposed because `45`, `RE34Y`,
`Ù0000`, `00000` and `02019` matched. (one is enough).
The fix consists of ignoring the lines that match with the number, label
and vendor ref if we find an exact match with the payment reference.
closesodoo/odoo#39102
X-original-commit: 35339bc24b52788e18b57a49f3a0d948f9e466b8
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
- ensure a valid image was given or prevent to save it otherwise, instead of
allowing any file, which would then crash at display
- restrict to a reasonable size
PR: #38292closes#38026closesodoo/odoo#39098
X-original-commit: 92eafdf7e283e5474b1da2c88cfbdebbee17b48e
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Before this commit, if `max_width` and `max_height` are 0, the image would not
be opened by Pillow at all (to gain a bit of CPU) however this was actually a
bad idea in this case because then we don't ensure the given value is actually a
valid image when we save it, only later at display we notice it and it crashes.
This optimization only made sense when `image_process` is called many times,
from the route displaying images every time a visitor is requesting an image,
for example. It doesn't really have an impact for one time operations such as
creating/writing.
So when size parameters are 0, which is the default, another parameter must be
passed to `image_process` to ensure image validity, and `verify_resolution` is
actually built for this, as it does the minimal amount of processing:
- loading the image
- making sure it is valid
- and ensuring the resolution is not completely crazy (`IMAGE_MAX_RESOLUTION`).
It doesn't alter the original image if no other operation was requested.
Pr: #38292
X-original-commit: e16c36bb4bfa3ae1739712c69c72849665a057dd
Binary fields are supposed to be saved as binary in cache, and not as string
which is also supported as an input value.
Pr: #38292
X-original-commit: 64e0d106adccd8132cbfeb6b60da74b3feaf05e1
The compute methods are always expecting the real value and not the bin_size.
The solution is to always compute with `bin_size=False`, and then manually
compute the `bin_size` and set it on the cache of `bin_size=True`.
PR: #38292
Co-authored-by Sébastien Theys <seb@odoo.com>
X-original-commit: 7744886d6141ca7971d91807d0444c707e10fdf8
Since commit https://github.com/odoo/odoo/commit/dba478332681dd21a39c4a183c002b1cf6e046d2, a survey can have questions with no section
associated, which means 'page_ids' field will be empty.
This prevents to display the analysis results of a survey, as we are
still expecting a structure page/questions. To solve it, if a question
does not have a section associated, we use an empty page instead.
closesodoo/odoo#39087
X-original-commit: 45c2964c1cfd07cabfa6a1a1b8e796bea4c521d7
Signed-off-by: Alex Tuyls <alt-odoo@users.noreply.github.com>
This commit adds a button in the certification card in the profile page.
this button opens the share modal and allows to share to social networks
the course linked to that certification.
Task ID : 1950396
PR #31776
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
This commit prepares the next one. It creates generic main and sub templates
for slide share modal.
In order to be usable for all cases, header and body sub template have been added.
Also and in the same purpose, as the website url can be another url
than the record to share (or if the record doesn't have website_url), this website_url
can be specified separately from the record. Otherwise, the standard behaviour is to
use the record.website_url.
Task ID: 1950396
PR #31776
The analytic account/tags must be set on taxes only when the 'analytic' box is ticked.
closesodoo/odoo#39088
--task: 2089557
X-original-commit: 0ed224048d2d5f7e6c37af42fb8865237b874b94
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
Managers were receiving 2 emails to say basically the same thing. This
commit removes one of those emails ("You have been assigned to ...").
closesodoo/odoo#39058
Taskid: 2067994
X-original-commit: 1dbffeb7dba9ed862d6c62ebd771e7581dd33250
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Before this commit, some views appeared broken on mobile.
We don't consider this as a bug because Odoo is not supposed
to be responsive in Community edition. This feature is only
available on Enterprise.
This commit aims at clarifying this situation by clearly moving
the base requirements to support browsers' responsive to the
Enterprise edition and stating that the Community edition only
targets desktop.
It's important to note that, for technical reasons, some
responsive-related JS/CSS code may still be present in the
Community codebase but they are not meant to provide any
explicit or implicit support for responsive/mobile devices.
Technically speaking, this commit removes the viewport meta tag.
This change will then force the "desktop-like" rendering even on
small screens for the Community edition and will keep the current
behavior (scaling/zooming on small screens) for the Enterprise edition.
By doing this we do not let the users think that something is broken
and must be fixed.
So,
in Community edition, desktop is always displayed;
In Enterprise edition, Responsive Web Design is available.
We also had to adapt a test to be able to apply XPath adding
viewport meta tag in enterprise.
Task ID: 2090202
closesodoo/odoo#38768
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
Currently there are some high-level tests that trigger composer creation,
call or send_mail action. However it is always a good idea to have some
performance tests only for some parts of mail application.
In this commit we also fix some naming and remove unnecessary variables
as a side dish.
closesodoo/odoo#38475
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Somehow followup of dbb6cfdbf8 . Purpose is
to use formataddr from tools instead of manually handcrafting the full
email address format. Indeed the tools one correctly encapsulates and
format name and email.
Task ID 2068986
Before this commit, if the user clicked on a company which have no company logo, the system did not let him create a contact.
opw-2086824
closesodoo/odoo#39054
X-original-commit: e3fe7a9af00b7afa5b03d5dcaac1d8f135cb1ea5
Signed-off-by: Pierre Rousseau (pro) <pro@odoo.com>
Before this commit, the search bar auto focus was already disable
on mobile based on media queries.
But "isMobile" equals false since we force the desktop mode.
To fix this, we use isMobileDevice which doesn't depend on the
resolution.
Task ID: 2090202
In this commit, we introduce "isMobileDevice".
Do not confuse with isMobile.
isMobile:
A frequent use case is to have a different render in 'mobile' mode,
meaning when the screen is small. This flag (boolean) is true when
the size is XS/VSM/SM. It is also updated dynamically.
isMobileDevice:
Mobile device detection using userAgent.
This flag doesn't depend on the size/resolution of the screen.
It targets mobile devices which suggests that there is a virtual keyboard.
Task ID: 2090202
Before this commit, some views appeared broken on mobile.
We don't consider this as a bug because Odoo is not supposed
to be responsive in Community edition. This feature is only
available on Enterprise.
This commit aims at clarifying this situation by clearly moving
the base requirements to support browsers' responsive to the
Enterprise edition and stating that the Community edition only
targets desktop.
It's important to note that, for technical reasons, some
responsive-related JS/CSS code may still be present in the
Community codebase but they are not meant to provide any
explicit or implicit support for responsive/mobile devices.
Technically speaking, this commit removes the viewport meta tag.
This change will then force the "desktop-like" rendering even on
small screens for the Community edition and will keep the current
behavior (scaling/zooming on small screens) for the Enterprise edition.
By doing this we do not let the users think that something is broken
and must be fixed.
So,
in Community edition, desktop is always displayed;
In Enterprise edition, Responsive Web Design is available.
We also had to adapt a test to be able to apply XPath adding
viewport meta tag in enterprise.
Task ID: 2090202
60 is different of 060. The 060 is the correct value for the afip code
in this case (EUR). Apply to all the numeric values in the currency afip
codes.
closesodoo/odoo#38953
X-original-commit: 8c47c7f0342b985287da86f7955a52ef05a6ba0d
Signed-off-by: Josse Colpaert <jco@openerp.com>
Since we are not using document only in invoice by now we remove the
option to incoude receipts.
closesodoo/odoo#38842
X-original-commit: af0703f959357120ec9a8ea674e02faaddfefb85
Signed-off-by: Josse Colpaert <jco@openerp.com>
Have an event in Mexico timezone
As a begin date, choose something in the morning
As a end date, choose 18:00 in that timezone (or later)
in the same day
The end date will be written as the day after at 00:00 in UTC
Before this commit, the event was considered taking more than one day
Also, the rendering on the website took the wrong widget, and did not
transform the UTC dates into their TZ value
After this commit, the event is considered taking place in the same day
The rendering on the website is correct
OPW 2087828
closesodoo/odoo#39060
X-original-commit: 4514ff30e9cc218474dda4519e36cfc983e49fc8
Signed-off-by: Lucas Perais (lpe) <lpe@odoo.com>
Tests can fail when they are run at the moment when `fields.Date.today`
is different from `fields.Date.context_today`.
closesodoo/odoo#39079
X-original-commit: 0405f4a35bcad60fd99b1a05ffc8d9774e9a2829
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Instead of showing a traceback, show a user-friendly error message
to the user to avoid recursive pos.category.
closesodoo/odoo#38803
X-original-commit: babcbf8a2bdf3ea9813705c5fce42e883831e009
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
* Install pos_hr
* Create new user [DEMO] (change password and save the user id)
* In POS session settings, uncheck "Login with Employees"
* Log in with [DEMO]
* Start a new POS session
* From the Employee page delete the record matching [DEMO] user id
* Process a transaction from the POS
Several error message will popup. This is due to
https://github.com/odoo/odoo/commit/26274dbb9720743461be2a70de02bf4c1ea377f4
which introduced a faulty matching between the id of user who start the pos
and an employee with the same id.
Assigning the single properties as before the change fix the issue
opw-2087591
closesodoo/odoo#39052
X-original-commit: c51e91cd755a3dc48bb41378528a39e0df434eab
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
Install Accounting, create a journal entry, post it, reverse it with
a date in the future.
The reverse entry will be posted, instead it should stay a draft (with
the appropriate 'auto_post' set to True)
opw-2083121
closesodoo/odoo#38802
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
On a time off request, if the 'Time Off Responsible' (leave_manager_id)
is not set, then the SUPERUSER_ID is taken as time off responsible for the
validation.
Before falling back on OdooBot, include the parent_id of the employee,
aka the manager, as a valid responsible.
closesodoo/odoo#39041
Task: 2072111
X-original-commit: 1e1b9b4089736ee8f7ef374c663376d040372ffd
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Task 2034073
The reconciliation widget is now entirely part of the enterprise version
as it is an advanced accounting feature
closesodoo/odoo#38424
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
- added CoA
- added standard input/output taxes with rate 17% and few others
closesodoo/odoo#39045
Task: 1966308
X-original-commit: eea6171d6990e98f99f14bb511b5fd08d0c0d7e7
Signed-off-by: Josse Colpaert <jco@openerp.com>
A user get a AccessError during a valid flow on the website shop
due to a attachment search (with website_sale_digital installed) :
- As a portal user buy a product and pay with wire tranfer (or other)
- Check the your quotation with this user and we get a AccessError
for the read ir.attachment model.
The bug comes from the website_sale_digital module which add a search
on ir.attachment for each product (allows digital product sell,
eg. ebook) on the controller rendering orders. To fix this issue, add
a sudo call before the search. It is legit because only the name and
date is retrieved and the download (of the digital product) checks
the access of this product attachment (if user already paid for it).
TASK_ID : 2004031
closesodoo/odoo#39043
X-original-commit: c757e14cb791262485a949eacdcfb2029d03fa5f
Signed-off-by: ryv-odoo <ryv-odoo@users.noreply.github.com>
Description of the issue/feature this PR addresses:
In pivot, when we click on '+', it must open the selection box at
the point where we click.
Current behavior before PR:
The box opens at the top of the page
Desired behavior after PR is merged:
The box opens at the point where we click
id=2066675
closesodoo/odoo#39034
X-original-commit: 989df08fd8bbfa4a1f05784b599b1657a9b28fe5
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Purpose
=======
Let's say that the field 'foo' is tracked and defined with a res.group.
When the field is modified, a mail.tracking.value is generated, but the
reference to the field name is a char field.
When displaying the mail.tracking.values on the chatter, a check is done
according to the field group to decide whether we should display it or not
to the user. See: odoo/odoo@c7aa8c5#diff-ad8b6db158187579d2208f233d993c3cR43
So if I rename the field, and if the mail.tracking.value is not modified,
the mail.tracking.value magically appears to the users who shouldn't
access it before.
Note: If the migration is correctly handled, this shouldn't be the case.
But manual manipulations on the database could lead to this issue.
Specification
=============
If the field referenced by the mail_tracking_value doesn't seem to exist,
then display its value to system users only, by security.
closesodoo/odoo#39033
Taskid: 2088634
X-original-commit: ae1e70eba10112170283cfc17fa95d94dd948d2b
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
When timeoff is 1 day or 0.5 days then it was not going to
correctly display timeoff number on approval page due to momment.
For 1 day leave the date_to and date_from as equal so momment diff will
be 0 days and floating is off for diff so not display 0.5 for floating leave.
even we enable floating it will display the wrong floating based
on 24 hours instead of 8 working hours a day.
so get the number_of_days from db and display on leave same as department
leave summary.
Task-2071031
closesodoo/odoo#39032
X-original-commit: 6953620f507990010c593a0d35d67c81f5b27e47
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
This test was raising an assert error if the DB has other websites than the
data/demo ones.
As we have a new module in Odoo 13.0 (https://github.com/odoo/design-themes/pull/178)
which is creating 25 websites, and since the design-themes runbot is now
running tests, we were having a red design-themes runbot.
closesodoo/odoo#39008
X-original-commit: 5c7b446363fbec7b2a76a579794e0fac20d05271
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Before this commit, the trash icons and "OR" indicator of each filter
was too far and couldn't be seen
Now, both of them are closer to the filter and can be seen in any circumstance.
Task 2073707
closesodoo/odoo#39026
X-original-commit: 87a91c78fb15ee941e72023e02e539de64f0486d
Signed-off-by: Julien Mougenot (JUM) <Arcasias@users.noreply.github.com>
Since 62c9dedafd, when accessing a website
connected as portal or public user, the themes images are not showed. An
error is arose 'Sorry, you are not allowed to access documents of type
'Attachment' (ir.attachment)'.
Now, the portal and public user have access to the themes images.
opw-2082468
closesodoo/odoo#39025
X-original-commit: 9b8c390cd5526556346356f260a9cfe1b90cd510
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
Co-authored-by: Lucas Perais <lpe@odoo.com>
Snippets with side margins look quite compressed between full width
snippets. This commit adds an option in the side-menu to control whether
a section is stretched or not. This option is available everywhere it
would have a reasonable visual impact (the cutoff was arbitrarily chosen
to be that the stretched section is at least 5% larger than the
unstretched version)
task-2080570
closesodoo/odoo#38852
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Martin Trigaux