Before this commit, creating a record of a model with at least one
property/company_dependent field would trigger the field's inverse
method regardless of whether an actual value was being passed in for the
field or not.
This means that if no value was given or if the value was the same
as the default value, we would waste precious time in the property
field's inverse method.
With this commit, we do not call the inverse method if:
1) there is no value for it in the vals dict (use default)
2) the value in the vals dict is the same as the default value
As an example, when creating a res.partner record while having account
installed (which introduces a property field in res.partner), the
creation time goes from 24ms to 14ms.
closesodoo/odoo#36267
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
Purpose is to set review message on both message and rating so that reviews
are correctly displayed in eLearning backend as well as correctly displayed
in chatter frontend.
Task ID 2058595
PR #36281
Creating channels and slides in backend was leading to warnings and/or crashes
because of computed fields not being always updated. With new computed fields
coming from 9920f20e4c this cannot be done anymore.
Task ID 2058595
PR #36281
Purpose of this commit is to
* delete rating when deleting message. Otherwise rating coming from
frontend portal review chatter are lost in the void;
* allow system users to delete ratings;
Task ID 2058595
PR #36281
Commit 9920f20e4c introduced a new field type in the ORM. However
it is not referenced in various JS parts, leading to crashes. Notably list view
of messages and activities crashes.
As this is basically an integer field, easy fix is to use an integer widget
on those fields.
Task ID 2058595
PR #36281
Purpose of this commit is to avoid having error message replacing the
cross used to close the container of the error message.
Task ID 2058595
PR #36281
When creating a picking and selecting an Operation Type, can't no more
select operation type of `mrp_operation`.
Task #2060793closesodoo/odoo#36262
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
When you select a customer in the front end, you can send him an email with the receipt as an image.
If you decided to send the mail and you'd like to print the receipt anyway, you have to click on the
When you're offline, the order will be queued and the ticket printed. You'll receive an error message
When invoicing, the invoice will be in attachment of the email.
TASK-ID: 1922660
closesodoo/odoo#35812
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
An RPC call using an empty array of fields has not the same behavior on
the MockServer and the actual server:
- the MockServer returns only the 'id' field
- the actual server returns all the fields for the model
This is due to the fact that an empty array evaluates to a falsy value
in Python and evaluates to a thruthy value in JavaScript.
This commit restores the parity between the two.
closesodoo/odoo#36278
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
In this commit alignment in bom structure & cost report
display in proper manner.
task-id : 2059697
closesodoo/odoo#36225
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
This commit header is quite fun. If a question is not a question it should
not have a type. Maybe it should not be a question but, hey, you don't always
do what you want. That's life my dear Lucette.
In this commit we remove required attribute from python field definition of
question_type and make it required conditional based. Real questions have a
type, unreal questions have no type.
Alss update Questions menu entry to display only real questions, not unreal
questions.
Most of this commit message makes no sense, but remember who asked to push
this model.
Task 2053833
closesodoo/odoo#35835
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Co-authored-by: Hardik K Prajapati <hap@odoo.com>
Co-authored-by: Mohammed Shekha <msh@odoo.com>
From the user's frontend "My Account" page:
- Try to edit your details.
- Complete the form with all required fields.
- Select a country for which there are no states
(the `state_id` field is hidden)
- And confirm
=> Internal server error
The state was not filled, therefore the value sent to the server
is an empty string. This empty string is used in the UPDATE
query to register the state value. Since it's a string and
not a valid (integer) id, the query fails.
closesodoo/odoo#36272
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Remove old module description because "nobody will ever read this information".
TaskID: BugsLogistics
closesodoo/odoo#36266
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
This commit tries to fix the issue in the "Send Invoice" modal.
Because of this issue, the recipients and body are empty.
task-2032586
closesodoo/odoo#35536
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
The modifications are applied in account, sale and website_sale
- Changed description to "Choose your default customer payment method."
- Removed the "Pay with" from labels in Modal
- In sale: Renamed "Confirmation & Payment" to "Payment Method"
task-2032586
Changes in account views to make them cleaner and
easier to use and understand.
Invoices/Bills tree view
---
- Distinct Invoices tree view from Bills tree view:
In Invoices:
- invoice_vendor_display_name is "Customer"
- invoice_date is "Invoice Date"
- "Payment Reference" is hidden because it's the same
as "Number"
In Bills:
- invoice_vendor_display_name is "Vendor"
- invoice_date is "Bill Date"
- "Source Document" is moved next to "Number"
- Renamed "Payment Status" to "Payment"
- "Payment Status" value "paid" renamed to "Paid"
- Search filters:
- Renamed "Open" to "Posted"
- Added a separator after "Posted"
- Removed "Linked to revoked mandate"
Invoices/Bills form view
---
- Removed "Original vendor bills" from form but kept it in list
and renamed to "Original Bills"
- Renamed state "Unposted" to "Draft"
- "Draft *" titles are now in h1
- Added placeholders and removed tooltips on Payment Terms
- Removed tooltips of invoice date
- Hid Accounting Date on Customer Invoices
because it's the same as Invoice Date
- Rewamped payment info popup:
- Renamed title to "Payment Info"
- Removed right alignment
- Removed Name info
- Reordered info: Amount, Memo, Date, Method
- Added optional to few fields in tab "Invoice Lines":
- Analytic Account: show
- Analytic Tags: show
- Intrastat: show
- Origin Country of Product: hide (and renamed to "Product Country")
- Unit of Measure: show
- Disc (%): show
- Taxes: show
- Added optional to few fields in tab "Journal Items":
- Label: show
- Analytic Account: hide
- Balance in Currency: hide (renamed to "Amount in currency")
- Taxes Applied: hide (moved before debit and renamed to "Taxes")
- Tax Grids: show (moved after credit)
- Due date: hide (moved before Balance in currency renamed to "Due Date")
- Tab "Other Info":
- Renamed sections:
Sales Information -> Invoice
Accounting Information -> Accounting
Payments Information -> Payments
- Website is now hidden if not set and tracked in chatter
Payment form view and modal
---
- State "Posted" renamed to "Validated"
- State "Cancelled" is hidden while module account_cancel
is not installed
- Renamed "Payment Method Type" to "Payment Method"
- Renamed "Payment Date" to "Date"
- Renamed "Payment Amount" to "Amount"
- Renamed "Payment Journal" to "Journal"
- Reordered fields:
Journal Amount
Payment Method Date
Recipient Bank Account Memo
- Payment Difference is now visible only with
accountant access rights.
Journals form view
---
- Removed Journal Groups
- Changed position of "Bank Account"
it's now the first tab
- In "Advanced Settings":
- Renamed section "Accounting App Options" to "Posting"
and only visible when Accounting rights
- "Post at Bank Reconciliation" was a Boolean field and is now a
Selection field with values pay_val for Payment Validation and bank_rec
for Bank Reconciliation.
In form view it's now a radio button.
Removed tooltip of this field.
- Section "Control-Access" is now visible with Accounting Manager rights
- Renamed "Invoice References" to "Payment References"
- Field "Communication Type" value "Based on Partner" renamed to "Based on Customer"
- Reorder sections:
Payment References
Email your Invoices/Bills
Control Access
Purchase form view
---
- In Purchase Order: Field Billing Status is invisible if the status
of the purchase.order is draft/sent/to approve/cancelled
task-2032586
- This commit fixes invoice reports header and footer:
The header was half displayed and "Phone Number" was
displayed on two lines
- This commit also add a link in report preview to go back
to the backend:
When account was the only module installed there was no
link to go back to the backend
task-2032586
- This commit moves the Payment Term "End of Following Month" from
demo data to data and adds two new Payment Terms: "21 Days" and
"30% Now, Balance 60 Days".
It allows the customer to define less Payment Terms
task-2032586
- This commit reorders the configuration menu in the
Invoicing/Accounting app in order to split the Invoicing menu
items from the Accounting ones.
- This commit also restores the Bank Account form view of V12.
task-2032586
Before this commit, leaderboard was displayed only if user was not connected.
As we feel this is very interesting to show we decided to display it in all
cases (either connected or not) on eLearning frontpage. Activating it is
now done using an entry in the customize menu.
Task 2005981
closesodoo/odoo#35791
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Different fixes for Payment Terminals in saas-12.5
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
closesodoo/odoo#36255
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
PURPOSE
Perform a back2basics review of survey to improve daily use, new user
onboarding and labelling.
SPECIFICATIONS
Improve labels of fields and wording in actions. See commit content for proper
specifications.
Reorder some code to better understand module organization.
Order answer lines following question order.
Display section in answer lines form view to better understand question and
answer organization.
Add a correct flag on answer lines and display it in user input embedded
view in order to know which line are correct.
When finishing a certification survey, add an overall correctness circular
graph. Quarters are
* correct
* partially (if multiple corrects answers on the survey);
* incorrect
* unanswered
Questions without points are not displayed in this graph.
LINKS
Task 2039068
closesodoo/odoo#36229
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Before this commit, if user tries to create a new record from a empty
grouped editable list in 'Inventory Report', he/she will get the form
view open which isn't editable.
To avoid that, we remove the group filter if there is no quant, so user
can create a new quant directly in the editable list.
Task #2056651closesodoo/odoo#36221
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Co-authored-by: jip-odoo <jip@odoo.com>
PURPOSE
Perform a back2basics review of survey to improve daily use, new user
onboarding and labelling.
SPECIFICATIONS
When finishing a certification survey, add an overall correctness circular
graph. Quarters are
* correct
* partially (if multiple corrects answers on the survey);
* incorrect
* unanswered
Questions without points are not displayed in this graph.
LINKS
Task 2039068
PR #36229
PURPOSE
Perform a back2basics review of survey to improve daily use, new user
onboarding and labelling.
SPECIFICATIONS
Order answer lines following question order.
Display section in answer lines form view to better understand question and
answer organization.
Add a correct flag on answer lines and display it in user input embedded
view in order to know which line are correct.
LINKS
Task 2039068
PR #36229
PURPOSE
Perform a back2basics review of survey to improve daily use, new user
onboarding and labelling.
SPECIFICATIONS
Reorder some code to better understand module organization.
LINKS
Task 2039068
PR #36229
PURPOSE
Perform a back2basics review of survey to improve daily use, new user
onboarding and labelling.
SPECIFICATIONS
Improve labels of fields and wording in actions. See commit content for proper
specifications.
LINKS
Task 2039068
PR #36229
If no Six Payment terminal is configured, kill eftdvs if it is running.
When removing the configuration for a Six payment terminal, we just
removed the file with the configuration but we didn't stop eftdvs. The
terminal the nstayed connected to this Box even after removing the
configuration, blocking the connection to another terminal.
Commit 2408bef fixed the way a sale order line is considered as mto or
not but did not took the line route or product category route into account.
closesodoo/odoo#36064
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Task 2041865
We want to show a hierarchy to ease the account type selection (hack in the select widget)
BALANCE SHEET
ASSETS
Fixed Assets
Non-current Assets
Current Assets
Prepayments
Receivable
Bank and Cash
LIABILITIES
Equity
Current Year Earnings
Non-current Liabilities
Current Liabilities
Credit Card
Payable
PROFIT & LOSS
Income
Other Income
Expenses
Cost of Revenue
Depreciation
OTHER
Off-Balance Sheet
closesodoo/odoo#36170
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
purpose of this commit is:
- to remove filter and groupby option which are added at the time of fuzzy
search, it was useless as we have separate groupby and filter menu
also it generates the big dropdown menu so it is more confusing.
- align caret icon with the label.
After this commit:
- when user do the fuzzy search then filter and groupby option will not be shown
in the dropdown
task-2036351
closesodoo/odoo#35092
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
Co-authored-by: Mohammed Shekha <msh@odoo.com>
* fix the gevent worker "logging" everything to stderr and ignoring
the logging configuration: passing loggers to WSGIServer means it
uses those loggers instead of writing directly to stderr
* fix the gevent worker logging the wrong client address when behind a
reverse proxy: it would log the client_address, immitate the
behaviour of werkzeug which goes and gets whatever REMOTE_ADDR is
set on the environment, that way it gets whatever update were
performed by ProxyFix (if any)
Fixes#32914closesodoo/odoo#36233
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>
Since changes made in the ORM, we cannot pass anymore string of integer
to many2One. We are now parsing the fields from the formular to
reprensent the integer as integer.
Since changes made on image fields, the "image" field name was not
correct so we renamed it in imgage_1920.
TASK-ID: 2058650
closesodoo/odoo#36219
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
When we are adding a tip, the unit_price of the tip product is changed
on the line, but not the lst_price, that lead to show the difference
between the lst_price and unit_price as a discount on the receipt if the
pricelist is configured to show its price difference as a discount.
So we are now also changing the lst_price.
TASK-ID: 2058650
When the total discount is computed on a receipt, it is computed based
on the the discount applied on lines, and the difference between the
pricelist price and the unit price. But there is an option on the
pricelist that say if you want to show or not the difference. Which is
not respected in this case because in total we always show all discount.
So we are now respecting the policy of the pricelist.
TASK-ID: 2058650
When we are setting a tip product and restricted categories, the tip
product is not available in the POS, so we now force to download the tip
product if tips are set on the POS.
TASK-ID: 2058650
When a snippet is selected, its options are shown in a section named
after the snippet. The name is guessed from the block classes if it
matches those of a snippet or is simply retrieved from the data-name
attribute. The problem is that that data-name attribute was not written
on the DOM but as jQuery data in some case which make them disappear
under some circonstances (like cloning a whole snippet thanks to the
keyboard, etc).
closesodoo/odoo#36217
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Aaron Bohy