Commit Graph
123272 Commits
Author SHA1 Message Date
Thibault Delavallée 2e4ea7c49a [IMP] survey: improve token and answer management
Purpose of this commit is to improve a bit management of user input tokens
and state

 * allow to test closed surveys;
 * better management of answers already filled;

This commit is linked to task ID 1932508 and PR #30508.
2019-01-25 13:12:35 +00:00
Thibault Delavallée 82f5ec044b [IMP] survey: better manage login required and signup
Purpose of this commit is to provide a real signup URL and redirection when
login is required on survey. It depends correctly on current partner state
and auth signup parameters. Redirection is now correctly managed so that
customer will be back on survey with their token.

This commit is linked to task ID 1932508 and PR #30508.
2019-01-25 13:12:32 +00:00
Thibault Delavallée e65bcb24fd [IMP] survey: refine access mode option on survey
Purpose of this merge is to improve access mode and authentication management
introduced at 9771fdfe8f . Purpose of this cleaning is to simplify options and make
them clearer. Instead of a selection with 4 entries we propose to use two
fields on survey model :

 * access_mode: everyone with a public link can access and answer; or only
   invited people;
 * login required: whether people have to login to answer or not;

All main use cases are covered with combination of those two options.

This commit is linked to task ID 1932508 and PR #30508.
2019-01-25 13:12:22 +00:00
Thibault Delavallée c801eecf23 [IMP] survey: access survey through access tokens
Purpose of this commit is to use an access token to access survey instead
of their ID. Routes are updated to use that token instead of the survey ID.
Purpose is to have less discoverable routes and be able to control a bit more
survey access even if it is not really a security parameter.

Some renaming is performed to avoid confusion in terms. Survey token and
answer token are now clearly labeled differently in the code to know which
model we are working on.

Some templates are updated to directly use the answer as base record to
have access to token and test_entry fields instead of giving those parameter
values directly in the controller. It makes some more diff but also allow
easier edition and improvement in templates when having directly survey
and answer record available.

This commit is linked to task ID 1932508 and PR #30508.
2019-01-25 13:11:50 +00:00
Thibault Delavallée 970cb47f57 [IMP] auth_signup: allow direct URL redirection instead of action when computing signup URL
Purpose of this commit is to improve the redirection done after signup.
Currently everything is tailored to create an Odoo action (action, model,
res_id, ...). This action is used to forge an URL that is the redirection
URL after signup. In some cases you would like to directly give the redirection
URL when no Odoo standard action is involved.

An example of use is the redirection when subscribing to take a survey. We
want customers to be back on survey that is a frontend URL, not a backend
URL linked to an action.

This commit is linked to task ID 1932508 and PR #30508.
2019-01-25 13:11:46 +00:00
Pierre Paridans 9f7e6bb798 [IMP] web: Deactivate swipe between form view in mobile
The swipe between the form view is taking too long to load, and the pager is a
more clean option to switch between form view.
Moreover, the swipe on tabs is not clear anymore.

- Deactivate swipe between form view
- Swipe should only be available on tabs when tabs are too long to fit in one screen.

Was originally introduced by https://github.com/odoo/odoo/commit/f4ee61f950dc1eeb7b3653ca96ea72721512b5e5

Related task: 1924764

closes odoo/odoo#30413
2019-01-25 13:02:46 +00:00
David Beguin 3dac18f9e9 [IMP] sale_crm : review quotations and sales smart buttons on opportunity
various improvements and fixes:
    - View quotations was incorrect
        -> should be real quotation view and not SO view
    - Cotation count was incorrect
        -> Should only include Quotations with state='draft' or state='sent'
    - SO button should be visible if number of SO > 0 and not the total amount

Task ID : 1908622
Closes PR #29461
2019-01-23 16:08:35 +00:00
David Beguin 73e9647b06 [IMP] crm : prefill partner info based on opportunity info
If the user is creating a res.partner from the partner_id m2o on crm.lead,
prefill contact information from the opp in it
(email, phone, mobile, street, street2, etc.).

If 'contact_name' is set on crm.lead, the created res.partner should have:
    > is_company = False
    > name = contact_name (from crm.lead)
    > company_name = company_name (from crm.lead)

If 'contact_name' is not set on crm.lead, the created res.partner should have:
    > is_company = True
    > name = company_name (from crm.lead)

Task ID : 1908622
Closes PR #29461
2019-01-23 13:49:54 +00:00
qsm-odoo 04fcbc7b22 [REF] website, *: remove 'web_editor.ready'
* website_event

Following the new editor's merge at https://github.com/odoo/odoo/pull/29775,
'web_editor.ready' was moved to website without being renamed.

Following https://github.com/odoo/odoo/pull/30409, this will remove
that 'web_editor.ready' module.

See upcoming improvements with https://github.com/odoo/odoo/pull/29442

closes odoo/odoo#30548
2019-01-25 11:04:24 +00:00
sed-odoo 37e0c5787a [IMP] l10n_be_hr_payroll_fleet, fleet: Adapt CO2 Tax
Specification
=============

- Adapt the formula used in the code with the current legal value.
- Add the LPG fuel type in standard fleet module.
- Adapt the atn furmula in the code with the current legal value.

closes odoo/odoo#29833
2019-01-25 09:07:19 +00:00
Thibault Delavallée bde36a276e [FIX] survey: fix invite mail template
Purpose of this commit is to improve the recently-introduced mail template
used to invite people to surveys. Containing

 * fix the display of deadline that is not required;
 * correctly talk about survey, not apparaisal;

This commit is linked to task ID 1932508 (side-dish fix).

closes odoo/odoo#30537
2019-01-25 09:21:50 +00:00
Arnaud Baes db1c43649d [MOV] sale_mrp, mrp: compute quantities for kit
The quantities for kits were computed only if sale_mrp was installed.
That's why the override of the method 'compute_quantities' needs to be moved in MRP.

TaskID: 1929518

closes odoo/odoo#30271
2019-01-25 09:00:55 +00:00
Arnaud Baes 8298142574 [IMP] mrp, purchase_mrp: Quantity received for kits in a PO
This commit generalize the method made for computing the quantity delivered in a sale order
in order to be used for the quantity received for a kit in a purchase order.

TaskID: 1929518
2019-01-25 09:00:55 +00:00
Antoine Prieels fae4de5c34 [IMP] mrp: Plan WO in the future
Add possibility to set a Start Date on Manufacturing Orders. Once the user clicks on Plan, the Work Order are planned at the first time available from this date.
When clicking 'Unplan', Work orders are now completely deleted

TaskID: 1889399

closes odoo/odoo#30184
2019-01-25 09:24:09 +00:00
Antoine Prieels 2ad8ebc461 [IMP] mrp: Add test for planning of MO
Check that workorders are planned directly

TaskID: 1889399
2019-01-25 09:24:09 +00:00
Antoine Prieels 43a7087354 [MOV] mrp: Move code from mrp_workorder
Move code that fills in date start and date end on the Work Orders and that does the unplan from Enterprise

Linked to odoo/enterprise#3420
TaskID: 1889399
2019-01-14 13:49:01 +00:00
Dipalee Bhalodia 78ab56e797 [MOV] stock_zebra,stock: Move reports from stock_zebra to stock
All the reports and test file from stock_zebra to stock  and mrp_zebra to mrp

closes odoo/odoo#27676
2019-01-22 11:38:56 +00:00
Robot Odoo 0f6b38b2bc [MERGE][IMP] survey : add datetime format and various improvements
Purpose of this merge is to add support of both date and datetime questions
in survey. Validation and check is added accordingly to current survey
question type support.

In this merge we also add some various improvements

 * Change the default value of the Validation Error message on
   the Date : "The answer you entered is not valid."
 * If long page, click on next and one error, the page should go up
   to allow the visitor to see where the error is.

This merge is related to task ID 1911291 and closes PR #29054.
2019-01-25 10:23:10 +01:00
Antoine Prieels (ANP) 8f486db52d [IMP] mail, snailmail, snailmail_account: improve error management
When a letter is sent through snailmail and encounter an error, it used
to create an activity to the user to notify him that there was an error
with its letter.

When a user had this activity, he didn't have any clues of what was the
error and how to manage it. So we decided to better handle snailmail
errors and give the possibility to the user to easily fix the source of
the snailmail errors.

First to give a better feedback on the letters in errors, we've made
features similar to ones existing for emails:
 - We add a mail message on the document that sent the letter, and put a
   small paper plane icon, which is red when an error occurs (like the
   envelope for email)
 - As letters can be sent in batch, we've also added an entry in the
   systray to easily manage the different documents having snailmail
   errors like for emails.

Then we identified, the most common errors encountered with the
snailmail letters and give proper way to let the user fix them:
 - Missing Required Field:
    - The address is not complete, some of the fields are empty.
    - We open a wizard allowing the user to modify the partner address
      and we try to resend all letters having this error on the modified
      partner.
    - We also try to avoid this error, by opening the wizard before
      sending the letter, but it only works for single documents, not
      for batch.
 - Trial/Credit Error:
    - The user has not enough credits to send letters anymore.
    - We open a wizard that give a redirection lnk to add credits on its
      iap account.
 - No Price Available:
    - The destination country is not supported by any of our providers,
      and we cannot do anything to send this letter.
 - Format Error:
    - The format of the pdf report send by the user is refused by our
      providers, because some visual stuffs are not respected, for
      example blank zone to print barcode or margins.
    - We show a wizard to the user letting him check a setting option
      that add a cover page in the envelope and the documents will be
      send with this extra page containing the address.
 - Unknown Error:
    - This is not one of the listed error above.
    - A wizard suggesting the user to contact support is displayed.

The cron that try to resend letters on error, has been addapted to only
try to send the error of type Trial/No Credit, because the account might
have been reloaded, and other errors, won't change if they have not been
fixed locally.

closes odoo/odoo#29685
2019-01-24 13:36:51 +00:00
RomainLibert 7274c0aa74 [REF] l10n_be_hr_payroll: Replace computed fields
The double holidays and the thirteen months fields are used for the salary
package configurator. But these fields are computed as in a perfect world.

As these values are now available with a specific salary structure,
replace the computed values in the salary package and remove the fields

closes odoo/odoo#30516
2019-01-24 14:35:50 +00:00
RomainLibert 5232670add [IMP] l10n_be_hr_payroll: add Double Holidays/13 Month salary structures
Adds the salary structure for 13th month
Adds the salary structure for double pecule
2019-01-24 14:34:49 +00:00
Yannick Tivisse c89c0e70da [IMP] hr_holidays: Avoid 2 leaves on the same day when changing state
Purpose
=======

There is already a check triggered when we modify the start/end date.

But it's still possible to:
- Create a leave A
- Refuse it
- Create a leave B on the same day
- Reset the leave A in draft state

Specification
=============

The test should also be done when modifying the employee or the state.

closes odoo/odoo#30480
2019-01-24 11:22:46 +00:00
Rohan PatelandLucas Lefèvre 4ba8f51d87 [IMP] hr_expense: improve mail gateaway
1/ Send mail notification if expense is registered successfully

Before this commit, when user submits the expense via email, user is not getting
information about whether expense is registered or not. After this commit user
will get a confirmation email.

Few other usability improvements,
- Improved tooltip for the field 'default_code' in expense's form and in the
'Emails' config setting.
- Added product's default code in product's kanban view
- Filtered uom based on category of product's uom.

2/ Better parsing of expense mail subject

Criteria for matching expense product from email subject is changed,
  - The product code should be the first word of the subject.
  - Only expense products are allowed, previously there was no filter and user was
    able to select any product in expense via mail.

Currency support is added,
  - Now user can specify currency symbols and ISO code in expense mail subject.
  - If subject contains multiple numbers in that case, number with currency will
    get higher priory, and it selected as an amount in expense.
  - If multi currency is active, user can use any active currency symbol/ISO code
    in mail subject. Respective currency will be selected in registered expense.
  - If multi currency is not active, user can only pass company currency. Other
    currencies are ignored and expense will be registered as default company currency
  - If user pass non active currency in subject then that currency will be ignored
    and expense will be registered as default company currency

Examples:
PROD_CODE 2 foo $1205.91 baz

Added python test cases for mail subject parsing.

Related to task #35093
closes #22168

Co-authored-by: Lucas Lefèvre <lul@odoo.com>
2019-01-24 13:08:27 +00:00
Robot Odoo af1728fddf [IMP] hr_payroll_account: Include employee's contract analytic account
If the employee's contract has an analytic account it should be considered for the payroll.
This is actually the way analytic accounts are meant to be used in the payroll, to segregate
information based on specific groups of employees or departments.

This does not override the default behavior, it just uses the analytic account on the
contract if it has it and the salary rule doesn't.

Ticket #1927941
Closes #30119

closes odoo/odoo#30491
2019-01-24 14:29:16 +01:00
Gustavo Valverde 691712eb43 [IMP] hr_payroll_account: Include employee's contract analytic account
If the employee's contract has an analytic account it should be considered for the payroll.
This is actually the way analytic accounts are meant to be used in the payroll, to segregate
information based on specific groups of employees or departments.

This does not override the default behavior, it just uses the analytic account on the
contract if it has it and the salary rule doesn't.

Ticket #1927941
Closes #30119
2019-01-24 12:28:02 +01:00
Yannick Tivisse 0fa32b27c8 Revert "[IMP] hr_payroll_account: Remove unused field"
This reverts commit 89b12e9857.
2019-01-23 18:36:40 +01:00
David Beguin d2ed4ba93d [IMP] survey : add datetime question type
to be able to choose between asking for a date or a date with time,
a datetime question type is now added.

Task ID : 1911291
Closes PR #29054
2019-01-23 13:28:30 +00:00
David Beguin f2e2b6260b [IMP] survey : scroll up to first survey validation error
- Change the default value of the Validation Error message on
    the Date : "The answer you entered is not valid."
- If long page, click on next and one error, the page should go up
    to allow the visitor to see where the error is.

Task ID : 1911291
Closes PR #29054
2019-01-23 13:02:56 +00:00
Deep Patel 4704128dc4 [IMP] point_of_sale : add keyboard events on pos product selection interface
Keyboard Shortcuts: Numbers on the keypads (0 to 9), Backspace and Delete

related to task: #33518

closes odoo/odoo#17162
2019-01-11 08:54:26 +00:00
qsm-odoo a00e6f3dd1 [FIX] website, *: restore 'animation' system to the way it worked
* website_forum

Following the new editor's merge at https://github.com/odoo/odoo/pull/29775,
the website 'animation' system was 'extended' to vaguely use a
'Registry' instance instead of an object. This was however left
undocumented, with a require in the middle of a file, restarting all
animations when used, only used by website_forum... with more code for
no reason at all, ...

This commit restores the system to the way it was before and re-adapts
website_forum:
- No need to check if website_forum is in the DOM as it is already
  checked by the animation system (on top of that... the new code was
  checking the DOM before it was ready...).
- No need of a dynamic add on a registry, this is always done before the
  DOM is ready, so before the animations are started.
- No need to know the root instance in website forum, just use the
  animation as the Wysiwyg instance's parent.

The goal of this commit is also to avoid useless conflicts with
https://github.com/odoo/odoo/pull/29442 (that should not have had any
conflict at all as totally independent of the editor task...)

closes odoo/odoo#30478
2019-01-24 09:48:47 +00:00
Yannick Tivisse 7a2394c631 [IMP] hr_contract_salary: Change the legal/extra legal leaves behavior
purpose
======

In salary configurator, improve the cusrsor to select only extra leaves.

Specification
=============

Specification
==========

Section legal leaves:
- Rename "Legal leaves" into "Extra Time Off"
- change the cursor  0 -> 15

Change the text (rmove completely old one if you go below 20)

In addition to your legal leaves, you can choose any number of extra time off you want. If you worked a full time 12 months last year, you will get a total of  [  27   ]  day(s) off.
The amount of annual time off (legal leaves) you get depends on your work schedule in the previous year. A full-time work schedule through the 12 months of the last year will grant you 20 annual time off (legal leaves)

In yearly advantages (on the right right)
- Cash                          4000 €
- Annual Time Off         20  day(s)
- Extra Time Off             7  day(s)

closes odoo/odoo#30425
2019-01-24 09:47:07 +00:00
qsm-odoo 0be8a1e43e [FIX] portal: remove useless dependency to 'web_editor.ready'
Following the new editor's merge at https://github.com/odoo/odoo/pull/29775,
the 'web_editor.ready' module was moved to website without caring about
where it was used.

Fortunately the only non-website app which uses it is portal in a module
which in fact does not need it.
It would probably make more sense if it was in portal though (see
https://github.com/odoo/odoo/pull/30409) but as an upcoming PR is about
to fix those problems (https://github.com/odoo/odoo/pull/29442), this
can stay in website for now.

closes odoo/odoo#30473
2019-01-24 09:51:00 +00:00
Xavier Morel 92d5a4bce5 [REM] builtin logrotate features
It's completely FUBAR when using workers[0] and properly
reimplementing it is not really worth the effort when logrotate(8) and
newsyslog(8) exist (or cyclog/multilog/cronolog if you subscribe to
the "logrotate and newsyslog are a design that should be consigned to
history" school of thought).

[0] https://stackoverflow.com/questions/34186774/why-doesnt-timedrotatingfilehandler-work-properly-and-how-to-solve-this-issuer

closes odoo/odoo#29073
2018-11-27 14:05:03 +00:00
Christophe Matthieu cb7589aaa5 [REF] website, *: rename and simplify web_editor.context
* website_forum, website_gengo, website_mail_channel, website_sale

Following the new editor's merge at https://github.com/odoo/odoo/pull/29775,
the web_editor.context module was moved to website without being
renamed. This commit renames it to website.context but also merge the
website extension that was made to that context directly within its
definition.

closes odoo/odoo#30409
2019-01-22 17:55:00 +00:00
Christophe Matthieu 6521cf4f66 [FIX] *: review 'frontend' pages init (web_editor.base)
* auth_password_policy_signup, auth_signup, website, portal, survey,
  web_unsplash, website

Following the new editor's merge at https://github.com/odoo/odoo/pull/29775
web_editor.base has been moved to website while it was still used by
frontend pages which do not depend on website (especially portal).

This commit moves web_editor.base to portal while waiting for
https://github.com/odoo/odoo/pull/29442. It also removes the unnecessary
dependencies to it in non-portal pages (in survey for example).
2019-01-22 17:55:00 +00:00
Martin Trigaux c0a7c1b167 [FIX] website_slides: remove outdated file
Was introduced at f6cb0f2308 which was part of #27353
The file was renamed but the original changes are no longer needed (was
odoo-dev/odoo@b9cd8a5712 and odoo-dev/odoo@d3c964d9b1 which cancel each other)
During rebase and squash, the previous version of the file reappear.
Remove it

closes odoo/odoo#30445
2019-01-22 15:50:00 +00:00
Yenthe V.G 2e37b16e1b [IMP] hr_expense: add names for easier xpaths
closes odoo/odoo#27353
2019-01-22 10:30:22 +00:00
Yenthe V.G f6cb0f2308 [IMP] website_slides: add sheet to website slide tag form view 2019-01-22 10:30:22 +00:00
Yenthe V.G a0584efe04 [IMP] website: remove unnecessary group elements (for easier xpaths) 2019-01-22 10:30:22 +00:00
Yenthe V.G 4a8de65cdc [IMP] website_blog: add group names for easy xpaths 2019-01-22 10:30:21 +00:00
Yenthe V.G bcf3b545e6 [IMP] delivery: add name for easy xpath expressions 2019-01-22 10:30:21 +00:00
Yenthe V.G 5d66c74e16 [IMP] resource: add sheet to form views and set group names 2019-01-22 10:30:21 +00:00
Yenthe V.G 63e090a781 [IMP] decimal_precision: add sheet to decimal precision form view 2019-01-22 10:30:21 +00:00
Yenthe V.G 246144ac51 [IMP] base: add sheet and group names on form views
To make the rendering looks better and to make it easier to do xpath
2019-01-22 10:30:02 +00:00
jbm-odoo de7c94a335 [IMP] fleet: Add a parameter to specify the alert delay
Purpose
=======

An alert is sent when the vehicle contract will be outdated in less than a month.

This could be a parameter than could be set on the res.config.

Specification
=============

Use ir.config.parameter in all the cases

Default value is 30 days

Consider 'diesoon' contract as an 'in progress' contract

closes odoo/odoo#29704
2019-01-22 09:44:34 +00:00
Yenthe666 2809fe4258 [IMP] mail: add icon to smartbutton
closes odoo/odoo#29818
2018-12-29 18:54:48 +00:00
qsm-odoo c97f16bece [FIX] website, *: restore media dialog uses
* web_editor, website_blog

Following the new editor's merge at https://github.com/odoo/odoo/pull/29775,
the media dialog was refactored but the code which used it outside of
the editor was not adapted at all. Also, the selected image was not
saved correctly anymore, making the media dialog useless outside the
editor in the current implementation.

- Adapted SEO image uploading and body image background choice which
  were not working anymore
- Adapted blog cover choice and gallery snippet which were strangely
  still working even though there were sending wrong parameters during
  media dialog initialization

closes odoo/odoo#30416
2019-01-21 16:48:31 +00:00
qsm-odoo 86d26ffb88 [FIX] website, *: restore using widgets outside the editor
* web_editor

Following the new editor's merge at https://github.com/odoo/odoo/pull/29775,
the editor dialog and the switches crashed on their use in website.
This is because the merge split some xml files without adapting xml
dependencies... this commit only takes care of code which depended on
'/web_editor/static/src/xml/editor.xml'.

closes odoo/odoo#30408
2019-01-21 13:27:52 +00:00
Demaret Rivarola Johan e2f20ffa93 [IMP] mail: chatter channel notification
Ability to notify the channel but do not add the channel as a follower.
Faster than mentioning every member of the channel.

Also, clean the rendering of the mention suggestions name to avoid
having escaped char in the UI.

Task id : 1859802
Closes #25887
2019-01-21 13:00:10 +00:00
jbm-odoo a3daff6bc1 [IMP] hr_holidays: Rename 'leave' into 'time off' + add dashboard
Purpose
=======

We need to use an international word to define holidays and leaves, rename everything into Time Off.
Employees needs a good dashboard and leaves summary

Specification
=============

1/ Add a new dashboard: https://balsamiq.cloud/sm5j0d/pg5w04r
   Create a new dashboard with a calendar and a summary of all time off and time off request
2/ Rename leaves into Time Off everywhere
3/ Improve general usability

TaskID: 1916871

closes odoo/odoo#29634
2019-01-21 11:29:30 +00:00