Issue:
------
When we want to add a newly-created user
who does not yet have "personal stages" to an fsm task,
it triggers a User Error.
Cause:
------
There's a mistake in the `project_id` field,
which is missing the 's'.
Therefore, when creating the personal stage,
the ORM does not find the value in the context
and inserts the command to set the default project.
As a result, when checking constraints,
we will trigger an error for the
`_check_personal_stage_not_linked_to_projects` method.
opw-3390169
closesodoo/odoo#127694
X-original-commit: 05722c9710f74a073833235de9bbe4743485174a
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Signed-off-by: Thomas Lefebvre (thle) <thle@odoo.com>
The `api.constrains` `_check_name` on `ir.model.fields`
ensures users do not create custom fields not starting with `x_`.
It offers a user-friendly message when users try to do that.
However, this `api.constrains` can be bypassed,
for instance when updating the field name through raw SQL.
This revision aims to no longer load custom fields
if they do not starts with `x_`.
In addition, it replaces the Python constraint
with an SQL constraint in order to have a stronger constraint.
Following bugs or unexpected flows, people
were able to add custom fields not starting with `x_`
with the `api.constrains` alone.
Adding the SQL constraint will tighten the constraint.
However, even without that SQL constraint,
for instance if users drop the SQL constraint manually,
custom field not starting by `x_` must not be loaded.
A user would be able to drop that constraint
through a SQL shell or a `cr.execute` in a server action.
This is to prevent users to override class attributes.
closesodoo/odoo#127702
Related: odoo/upgrade#4908
In this pr https://github.com/odoo/odoo/pull/121601, we did some modification on
the payment form but by doing that we change the label of the menu item.
So this PR will change the menu item back to what is used to be but keeping the
change on the action.
closesodoo/odoo#127626
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
Before this commit, when clicking on avatar of author of an
authenticated visitor in a livechat, it was opening the chat with
this user.
The intended behaviour is to show the profile, as it's quite useful
for livechat. Opening a DM chat is useless, because the livechat
already represents a chat with the person
closesodoo/odoo#127615
X-original-commit: 4eedc234fe19ab681c6a35c2265e9763b2a80760
Signed-off-by: Didier Debondt (did) <did@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Before the task
when the default language for a website is not en_US, and users try to
edit_translations from the website, all terms are marked "translated"
because odoo adds
`data-oe-translation-state="to translate"` if the term is not extracted from
the en_US value and is the same as its en_US term
After this commit:
if the record's bounded website's default language is lang_base
odoo adds
`data-oe-translation-state="to translate"` if the term is not extracted from
the lang_base value and is the same as its lang_base term
closesodoo/odoo#127468
Task-id: 3344973
X-original-commit: 7c20510bda2f1312a9392df445ee38aea7b2267b
Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>
Signed-off-by: Chong Wang (cwg) <cwg@odoo.com>
This commit changes the hex_color param which is not relevant
anymore since we are now using a color_index to make use of
a css class to take advantage of its responsiveness.
Task-3384796
closesodoo/odoo#127677
X-original-commit: a5687eac9115f1c8274f52e6662b23b8ad26f72f
Related: odoo/enterprise#43792
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Before this commit, it was not possible to copy some text content in
chat window with CTRL-C from the home menu.
This happens because keydown events are intercepted by the (hidden)
search bar in the home menu. So when pressing CTRL, the focus is
lost in the chat window.
This commit fixes the issue by not bubbling events from chat window.
Exceptions are inside dropdown, as the keyboard navigation there
make use of the hotkey service that needs bubbling of keydown events.
closesodoo/odoo#127662
X-original-commit: 05d9d3ce1fed0c76d9c85a50e361035a7a81b46b
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
`BroadcastChannel` is not supported in Safari < 15.4.
This commit prevents the crash by not using broadcast channel
if it doesn't work.
A minor inconvenience of not using `BroadcastChannel` API is that
activity data are not synced among tabs. But this is still better
than a crash.
closesodoo/odoo#127660
X-original-commit: f7f7e11ae30d2a5a659b09d913566b0cab95846a
Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
This commit fixes the position of the notification
manager which was wrongly placed in the dom and
caused the notifications to be behind dialog's backdrop.
closesodoo/odoo#127631
X-original-commit: 381d574974bcfe274291628889459148ad741812
Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
Signed-off-by: Michaël Mattiello (mcm) <mcm@odoo.com>
The aim of this commit is to:
- ease the company configuration in DK
- make the feature work when the country_code prefix isn't present
Context:
The DK company registry is the CVR. The CVR is quite the same than the
VAT number.
Re-applied logic used in `l10n_be` to ease the configuration.
Before the commit:
The company registry has to be inputed.
After the commit:
The company registry don't need to inputed while a DK VAT is setup for a
DK company.
closesodoo/odoo#125058
Task-id: 3334595
Related: odoo/enterprise#42561
Signed-off-by: Josse Colpaert <jco@odoo.com>
Refactor CoA modules and maintain separate tax and fiscal position data
- Combine multiple CoA modules into a single module for each country,
as support for multiple CoA support has been improved
- Keep tax declarations and fiscal position templates in separate files
for better organization and maintainability
closesodoo/odoo#116274
Task-id: 3180738
Related: odoo/upgrade#4529
Signed-off-by: Quentin De Paoli <qdp@odoo.com>
Fixup of 5cb044dd8a2385c9a3c09520ed97eb4faa39216d
We should use float_compare when working with float amounts as the
standard == may give wrong results
opw-3389449
closesodoo/odoo#127684
X-original-commit: 91f970fdfd8136e303b7052d690d8997f0278f24
Signed-off-by: John Laterre (jol) <jol@odoo.com>
Websocket instances use `selectors.DefaultSelector` in order to
wait for the socket to be ready for I/O. Gevent replaces the
default selector standard implementation by its own, using
`select.select` by default. The issue is that `select.select`
can only handle fd between 0 and 1023 which leads to select
out of range errors when this cap is reached.
In order to solve this issue, this commit enforces the use of
the `PollSelector` when running in evented mode and when it
is available: `select.poll` does not suffer from the same limit
as `select.select` does.
closesodoo/odoo#127692
X-original-commit: 7e8c0dbe118494c94745ba0fde6290db66d610e2
Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>
Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
Web lacked a default route for /robots.txt meaning that if you didn't
installed website (which comes with a full fledged robots.txt) you would
get a 404 page not found.
closesodoo/odoo#127402
Signed-off-by: Julien Castiaux (juc) <juc@odoo.com>
Add a test that checks that a chart_template reload
when data didn't changed won't delete or create any
records.
Test added retroactively for this fix: https://github.com/odoo/odoo/pull/126830closesodoo/odoo#127685
X-original-commit: 7d78bd2733e9b1aaada0551333bfdf8e7d470c8b
Signed-off-by: William André (wan) <wan@odoo.com>
Steps to reproduce:
- Install 'survey' module
- Create a survey with 2 questions
- Change the sequence of the questions
- Edit the second question (last in the sequence)
- Set it as conditional
- Select first question as trigger (with any answer)
- Duplicate the survey
Issue:
The triggering question is not set on the right question.
Cause:
When copying the survey, we map the old question to the new ones but
there are by default sorted by order of creation and not by sequence
and therefore the mapping is wrong.
Solution:
Order the questions and answers by sequence before mapping them.
opw-3330476
closesodoo/odoo#127681
X-original-commit: 70f7e13c38acd07ea04324bc78e379dac6051e41
Signed-off-by: Nasreddin Boulif (bon) <bon@odoo.com>
Before this commit, fetching mention suggestions
(e.g. with `@mention` in discuss composer) was not
making a silent RPC. This is a minor RPC, so it should
not display a "loading" whenever suggestions are being
fetched.
closesodoo/odoo#127649
X-original-commit: a7ba5365614c3b599bc55e4cb3903a0e89429f7a
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Steps to reproduce
==================
- Install purchase_stock
- Use a mobile viewport
- Go to Purchase
- Click on a record
- Try to set the "Deliver To" field
- Click on a record
-> An action is triggered and the record is not selected
Cause of the issue
==================
[commit] removed the only use of `forceGlobalClick`.
When it is set, KanbanRecord.selection_mode evaluates to true.
Solution
========
forceGlobalClick should be set when selecting a record from the
SelectCreateDialog.
[commit]: https://github.com/odoo/odoo/commit/6e18fb3c35281bdba26d9616150141298975bb40
opw-3337018
closesodoo/odoo#127632
X-original-commit: 7a1db9fade48d231a71084624fa0063989afd2b9
Signed-off-by: Julien Mougenot (jum) <jum@odoo.com>
Signed-off-by: Hubert Van De Walle <huvw@odoo.com>
The buttons on the Mailing Lists page were under the content and felt
weirdly placed. These have been moved up on smaller devices to be next
to the Total Contacts column, making the visual result more balanced.
Note that these buttons are only visible on tablet and desktop, not
mobile.
The buttons' spacings have been fixed so as to not touch one another.
This commit also fixes the padding on either side of the ungrouped
Kanban card to be aligned with the control panel.
task-3378519
part of task-3326263
closesodoo/odoo#127613
X-original-commit: 8c4dbaa37cccda6a5af5e9c5be216e69ecd4227d
Related: odoo/enterprise#43762
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Some buttons were stuck together or some had too much of a gap between
them, this commit aims to harmonize the space between buttons.
task-3378519
part of task-3326263
X-original-commit: 68d16f5b2131f44b2dfc3a5d6756aea8987b3fd5
Part-of: odoo/odoo#127613
Before this commit, when updateBusSubscription was called, it was
postponed to the next event cycle by its first line `await`.
This was needed to avoid registering too many times when adding a large
set of channels: we waited for all channels to be added by the for loop
before actually calling the function.
However, this registered one event per function call. The first one did
the job, and all the subsequent ones did nothing, apart consuming CPU
(sorting the ids and JSONifying them cost memory and CPU).
On Chrome-based browsers, this resulted in a freeze of the rendering if
the number of channels became large (e.g. 600).
With this commit, we make updateBusSubscription a debounced function,
with no delay so that the function gets executed at the next event cycle
like before.
However, the difference is that the debouncing doesn't create a new
postponed call for each call: the function will only get executed once
after the current event cycle, no matter how many times it was called.
closesodoo/odoo#127598
X-original-commit: 2a5c78679875414dcfad7692b660a9c19047485b
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Before this commit, when there were some chat windows open
in desktop, mobile device were displaying the chat windows
at page load.
This was even buggy, because the chat windows are mounted in
a folded state, and it shows only the header of chat window.
The content behind the chat window is visible but we cannot
interact unless the chat window is closed.
This commit makes a few changes to fix the issue:
- Folded state of chat windows is ignored in mobile: the chat
window is fully displayed in mobile even when in "folded" state.
- At page load, server data from chat window state are ignored
in mobile
- Messaging menu in mobile should not display content below:
dropdown in mobile had some margin which displayed some content
below. Fix is to have `m-0`.
- Chat Windows are displayed on top of Messaging Menu in mobile.
In desktop it makes sense it's the other way, because messaging
menu can be toggled when there's a chat window. But it's not
clickable in mobile, and it acts as the previous screen to open
a chat window.
closesodoo/odoo#127597
X-original-commit: 791924d6d1d0e5aff6d9e84844626ac5863c2a88
Signed-off-by: Didier Debondt (did) <did@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
=== ISSUE ===
If you open a list view and group item by, the caret at the beginning of
the row is not aligned.
=== AFTER ===
We had a `align-items-center` class on the container to make sure items
are centered vertically.
task-3398704
part of task-3326263
closesodoo/odoo#127595
X-original-commit: 920cfa51aad26b71884fb0187264a0f65ea4edd0
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Before this commit, 'last_session' inaccurately returned the newest
session, which was incorrect as the first session technically has no
preceding session. This update ensures that `last_session` does not
return any session when it is the first instance.
Also, the computation for the `cash_register_total_entry_encoding`
when the session is closed was incorrect, and it did sum the cash
difference which led to incorrect computation.
opw-3302489
closesodoo/odoo#127572
X-original-commit: cbda861f3c2a2b39490b7148bcbba28f42f66285
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Signed-off-by: Pedram Bi Ria (pebr) <pebr@odoo.com>
Steps to reproduce:
-------------------
- to be in debug mode;
- add a description in an existing task;
- go to Set Defaults in the debug mode;
- add a default description;
- add project id as a condition;
- go to the kanban view of the project;
- create a task;
Issue:
------
Default description is not present.
Cause:
------
The description must be added as a parameter
to the onchange in order to be set to the default value.
The fields passed as parameters are the view's active fields.
Active fields are found during parsing
of the `quick_create_task_form` view arch.
Unfortunately, the latter does not contain the `description` field.
Solution:
---------
Add `description` field to be detected as an active field
of the quick create view.
opw-3381088
closesodoo/odoo#127571
X-original-commit: 0c391e045743128f6d5050204ccd5e18794ca793
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Signed-off-by: Thomas Lefebvre (thle) <thle@odoo.com>
Before this commit, to mark a message as read in Inbox
of Discuss app, we had to click on "More" option and
then select "Mark as Read".
Considering this is a frequently used option in Inbox,
it'd best to have it easily accessible like "Reply".
This commit shows "Mark as Read" as a quick option of
message when in inbox. As to keep at most 3 quick options,
the "Add a reaction" option has been moved to the "More"
menu when in inbox.
Note that Emoji picker requires an anchor, and items in Dropdown
are components therefore they cannot have `t-ref`. To solve this
issue, there's an invisible `<span>` in the quick option list
that is used as anchor for the emoji picker when used from
the "More options".
Task-3412306
closesodoo/odoo#127570
X-original-commit: b9c8fe1759f03952a42c9bee117e718eab3fef08
Signed-off-by: Didier Debondt (did) <did@odoo.com>
Before this commit, message actions were floating on top-right
corner only in chat windows. In mobile, most threads are shown
in a (fullscreen) chat windows. Some exceptions are mailboxes
and chatters in an Odoo view.
As a result, lots of horizontal space is wasted for this action,
so that messages take only half of the screen width.
This commit fixes the issue by using floating visual of message
action list when in chat window or in mobile. That way, when the
width of thread is small, then messages take most of the container
width thanks to actions being in floated layout.
Task-3411797
closesodoo/odoo#127569
X-original-commit: fb100f848388d6e50029a81080e051c77cc057c2
Signed-off-by: Didier Debondt (did) <did@odoo.com>
Prior this commit, the "Settings" title was displayed before
`.o_cp_buttons` when it should be displayed after
This commit also adapts the position of `.o_dirty_warning` so it goes
after the title and can benefits from `.o_control_panel_breadcrumbs`'s
`.align-items-center`
part of task-3326263
closesodoo/odoo#127568
X-original-commit: 169031b8302f935265a36607b0f14c9b5d5ff722
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Currently, the domain editor dialog doesn't handle domains like
[('foo', '=', uid)] if you don't provide the (user) context in the
component props.
Since this kind of domain is expected to work everywhere, the component
now uses the user context by default to evaluate the domain.
There's no need to provide the context everytime the component is used.
closesodoo/odoo#127565
Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
The domain component in readonly mode doesn't display dynamic/contextual
values.
For a domain `[('foo', '=', uid)]` the component displays "foo =" instead
of "foo = uid"
Part-of: odoo/odoo#127565
Before this commit:
EmojiPicker was in separate group as widget.
After this commit:
EmojiPicker should be grouped together.
task-3414175
closesodoo/odoo#127561
Signed-off-by: Simon Genin (ges@odoo) <ges@odoo.com>
=== ISSUE ===
If you navigate to MRP and open a work center, there is a missing gap
between the `back` and `login` buttons.
=== AFTER ===
We add a `gap-1` class to the container to make sure these buttons are
correctly spaced
task-3398605
part of task-3326263
closesodoo/odoo#127558
X-original-commit: 76d54c260504ad53df6b2890552e78526abbf704
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Prior to this commit, the layout of the availability popover was broken.
This commit fixes this issue.
task-3397905
Par of task-3326263
closesodoo/odoo#127557
X-original-commit: 9db9a9b1a08e5d1358fafc423f3ecb93bf08c07d
Related: odoo/enterprise#43727
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Related to commit 45b9e04.
This commit fixes the overflowing status buttons in the MRP module's
Workcenter view. It also adapts the font-size of one of the status
buttons texts in website_slides by wrapping it inside the usual
structure: .o_stat_info > .o_stat_text`.
The same fixes were done for project, stock and sale_timesheet
task-3326558
part of task-3326263
closesodoo/odoo#127555
X-original-commit: odoo/odoo@f0b3806
Related: odoo/enterprise#43726
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
- Fixes tips ticket printing when there are tips after payment.
- Makes the ReceiptScreen opened after TipScreen, to show the receipt screen even when there is a tip added after payment.
closesodoo/odoo#127548
Task-id: 3394214
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
This commit reverts partially https://github.com/odoo/odoo/pull/116388
Intent of commit above was to solve a UX issue when user wanted
to send a message containing an emoji at the end, by using an
emoticon.
For example, user expects to type `:)` then `Enter` to post a message
with happy smiley, but instead it adds the 1st canned response
matching search term `)`.
The solution of commit was to enable canned response only in livechat
and in helpdesk.
However, canned responses are more popular than we thought, and they
are even used in other apps like Project. The users of Project either
use canned responses a lot or never. So it's not a good option to
simply disable canned responses in this app.
This commit make canned responses available in all threads except
`discuss.channel` that are not livechat. In other words, canned
responses are specifically disabled in
- Public discuss channels
- Direct Messages chats
- Group chats
We think that conflicting features canned responses and emoticons
happen mostly in chats.
- Livechat needs canned response so there's still this clash, but
canned response have a lot of value so it's fine for emoticon to
be slightly harder to use.
- Public channels, group chats, and DM chats have no use for canned
responses, therefore disabling canned response makes sense!
closesodoo/odoo#127522
X-original-commit: afdaa5e20e878d01d437d9a23a27cf4685c80448
Related: odoo/enterprise#43713
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
This commit extracts a method called `_parseElementsFromGS1` to allow
customizations of interpreting the parsed gs1 barcode. It also returns
`customProductOptions` which serves as override for the product options
when adding a product to the order.
closesodoo/odoo#127477
X-original-commit: 4c9b8e6c7e465f152fdd64a18cf8ca0d4b00e27b
Signed-off-by: Joseph Caburnay (jcb) <jcb@odoo.com>
Before this commit, only logged notes could be edited in chatter.
With this commit, messages sent with "Send message" are also
editable.
Task-3380465
closesodoo/odoo#125939
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Following the new accounting act of 2023 in Danemark, by checking the list of
taxes we saw that one particular tax was missing and for the other either they
can be associated to existing ones or have minor uses and so no need to add them
Also, we added a mapping for OSS to map in the section "Category B (Not to be
reported for EU sales without VAT)"
I have also changed some name where the translation were a bit shaky.
closesodoo/odoo#125720
Task: 3334595
Signed-off-by: Brice Bartoletti (bib) <bib@odoo.com>
Steps to reproduce:
1. Create a product "My Test Product" (no attribute)
2. Create a quotation, select the "My Test Product" product and confirm the sale order
3. Go back to product and add an attribute "Size" with values "L", "XL"
4. Create another quotation, select the ""My Test Product" product => crash
We consider archived combination of attributes as forbidden combination in
the configurator, but when the archived product doesn't have any attribute,
the `archived_combination` was an empty list, which wasn't supported well
by the product configurator logic (client-side).
To quickly fix this issue, we can simply stop sending empty archived combination
(i.e. when the archived product had no attributes).
opw-3410383
closesodoo/odoo#127335
X-original-commit: ca1ac1a115fe06a0a2d2de0fb131a58019f73631
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
This commit adds a space between the "send" buttons in the Meeting's
form `view_calendar_event_form`. It also removes the `sm-2` class that
seems to be a typing mistake.
task-3326568
part of task-3326263
closesodoo/odoo#127200
X-original-commit: 675f45e046c794cf8e72e3a703c3487cb56839ee
Related: odoo/enterprise#43578
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Thomas Lefebvre (thle)