Commit Graph
129321 Commits
Author SHA1 Message Date
Thibault Delavallée 241453aaec [MOV] website_mail: rename portal related files
PURPOSE

Fix frontend rating and clean a bit module organization

SPECIFICATIONS

In order to ease understanding of portal chatter dependencies let us name
files according to guidelines. In this commit we rename a bit files in
website mail to understand which widgets and portal parts are impacted by
website mail bridge module.

Assets are also moved in their own file to ease module discovering.

LINKS

Task 2057301
PR #35870
2019-08-21 12:50:51 +00:00
Thibault Delavallée 226e21c403 [IMP] website mail: remove useless public channel data
PURPOSE

Fix frontend rating and clean a bit module organization

SPECIFICATIONS

Remove useless mail.channel data as it makes noise without any added value.

LINKS

Task 2057301
PR #35870
2019-08-21 12:50:51 +00:00
ryv-odoo 57d51a4050 [FIX] website_rating: correctly take into account rating ratio in frontend
PURPOSE

Fix frontend rating and clean a bit module organization

SPECIFICATIONS

Currently when updating a review on slides, the rating value is divided
by 2 on each update as the rating ratio is not taken into account. In this
commit we correctly update the hidden input value during the start function
using the rating ratio.

LINKS

Task 2057301
PR #35870
2019-08-21 12:50:51 +00:00
Robot Odoo 59ac728175 [ADD] pos_epson_printer: Use Receipt printer without IoT Box
Linked to odoo/enterprise#5182

Add possibility to print receipts and orders on an ePOS compatible
Epson receipt printer located in the same local network than the
browser running the pos.

TaskID: 2033442

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#35829

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-08-21 17:25:28 +02:00
Hetal Dhanak 9412695d08 [FIX] mrp: cast datetime from web interface
Updating a datetime field in a form view will fill the 'values' dict
with a string.
This commit casts the dates in mrp.production and mrp.workorder that are given to
their respective stock move into actual datetime object. This prevent any
converting error later in the process

Task : 2055912

closes odoo/odoo#35825

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-21 13:45:23 +00:00
svs-odoo 9ff7758c79 [FIX] mrp: can't open workorders from mrp overview
How to reproduce:
- Install mrp & mrp_workorder;
- Open Manufacturing and plan a workorder;
- Go on the Work Centers Overview;
- Click on "WORK ORDERS" button -> You got a "Something went wrong !".

closes odoo/odoo#35900

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-21 11:17:09 +00:00
Hardik Prajapati 8b495f3989 [IMP] mrp: better labels for the fields on the WO to consistency with the MO.
-hide the quantity done when the workorder has not start to work
-change the label of done to consumed when finish workorder

pad- https://pad.odoo.com/p/r.ed6d2ceefdd46214b72dc4e79552350e

task-1889396

closes odoo/odoo#34202

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-21 11:15:14 +00:00
Robot Odoo dc9c3aae96 [MERGE][ADD] project_expense: setting project on expense
This merge commit provide the possibility for project user to select
a project on an expense. Selectable project are only the one with an
analytic account set. Setting the project will set the analytic
account, so posting the expense will create analytic entries, and will
finally appear on the project overview.
If the analytic account still match an open sale order (and if the
product is reinvoicable), a new SO line will be added on the SO (this
flow does not change here).

Task-1843241 (previsouly Task-1911581)

closes odoo/odoo#29638

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
2019-08-21 14:53:47 +02:00
jem-odoo f871908e86 [IMP] sale_expense: cost tracking and reinvoice flow for expense
Since 12.0, we wanted the employee to select directly the sales order on which
the expense should be reinvoiced. The goal was to avoid employee to select the
analytic account (too technical and usually unknown for employee). Problem is
that we had to give read access to SO to simple employee, breaking the access
rules "See your own document".

As we want to allow all internal employees to determine if the expense should
be reinvoice and on which sales order it should be, we need to allow them to
select that sales order.
This commit allows user to search on SO (simply get their name_get), no information
more to avoid breaking "See your own document" for salesman. Falty ir.rule and
access rights are now removed.

We now clearly split the cost tracking and reinvoicing flow:
- the analytic account field (visible only with group 'analytic' as considered
as advance feature) allows user to track their expenses in some accounts.
- the sales order is displayed for users or approvers to reinvoice the expense.
As this operation implies the tracking, if the AA is not give, the SO will create
its own AA in which the expense will be tracked.
This SO field is only relevant when the product has a reinvoice policy, so we hide
it if there is no reinvoice policy defined.

Reinvoicing an expense has now a different flow from reinvoicing a "Vendor Bill",
which still do magic to determine the SO from the AA set on its lines.

Technical:
to allow user to select SO from a m2o dropdown, the `name_search` is done in `sudo`
for internal user. This is a borderline 'feature' of the system. A few thing show
that the system does completely supports this ("Search More" gives access error, ...).
We still keep this solution, as we don't want a sub group giving access to SO to all
employee (aka an option allowing people to break the sales rights).

Task-1843241
2019-08-21 11:22:59 +00:00
jem-odoo 1f77ff3cd6 [FIX] sale: name get uniformize API
This commit makes the override of the `name_search` more
consistent the basic implementation of the ORM (using lazy
name_get and supports the `name_get_uid` parameters)

Task-1911581
2019-08-21 11:22:58 +00:00
jem-odoo 7c5ce75aeb [FIX] analytic: missing depends
This commit adds a missing `depends` on the `debit` and `credit` computed
field on analytic account model. Indeed, without that, the recompute is not
done when accessing thoses fields after adding lines in the same
transaction (like in tests).

Task-1911581
2019-08-21 11:22:58 +00:00
jem-odoo 00ac6c60f6 [FIX] project: portal user can not read AA
For historical reason (problably the inheritS between project and AA, removed in 12.0), portal
user can read Analytic Account. This makes no sense, as it is a purely internal resource
for companies. Removing the access rights don't change anything for portal user and make
those data secure.

Task-1911581
2019-08-21 11:22:58 +00:00
jem-odoo ba92261148 [FIX] sale_timesheet_purchase: correct action xmlid
Since the refactoring of the accounting model, some action changed
but their xmlid were not adapted everywhere.

Task-1843241
2019-08-21 11:22:58 +00:00
Denis Ledoux 4737e01691 [FIX] sale: fix _compute_quotations_to_invoice following odoo/odoo@9920f20e4c
closes odoo/odoo#35895

Signed-off-by: Denis Ledoux <beledouxdenis@users.noreply.github.com>
2019-08-21 09:59:06 +00:00
Alexandre Kühn 8de430d251 [FIX] base: update minifier regexp to rjsmin (1.1.0)
This version adds full support of string templates.
Before this version, rjsmin may produce wrong code with string
templates. For example:

```js
const url = `https://odoo.com`;
console.log(url);
```

was minified to:

```js
const url=`https:console.log(url);
```

Because `//` was wrongly handled as a comment inside the string
template.

closes odoo/odoo#35867

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
2019-08-21 10:22:05 +00:00
jbm-odoo c230cfa0fe [ADD] stock_sms: Integration with stock pickings
The user can already send a confirmation email when the
Stock Picking is done. It'd be great to communicate the
same information by SMS.

In addition, the current mailing tool requires a manual
action. The idea is to automate the process via a
Setting instead.

id=1972567

closes odoo/odoo#35662

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-08-21 10:04:54 +00:00
Pierre Masereel 93be40e6eb [FIX] point_of_sale: download invoice from POS
When you are creating an invoice from the POS, the report route is
called to download the invoice, since changes made in rev: 118190f3b3

The values for ids where empty, so we give them now the correct id list.

closes odoo/odoo#35889

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-08-21 09:59:57 +00:00
Arnaud Baes 2408befc8d [FIX] sale_stock: wrong route computed on so lines
_compute_is_mto was based on the sequence of the routes,
as most of those sequences were hardcoded, some had the same values,
resulting in wrong calculations. Furthermore, the method was setting the so lines
as mto if the sequence of the MTO route had the priority on the other ones, even if
the mto route wasn't set on the product.

This simply ensure to check the mto route is set on the product,
sequences should be set manually to prevent any sequence conflict.

TaskID: 2053703

closes odoo/odoo#35740

Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
2019-08-21 09:51:17 +00:00
Christophe Simonis c1281f5795 [REM] remove empty module test_pylint
closes odoo/odoo#35892

Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-08-21 09:10:02 +00:00
Florent de Labarre 2160db3376 [REM] stock: remove unused code
closes odoo/odoo#35877

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-20 19:54:13 +00:00
Antoine Prieels 380c933a1d [ADD] pos_epson_printer_restaurant: Use Order printer without IoT Box
Add possibility to print orders on an ePOS compatible Epson receipt
printer located in the same local network than the browser running the
pos.

TaskID: 2033442
2019-08-20 12:19:19 +02:00
Antoine Prieels 8ea5583b93 [ADD] pos_epson_printer: Use Receipt printer without IoT Box
Add possibility to print receipts on an ePOS compatible Epson receipt
printer located in the same local network than the browser running the
pos.

TaskID: 2033442
2019-08-20 12:19:19 +02:00
Nicolas Martinelli ddeb7b7cb0 [FIX] account: UK country code
The country code for United Kingdom is GB.

closes odoo/odoo#35828

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-08-20 07:34:37 +00:00
Gert Pellin 118190f3b3 [IMP] point_of_sale, pos_restaurant: multi-user sessions
PURPOSE
=========

When working in restaurants, there are often more than one waiter working on the same floor.
But Odoo doesn't support that.
There can only be one person working on one session for the same tables.
The purpose of this task to allow several people to work on the same session (while synchronizing sessions).

SPECIFICATIONS
===============

- MultiUser is active by default.
- Allow multiple waiters to login on one PoS Config.
- All waiters login to the same session, the waiter that does the paiment is the responsible for the order (same as now).
- Synchonize the information across the multiple instances running on same floors.

Syncronisation will take place at switch of table.
(close tables automaticly if no activity, to force sync)

- Syncro cannot be done if no internet : how do we manage it ? We should inform the user the internet connection has been lost and that synchro cannot be done. What impacts? To check

Useful links
https://github.com/it-projects-llc/pos-addons
https://apps.odoo.com/apps/modules/11.0/pos_bus_restaurant/

Related PR:
odoo#32789

TASK-ID: 1891130

closes odoo/odoo#33973

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-08-19 14:15:25 +00:00
Pierre Masereel 761f695e0d [FIX] pos_restaurant: fix typo
Forgot to remove unused function with pudb in a248171d96

closes odoo/odoo#35822

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-08-19 17:53:02 +00:00
Martin Trigaux 30ab0d3a89 [IMP] base: better default for translation overwrite
Following 43d355c208, same logic
Hide it but make it checked by default

closes odoo/odoo#35819

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-08-19 14:55:57 +00:00
Robot Odoo 9b6a5398df [REF] mrp_subcontracting
This PR modify the subcontracting process:
- Support extra quantity
- No more interaction with the subcontract order. Everything is directly accessible on the operation
- Dropshipping with subcontracting
- Bypass reservation process
- The partner type subcontractor is removed and every partner could be set on the BoM
- Update the initial demand will trigger the rules.
- Demo data
- Subcontractor is required on the BoM (no more BoM for all partners of type subcontractor)

Visually:
- Remove the stat button for linked operation.
- Register Components is only available when a subcontract component is tracked
- Button on operations in order to correct tracked components
- Show Operation button will ask to record components until the total quantity is provided(correction on finish lines are allowed after)

More details available in each commit
Task 1962187

closes odoo/odoo#35738

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-08-19 18:48:35 +02:00
Arnold Moyaux 4055293873 [IMP] mrp_subcontracting: bypass reservation
A subcontracting receipt should be always assigned even
if the components are not deliver. It depends on the partner
and not our company.
2019-08-19 15:03:59 +00:00
Arnold Moyaux c7b947364d [IMP] stock: Hook for reservation
Before a modification on a quant, stock.move and stock.move.line
check if they satisfy the condition to impact the quant.
However in a new module this condition is hardly editable.
The purpose of this commit is to easily add condition to bypass
reservation.
2019-08-19 15:03:59 +00:00
Arnold Moyaux 673450df40 [FIX] mrp_subcontracting: return to subcontract location
Before this commit a returns would select the classic
partner location. However in the case of a subcontractor return
it should be returned to the subcontract location
2019-08-19 15:03:59 +00:00
Arnold Moyaux 5d809fd6b4 [MOV] purchase_mrp_subcontracting -> mrp_subcontracting_account 2019-08-19 15:03:59 +00:00
Arnold Moyaux a684372fdd [IMP] mrp_subcontracting: subcontractors required
Force to set subcontractors on subcontracting BoM since
it's always used in order to determine if a subcontracting
should be apply on a receipt or not. Also there is not magical
behavior has 'if there is no subcontractor on the BoM then it
means all partners...'
2019-08-19 15:03:59 +00:00
Arnold Moyaux 39c5d0f35e [IMP] mrp_subcontracting: cancel subcontract order
A subcontracting receipt cancellation should cancel the
subcontracting order and the associated document.
2019-08-19 15:03:59 +00:00
Arnold Moyaux a3aeabd44d [FIX] mrp: do not base default on active_id
Since active_id do not works allows to use a context
key that will not be modified magically.
2019-08-19 15:03:59 +00:00
Arnold Moyaux d151373941 [REF] mrp_subcontracting: views v2
- nothing tracked
The "register components" button shouldn't appear, the receipt looks normal.
- finished products tracked
The "register components" button shouldn't appear, the receipt looks normal.
- finished products not tracked and components tracked
The "register components" button appear and the burger redirects to "Produce" wizard. The user should record all the productions before being able to access SML through the burger wizard. He cannot force any SML for subcontracted products with tracked components before having recorded all the productions.
- finished products and components tracked
The "register components" button appear and the burger redirects to "Produce" wizard. The user should record all the productions before being able to access SML through the burger wizard. He cannot force any SML for subcontracted products with tracked components before having recorded all the productions.
2019-08-19 15:03:59 +00:00
Arnold Moyaux 1861200315 [IMP] mrp: inline view to ir.ui.view
The purpose is to use it independently from the MO
2019-08-19 15:03:59 +00:00
Arnold Moyaux 5b526e8756 [IMP] mrp_subcontracting: modify initial demand
Modify the initial demand for a subcontract receipt should
update the delivery to the subcontractor.
2019-08-19 15:03:59 +00:00
Arnold Moyaux a6fb45d458 [IMP] stock: allow to skip next activity
Due to subcontracting. Some documents are hidden from the users since
they are there to ease technicaly. However they are linked to useful
documents and we want to avoid to log an activity on them.
2019-08-19 15:03:59 +00:00
Arnold Moyaux cbea919a9a [FIX] mrp_subcontracting: access error on purchase
Usecase to reproduce:
- Validate a purchase_order with a user without group inventory user or manufacturing user.

AccessError on operation read for BoM. A purchase user should be able
to validate an order independently of the documents that will be
generate.
2019-08-19 15:03:59 +00:00
Arnold Moyaux 4c4a7879e9 [ADD] mrp_subcontracting_dropshipping
Allow to do a dropshipping with a subcontractor.
If the product uses the routes drophipping and have
a subcontracting BoM. Then a PO for the subcontractors
will genrate a need in the subcontracting location for
the required components.

A module is needed because the picking_type_id for dropshipping
do not have a warehouse_id. The warehouse_id is needed in order to
know from which warehouse the subcontracting components should be
deliver.
2019-08-19 15:03:59 +00:00
Arnold Moyaux a29d3e5270 [IMP] mrp_subcontracting: common test file
The purpose is to use the global setup in external
module.
2019-08-19 15:03:59 +00:00
Arnold Moyaux d84952159b [ADD] mrp_subcontracting: MTO, not ressuply flow
Test the flow when a product is set as resupply on subcontract
and not MTO, it should be trigger by a reordering rule and not
by a subcontracting receipt.
2019-08-19 15:03:59 +00:00
Arnold Moyaux 7e52a1c28d [IMP] mrp_subcontracting: add demo BoM subcontracting
Add a subcontract BoM for [FURN_8888] Office Lamp with
subcontractors Azure Interior.
2019-08-19 15:03:59 +00:00
Arnold Moyaux 4d5ec8ff12 [IMP] stock, mrp: remove MTO route magical behavior
When a move is created from a location A to a location B and not
via a rule but it wants to apply the rule logic in order to know
if a move is MTS or MTO then _adjust_procure_method is called.

It will check if a rule between A and B for the selected product/
category/warehouse and if it exists it will apply the rule procure
method to the move. If not it will check if the route MTO is ticked,
and will set the move as MTO even if no rule exist. It could be
miss understanding by the user that have moves MTO without matching
rule. It would be easier to have a single proccess with rule.
2019-08-19 15:03:59 +00:00
Arnold Moyaux c3dc552185 [ADD] mrp_subcontracting: lot tracked flow test
Add a test for the following usecase:
- Subcontracted product and components tracked by lot.
- Create a receipt
- Use the register components button in order to prefill quantity
- Correct the final lot on details operation form
2019-08-19 15:03:59 +00:00
Arnold Moyaux 8c2b0a937f [IMP] mrp_subcontracting: partner on subcontract delivery
If the components have the route resupply subcontractor on order then the
delivery order triggered by the receipt do not have the origin nor the
subcontractor partner. This commit update the procurement group in
order to add those information and propagate it.
2019-08-19 15:03:59 +00:00
Arnold Moyaux 875d99812f [FIX] mrp_subcontracting: allow to create lot.
due to commit 108ee65af2a88d61526dc047043138bddc3f9b63#diff-99ad190cf09687f6efdebc1f7636062c
picking type for subcontracting order use field use_create_components_lots
instead of classic picking type.
2019-08-19 15:03:59 +00:00
Arnold Moyaux 33cf89a6c6 [REF] mrp_subcontracting: remove partner type
Replace the type subcontractor on the partner.
Instead replace it by a property for a subcontracting location.
The purpose is to have a simplier configuration. The user would
just need to add the partner on the BoM in order to start a
subcontracting process.
2019-08-19 15:03:59 +00:00
Arnold Moyaux 319ae31860 [FIX] stock: same origin documents
Create two moves with a product MTO and the same SO.
Confirm them. It will generate a new picking without origin.
However the purpose of removing origin on picking is to avoid
an endless enumaration of all documents but if they only have
one origin it should be display.

In this case, the origin was ignored because moves.mapped('origins')
result in a list of ['doc_origin','doc_origin'] and have a length
of 2 because .mapped do not return a distinct set on fields different
than Many2one, one2Many and M2M.
2019-08-19 15:03:59 +00:00
Arnold Moyaux 37200abfc5 [REF] mrp_subcontracting: lot produced/consumed management
Currently, the subcontract picking present multiple difficulties:
- The user has to introduce multiple time the lot produced.
In register components button and then create a new move line with
the show details operation button.
- Same problem with the correction system. The user has to modify the
lot in details operation and then go on the subcontract production and
unlock and edit it.

In order to facilitate those behavior. A move line will be automaticaly
created during the register components process. Also the subcontract
moves for components will be available in the detail operations tab.
2019-08-19 15:03:59 +00:00