Since ea1b3254bb, the phone widget was no more highlighted as it is not contain in a 'span'.
This commit reintroduce the correct behavior for the phone widget.
closesodoo/odoo#33460
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
This commit improves screens usability in the Time Off app.
The following points have been changed:
1. For leaves and allocations, add buttons on the kanban
card to directly approve or refuse if it's not already
validated.
2. On the leave kanban card, only display the dates,
not the full datetime.
3. Add a description to the activity created when a
leave/allocation needs to be approved by someone.
4. Allocation are now sorted in the list view by date_from,
more recent firsts.
5. In the allocation form view, add a stat button to know
how many leaves has been allocated and how many has been taken
for the leave type.
6. In the leave form view, in , there are currently two duration
for managers. The readonly duration is an informative field for regular
employees and the editable duration is meant for managers, it the
number of days needs to be manually set for some reason.
Make sure, the manager only sees the editable duration fields.
7. From "My Dashboard", the creation form view should not be the
manager form view (default view) which has additional unecessary fields
when requesting a leave for yourself (`employee_id`, `holiday_type`, ect).
It's now showing the form view for regular employees.
8. When approving a leave, to make an informed decision, it might
be needed to check leaves already taken by the employee or leaves
of its collaborators. This commit adds a widget displaying some stats
in a leave form view. This widget is only displayed in the context of the action leading
to leaves to approve. Stats displayed are:
- the number of days taken
by the employee this year, grouped by leave type
- Leaves taken by employees in the same department in the current month.
Task 1961713
--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr
closesodoo/odoo#32409
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
When clicking on an activity on the systray, the form
view should be the "approve view" (with the stats widget).
The view loaded by the systray JS is the default view.
Hence the approve view need to become the default view.
A few action that used the default view need to be adapted
since that default view has changed.
When approving a leave, to make an informed decision, it might
be needed to check leaves already taken by the employee or leaves
of its collaborators. This commit adds a widget displaying some stats
in a leave form view. Stats displayed are:
- the number of days taken
by the employee this year, grouped by leave type
- Leaves taken by employees in the same department in the month
of the leave.
This widget is only displayed in the context of the action leading
to leaves to approve.
This commit improves screens usability in the Time Off app.
The following points have been changed:
1. For leaves and allocations, add buttons on the kanban
card to directly approve or refuse if it's not already
validated.
2. On the leave kanban card, only display the dates,
not the full datetime.
3. Add a description to the activity created when a
leave/allocation needs to be approved by someone.
4. Allocation are now sorted in the list view, more recent firsts.
5. In the allocation form view, add a stat button to know
how many leaves has been allocated and how many has been taken
for the allocation leave type. The button redirects to the employee's
leaves of the leave type. Only shown for holiday type 'emloyee'.
6. In the leave form view, there are currently two duration fields
for managers. The readonly duration is an informative field for regular
employees and the editable duration is meant for managers, it's used if
the number of days needs to be manually set for some reason.
Make sure the manager only sees the editable duration fields.
7. From "My Dashboard", the creation form view should not be the
manager form view (default view) which has additional unecessary fields
when requesting a leave for yourself (`employee_id`, `holiday_type`, ect).
It's now showing the form view for regular employees.
Task 1961713
The two fields of leaves `request_date_from` and
`request_date_to` are not set in demo data.
These fields are displayed in the form view and are
empty.
This commit add values for these fields to have
a nice and complete form view.
Purpose
=======
Currently, `resource.calendar.leaves` are ordered
by creation date. In a list view,this is counter intuitive
if leaves are not created in the order in which
they will happen.
Specification
=============
Order `resource.calendar.leaves` by `date_from`
instead of creation date.
Commit ca35f98 change the picking view but introduce an error by
calling 'self'
closesodoo/odoo#33438
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Purpose
=======
Managing people's names is hard.
The full name is stored in a single field.
But is it first name first? Last name first? How many names?
We don't want an onchange to automatically change names
for which we might have spent a lot of energy correctly
formatting in the database.
Specification
=============
Remove the automatic sync between the user's name
and the employee's name when a user is linked to
the employee.
TaskID: 1953003
closesodoo/odoo#32521
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
This commit adds `website_sale_tour` test which is testing the whole ecommerce
flow.
This tour will test b2b and b2c flow using public user, tests website sale
flows with tax included and tax excluded price. Also test address management.
Also, the signup URL needed to be modified as PhantomJS run all tour on domain
127.0.0.1 but ignup button has absolute URL.
Runbot stores next step to be executed on `localStorage` and due to domain
name change during tour execution, it will lose track and runbot will fail.
Closes: #24179
Task-1829827
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Co-authored-by: Ravi Gadhia <rga@odoo.com>
Co-authored-by: Mohammed Shekha <msh@openerp.com>
purpose of this task is do not set default purchase representative in the purchase order when the PO is created automatically.
When the purchase order is created automatically, this purchase order would be assigned to odoobot.
Odoobot is not a real user. so nobody notified any activity of that purchase order.
so keep the responsible field empty when the PO is created automatically.
Purchase manager can easily filter "unassigned" purchase order and he can assign unassigned PO to someone (real user).
Task-1940489
closesodoo/odoo#31729
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
For signature field widget, we can set 'full_name' node option, which can be
used to auto fill the sign. However, current implementation for getting data
for field provided in 'full_name' (mainly, a string) has some flaws.
For example :
-In case of m2o fields, the string is not properly fetched due to different
structure than regular 'input' fields
- In case of x2m views inside a form view, field with same name can exist in
both parent record and child records. This is already the case with form view
of res.partner, where 'phone' field is there in both parent's form as well as
children's kanban view (for field 'child_ids'). With current implementation,
if we add signature on the form view, and set 'phone' as 'full_name' node
option, instead of form view, we will get phone number from 'child_ids'.
This commit improves the behavior by getting data from the 'recordData' instead
of searching them from the DOM. To have recordData in it's latest state, we've
set 'resetOnAnyFieldChange' flag to true.
task-1948364
closesodoo/odoo#33105
Signed-off-by: Martin Geubelle (mge) <mge@openerp.com>
Currently, an editable list view (`editable` set) makes its cells editable. However, if
the attribute `edit=false` is set (from context key or from access right restriction.
See _postprocess_access_rights method of `ir.ui.view` for more details), the list view
should not be editable, but is still.
This commit makes the 'editable' property of the listview checking the `edit` attribute
and provides some tests.
Task-32612
closesodoo/odoo#21613
Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
Co-authored-by: Mohammed Shekha <msh@openerp.com>
- SDD: was put out of circulation in 2007, SDG is now used
- SRG: was replaced by SRD in 2004
- TMM: was replaced by TMT in 2009
- ZMK: was replaced by ZMW in 2012
- ZWD: ZML is now used
Closesodoo/odoo#24521
Task-id: 1823998
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
The purpose of this commit is to clean the user interface of local incoming
mail server and also update the script field default value
and configuration as per new script (from openerp_mailgate to odoo-mailgate).
task-1891157
closesodoo/odoo#33072
Signed-off-by: Martin Geubelle (mge) <mge@openerp.com>
Since c456228fa466982806355475079121f0b45c0166, the compute method was not the good one.
closesodoo/odoo#33414
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
When clicking on 'In Progress', 'To Launch' will open a list view instead it
is needed that, clicking on those links will open tablet view in enterprise and
list view in community.
And also, to remove xpath (from enterprise) because they are not generic
and can only be applied at one element at a time. Instead, a method is defined
by this commit which is overridden in enterprise to open kanban view.
task - 1967745
closesodoo/odoo#32815
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
'batch' and 'batch_size' fields are community fields and their
features are also in community so we moved the form view inherit
that add both fields in form from enterprise to community.
Task 1967745
removed move_id from view to prevent traceback.
added readonly and no_create attribute on account_id to be consistent with
form view.
Task-1974059
closesodoo/odoo#33269
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
After deep comparison between majors versions, it seems that
there is no breaking changes and this fix a lot of issues in
mobile.
e.g.:
Before this update, the validity date wasn't correctly formated
and the end user had to enter the right format himself.
Some users were blocked at the payment process.
The root cause for this issue is the inconsistent list of native
events triggered by mobile devices.
Note that this library is only used for acquirer forms (S2S Form
Template) when "Redirection to the acquirer website" is checked
(payment_flow == 's2s') in the acquirer configuration.
We are aware that this library is deprecated and should be replaced
in the future.
See https://github.com/stripe/jquery.payment
opw-1986545
closes#33356closesodoo/odoo#33376
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
This commit improves the performance of product expiry activities generation.
It also removes direct refs to activity types to ensure code stability in case of user deletion of system data.
The xml refs to activity types should only be used through mail methods to ensure fallback strategies can be managed in the mail module only.
closesodoo/odoo#33300
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
The disconnected/connected notifications were broken due to changes in
the way the Notification template was loaded. We need it loaded in
assets as we cannot load it afterward if the server is disconnected.
This was broken by : https://github.com/odoo/odoo/pull/32793closesodoo/odoo#33252
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
There is now a default groupby for the linktracker
graph, it is grouped by country.
task-1961604
closesodoo/odoo#33181
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Reorganise the categories of the events sorting them by sequence.
Same behavior as "eCommerce Product categories".
task-1917687
closesodoo/odoo#32010
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Since the kanban module refactoring, the module technical name is most of the
time not visible in debug mode. Only module with a very short name leave enough
space for the technical name to be shown (completely).
We can now correctly see the technical name in debug. It will replace the
description (which is not really mandatory in such a mode).
Adding it in top of the description would've break the cell 'height pixel
perfect' looking, thus breaking the layout.
closesodoo/odoo#33374
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Purpose of this task is, some aspects of the CRM searchview
do not make sense with leads so remove those search filters.
add string="Lead" to the name quicksearch
remove partner_id quicksearch
remove lost_reason quicksearch
remove lead/opportunity, won filter as this is irrelevant to lead
remove stage,lost reason, conversation date, expected closing date as it is not related to lead
Task-1941642
closesodoo/odoo#32407
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
This commit introduces the duration (time) units of measures, flagged as internation
unit of measure. We already have the "working time" UoM, but those ones are customizable
and might differ from the International System of Units; indeed, one working day means
8 hours (more or less) for some company.
The rational here is, when we are handling datetime, we need to get the UoM in the Odoo
System to convert the result; for instance, computing the difference between 2 datetimes
will return the number of days (or hours). But you need to match it with an odoo UoM to
extract informations from that value.
This unit of measure 'duration' is like a master data, because existing in the real world
and that many module will depend on.
Task-1971491
closesodoo/odoo#32840
Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
This commit rename the measrurement_type 'time' into
'working_time' to be more precise, as time might means
duration.
This changes prepare the distinction between 'working time'
and international duration unit.
Task-1971491
Commit ca35f98 change the picking view but introduce an error by
calling 'self'.
closesodoo/odoo#33361
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
The lunch application works fine, but some usability points need to be
improved in order to have a smoother onboarding.
These include:
Making lunch location tree view editable, instead of having to use the form view
Auto filling partner details from vendor form
Fixing typos in various labels
Add a name field on lunch.alert instead of using the message as _rec_name
Adding a stat button on lunch category to see the associated products
Task 1942776
closesodoo/odoo#33091
Signed-off-by: Romain Libert (rli) <rli@odoo.com>
This commit changes the presentation of the "Create new course"
modal so that it is closer to what we have in backend
task id: 1978734
closes: #33119
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Purpose: make some methods from mail.thread mixin private and update their
naming if necessary. Some methods prepare data for business flows and deal
with internal information. Public methods should either use of give some
access to those methods. Computation itself should be keps internal.
Another purpose is to prepare blacklist and bounce management improvements
by improving blacklist mixin. It is now reflected on models and build on
top of mail.thread. It is renamed to mail.thread.blacklist to be coherent
with mail.thread and mail.thread.cc mixins.
Related to task ID 1911679
closesodoo/odoo#29483
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
* mail.blacklist.mixin now clearly make inheritance on mail.thread. Indeed
we consider models using the blacklist mechanism as being used in mailing
features, meaning they will anyway inherit form mail.thread. In standard
Odoo it is the case for the 3 models using it (Lead/Opportunity, Contact
and Mailing Contact);
* define message_bounce directly in mail.blacklist.mixin. Bounce counter
is indeed linked to the blacklist and mailing mechanism;
* rename mail.blacklist.mixin to mail.thread.blacklist to ensure coherency
with mail.thread and mail.thread.cc (another mixin build on mailL.thread);
Inherit declarations in various addons are updated accordingly.
Related to task ID 1911679
Linked to PR #29483
Like already done for some mail mixins
* mail.thread reflected on ir.model: see 1119fdd8a3c7fb0a18b348c4724d71eebf53a28e;
* mail.activity.mixin reflected on ir.model: see f48021846a2b54d84d4317b40fa7128f76c28d10;
We allow to reflect the mail.blacklist.mixin on ir.model in this commit. This
inheritance imply the mail.address.mixin to allow normalization of emails on
models using the blacklist mixin.
It is useful notably to clearly store this inheritance and also allow
future tweaking through studio to enable more advanced mail capabilities
to custom models. Blacklist is useful when dealing with mass mailing and
marketing automation.
It will also be used in mailgateway to find all blacklist-related models
in Odoo and update the blacklist accordingly to the bounce and error
management in the mailgateway. Those improvements will come soon.
Related to task ID 1911679
Linked to PR #29483
Purpose: make some methods from mail.thread mixin private and update their
naming if necessary. Some methods prepare data for business flows and deal
with internal information. Public methods should either use of give some
access to those methods. Computation itself should be keps internal.
In this commit we put message_get_suggested_recipients as private. As it is
used in discuss JS we define a controller that controls access to this method.
It explicitly checks for related document access rule and rights before
calling the private method.
Some addons are updated accordingly to the method change.
Related to task ID 1911679
Linked to PR #29483
Purpose: make some methods from mail.thread mixin private and update their
naming if necessary. Some methods prepare data for business flows and deal
with internal information. Public methods should either use of give some
access to those methods. Computation itself should be keps internal.
In this commit we put message_receive_bounce as private. Future commit(s)
will probably rewrite part of the bounce logic.
Some addons are updated accordingly to the method change.
Related to task ID 1911679
Linked to PR #29483
Purpose: make some methods from mail.thread mixin private and update their
naming if necessary. Some methods prepare data for business flows and deal
with internal information. Public methods should either use of give some
access to those methods. Computation itself should be keps internal.
In this commit we put message_get_default_recipients as private. Its API
is improved to clearly separate model-inherited method (overriden in some
addons) and general tool method given by the mixin. Finally all sudo hidden
in the computation are removed. Caller now give a sudo-ed record set in order
to be more explicit. Low level method just computes the result and does not
care about sudo-ing or ACLs.
Note a model approach for this method is necessary as mass mailing using
mail.template records does not ensure records to check inherit from mail
thread.
Some addons are updated accordingly to the method change.
Related to task ID 1911679
Linked to PR #29483
Purpose: make some methods from mail.thread mixin private and update their
naming if necessary. Some methods prepare data for business flows and deal
with internal information. Public methods should either use of give some
access to those methods. Computation itself should be keps internal.
In this commit we put message_partner_info_from_emails as private. As it is
used in discuss JS we define a controller that controls access to this method.
It explicitly checks for related document access rule and rights before
calling the private method.
Some addons are updated accordingly to the method change.
Related to task ID 1911679
Linked to PR #29483
Pierre Rousseau