Commit Graph
129958 Commits
Author SHA1 Message Date
Thibault Delavallée 1dbeaddeae [FIX] website_profile: fix another broken image thingy
As image fields have been renamed recently [1] we have to update controllers
of profile in order to write on image_1920, not image anymore.

Task 2067872 (eLearning internal testing)
Task 2058598 (survey internal testing)
PR #36756

[1] See 58a2ffa26f
2019-09-13 10:05:15 +00:00
Thibault Delavallée 65c3be37fd [FIX] survey: set email_from on certification mail template
Otherwise public users cannot receive their certification. Indeed email_from
will be the one of public user which is probably not set.

Task 2067872 (eLearning internal testing)
Task 2058598 (survey internal testing)
PR #36756
2019-09-13 10:05:15 +00:00
Thibault Delavallée e3828ec9cd [FIX] survey: fix another crashing computed field
Still due to some recent ORM changes: finding a real ID, assigning values
even in create mode with default values.

Task 2058598 (survey internal testing)
PR #36756
2019-09-13 10:05:15 +00:00
Thibault Delavallée 93c6f77799 [FIX] mail: remove channel and partner default context keys when creating followers
Purpose of this commit is to avoid conflicts when creating new followers
with existing context keys. Indeed some actions may propagate a default
partner id or channel id that is not wanted. Example if when inviting someone
on a slide.channel in eLearning, a default_channel_id is set in context
that clashes with follower creation, thinking it is a mail.channel.

Task 2067872 (eLearning internal testing)
PR #36756
2019-09-13 10:05:15 +00:00
Pierre Masereel a96048afcc [FIX] delivery: remove radio button
This commit (https://github.com/odoo/odoo/commit/6173dd21415ab441caaf4404bf812ce2413e29f0) put a radio widget on the carrier selection
which makes no sense, so we removed it.

closes odoo/odoo#36824

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-09-13 08:41:46 +00:00
Martin Trigaux 19e50ea374 [FIX] tools: do not translate selections with _translate=False
If a model is tagged with _translate=False, it should not be translated.
A special case was made for ir.model.fields but not ir.model.fields.selection

Before this commit, the selections of web_editor.converter.test were translated

closes odoo/odoo#36576

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-09-09 14:57:15 +00:00
RomainLibert 5d2021e79f [FIX] hr_holidays: fix time off copy
closes odoo/odoo#36822

Signed-off-by: Romain Libert (rli) <rli@odoo.com>
2019-09-13 08:00:42 +00:00
RomainLibert d37e03cc67 [FIX] l10n_hr: fix typo
closes odoo/odoo#36820

Signed-off-by: Romain Libert (rli) <rli@odoo.com>
2019-09-13 07:50:25 +00:00
qsm-odoo ee33597ec9 [IMP] website: vertically center the images in gallery slideshow
Note: the design of the whole snippet should be improved

Part of https://github.com/odoo/odoo/pull/36803
task-2070930

closes odoo/odoo#36803

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-09-12 16:31:57 +00:00
qsm-odoo 4c7c8e32b5 [FIX] web_editor: remove double highlight border on selected image
Probably due to some revert fail of the new/old editor.

Part of https://github.com/odoo/odoo/pull/36803
task-2070930
2019-09-12 16:22:56 +00:00
qsm-odoo d394b9f087 [REF] website: only show relevant option according to gallery mode
Refactor the whole _setActive method of the gallery snippet option and
make sure only relevant options are shown (for example, disable the
column option in slideshow mode or the interval delay for masonry mode).

Part of https://github.com/odoo/odoo/pull/36803
task-2070930
2019-09-12 16:22:56 +00:00
qsm-odoo 9bac0a917b [FIX] web_editor: fix overlay cover on infinitely animated elements
Before this commit, the overlay cover operation was deferred while an
animation was ongoing on the target element. The problem was that the
animation end event is not triggered if the related DOM is removed
before the animation ends... or simply if the animation is infinite.
When this occured, the overlay never appeared.

Note: this could probably be backported if the need rises.

Part of https://github.com/odoo/odoo/pull/36803
task-2070930
2019-09-12 16:22:56 +00:00
qsm-odoo de97b1ca42 [FIX] website_blog: do not preview "number of blog posts" options
Only re-render with the chosen number on click, not on hover.

Part of https://github.com/odoo/odoo/pull/36803
task-2070930
2019-09-12 16:22:56 +00:00
qsm-odoo 74c54405ef [FIX] website_blog: restore 'choose a blog' for latest posts snippets
The option was broken since its UI is generated in JS and was not
adapted to the new editor UI.

Part of https://github.com/odoo/odoo/pull/36803
task-2070930
2019-09-12 16:22:56 +00:00
RomainLibert 2b34d22b42 [IMP] hr: add note field on hr_plan_activity_type
We would like to have a custom note on plan activities

closes odoo/odoo#36796

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-09-12 14:31:16 +00:00
RomainLibert 9ef2157d17 [IMP] lunch: location multi company
closes odoo/odoo#36331

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-09-04 07:26:43 +00:00
RomainLibert ba8bdcfaf2 [IMP] lunch: improve lunch again 2019-09-04 07:26:43 +00:00
Pierre Masereel e09d7d1b25 [FIX] pos_discount: get price based on total without tax
When you are applying a discount, the base amount is the one tax
included which is wrong as we'll apply the tax of the discount product
on it. So we are basing the discount computation on the total without
taxes and then apply the tax configured on the product.

It doesn't work with multiple taxes, but will be handled in future
developement in odoo.

closes odoo/odoo#36798

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-09-12 14:17:50 +00:00
Raphael Collet 492e4cc5a1 [REF] fields: setup and use of depends_context
closes odoo/odoo#36795

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
2019-09-12 14:24:58 +00:00
wan 956338f28a [FIX] account: manage multi-company for accrual wizard
Before, it was possible to select lines from different companies and create a line from a yet different company. This is now forbidden.
Also, add tests to ensure only the account is changed when creating an accrual entry.

closes odoo/odoo#36751

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-09-12 09:31:53 +00:00
Odoo's Mergebot 4926f03e6f [MERGE] mail: improve record creation with batch operations
PURPOSE

Optimize record creation in mail module by adding batch operations.

SPECIFICATIONS

Compute default followers once at creation for all created records. As the
same value is computed for each new record computing it once is sufficient.

Log default creation message in batch when having no specific subtype at
create. It allows to speedup record creation. For 1000 records, these specific
lines take
  * 2.1s before the commit
  * 1.2s after the commit

LINKS

PR #36654
Task 2070602

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-09-13 10:44:22 +02:00
Odoo's Mergebot 5dc97ee7da [MERGE] sms, mass_mailing{_sms}: implement YAB2B
PURPOSE

Once SMS Marketing has landed, a few comments/reviews to improve the interface,
clarify buttons and actions and ease the onboarding.

SPECIFICATIONS

[FIX] sms - mass_mailing: fix some bugs
- Cancel button in the sms form view not related to a action :
When we click on the cancel button of the sms form view, get traceback.
Fix the issue by adding the cancel action in sms model.
- Mass mailing contact - False as the display name :
The display name was the mail address but when the contact didn't have
mail address a ugly False was print to described the contact (form view).
Then change the _rec_name to print the name as the display name.
- Fix SMS composer for the res.partner tree
Only the first record was truly selected when open the sms composer
(mass) from the tree view of partner. Fix that by bind the actives_ids
in the context and also fix the names of related actions.

[IMP] sms: allow to preview a sms template
Add a way for the user to preview sms content from a sms
template depending of a record (targeted model) and the
installed languages (as for the mail template). Add button
to open this preview on the form of the sms template.

[IMP] sms: allow to create a sms context action from template
In the SMS template, we add the ability to create (and remove)
a contextual action on the targeted model from a sms template.
We change the sms composer to guess the composition mode,
and then to be usable by contextual action. The guess composition mode
works differently if there are multiple target
selected (mass) or a single target (comment).

[IMP] (sms_)mass_mailing: improve interface
- Change the name of "Mass SMS" by "SMS Marketing"
- Improve the Mass Mailing views (kanban, form)
- Improve the Mass SMS views (kanban, search, form)
- Hide the sanitized numbers from views (sometime replace by mobile)
- Fix demo data of sms
- Explain the language field of sms template
- Improve the render of the sms composer wizard

LINKS

TASK_ID : 2053631

closes odoo/odoo#36286

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-09-13 10:44:08 +02:00
ryv-odoo 8e2da3b4d6 [IMP] (sms_)mass_mailing: improve interface
- Change the name of "Mass SMS" by "SMS Marketing"
- Improve the Mass Mailing views (kanban, form)
- Improve the Mass SMS views (kanban, search, form)
- Hide the sanitized numbers from views (sometime replace by mobile)
- Fix demo data of sms
- Explain the language field of sms template
- Improve the render of the sms composer wizard

TASK_ID : 2053631
2019-09-12 14:53:44 +00:00
ryv-odoo e4afa5d6d0 [IMP] sms: allow to create a sms context action
In the SMS template, we add the ability to create (and remove)
a contextual action on the targeted model from a sms template.
We change the sms composer to guess the composition mode,
and then to be usable by contextual action. The guess compostion mode
works differently if there are multiple target
selected (mass) or a single target (comment).

TASK_ID : 2053631
2019-09-12 14:53:44 +00:00
ryv-odoo 076e71cb5b [IMP] sms: allow to preview a sms template
Add a way for the user to preview sms content from a sms
template depending of a record (targeted model) and the
installed languages (as for the mail template). Add button
to open this preview on the form of the sms template.

TASK_ID : 2053631
2019-09-12 14:53:44 +00:00
ryv-odoo 8ef1543908 [FIX] sms - mass_mailing: fix some bugs
- Cancel button in the sms form view not related to a action :
When we click on the cancel button of the sms form view, get traceback.
Fix the issue by adding the cancel action in sms model.

- Mass mailing contact - False as the display name :
The display name was the mail address but when the contact didn't have
mail address a ugly False was print to described the contact (form view).
Then change the _rec_name to print the name as the display name.

- Fix SMS composer for the res.parnter tree
Only the first record was truely selected when open the sms composer
(mass) from the tree view of partner. Fix that by bind the actives_ids
in the context and also fix the names of related actions.

TASK_ID : 2053631
2019-09-12 14:53:44 +00:00
wan f97c902847 [FIX] account: multi-company CoA installation
With the changes in the ORM, the method _compute_has_chart_of_accounts is now also called after the create, erasing the value of chart_template_id.
We cannot set that field as related to the company because set_values checks if the value changes and it wouldnt be the case if we already changed it at the validation of the config form.

So this commit checks if there is already a value before setting the default.

closes odoo/odoo#36780

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-09-12 14:51:33 +00:00
sri-odoo 94b3e339ba [REF] web: extend ui colours
closes odoo/odoo#36781

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
2019-09-12 12:45:53 +00:00
Raphael Collet 5450f03038 [FIX] product: cannot order by many2many field
closes odoo/odoo#36789

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
2019-09-12 13:53:12 +00:00
Raphael Collet 2cfdb12cb0 [FIX] website_hr_recruitment: cannot order by non-stored field 2019-09-12 13:53:12 +00:00
Raphael Collet 2ac4f2ee0f [FIX] purchase_requisition: cannot order by non-stored field 2019-09-12 13:53:12 +00:00
Raphael Collet 8546d07d0f [FIX] mrp_subcontracting: cannot order by many2many field 2019-09-12 13:53:12 +00:00
Raphael Collet 558d675529 [FIX] crm: cannot order a model by a non-stored field 2019-09-12 13:53:12 +00:00
Yannick Tivisse 1b454088e6 [FIX] models: warn on ignored fields in "order by" 2019-09-12 13:53:12 +00:00
Mathieu Duckerts-Antoine b39affc496 [FIX] web: click on an embedded pivot view cell does not causes a crash
The custom event 'open_view' triggered by the pivot
renderer was not stopped in the pivot controller. This
used to cause a crash because the dashboard controller
also listens to a custom event with the same name but
following another logic.
The present fix simply stop the propagaton of the event.
A test has been added in the module web_dashboard.

closes odoo/odoo#36466

Signed-off-by: Géry Debongnie (ged) <ged@openerp.com>
2019-09-12 13:09:35 +00:00
Raphael Collet 44ea2adda7 [FIX] fields: conversion of Many2oneReference value
The value of that field can be given as a dict containing the fields of
the corresponding record.

Co-authored with Michael Mattiello <mcm@odoo.com>

closes odoo/odoo#36779

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
2019-09-12 12:23:55 +00:00
Xavier ALT 21fa7ca76f [ADD] base: add Luxembourgish language
Add luxembourgish language code in order to be able to translate terms
for that language in Odoo.

closes odoo/odoo#36757

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-09-12 12:12:17 +00:00
Kaushalya Mandaliya 710406e935 [IMP] website: UX improvements in Optimize SEO Dialog
Added cursor pointer when hovering a keyword in Related Keywords and
added relevant tooltip for the better user experience.

Renamed classes:
js_seo_keyword_suggestion -> o_seo_keyword_suggestion
js_seo_suggestion -> o_seo_suggestion

task-2070946
closes odoo/odoo#36709

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-09-12 10:58:57 +00:00
Sébastien Theys c8f2924c66 [IMP] mail: use _message_log_batch in create
For 1000 records, these specific lines take:

- 2.1s before the commit
- 1.2s after the commit

Almost 2 times faster.

PR: #36654
Part of task-2070602
2019-09-12 08:45:51 +00:00
Sébastien Theys 665c1035fc [IMP] mail: call _add_default_followers only once in create
There was no reason to call the method many times in the loop as its result
does not depend on `vals_list`.

PR: #36654
Part of task-2070602
2019-09-12 08:45:50 +00:00
Sébastien Theys 35ccc8bb06 [IMP] test_mail: update query count to reflect improvements
Set threshold to actual values since these have not been updated after recent
improvements.

PR: #36654
Part of task-2070602
2019-09-12 08:45:49 +00:00
Pierre Masereel dc2e990aec [FIX] delivery: get correct carrier for invoicing policy
The carrier argument passed to the _create_delivery_line function
can be different to the carrier already existing in the sale order
so we should use the correct setting of carrier where we are calling
the function.

closes odoo/odoo#36424

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-09-12 05:28:49 +00:00
Joseph Caburnay 26b692cbe2 [FIX] delivery: warning message in the delivery wizard is not updated
When a warning is generated when rating a delivery method, the warning
message remains when changing to a different delivery method that isn't
supposed to give a warning.
2019-09-12 05:28:49 +00:00
Joseph Caburnay bdb1ce15f2 [FIX] delivery: delivery line is not set to zero cost
If the chosen delivery method has free_over active, and if the cost
of the sale over exceeds the free_over amount, the delivery line
should have price_unit of zero.
2019-09-12 05:28:49 +00:00
Ivan Yelizariev c0a897d528 [IMP] point_of_sale: get login_number in the same transaction as update it
Otherwise, if two POS stations are using the same user with the same pos.config,
i.e. create two session AND if you have bad luck, then those sessions will get
same login_number, which leads to losing half of orders, because POS stations
will generate same pos_reference and only first order from the POSes is saved,
while another order is lost without let know to cashier.

closes odoo/odoo#24486

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-09-12 11:36:39 +00:00
Raphael Collet bf8d288d04 [FIX] base: simplify computation of commercial_partner_id
The computation was using an SQL query to speed it up, but the recent
changes in the ORM have made this optimization useless.

We have benchmarked an import of 10000 partners linked to the same
parent, in a database with Sales and Stock installed.  The import is
slightly faster without the SQL query (7 min vs 8 min).

closes odoo/odoo#36768

Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
2019-09-12 10:28:55 +00:00
RomainLibert 3b08cd15b1 [FIX] l10n_hr: add internal_type to account type
closes odoo/odoo#36742

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2019-09-12 07:35:41 +00:00
wan 4d38d04d81 [FIX] account: width of scrollbar in account searchpanel
When there is a lot of data to be displayed in the searchpanel, the scrollbar appears. The with of the scrollbar takes too much space compared to the width of the custom searchpanel.
This commit reduces the size for Chrome and Firefox >= 64

closes odoo/odoo#36758

Signed-off-by: Cedric Snauwaert (csn) <csn@openerp.com>
2019-09-12 09:29:01 +00:00
Julien Castiaux 51a602824c [FIX] account: inherits key is define in the backend
Install Account, do an invoice, send and print it. Install
snailmail_account, do the same process. The wizard refuses to send the
email because the Compose field is empty.

The `account.invoice.send` model is defined with an `_inherits` to
`mail.compose.message` on the `compose_id` key. When the model is first
created, that `compose_id` key is left unpopulated on the view as the
referenced model is not created yet. Hence posting the view is
impossible as it fails the form validation.

closes odoo/odoo#36715

Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
2019-09-12 07:46:39 +00:00
Joseph Caburnay 25b7494e77 [FIX] point_of_sale: make the email button behave as the invoice
This commit makes the email button to behave consistently with the
invoice button. Basically, if there is no selected customer when
invoicing, the UI should direct the user to select a customer. This
behaviour is implemented with the email button with special check on the
validity of the customer email.

closes odoo/odoo#36681

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-09-12 08:21:44 +00:00