The Send/Send & Print button is accessible in list view, the wizard
should raise an error if it is opened with invoices in "draft" state.
closesodoo/odoo#138311
X-original-commit: cbc0972bb3eaddf88131b0153f364d1a65d0a968
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Signed-off-by: Claire Bretton (clbr) <clbr@odoo.com>
Steps to reproduce:
-Install sale_purchase_stock and sale_product_matrix
-Have a Service product that is subcontracted.
-Set a variant with a Specification Attribute that has a custom value.
-Create a sales order with the Service product,
add anything for the specification in the variant.
-Confirm the order, this generates a PO.
Bug:
The PO line only says the name of the product,
and doesn't include the specification in the variant.
Fix:
propagate the description same as:
"_prepare_procurement_values" and "_prepare_purchase_order_line_from_procurement"
opw-3438125
closesodoo/odoo#138310
X-original-commit: 5b3bcee8f7308621608d91e33bac808586e8c17f
Signed-off-by: Walid Hanniche (waha) <waha@odoo.com>
Signed-off-by: Quentin Wolfs (quwo) <quwo@odoo.com>
Versions:
---------
- saas-16.4+
Steps to reproduce:
-------------------
1. create a customer invoice;
2. set customer to be a person (not a company);
3. set a due date instead of payment terms;
4. click preview.
Issue:
------
The invoice will say "Payment within 30 calendar days" regardless of due
date selected.
Cause:
------
This is a placeholder string for a `t-field` that should be hidden when
viewing actual records.
Solution:
---------
Add `t-if="o.invoice_payment_term_id.note"` to the element so it won't
get rendered if there are no payment terms to be displayed.
opw-3523921
closesodoo/odoo#138275
X-original-commit: 1e729a0f1de87335a2c4517bb815bc5ab7d4bd01
Signed-off-by: Laurent Smet (las) <las@odoo.com>
Signed-off-by: Levi Siuzdak <sile@odoo.com>
When having a company with sub company.ies, if
we select only one of the branch, the number
of entries to reconcile is not reflected only
the entries from the selected branch but the one
from all the branches, therefore when opening the
reconciliation widget, the number of line to reconcile
is not the same as indicated.
With this commit, we only count the entries that belong
to the selected company.
Steps:
- Having a company with one branch (X and X.1)
- Having 1 statement line for X and 2 for X.1
- Select the two branches
- See that there are 3 entries to reconcile
indicated on the bank journal
- Select X or X.1 only
-> There are still 3 entries to reconcile
indicated instead of 1 for X and 2 for X.1
closesodoo/odoo#138257
X-original-commit: 023c97c21194e83eda2433e2fe3c32de1d3b320b
Signed-off-by: Josse Colpaert <jco@odoo.com>
Signed-off-by: Guillaume Vanleynseele (guva) <guva@odoo.com>
Before this commit
=================
While updating the Bill of Materials (BOM), the work center and operation name
remained unchanged in the manufacturing order.
When Archiving/Unarchiving the operation doesn't show the "Update BoM" button
in the appropriate MO.
Steps to Produce
================
- Create a BOM1 with operations
- Create a MO with BOM1 and confirm MO
- Goto BOM and change the workcenter and operation name
- In MO Click on the 'update BoM' button
- Now you see the operation name and workcenter are not updated in MO
After this commit
=================
With this commit the work center and operation name get updated with the update
BOM click. For Archiving/Unarchiving the operation results to the display of
the "Update BoM" button in the appropriate MO. Directly editing an
operation will also cause the "Update BoM" button to appear
task-3461985
closesodoo/odoo#138256
X-original-commit: c343ebf0a28f6404f7ad6fc892c4a42edd2bbbe0
Signed-off-by: Tiffany Chang (tic) <tic@odoo.com>
The summary is a short char field. It should not contain carriage
returns.
The description is the longer text field.
Remove unnecessary spaces in both.
Automatically dedent the description to avoid this issue poping up
again in future modules.
closesodoo/odoo#138214
Related: odoo/enterprise#48695
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
The jSignature lib is only used by the NameAndSignature component,
which is not accessible on a many screens. This commit thus
removes the lib and its extension from the bundles, and makes the
NameAndSignature component load it on demand.
Part of task~3439226
closesodoo/odoo#138054
Related: odoo/enterprise#48633
Signed-off-by: Samuel Degueldre (sad) <sad@odoo.com>
This commit converts the SignatureForm widget into a Component.
This allows to remove the last usage of the legacy NameAndSignature
widget, which we thus remove.
Part of task~3439226
Part-of: odoo/odoo#138054
This function must be used to safely redirect to another url. It
ensures that we stay on the same origin, and thus that the url is
safe.
Part-of: odoo/odoo#138054
Maintain the playful tone whilst avoiding nonsensical phrasing.
I will not take comment at this time, thank you.
Task-🤔🙃😬💅😐🤓closesodoo/odoo#138302
Signed-off-by: Bouvy Damien (dbo) <dbo@odoo.com>
Steps:
- Install project and live chart applications
- In project reporting then
- Customer ratings
- Click on kanban card, task form view open
Issue:
- When we click on a Kanban card, it opens the 'project.task' form view instead
of the 'rating.rating' form view
Cause:
- This problem occurs when you install the 'Live Chat' application because,
in the 'Live Chat' application, they inherit the Kanban view from the 'rating'
module and insert some actions into the inherited view. This action affects
other modules where customer ratings are required, such as the project module
and others.
Fix:
-By creating a separate view for the Live Chat customer ratings,
the problem can be solved
task-3522178
closesodoo/odoo#138276
X-original-commit: f50e6dbbd46bf0d16c8f522d4f1d9b10445d1065
Signed-off-by: Matthieu Stockbauer (tsm) <tsm@odoo.com>
Before this commit, when using a loyalty reward with points, it is
possible to give partial rewards. This commit prevents partial rewards.
Example:
- Rule: Grant 1 point per product bought;
- Reward: 1.5$ per point in exchange of 2 points (3$)
Before this commit, if you buy 3 products, you get 4.5$ by using 3
points. After, you only use 2 points and get 3$ (no partial reward).
task-3300880
closesodoo/odoo#138277
X-original-commit: b3a2fb51bc48b83e821648b40f0dc7d86369ca7c
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Signed-off-by: Vallaeys Valentin (vava) <vava@odoo.com>
This commit allows to reorder global filters via drag and drop. The
fact that global filters have a concept of order means that the
structure of the global filters in the core plugin need to change from
an Object<string, GlobalFilter> to an Array<GlobalFilter>.
closesodoo/odoo#135869
Task: 3502684
Related: odoo/enterprise#47583
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
The commands `ADD_GLOBAL_FILTER` and `EDIT_GLOBAL_FILTER` had the filter id
once in cmd.id, and once in cmd.filter.id. This made it possible to send
a command with 2 different ids, which can have arbitrary behaviour depending
on the implementation details of the command.
Changed it so we only use cmd.filter.id, and removed the cmd.id field. Also
simplified the commands helpers for the tests.
Task: 3502684
Part-of: odoo/odoo#135869
Task Description:
This PR aims to add the possibility to edit the evaluation domain of
an Odoo chart, the same way it can currently be done for other
datasources like `List` or `Pivot`. This revision ensures that the chart
datasources are properly reloaded their domain update.
closesodoo/odoo#135242
Task: 3384872
Related: odoo/enterprise#47336
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
PR [1] introduced the evaluation of ocntextual domain. However, this was
only evaluated once at the creation of the datasource. This revision
changes the flow to evaluate the context upon the datasource loading.
[1] https://github.com/odoo/odoo/pull/131874
Part-of: odoo/odoo#135242
* Chart of Accounts: we cleaned it, mapped it and kept the most important accounts
* Contacts: added the type of identification field and validation of the identification format
* Taxes: we kept what we had and mapped them with the correct accounts
* Added Legal document types in Uruguay.
* Valid contact identification types in Uruguay.
* Added fiscal position to auto compute taxes
* Frequently used default contacts already configured: DGI, Consumidor Final Anónimo.
* Translations: added translations for the module
closesodoo/odoo#133891
Signed-off-by: Josse Colpaert <jco@odoo.com>
The legacy RPC was removed in 7422eb6 and replaced by `rpc_service`. The
changes to adapt the list view button on the `/shop` pages did not work.
This commit will use `rpc_service` instead of `this.rpc` which is not instantiated.
closesodoo/odoo#133064
Related: odoo/enterprise#46252
Related: odoo/upgrade#5190
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
It introduces:
New navigation flow with buttons inside the cart_summary template
Reviewed tables across the pages removing stripes and improving spacing
Redesigned stepper wizard with a reusable template in /website
task-3083707
Part-of: odoo/odoo#133064
Co-authored-by: Valentin Chevalier <vcr@odoo.com>
Steps:
- Create a new event.
- Choose any template (training, conference,...).
- Create new registration ticket for this event.
- Create a new quotation.
- Add 2 lines for "Event registration" product, and select each time the event and ticket created above.
- Click on "Confirm".
Issue:
4 registrations lines are created and 3 attendees.
Reason:
In ``RegistrationEditor.default_get()``, we match each sale order line with existing registrations in the sale order having
the same ``event_ticket_id`` without assuming we can have multiple sale order lines with the same ``event_ticket_id``. That
leads to [number_of_sol] * [number_of_ticket] registrations. To solve it, we just add an additional check for the
``sale_order_line_id`` to have a perfect match.
opw-3495415
closesodoo/odoo#138242
X-original-commit: 926ab300650eda02aefa728fa32b44831c49dfb3
Signed-off-by: Jérémy Hennecart (jeh) <jeh@odoo.com>
Current behavior:
When you link a printer to the sales detail report. The report will
contains no order. This happens because we are trying to assign docids
to the session_id.
Steps to reproduce:
- Install pos_iot
- Link a printer from the demo iot to the sales_detail report (go in
settings > reporting > reports)
- Do some orders on the PoS, and close it
- Go in the backend, and print the sales detail report
- You will see that the report is empty (You can put a breakpoint in
`get_sale_details` method to see that it will be empty)
opw-3247196
closesodoo/odoo#138241
X-original-commit: 489985661d689dde1a1385db2fc4a0a51fb5a7db
Signed-off-by: Vlad Stroia (vlst) <vlst@odoo.com>
Signed-off-by: Robin Engels (roen) <roen@odoo.com>
This PR contains a few adaptations and fixes after the major design
refactoring.
closesodoo/odoo#137704
Signed-off-by: David Monnom (moda) <moda@odoo.com>
Purpose of this commit is to try to detect and log 'email_from' invalid
values when sending emails based on outgoing 'mail.mail'. This implies
checking the returned messages when having a generic Exception when sending
the emails, as we distinguish two use cases that raise through a simple
raise: missing from and invalid from.
New failure types 'mail_from_missing' and 'mail_from_invalid' are also
added at 'mail.notification' and 'mailing.trace' level, as other failure
types.
Task-3547653 (Mail: Add error type for wrong email_from)
Prepares Task-36879 (Mail: Support MultiCompany Aliases)
closesodoo/odoo#138202
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Extract some test preparation, cleanup and improvements before gradually
adding features that impact tests.
Add tests about 'copy()' behavior in 'mail.alias.mixin' as it will be
impacted by multi-company enabled aliases.
Task-3547653 (Mail: Add error type for wrong email_from)
Prepares Task-36879 (Mail: Support MultiCompany Aliases)
Part-of: odoo/odoo#138202
__Current behavior before commit:__
When changing the `display_type` of an attribute in the website editor,
the page is reloaded. However the template `website_sale.product` is
contained in a `t-cache` on "pricelist,product". This means that the
template will not be rendered again when the page is reloaded. Thus, the
change will not appear for the user.
__Description of the fix:__
Flush the cache from the `ir.qweb` model when the attribute display type
is edited. This way the template `website_sale.product` will be
refreshed.
__Steps to reproduce the issue on runbot:__
- Go on the website product page of *Customizable Desk*
- Open the website editor
- Click on the Legs attribute values
- Under the **Block** section, change the **Display Type**
The page is reloaded but the display type stays the same
([Video][1])
opw-3495159
opw-3493820
[1]: https://drive.google.com/file/d/142VP4prnHskfa7uFoEkadsoQfQVO-uyW/viewclosesodoo/odoo#137498
X-original-commit: cc8664973efd7ea3433b5ec5b741f0882fb17dc0
Signed-off-by: Julien Launois (jula) <jula@odoo.com>
In a6fea37, escapeHTML was introduced to replace the corresponding
underscore.js function. It is very similar to the widely used escape
function, except it additionally escapes single (') and double (")
quotes.
The additional escaping is not generally harmful, and is necessary to
safely inject values into attributes. As escapeHTML is almost unused,
remove it and update escape to include quotes.
taskId : 3522892
closesodoo/odoo#137216
Signed-off-by: Mathieu Duckerts-Antoine (dam) <dam@odoo.com>
Before this commit:
In the `mailings` when we enable the A/B testing and click on the "Create an Alternative" button,
the "Send final on" field doesn't copy to the new mailing.
Reason:
The related field are copy `false` by default.
After this Commit:
Now it will copy the "Send final on" into a new mailing
closesodoo/odoo#138195
Task: 3465887
X-original-commit: 3d6dd2402a65af40c77692250fd710d3355960e7
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Issue:
======
We have a delivery order created by a sale order by another user.
A user with administrator access to inventory and sale : own documents
only ,can't deliver products of
that sale order without backorder , it shows access error.
Steps to reproduce the error:
=============================
- Create another user with admin access for inventory and own documents
for sale.
- Create a sale order with the current user.
- Change now for the inventory admin and deliver some of the products
and click on no-backorder.
- Access error will show.
Origin of the issue:
====================
The admin user should be able to deliver the products but when creating
no backorder he needs to write on the sale_order.
Solution:
=========
Added `sudo` to the function that logs in the sale_order.
opw-3380566
closesodoo/odoo#138176
X-original-commit: de2d889b053827e39b11a648797ad2f30e646ce6
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Mahdi Cheikh Rouhou (macr) <macr@odoo.com>
Follow-up of https://github.com/odoo/odoo/pull/132701
`@extend` was used to reuse classnames intended for styling,
such as `.btn`. However, this has the side-effect to increase
specificity on these classnames, which results in breaking style
on the website where the specificity on `.btn` must not change.
This commit fixes the issue by using a mixin rather than
`@extend`. Since using these mixins are not equivalent, we took
the opportunity to slightly improve the constrast of text color
and background.
closesodoo/odoo#138108
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
The previous commit reverts the ORM fallback of `display_name`. Then the
`display_name` can legitimately be `False` again. But the `Many2one` and
`Many2XAutocomplete` components don't handle this case (and generate a
traceback see task-3424154).
This commit adds the same fallback ('Unnamed record') for these two
problematic components; one when the name_search returns `False` as
`display_name` (autocomplete for Many2Xfields) and another when we read
the many2one `display_name`. This name is not user friendly, but for
the business model it shouldn't happen anyway. It is also better than
the empty string which is confusing with no value. Note that there is
already a fallback for `display_name` that is used in the broadcrumb
(https://github.com/odoo/odoo/blob/50b2a24f22cb470bcc1a9befe677cf794211d7b2/addons/web/static/src/views/form/form_controller.js#L282).
Part-of: odoo/odoo#138061
This reverts commit 4573ca0c83eb63785016f4389a5157efb21fa9a4.
Because now, `display_name` is implicitly on every form (last breadcrumb
item). Then it will be queried by `onchange` calls. When we create a
new record, `_rec_name` can be `False` and the display_name will be a
technical one: '<model_name>,<NewId0x...>' which is uglier than the
previous situation showing 'New'.
Part-of: odoo/odoo#138061
Some Qunit tests (in stock_barcode module) need to mock the barcode
service in order to be executed correctly.
This commit adds a new helper function that simulate the barcode service bus.
closesodoo/odoo#136236
Related: odoo/enterprise#48054
Signed-off-by: Steve Van Essche <svs@odoo.com>
This commit removes some warning messages displayed in some wizard and
removes the fields used to display or not those warning
messages.
task-3356114
closesodoo/odoo#124820
Related: odoo/upgrade#4899
Related: odoo/enterprise#42472
Signed-off-by: Xavier Bol (xbo) <xbo@odoo.com>
Before this commit error messages in odoo are boring and
not much attractive to user. Those were like odoo is preventing
them from doing something user want to do.
In this commit, we have modified the message to be a more friendly
and humorous tone, making it less tedious and more enjoyable. It
aims to enhance the user experience and ensure that interactions
with any application are both pleasant and informative. As a result,
the messages have been clear, short, easy to understand and informative.
task-3356114
Part-of: odoo/odoo#124820
Co-authored-by: Kamlesh Pathekar <kpt@odoo.com>
In HBA's demo sheet, `markAsValueUsed` goes from more than 2% of the total
loading time to less than 1%
closesodoo/odoo#138166
Signed-off-by: Rémi Rahir (rar) <rar@odoo.com>
Signed-off-by: Lucas Lefèvre (lul) <lul@odoo.com>
Instanciating an error is very slow.
In HBA's demo spreadsheet, `_assertDataIsLoaded` takes up to 17% of the total
spreadsheet loading time.
With this commit, it's reduced to less than 2%
Part-of: odoo/odoo#138166
`getReportMeasures` is called repeatedly for every pivot function.
In HBA's demo spreadsheet it takes up to 30% of the loading time.
Part-of: odoo/odoo#138166
On HBA's demo spreadsheet, `parseGroupField` takes more than 3% of the total
loading time.
This commit reduces to less than 1.5%
Part-of: odoo/odoo#138166
Claire Bretton (clbr)