Before this commit on mobile when you come to odoo from a notification
url like:
https://my_domain/web#action=mail.action_discuss&active_id=1&menu_id=93
a traceback occurs on mobile discuss wasn't loaded correctly and the
content didn't appear.
With this commit, it's open the related discuss thread.
It's also ensure the return to the chat tab when you close a chat and
the return to the channel tab when you close a channel conversation.
We also ensure the loading of the inbox items when you navigating on
the mobile discuss button.
Steps to reproduce:
1. Open a chat from a mobile notification
2. A traceback occurs
opw-2310319
closesodoo/odoo#58431
X-original-commit: 8ca5024bef246c93bbb7522d77aca4c4ba7a33b4
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Before this commit:
When a tracking field is set to 0, the mail tracking value doesn't display 0 in
the chatter. It is empty instead
i.e: Field Name: 1 ->
After this commit:
Tracking value will show the changed value even if it is false or 0
i.e: Field name: 1 -> 0
closesodoo/odoo#58423
Task: 2334048
Closes: https://github.com/odoo/odoo/pull/57342
X-original-commit: 57f4018694a895fd804b51e8206503e3d1d3c5d4
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
When navigating fields using the keyboard, it's not possible to reach
most of widgets for selection fields. That is because most of them
consist of one main element containing several other ones, one per
possible selectable value (e.g. buttons). When their focusable element
is computed, the main element is taken, instead of its sub-elements,
which causes the field to be skipped when navigating.
This commit fixes the above, as well as some missing aria attributes and
keyboard events, for the following widgets:
- `priority`
- `state_selection`
- `statusbar`
- `radio`
opw-231112
closes#58302closesodoo/odoo#58421
X-original-commit: 2471e7c176c5df0f310f2939f8a6cf6948c0ac0c
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
In some undeterministic conditions, the Windows virtual machine can take
more than 60 sec to start and have the sshd service ready.
With this commit, the packaging script tries to connect to the VM up to
30 times, giving more than 10 minutes for the boot.
As soon as the connexion is ready, the packaging starts. This means
that the script will probably start sooner in most of the cases.
closesodoo/odoo#58417
X-original-commit: aed85d89f958377f44e150c30a44f28e281dcb79
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
- Create a price list with a foreign currency;
- Create a product with some variants;
- Configure the variants and make at least one of the variants with
extra price;
- Set the 'Sales Variant Selection' with 'Order Grid Entry';
- Create a new quotation with the foreign currency price list;
- Add the product just created to the quotation.
Before this commit, an error is raised, because the currency convert
need a valid company id.
Now, the order grid entry is shown.
opw-2329658
closesodoo/odoo#58415
X-original-commit: bf325b60d24b7045e8bfb3f16be2476889368926
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
To avoid dynamically building xml_id names,
in the purchase dashboard, remove the name attr used to
construct dynamically the action xml_id.
In any case, it was all the same, then just put it in the js.
closesodoo/odoo#56211
Related: odoo/upgrade#1704
Related: odoo/enterprise#12553
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
- On `mrp.production`, remove `workorder_done_count`
unused since mrp v14
- On `mrp.workorder`, remove `use_create_components_lots`,
unused since ed7012e8fd
Co-authored-by: Feyensv <vfe@odoo.com>
- On `stock.picking`, remove unused `rate_picking_late` and
`rate_picking_backorders` and change the compute accordly
- On `stock.warehouse`, remove unused field warehouse_count and
remove show_resupply which can by replace by
the groups="group_stock_multi_warehouses" since
7bf064fcc160fb3f91d58e64d45e8a981865dc41
Before 9920f20e4c, the `
`_compute_product_qty` (`stock.move`) used the context to choose
the rounding method. It was remove (always used 'HALF-UP')
and replace by a comment. The rouding method used by the context was
used only on the `_split` method with always 'HALF-UP'.
Then remove rouding_method of context and remove the obselete comments.
task-2041971
Bug
===
If multiple invoice have different currency, the invoiced amount of
the mailing will be wrongly computed.
Task-2265628
closesodoo/odoo#58390
X-original-commit: d7193351343758bfae1567fd19f57b3a686bdf80
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Before this commit the overlay of an image was not updated when the
image was replaced by another.
task-2312878
closesodoo/odoo#58335
X-original-commit: d4641b5bdc2b05523e29fb87a3b953dea90fbd8a
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Purpose
=======
Since cb55b30293 we set a fixed
width for the color picker widget in readonly mode. This value
is quite huge and cause issue in saas-13.5 in the event track
form view.
Task-2320370
closesodoo/odoo#58379
X-original-commit: f24e7739d4c40c041bd768515f47d545e78ea522
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
To reproduce:
- With visitor talk in the livechat to enable a livechat session with admin
then fold the chat window.
- With admin, send a message in the livechat.
- Normally should have (1) in the chat window title (visitor side), but it
isn't the case before this PR.
task-2342167
closesodoo/odoo#58377
X-original-commit: fce26ccfb5879ed4e468596f675932e7687f82c6
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
The text tools were moved in the right panel with a temporary solution
but as there is no right panel in translate mode, the text tools were
just floating summernote-way. This commit restores the top editor bar
in that case while waiting for the new editor.
Part of https://github.com/odoo/odoo/pull/58347closesodoo/odoo#58372
X-original-commit: b9d4ccfc8db1f3425b8ee0e8d6311ebaac0f26b2
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Those were misaligned since the merge of the right-panelization.
Part of https://github.com/odoo/odoo/pull/58347
X-original-commit: be59e6cd0d30c8e5fb70311db4d9657826a9d43f
When the pending value is the same as the current server value, the pending
value should be ignored and no RPC should be done.
In particular this prevents a non-main tab from calling the RPC when receiving
a bus notification that would lead to closing a chat window, which in turn used
to call the close RPC again before this commit.
This led to inconsistencies especially on the main tab, if the chat window was
requested to be open again after the initial close, but before the "secondary"
close, it would end up closing instead of opening.
The current commit reduces the issue and prevents as many unnecessary RPC as
there are tabs open, which is a good improvement.
But it does not negate it completely. Indeed, when quickly closing then opening
the same chat window, it might still happen for network reasons that the RPC or
the corresponding bus notifications are received in the wrong order. This is
less frequent both functionally (to click so fast) and technically (to have the
network that slow) at the same time, so it is considering acceptable / out of
scope.
The opportunity is taken to clean up the code by removing unnecessary fields and
making use of compute and flux specific RPC instead of `_updateAfter`.
task-2273658
task-2329521
closesodoo/odoo#58369
X-original-commit: cbb1d855c7af5f78819db3cd476dbe0f985bc214
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
- avoid updating default position list in place
- ensure computed position takes into account enough margin with border
- fallback to requested position instead of bottom
Part of task-2270731
closesodoo/odoo#58370
X-original-commit: 3fad17421518732db2085c3eec596600cfe34f03
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Emoji popover should be rather narrow, it doesn't look good to have one line
of emojis taking the whole screen. The goal is too keep the choices in close
range of the open button for quick selection.
Part of task-2270731
X-original-commit: 75d742f4e48c836f74bc7beee10c89ea544173eb
Because the position of the popover depends on the size of its content.
Part of task-2270731
X-original-commit: 3066a946ef1ca0973503207d0486515798168fa2
When a bad promo code is entered on the "Extra steps" page, we are
redirected on the "Confirm Order" (/shop/payment) page which might make
the user miss extra steps page.
opw-2339906
closes#58338closesodoo/odoo#58362
X-original-commit: 659192d317613e1a3103365c793d5660152d54a0
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
Using this partner will copy his phone number on the lead.
However, the lead and the partner don't have the same country, which
will lead to ad invalid phone number (for the lead country).
It avoids a warning emitted by the `phone_validator` module, while
browsing the lead.
closesodoo/odoo#58352
X-original-commit: 2c94c4c81ffa171158586cd64828d27c537cd1d6
Signed-off-by: Christophe Simonis <chs@odoo.com>
[FIX] mrp: installation on very large inventories
Before this commit, installation of MRP in a database with 4.8M stock.move + 4.8M stock.move.line was not possible at all.
The process lasted for a very long time (>90 min in our tests) then eventually failed after using the whole RAM of your server.
This commit allows installing MRP in databases with large stock.move /stock.move.line tables by bootstrapping the slow parts in SQL.
(A more general fix regarding the time complexity of some parts of the prefetching algorithm is coming later in 13.0-init-computed-fields-rco)
-----
[FIX] mrp: more Voodoo magic
It appears that if you update a record more than once in the same
PostgreSQL transaction, PostgreSQL is going to re-check all the
constraints on the table.
** THIS IS THE PART WHERE THE BLACK MAGIC HAPPENS **
We combine the setting of the default value of stock.move.unit_factor in
the same UPDATE query to avoid the constraint re-check; it saves
approximately 60% of the SQL running time in my case.
** ... AND NOW YOU CAN SAY: WHAT THE F...?! **
Thanks to @rco-odoo for the tip; he knows it from the wise @nseinlet.
-----
opw-[2281585](https://www.odoo.com/web?debug=1#id=2281585&action=3531&model=project.task&view_type=form&cids=&menu_id=4720)
closesodoo/odoo#57946
Forward-port-of: odoo/odoo#57850
Signed-off-by: Richard Mathot (rim) <rim@openerp.com>
- The balance operation is performed automatically at the end of the
day but it doesn't print any receipt. We add the possibility to perform
the balance manually to get a receipt showing all the transactions of
the day.
- By default, DCC is set to true, but it requires a different
implementation. As we don't support it, Six asked us to changed the
variable to False, to make it clearer in case of debugging.
closesodoo/odoo#58360
X-original-commit: bc5ea7e3d3b694bbe88b14c10cd5cc80ca617e48
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
Signed-off-by: Antoine Prieëls <aprieels@users.noreply.github.com>
It appears that if you update a record more than once in the same
PostgreSQL transaction, PostgreSQL is going to re-check all the
constraints on the table.
** THIS IS THE PART WHERE THE BLACK MAGIC HAPPENS **
We combine the setting of the default value of stock.move.unit_factor in
the same UPDATE query to avoid the constraint re-check; it saves
approximately 60% of the SQL running time in my case.
** ... AND NOW YOU CAN SAY: WHAT THE F...?! **
Thanks to @rco-odoo for the tip; he knows it from the wise @nseinlet.
X-original-commit: 8e47e2f605309c8ed0d5509f7bb070528d8f32c4
Before this commit, installation of MRP in a database with 4.8M
stock.move + 4.8M stock.move.line was not possible at all.
The process lasted for a very long time (>90 min in our tests) then
eventually failed after using the whole RAM of your server.
This commit allows installing MRP in databases with large stock.move /
stock.move.line tables by bootstrapping the slow parts in SQL.
A more general fix regarding the time complexity of some parts of the
prefetching algorithm is coming later in 13.0-init-computed-fields-rco
opw-2281585
X-original-commit: 549de5601efdad3ebdb03feb8beb1e898f80113a
Also, what the point of a rate without currency?
closesodoo/odoo#58327
X-original-commit: bc00059bcd1c6475b00503e9242edd6547dbd93d
Signed-off-by: Christophe Simonis <chs@odoo.com>
Many customers wonder "Why does my filestore take so much disk space?".
We display the size of the file (if available) in the
technical list view available under Settings > Technical > Database >
Attachments
opw-2338830
closesodoo/odoo#58267
X-original-commit: 9c1874591e7fc9130cc44559df09e9fdbae4466a
Signed-off-by: Richard Mathot (rim) <rim@openerp.com>
Passing a field containing `undefined` should lead to the same result as not
passing the field.
Fields that relied on `undefined` as a value have been changed to use the newly
introduced `clear` command, that resets a field to its default value (often
that is equal to `undefined`).
task-2336491
closesodoo/odoo#58314
X-original-commit: b18824485483564d2ab80f41914a3548aa528ae0
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
If an user that only has access to accounting but not to sale, tries to
validate an invoice created from a sale order, an access error will be
raised. That's because, when the invoice status changes, the invoiced
quantity on the related sale order is recomputed using the current user,
which may not have access to read sale order lines.
This commit fixes the above by ensuring the recomputation is performed
with superuser access rights.
closesodoo/odoo#58304
X-original-commit: 0bf30e1b5907997ae22d27cc420c3533940d634f
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
The field `invoice_partner_bank_id` was renamed `partner_bank_id`
closesodoo/odoo#58295
X-original-commit: c58684c07658ef7170f9696cc2fbb033ec46ba96
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
due to breaking changes in https://github.com/odoo/odoo/commit/bf32b22ce247c19fda94ded74e37f7c6120ce2c4
and especially the part:
"NOTE 1. If the default_get within the onchange returns a value for
a field that is not in the view, we ignore it, and it won't be saved.
Before, that value was kept and sent upon save. This change in behavior
may prove problematic, although the overall risk is small. Decision has
been made to keep heavy comments and code snippets if we were to revert
back somehow to the previous situation."
the wizard to sending failures sms was broken as the field notification_id
which is required was not present in the view and was thus ignored by
to web client when calling 'create'.
closesodoo/odoo#58294
Task: 2335273
Closes: https://github.com/odoo/odoo/pull/57912
X-original-commit: 9fed44512074d36f7b4aedf8ed08422304e433ea
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
This commit fixes a bunch of small issues on the session manager.
- Put the progress bar below survey link to optimise available room for title.
- Ensure attendees count is also updated when refreshing the results
and progress bar.
- Ensure the graph is correctly setup when there is no attendee yet.
- Update y axis in chart when new attendee join the survey in the middle of
a session.
- Set padding top to chart to avoid top bar label to disapear from chart if bar
is near 100%.
Task ID: 2343508
closesodoo/odoo#58291
X-original-commit: 018a07dc7bba85f5afdd41f8610098a3c493c82a
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Before that, making a misc operation with cash basis taxes always set the move lines as tax_exigible=False (or at least, it was supposed to, see below). This was wrong, as if the move did not contain any payable/receivable account, it would result in no cash basis move being ever created, and so the entry would never affect the tax report.
Additionnally, the tax line was wrongly managed for cash basis taxes on misc entries, as vals.get('tax_ids') returned an ORM command, so a non-False value, even when the tax_ids field was empty. this caused the condition to execute and to reassign taxes to an empty list, which then caused tax_exigible not to be set to False, even when it should.
X-original-commit: https://github.com/odoo/odoo/commit/2437eb0691d07f92094152b84c96a2149c8f4fd8
[FIX] account: make tax exigible correct in cases where the move lines are created separetely from the move.
Additional fix on top of https://github.com/odoo/odoo/commit/02fe997932070cc101a96eb869023702c224318b
Also, add tax_exigible to the form view of account.move.line, as it will not be computed automatically anymore when modifying a single line in draft state through its form view. It now needs to be manually changed in case the user wants to change something having an impact on it through this form (note that this is absolutely not a typical use case).
closesodoo/odoo#58260
X-original-commit: 867797e4983b704599be7943490fc6f071d8c0b7
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
* Change the `addons/account/i18n/vi.po` PO file to replace the
translation of `Vendor Bill` like msgids from `Công nợ nhà cung cấp`
to ` by `Hóa đơn Nhà cung cấp`, there should be 3. What's matter is
the `đ` character.
* Create a brand new Vietnamese database (using `-l vi_VN` and
`--load-language=vi_VN`)
* Install Invoicing (`account`), an email alias constraint is raised.
> You cannot use anything else than unaccented latin characters in the
> alias address.
During the installation of the invoicing module, an email alias is
created for every journal account of purchase type. The alias is created
using the current journal name. Here the journal name is `Hóa đơn Nhà
cung cấp`, as mail aliases should only contain ascii characters, we
attempt to remove the accents. The `tools.misc.remove_accents`
successfully remove most of them but the `đ` character is left as-is,
the final alias is `hoa-đon-nha-cung-cap` which is invalid as it
contains some non-ascii characters.
The `remove_accents` function uses the [NFKD] Unicode Compatibility
Decomposition Normalization Form. This normalization process unify all
abstract equivalent characters, i.e. characters only different by font
or rotation. While this normalization process helps to transcript a lot
of characters to their ascii compatibility equivalent, some 118,230
other non-ascii characters (mainly from the Chinese and Japanese scripts)
are left as-is as they lack an ascii compatibility equivalent.
The solution has been to not use the journal name but rather the journal
code or journal type as email alias when the name is unsafe. The journal
code is a short version of the name, the journal type is not
translatable so is always ascii.
One additional watchdog has been added to the sanitization function of
email aliases so non-ascii characters are replaced with a '?' which is
an authorized character in emails local-part.
[NFKD] https://unicode.org/reports/tr15/Closes#55492Closes#55493closesodoo/odoo#58279
X-original-commit: 8dc85be3821cf26226cd0bf4ce2b6739e68fc66f
Signed-off-by: Simon Goffin (sig) <sig@openerp.com>
Signed-off-by: Julien Castiaux <Julien00859@users.noreply.github.com>
Co-authored-by: Thong Le <thongthele@users.no-reply.github.com>
When the sceencast argument is used to produce a video file of failing
tests, the framerate is computed with a KISS average.
This results in a misleading video flow. For example, if a tour step is
stuck, the average could show a smooth transition instead of the reality.
With this commit, the real duration of frames are used to produce the
video. The result is a more realistic video flow.
The configuration text file used by the ffmpeg concat demuxer is kept
alongside with the video file so that it can be used for other purposes
(e.g.: parse the durations to be used by a video player on runbot).
closesodoo/odoo#58280
X-original-commit: 58eb6a4565c024077557fa2de83fdf831e5ef026
Signed-off-by: Xavier Dollé (xdo) <xdo@odoo.com>
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
Reword some theme options, highlight <we-title> components when used as
a "sub-section" titles.
task-2335267
Part-of: #57942
X-original-commit: d6acbfee1834ab32460300b9d7f5dd9188f68014
Fix the design. Trig animations hovering any part of the button rather
than its inner image only.
task-2335267
Part-of: #57942
X-original-commit: 55424d41b355ae1303f040bdd953e357365289f3
Romain Estievenart