Commit Graph
132514 Commits
Author SHA1 Message Date
Andrea Grazioso (agr-odoo) 14e87b9783 [FIX] point_of_sale: add serial number on refund
Install POS, create a product available in POS, tracked by Serial
Number.
Add some product to the inventory.
Open the POS session, sell the demo item, close the session (do not end
the session, just close the interface).
Go to POS orders, select the last order and click on "Return Products",
the refund will be created.

The user will be unable to process payment for the refund order because
Serial Number is missing. Adding a copy of the lot from the original
order line fix the issue

opw-2152776

closes odoo/odoo#41762

X-original-commit: 886dee9efc3bd743ca1b9353872021c1f81efa9a
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-12-12 07:25:08 +00:00
Nicolas Martinelli 40fa388b5b [FIX] point_of_sale: prevent deletion of payment
Deleting a payment will prevent the POS session closing.

opw-2155093

closes odoo/odoo#41752

X-original-commit: a6927e31af53f28c04eb567db0da396ad07e7206
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-12-12 07:38:26 +00:00
Aurélien Warnon 0d6ddb7bda [FIX] event[_sms]: correctly take parameters from event type mail
PURPOSE

This commit 62ac23f0b9 introduced SMS capabilities on for
event.type.mail and event.mail models.

Values of event_type_mail_ids on event.type are supposed to be copied to
event_mail_ids on event.event when changing the event_type_id of an event.

There are however 2 issues with that integration:

- The 'notification_type' field was not correctly set on default
  event_type_mail_ids on event.type;
- The 'notification_type' and 'sms_template' fields were not copied from
  event_type_mail_ids to event_mail_ids;

LINKS

PR #39892
Task ID 2115792

closes odoo/odoo#41736

X-original-commit: 3fd66d844aa66ca8d54223071c787974e6c88c94
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-12-12 06:24:35 +00:00
Andrea Grazioso (agr-odoo) c8e862249e [IMP] account_check_printing: store check number also as int
Go to Accounting > Vendor Bill, pay via check, view the invoice and
click on 'Print Check'. The widget will popup but as the 'next check
number' will always display 1.

This append because the model of account_payment has changed
https://github.com/odoo/odoo/blob/13.0/addons/account_check_printing/models/account_payment.py#L28
and now check_number is a char so it will not sorted correcly by the
database.

To avoid doing a lot of strings manipulation it is convenient to
store the check number as integer, with proper default case

Followup of opw 2151242

closes odoo/odoo#41659

Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-12-12 09:00:18 +00:00
Pierre Rousseau 513f8e134e [FIX] web: pivot isHeaderClicked
This commit explains why we use isHeaderClicked.

closes odoo/odoo#41756

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
2019-12-12 09:40:04 +00:00
oco-odoo 2a99353026 [FIX] account: avoid crashing when selecting a reconciliation model when doing manual reconciliation
Before that, an empty account.bank.statement.line recordset was passed to the function, and caused the recordset containing the currency to use to also be empty, eventually leading to a rounding value of 0, which raised and error.

closes odoo/odoo#41474

Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-12-06 12:06:33 +00:00
Laurent Mignon (ACSONE) 28c444e9e7 [FIX] base: Allow user to change its own language
Before this change, it was not possible to a user to change its own
language via the Preference view.

In order to allow a user who does not have access rights on the
res.users model to modify his language (field included in the list of
SELF_WRITEABLE_FIELDS fields) it is necessary to force the reandly
attribute to False in the view used to edit the user's preferences.

opw-2151630
Closes #41412

closes odoo/odoo#41748

X-original-commit: 272bff9e3173e1ed5da5d5a87e4c7be53ad59700
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-12-12 07:05:23 +00:00
Victor Feyens 3a6385343a [FIX] event_sale: ticket prices
closes odoo/odoo#41738

X-original-commit: 270b5798b5869c93f80863ee0bd891ab7a2488f0
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2019-12-11 16:36:22 +00:00
Debauche Stéphane 8453b7fb90 [IMP]: mass_mailing: improve some views
- In the campaign form view, when you click on "SMS", the filter has changed
  ``My Mailing`` -> ``My SMS Marketing``
- In the campaign form view,  display the Mail/SMS subject instead of the SMS name
- In UTM, move the campaign from the data to the demo data

Task #2082296

closes odoo/odoo#40205

Related: odoo/enterprise#6685
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-11-14 07:37:16 +00:00
Romain Derie e788c040f6 [FIX] website: set correct value in frontend_lang cookie
Before this commit, the `url_code` field value was stored in the cookie instead
of the `code` field.
This was making the language selector in the frontend to not change the lang
correctly when trying to access the website default lang, ONLY for the lang
having an `url_code` different than its `code` value (typically the case for
principal languages).

Step to reproduce:
  - Add `fi_FI` as main lang on website
  - Visit frontend and change lang to `Suomi`, it won't change

This behavior was only related to the language switcher. It did not affect
dispatching (if correct lang in url) and nearest lang finder.

Fixes #41522

closes odoo/odoo#41728

X-original-commit: b62b2828552abb38c8adc74c69cb427c3fd98605
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
2019-12-11 13:33:22 +00:00
Vincent Schippefilt 0f2a500f0e [FIX] web: fix click_all test
Before this commit, after the introduction of OWL, for some reason,
maybe because the session is ready earlier or later, the webclient is
opening the first app sightly earlier than before, making it too early.

The click_all failed actually because, in the initialization of the
webclient, it does a read on read user, protected by a drop_previous
it tries to start the first applictaion, when this happens, the hash
changes
==> because the hash changes, it tries to open an application, with is
also protected by the same drop previous, this discarding the result of
the read and preventing the then callbacks of the read to happen.

After this commit, we are declaring that the client is ready after the
actual load of an application.

closes odoo/odoo#41695

Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2019-12-11 14:37:04 +00:00
Yennifer Santiago 74dcb64f46 [CLA] Add ysantiago as new contributor in vauxoo
closes odoo/odoo#41715

X-original-commit: 5028acce9e56afadfa409316f758f220803aacf8
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-12-10 21:33:35 +00:00
Nicolas Lempereur 76e36be45f [FIX] product: no default_code empty string
Currently, empty strings and False have different meaning when assigning
a Char or Text field with ORM methods.

So avoid setting empty string on `default_code`.

opw-2151849
closes #41662

closes odoo/odoo#41674

X-original-commit: d038cc1a0a6e1d939318763aa9dba48aa1eafcf5
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2019-12-10 15:57:17 +00:00
Debauche Stéphane f21b696c6e [IMP] sale_stock_margin: improve the margin computation
Before
======
The margin stay unchanged after the validation of the delivery.

After
=====
The margin is updated when the delivery is validated.
To compute the margin for FIFO products, we use the value in the stock valuation layer as ``standard_price``.

e.g.:
    IN 1 product @ 10
    IN 2 product @ 20
    SO 4 products @ 40

    After delivery validation (after stock move creation), the margin is
    (40 * 4 - 10 - 20 - 20 - 20)

Task #2038418

closes odoo/odoo#41381

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-12-10 16:13:29 +00:00
Debauche Stéphane 39872c9324 [IMP] stock_account: change the standard price calculation for FIFO products
Before
======
If a product is FIFO, the standard price is the unit cost of the last released.
```
+ 1 product @ 10€
+ 1 product @ 15€
- 1 product
-> Actual standard price is 10€

```

After
=====
If a product is FIFO, the standard price of the ``product.product`` is the
unit cost of the next product which will  be released
```
+ 1 product @ 10€
+ 1 product @ 15€
- 1 product
-> Actual standard price is 15€

```

Task #2038418
2019-12-10 16:13:28 +00:00
Ipsita Borisagar 83a5b691af [IMP] project: minimal chatter on project form view
Before this commit, chatter of project form view took about 1/3rd
of screen width on big screen, even though no discussion is possible.

This commit solves this issue by moving the chatter at the bottom of
the sheet, so that it isn't displayed at the right of the screen.

Task-2125078

closes odoo/odoo#41082

Related: odoo/enterprise#6959
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2019-12-10 09:02:02 +00:00
Laurent Smet 6d699ace25 [FIX] payment: Display the "register payment" button in receipts
The button attrs has been well fixed in the 'account' module but not in 'payment'.

closes odoo/odoo#41657

X-original-commit: b5b7131c97aff987ef365dfaeefcbb2dc3bbdf68
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-12-10 13:31:31 +00:00
Laurent Smet d4341ae212 [FIX] account: Fix sequence used by receipts
X-original-commit: 4c4825758c40004ca539f3669d333426664a4406
2019-12-10 13:25:39 +00:00
Laurent Smet 04287b45c8 [FIX] account: Prevent erasing currency when changing the date
- Create a misc. journal entry.
- Add a foreign currency on the line.
- Change the date.
=> The currency is erased because the onchange works only for invoices.

X-original-commit: e0bb4134512ec252b66ecfe91ce259d8cdcffedf
2019-12-10 13:21:53 +00:00
Sébastien Theys 905eed0de1 [FIX] web: introduce format for many2one_reference for form view
The format of `many2one_reference` was not introduced when the new field type
was created, which leads to empty values when the web client is trying to
display the value of such fields in form views.

Since the value of this field is an ID, it is decided to display it like an
integer, which is consistent with previous behavior: the fields that are now
`many2one_reference` are still stored as integer and they were already displayed
as integer before.

This was fixed in list views in commit d0c852f50e
and the current commit fixes it for form views.

opw-2127010
closes #38009

closes odoo/odoo#41666

X-original-commit: c37a16c9dfd09038925034b90ab49e1ab674e714
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2019-12-10 14:46:30 +00:00
Romain Derie 1559750620 [FIX] web_editor, website: better handling of invisible title entry
Using `Title` as invisible entry had the benefit of being translatable
but has the issue to be displayed on mouse over which we don't want.
Using `string` will fix it and will still be translatable.

closes odoo/odoo#41646

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-12-10 15:15:17 +00:00
Hardik Prajapati 907c61bc63 [IMP] l10n_it_edi: shown payment terms in electronic invoice
shown payment information along with bank details in exported
electronic invoice XML file

closes odoo/odoo#41656

Task: 1948158
X-original-commit: 7d2cf514a2443accbb9455553f27bbe2185e47a4
Signed-off-by: Josse Colpaert <jco@openerp.com>
2019-12-10 13:38:43 +00:00
Robin Heinz 97914cc081 [FIX] point_of_sale: fix indentation Account Cash Rounding.
closes odoo/odoo#41655

X-original-commit: 03125ee8162e32ea91534a5fe8df9b597b9df5a7
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-12-10 14:03:23 +00:00
Jorge Pinna Puissant d821999025 [FIX] mail: restore "pencil" icon behaviour in Followers widget
When editing the followers, the "pencil" icon that leads to the edition
of subtypes should be always be displayed, and not only when "debug"
mode is activated. This commit restores this behaviour, as it was not
the case any more.

opw-2144399

closes odoo/odoo#41643

X-original-commit: fd65f85e755eb0b732e0876c1849a0f4806968f1
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
2019-12-09 13:57:47 +00:00
ryv-odoo b5e24e9760 [IMP] stock: readd include exhausted product option
In the inventory adjustment form, readd (remove in 13.0)
the option to include exhausted product.

task-2115194

closes odoo/odoo#41239

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-12-10 14:51:33 +00:00
ryv-odoo 68518afe33 [REF] stock: remove and refactor quantities fetching
In order to clean the fetching of quantities for a inventory,
replace SQL query by a read_group. Also, the _computed_outdated
and _get_inventory_lines_values use the same read_group to be
consistent.

task-2115194
2019-12-10 14:33:16 +00:00
ryv-odoo 04f09a5a17 [REM] stock: remove dead code
In views of stock inventory line,
the view with the id "stock_inventory_line_tree" was not used.
Then remove it, and rename the "stock_inventory_line_tree2"
into "stock_inventory_line_tree".

task-2115194
2019-12-10 14:33:16 +00:00
Victor Feyens 17fbb9428a [IMP] stock: little context cleanup
closes odoo/odoo#41636

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-12-10 13:34:50 +00:00
Victor Feyens c278d99f89 [FIX] stock: traceback when trying to update quantity on hand
When accessing the quantities on hand of a product, `_get_quants_action`
is called to specify the action returned.

In some cases, the action context may be updated.  This led to a
traceback because the context of the action isn't a copy of the current
context but a link to the current context frozendict, which cannot be
updated.
2019-12-10 13:26:47 +00:00
Obay Abdelgadir 6d6b3479cf [IMP] doc: remove deprecated class oe_no_button
Related to issue: #41517
The class has no effect but was still referenced in the documenation

closes odoo/odoo#41629

X-original-commit: 063098bdf3414ffa1db12d3bfc5999506c109329
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-12-10 10:26:04 +00:00
Martin Trigaux b7d91ba25b [I18N] *: remove es_AR translations
Followup of a425695e
The terms were back in 12.0
Courtesy of Juan José Scarafía

closes odoo/odoo#41624

X-original-commit: 85d0c7001a997748d7691205bbb8d066597591a5
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-12-10 10:00:18 +00:00
Simon Lejeune 80b55624c8 [FIX] uom: _check_category_reference_uniqueness
Edit the liters uom (default in its category) and change its category to
unit. You now have two references uom in the unit category. Try to set a
third one and now it fails.

This was because the constraint is implemented with an sql query but
since the new ORM the update in database are delayed. We force a
database update with flush so that the query gant get all the
informations it needs.

closes odoo/odoo#41621

X-original-commit: 68ced7972db64b22a4ff031bba0f78c06a88372d
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-12-10 09:02:53 +00:00
snd 1492e1a644 [FIX] Account journal dashboard bar graph
Fix _get_bar_graph_select_query to correctly compute the residual
amount when calculating the values for the graph of a bill or invoice
journal.

closes odoo/odoo#41592

X-original-commit: 73d28be404901378dc06e756868e5a1ef6cf7b0b
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-12-09 12:15:41 +00:00
Julien Castiaux c999d98421 [FIX] website_slides: image no more available
[Nighly Runbot #730241](http://runbot.odoo.com/runbot/build/730241)

closes odoo/odoo#41571

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2019-12-10 10:46:05 +00:00
Julien Castiaux ffeea439ca [FIX] website_slides: move tours under /static/
All assets have to be loadable directly from the browser, /tests/ is not
accessible, /static/ is.
2019-12-10 10:46:00 +00:00
MaxLarue 028768f288 [IMP] hr_timesheet,helpdesk: Display remaining hours on a task
Show the remaining hours to timesheet on tasks. Allows to quickly evaluate
task's state.

This  is done in the name_get of a task through a context key, because we
need this different name on some views, not all.

related task #1856139

closes odoo/odoo#33586

Related: odoo/enterprise#4400
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-12-10 09:15:17 +00:00
Prakash Prajapati 824b6cf02e [FIX] calendar: fix archive ribbon on private event
When the event is private and some other user going to
see the event at that time it was going to display the
archived ribbon because the active field was not in the list
of public fields(readable field).

so added an active field to the readable list so it will display the
propper archive ribbon on a private event.

Task-2144553

closes odoo/odoo#41589

Closes: #41157
X-original-commit: c1b89567ca3fdd6f4004389aad345ad3e52248c3
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-12-03 06:45:10 +00:00
Prakash Prajapati 9ab4f99db3 [FIX] calendar: fix traceback for calendar private event
Currently when other users view the private event of
another user it display the name of the private event as
'false' instead of 'busy' and onclick of event it generates
traceback.

so to fix it added display_name in condition of read because
the event name displayed in calendar view(previously name) is
replace by display_name in commit 369c20a99b

Task-2144553

Closes: #41157
X-original-commit: 1ec853751bd995449619585db8e17f582ba5e5bc
2019-12-03 06:45:10 +00:00
Nicolas Lempereur 172b69c050 [FIX] web: control panel date filter ok in arabic
The date filters sent to servers were being computed in current locale,
so in arabic we would get things like this:

- "٢٠١٩-١٢-٠٩" instead of "2019-12-09"
- "٢٠١٩-١٢-٠٩ ١٦:١٦:١٥" instead of "2019-12-09 16:16:15"

which would cause a traceback in backend.

opw-2122333
closes #41570

closes odoo/odoo#41596

X-original-commit: da778afc24b048244467649dfa4af4e6f4a78e44
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2019-12-09 15:19:15 +00:00
laa 9cfb6c05a4 [FIX] Portal : missing url args
on the portal:
- in Timesheets, when search something, the text of the search must remain displayed
- in Tasks, when search something, the text of the search must remain displayed
- in Purchase Orders, "Sort By" and "Filter By" selectors shouldn't change when going to next page
- in Timesheets, the "Group By" selector shouldn't change when going to next page

closes odoo/odoo#40278

Related: odoo/enterprise#6787
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-11-28 15:39:03 +00:00
laa cbc93d0d11 [IMP] project: Add a group by stage for tasks on the portal
A group by stage on the portal would allow the customer to have an overview of his tasks' progress, which is especially useful in a multi-project setting.

- add a "Project" column
- rearrange columns in the order: Ref -> Task -> Project -> Stage

- add a group by stage for Tasks on the portal
- hide "Stage" column when group by stage is selected
- hide "Project" column when group by project is selected

- add a sort by project for Tasks on the portal
- when sort by Stage sub-sort by Project
- when sort by Project sub-sort by Stage

- add a 'Search in Project' for Tasks on the portal

- the "Group By" selector shouldn't change when going to next pages
2019-11-28 09:54:12 +00:00
Nicolas Lempereur 98bba5fa0b [FIX] account: invoice report fallback company currency
In 13.0 if currency_id is not set, we are fallbacking on
company_currency_id.

This was not taken into account in account.invoice.report view and so
when grouping by currency, we would get an "Undefined" grouping which
meant "company currency".

Now we fallback on company_currency in the view, and if we displayed
data for several companies with different currency, this should also
remove the amalgamation of different currency in "Undefined" group.

opw-2151492
closes #41491

closes odoo/odoo#41593

X-original-commit: ee2858c9c9eec5121b63bd8565980d93846bcade
Signed-off-by: Nicolas Lempereur (nle) <nle@odoo.com>
2019-12-09 13:15:43 +00:00
oco-odoo 145bd8c49f [FIX] account: when changing the country of a tax report, only delete the tags if they are not linked to any other report
Before that, we deleted all the tags and removed them from the repartition lines all the time; we only want to do that if the tags are not shared with another report, so we use == instead of 'in'.

closes odoo/odoo#41579

X-original-commit: 5f147681c721f5de609622f2cf80b3919eaf49bf
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2019-12-09 12:57:41 +00:00
oco-odoo b2465a48bb [FIX] account: don't delete the tags on taxes when upgrading a tax report
Before that, upgrading a l10n_* module with a tax report removed all the tags from the tax repartition lines.

X-original-commit: a1364bde860266154298034bbae3693161834f49
2019-12-09 12:46:57 +00:00
qsm-odoo 56f6d62324 [FIX] website: restore parallax design
Commit https://github.com/odoo/odoo/commit/cf5b3e1db5d312133eb1af7ff0d5471db47987e5
fixed a problem by creating another one: the parallax with a given speed
appeared broken on page load (which is even more visible in 13.0 with
lazy loading).

This commit restores the design and solves the original problem.

closes odoo/odoo#41594

X-original-commit: a9aa72ecb5350cc0e9fa5b6a17d4db8d2f1895fd
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-12-09 12:24:00 +00:00
Jorge Pinna Puissant 67da6d664f [FIX] account: convert amount in currency into debit/credit
— Enabled multi currency;
— Create new journal entry;
— Add a new line;
— Add the column 'amount in currency';
— Select a different currency than the company currency;
— Set an amount in 'amount in currency'.

Before this commit, the amount in currency is not converted into debit
or credit fields.

Now, the amount is correctly converted into debit or credit fields.

opw-2129294

closes odoo/odoo#41580

X-original-commit: ae3d7aeb706dc1bc3216fd63c6a943e5d9cb56e7
Signed-off-by: Jorge Pinna Puissant (jpp) <jpp@odoo.com>
2019-12-09 09:26:01 +00:00
lejeune quentin ef09a4f44e [FIX] hw_drivers: Fix printer unknow in PrinterDriver
We add a condition to add printer.
Printer, for protocol DNSSD and LPD, must have a "model"

closes odoo/odoo#41591

X-original-commit: a07f118fc7182fa96344fad4a0164ed86c446352
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-12-09 12:47:59 +00:00
Adrien Dieudonne 6b9197244e [IMP] web: Chart.js update to 2.9.3
Update of Chart.js library to the latest version.

Before this commit, we weren't able to see all
x-axis dates labels like in Accounting Overview.
Tick label rotation on mobile has been fixed in
https://github.com/chartjs/Chart.js/pull/5961.

closes odoo/odoo#41582

X-original-commit: 24d8ae59e08143dc0ca7e05be37a3cd607d58a4a
Signed-off-by: Adrien Dieudonné (adr) <adr@odoo.com>
2019-12-09 14:15:05 +00:00
Simon Lejeune 782b5a347c [FIX] stock_account: value of return
When returning a delivery where the value was taken from different
receipt, the last receipt's unit cost was wrongly used when returning
the delivery.

Now we use the `unit_cost` of the delivery when returning it.

task-2150889

closes odoo/odoo#41564

X-original-commit: 468ab4f23c8212e1aba21197b3f83afe741b3d9e
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-12-09 10:20:06 +00:00
lejeune quentin 4bb7fa19f1 [FIX] hw_drivers: Fix detction method for printer
Actual IoT Box not detect correctly Epson TM-T88v.
Now we can detect printer even if name is 'Unknow'

closes odoo/odoo#41563

Taskid: 2153108
X-original-commit: 4c7a1d7a9ba2ad0fbdd92b3a73b0d6294cb6e4a3
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-12-09 09:56:47 +00:00