Commit Graph
123546 Commits
Author SHA1 Message Date
Thibault Delavallée 0e91762c99 [IMP] survey: rename and improve statistics fields
Purpose is to clean a bit those fields. A field holding the number of send
invitations is added as well as a button. It allows to directly jump on
answer linked to an invite which helps dealing with private surveys.

This commit is linked to task ID 1935176 and PR #30689 .
2019-01-31 11:53:44 +00:00
Thibault Delavallée 35df807db8 [FIX] survey: correctly flag answers done with invite
A field exists to differentiate answers done manually through frontend of
survey and answers created through invitation. The field was not correctly
set by the invite wizard. This commit fixes it.

This commit is linked to task ID 1935176 and PR #30689.
2019-01-31 11:53:38 +00:00
Nimesh Jethva c7b24e6831 [IMP] crm_reveal : The 'reveal card layout' could look better.
Improve card layout in chatter.

This commit is related to task ID : 1903882

odoo/closes #29410
2018-12-17 11:38:37 +00:00
wan 82294fd7d3 [IMP] account: reconciliation model usage tracking
Task 1883977

==== Purpose ====
Keep track of journal entries generated using the reconciliation model.

There is no easy way to see a summary of what journal items have been reconciled with a bank statement. This makes troubleshooting difficult. There should be a way to see the detailed history of which bank statement items were reconciled with which journal items.

==== Technical Specs ====

Make a many2one in account.move.line to retrieve the account.reconcile.model having generated this line.
(Make a computed many2many on account.move to the account.reconcile.model)

Add a stat button on the account.reconcile.model form view to retrieve journal entries more easily.

closes odoo/odoo#28752
2019-01-28 13:56:53 +00:00
Kirti Choudhary 78feb99009 [IMP] base: fix demo data
closes odoo/odoo#30725
2019-01-31 11:12:16 +00:00
Hetal Dhanak 32486fc1a6 [IMP] sales: make sign and pay in portal a continuous flow
Purpose of this commit is to make a single flow to sign and pay in the
customer portal. When having signed its document popup for payment is
automatically opened.

This is much better for usability and avoid to have orders being signed
and not paid because the customer did not see it was still to be paid.

This commit is related to task ID 1910532 and PR #29849 .
2019-01-31 10:38:59 +00:00
Thibault Delavallée a0df48e744 [FIX] sale: fix wording of link when sending a quotation by email
Since commit 34c47eecd3 wording of link when
sending a quotation by email is broken. Indeed has document in draft is
not correctly considered as having to be signed and/or paid the link is
not labelled correctly.

This commit fixes it. Parameter is also renamed to be more understandable.
This commit is linked to task ID 1910532 and PR #29849 .
2019-01-31 10:37:40 +00:00
Nimesh Jethva 08d3dd8576 [IMP] mail: Improve res.partner form view
Track field Sales Person in res.partner

This commit is related to task ID : 1911137

closes odoo/odoo#29050
2019-01-31 04:31:30 +00:00
Swapnesh Shah 1971557fdd [IMP] website_forum: make method private
Model methods should be private by default unless they need to be
exposed via RPC on purpose (e.g. for the web client).

The `send_forum_validation_email()` method is only called by a
controller and has no reason to be exposed via RPC, hence the conversion
to private.

Closes #30669
2019-01-30 22:59:08 +01:00
Luis González a914d67661 [DOC] models.py: Fix old reference in _get_external_ids method's doc
It was referencing _get_xml_ids, whereas the method name is
_get_external_ids

closes odoo/odoo#28647
2018-11-14 04:19:38 +00:00
Pratima Gupta de97a490f1 [IMP] various: improve applications and categories name
Purpose is to ease understanding of applications / categories and their
links with the access rights labelling.

This commit is related to task 1884968 and PR #29176.
2019-01-30 14:03:33 +00:00
Hetashree Chauhan c6d798bdf5 [FIX] mrp: cleaner move tracking view
- Harmonize quanity done in stock move header
- Replace product_qty by product_uom_qty the purpose is to stop being
confusing when the user uses UoM. Since for 1 dozen it will show 12
reserved and 1 done because product quantity is in quant UoM not move
UoM.

this commit is related to master bug - 1923213.

closes odoo/odoo#30691
2019-01-30 13:10:03 +00:00
shreya thakrar 2c5cb0ae98 [IMP] POS: update header logo
Specifications:
 * update logo to use the "white from brand"
 * update margin

Task 1933826 PR #30590
2019-01-30 13:50:49 +00:00
Parth Choksi 354187cf80 [IMP] product, purchase, sale: Improved help messages in empty list views
Improve help messages and wording in empty list views.

Task ID: 1920451

closes odoo/odoo#29763
2019-01-09 04:55:00 +00:00
mgh-odoo f5a47e4af6 [IMP] stock: Removed forced groupBy
currently, group by is applied forcefully that user cannot change.
this commit will remove forced group by and applied as a default group by that user can change.

Task: 1910855

closes odoo/odoo#29727
2019-01-02 12:36:41 +00:00
Juhil Somaiya f50bdf5cb4 [IMP] sale,stock,...: Set weight on consumable/storable demo products
This commit is related to task id: 1915274

closes odoo/odoo#29279
2019-01-30 12:59:27 +00:00
Nimesh Jethva 3dda284d74 [IMP] hr_expense : subtype "paid" should be checked by default.
'paid' is main event that every user wants to know so
add subtype Paid checked by default.

Related Task ID : 1914987

closes odoo/odoo#29241
2018-12-13 09:21:29 +00:00
Robot Odoo c075711c9c [ADD] qweb view
Currently, non-trivial client interface customisations generally *have*
to go through client actions (a limited amount can use complex HTML in
the form, but it's not that common). This can require a significant
amount of messing around with JS code, and doesn't integrate well with
the rest of the system (primarily due to the loss of the control panel /
search view).

This change re-uses the existing `ir.ui.view[type=qweb]` as actual views
(bound to a model) to provide for flexible views rendered synchronously
server-side without needing javascript development. A few dynamic
behaviours are also provided (on top of bootstrap's which should be
usable out of the box):

* an extension of `a[type="action"]` which allows for more detailed
  crafting of the action (not just accessing an action by id and by model,
  method)
* a new `a[type="toggle"]` which provides lazy loading of sub-items
  (currently by calling a method which returns HTML to insert after the
  loading anchor)
* simple fold/unfold (without lazy loading) can be performed through
  bootstrap

closes odoo/odoo#28716
2019-01-30 17:12:20 +01:00
Arnaud Baes bf4a8b3de8 [IMP] purchase: Email sent from PO sent by the current user.
When an email was sent from a PO, the sender was by default the user who created the PO.
The sender is now replaced by the current user.

TaskID: 1934477

closes odoo/odoo#30660
2019-01-29 15:04:59 +00:00
Antoine Guenet fa5c987c86 [FIX] web_editor: preserve image classes when replacing image
closes odoo/odoo#30661
2019-01-29 14:56:42 +00:00
Adrian Torres ee6dc40a60 [IMP] fields: forbid required m2o ondelete set null
A many2one field that is required means that its column cannot contain
null values, however the default ondelete policy for all m2o fields is
`set null`, which contradicts `required=True`.

This patch will, by default, apply the `restrict` policy to required m2o
fields unless the ondelete attribute is explicitly specified. However,
if the policy specified is `set null`, a ValueError will be raised
whenever the registry registers the field as this makes no sense.

The default ondelete policy remains unchanged for non-required m2o
fields (set null)

closes odoo/odoo#30122
2019-01-29 16:17:03 +00:00
qsm-odoo 9ea1eb7aa5 [REF] website_event: properly define and use country events snippet
The snippet was not using an XML template of his own and its code was
duplicated by the "Country Events" option.

closes odoo/odoo#30663
2019-01-29 16:30:35 +00:00
Xavier Morel f5438289bd [CHG] sale_timesheet: convert project overview to qweb view
Note: conversion was performed with as little code changes as
      feasible, mostly moving code from the controller to the model &
      inlining some parameters
2019-01-29 10:22:35 +00:00
Xavier Morel 58e0c88ece [ADD] web: server-side-rendered qweb templates as views 2019-01-29 10:22:18 +00:00
Xavier Morel 1d1d5ed7ad [IMP] web: prevent default in _onActionClicked
This avoids odd behaviour when leaving a `href="#"` on a link with
target=action: without preventing the default behaviour, it would first
switch to the application switcher (/web/#) then actually execute the
action.
2019-01-29 10:22:17 +00:00
Xavier Morel 9db74611de [IMP] web: action links from bits & pieces
Before this, the action manager only supported auto-triggering actions
from (model, method) or (action_name).

This adds support for providing all the action details via data
attributes:

* model (defaults to current action's)
* resid (defaults to none)
* views (defaults to list, form, unless resid is specified then
  defaults to just form)
* domain (defaults to [])
* context (defaults to {active_id, active_ids, active_model} from
  current action if the model has not changed, empty otherwise)

The action's name/title is either the link's title (?) or its textual
content.
2019-01-29 10:22:17 +00:00
Xavier Morel 42fbee83ad [IMP] qweb: stop requiring t-name-flagged sub-node
QWeb's rendering currently *requires* that when loading a document
instead of rendering the document itself it will render a sub-node
with a properly labeled t-name. If a view is invoked by id, ir.qweb
will look for a child with a t-name and fix up that t-name such that
the base qweb object will find and render it.

This feature mostly exists for JS compatibility (because a single
document can contain multiple cross-linkable templates, and it was
useful for cross-implementation tests though I'm not sue they're even
checked anymore), and the <template> tag kinda took care of it,
however with a more proper qweb view it becomes more of a liability /
pain in the ass.

Note: turns out there are bits of javascript which read server
templates (???) and need to be altered to correctly handle the lack of
<templates> wrapping.
2019-01-29 10:22:17 +00:00
Antoine Guenet a27837a000 [FIX] web_editor: properly disable the toolbar on snippet removal
Update editor toolbar on each change to properly disable it when needed

closes odoo/odoo#30594
2019-01-29 07:54:58 +00:00
Thibault Delavallée 0598d975dc [FIX] survey: fix prefill
It seems page_id is now a string instead of an int.

closes odoo/odoo#30639
2019-01-29 09:12:49 +00:00
Thibault Delavallée c273e89d55 [REF] website_slides: introduce slide / user relationship and use it for vote
Purpose of this commit is to store a relationship between slides and users.
Indeed starting from now we will track more user interaction with the slides
module.

In this commit we introduce a model that is used to populate and decorate
the relationship between slides and users, slide.users. From slides or users
point of view it behaves like a many2many. It can also be used to store
more information about the user interaction with the slide.

We use it here to store the user vote. Like and dislike are not static
counters anymore but computed fields based on user votes. It is implemented
as a tristate field.

As it is a technical model no access on slide.users is granted. Controllers
and methods grant access to the relationship in order to avoid information
lead and keep technical details private.

Future commits improving the eLearning use of slides will notably store
information about user having read the slide, taken a quizz or gaining
karma depending on some actions performed on the slide.

This commit is linked to task ID 1934488 and PR #30620 .
2019-01-29 09:24:48 +00:00
Yenthe666 bf4427f682 [FIX] lunch: make lunch location name required
closes odoo/odoo#30627
2019-01-28 17:04:14 +00:00
Christophe Simonis cfd0147439 [FIX] website_{sale,slide}: remove duplicated field in view
Oversight of previous forward-port.

closes odoo/odoo#30626
2019-01-28 16:38:54 +00:00
Christophe Monniez 609c3ea573 [FIX] tests: avoid check document.readyState of about:blank
In an HttpCase test, when the browser_js method is used, an optional
javascript code can be used to check that the page is ready to execute
the test.

When no 'ready' code is given it defaults to check the
'document.readyState' status.

In some rare cases (discovered by @Xavier-Do) this status is checked on
the 'about:blank' page. As the page seems ready, the test code is
evaluated and fails.

With this commit, when no specific ready code is provided, the test will
wait for a chrome devtools event that ensure the page is fully loaded
before starting the test.

cherry-pick of 03a8819652

closes odoo/odoo#30609
2019-01-28 13:16:26 +00:00
David 60748a95e2 [FIX] point_of_sale: wrong tax in fp if unmapped
- If a fiscal position is set in the point of sale and a product tax
isn't mapped in it, it wasn't applying any tax at all. After this fix,
the tax defaults to the product one.

closes odoo/odoo#30556
2019-01-28 15:07:57 +00:00
Robot Odoo a0074af212 [MERGE][FIX] website_slides: fix various issues
Purpose of this merge it to merge various fixes and small improvements
related to slides module. As an update of this module is pending fixing
it before is quite helpful.

This merge is linked to task ID 1933820 and PR #30553.
2019-01-28 17:23:55 +01:00
Thibault Delavallée 088041f79d [FIX][IMP] channel: improve can_upload / can_see computation on channel
Purpose of this commit is to clean a bit interface of slides

 * separate can_see from can_upload;
 * correctly set can_see on partial visibility channels;
 * remove upload button for portal users as they have no rights to upload a
   document and this is not supported in any way;

This commit is linked to task ID 1933820 and PR #30553.
2019-01-28 15:37:14 +00:00
Thibault Delavallée f766653780 [FIX][IMP] slide: do not propose to create tags / category if no right
This commit is linked to task ID 1933820 and PR #30553.
2019-01-28 15:37:14 +00:00
Thibault Delavallée c5da7b8aeb [IMP] website_slides: improve like / dislike
Like / dislike of slides is fixed and improved to make a tri-state like
behavior. Future commit will change this implementation in order to use
a relationship table between users and slides as we are moving towards
the eLearning platform. Let us have this simple implementation currently
and rewrite it in a near future.

This commit is linked to task ID 1933820 and PR #30553.
2019-01-28 15:37:13 +00:00
Thibault Delavallée 2db50e5796 [FIX] website_slides: quickly fix pdf viewer not appearing
Pdf viewer does not display or is incorrectly displayed. This commit proposes
a minimal fix to at least display the iframe holding the pdf viewer.
This will be improved with eLearning improvements for slides.

This commit is linked to task ID 1933820 and PR #30553.
2019-01-28 15:36:30 +00:00
Thibault Delavallée d3e462b279 [FIX] website_slides: fix statistics computation
Statistics computation section is a bit broken as some variables are
incorrectly defined or propagated.

This commit is linked to task ID 1933820 and PR #30553.
2019-01-28 15:36:30 +00:00
Thibault Delavallée a912c09304 [FIX] website_slides: fix various calls undefined methods
Several places call 'this' whether it is not linked to the current object.
Use self instead.

This commit is linked to task ID 1933820 and PR #30553.
2019-01-28 15:36:30 +00:00
Sébastien Theys 130af96dc1 [IMP] portal,sale: improve signature widget and move it to portal
Purpose
=======

The goal is to avoid duplicate code between portal and sign (enterprise), and
also to allow the user to use the signature mode 'auto' and 'load' in portal
(before this commit only 'draw' was available in portal).

The sales order signature (currently the only portal signature) has been changed
to use this new code.

This signature widget has been improved:

Improved style:
 - better structure and use of BS classes
 - removed most of custom CSS
 - made it more responsive

Changed code to follow guidelines, added JSDoc.

Technically
===========

New widget NameAndSignature common to portal and sign (enterprise).

Reworked existing portal signature form to use new widget.

Related to enterprise PR https://github.com/odoo/enterprise/pull/3266

task-1894903

closes odoo/odoo#29453
2019-01-28 09:48:32 +00:00
Xavier Morel a0e05e2ab9 [IMP] fields: selection fields only use strings
closes odoo/odoo#29039
2019-01-26 14:25:44 +00:00
Darshil Trivedi c48c3e6155 [IMP] stock, purchase_stock: Stock move description
Display product picking,receipt or delivery description depending
the picking type. The purpose is to display usefull information/note at
the right place at the right moment.

This commit is related to task ID : 1880135

closes odoo/odoo#28175
2019-01-28 10:35:11 +00:00
Christophe Simonis cf52a04979 [MERGE] forward port branch saas-12.1 up to d3b8422c9c
closes odoo/odoo#30614
2019-01-28 13:58:11 +00:00
Nicolas Martinelli cd1f57e9de [FIX] website: misspellings
opw-1931844

closes odoo/odoo#30561
2019-01-28 07:13:21 +00:00
qha-odoo 5b563549fa [IMP] website_event, *: refactor website events layouts
* base, portal, website, website_event_sale, website_event_track

- The previous event registration form was not clear on mobile

- Review some layouts to match the new design general idea, using cards
  (see forum refactoring of https://github.com/odoo/odoo/pull/29235)

- Use correct bootstrap components (like a menu instead of a breadcrumb
  on event pages)

- Review options to be able to disable the left / right column and
  choose the exact options you want to appear in them

task-1858034

closes odoo/odoo#30559
2019-01-25 14:30:55 +00:00
Florent de Labarre 340bc5c42e [IMP] hr_holidays: archived leave type
Add a filter for archived leace types.

closes odoo/odoo#30279
2019-01-25 14:41:58 +00:00
Siddarth Gajjar b43fcd6700 [FIX] mass_mailing: restore email templates
Following the new editor's merge at https://github.com/odoo/odoo/pull/29775,
the classes 'o_mail_wrapper' and 'o_mail_wrapper_td' were renamed to
'o_mailWrapper' and 'o_mailWrapper_td' because of what appears to be a
JS-variable-search-replace fail. Strange enough, the scss was not
impacted which allowed to see the bug in master.

closes odoo/odoo#30544
2019-01-25 12:43:43 +00:00
Robot Odoo 26f828e6c9 [MERGE][REF] survey: further refine access mode
Purpose of this merge is to improve access mode and authentication management
introduced at 9771fdfe8f . Purpose of this cleaning is to simplify options and make
them clearer. Instead of a selection with 4 entries we propose to use two
fields on survey model :

 * access_mode: everyone with a public link can access and answer; or only
   invited people;
 * login required: whether people have to login to answer or not;

All main use cases are covered with combination of those two options.

In this merge we also refine survey routes now using an access token defined
on survey model instead of its ID. It allows to keep surveys somehow private
especially for surveys on invitation only.

Some fixes related to last changes are also done in this merge. Some
improvements in survey templates are also provided to ease their update.

This merge is linked to task ID 1932508 and PR #30508.
2019-01-25 15:57:41 +01:00