Commit Graph
127612 Commits
Author SHA1 Message Date
Rémi Rahir 376415052c [FIX] phone_validation, crm_phone_validation: Phone number parsing
Before this commit, when filing a phone number field on a model form (typically on website_form),
the module phonenumbers would try to parse the number against the country of the model.

However, this call fails when the number starts with 00 instead of + and that the model
doesn't have a country_id field or if said field is not set.

For this specific case, we chose to skip the number parsing altogether as providing a default
country to the parser can lead to a wrong parsing. i.e, phonenumbers.parse(+32477111111, 'US') will
find the number as US-based when it is a belgian number.

solves issue #22513

Also corrected a faulty behaviour where the option to have a number parsed in its international format
field `phone_international_format` on `res.company` was never properly assessed when the field comany_id of a
model was not present in the model's form view. Added company_id field on opportunity's form view for a proper fix.

Also fixed a syntax error in a logger.
2018-02-07 14:22:46 +01:00
Romain Derie 66e76d681d [FIX] payment_stripe: integer currencies (portal payment)
Before this commit:
On portal (My Account > Invoices > Pay Now), a stripe payment in a normal
currency (eg: a non integer currency) would debit the amount *100.
This comes from b335ae0348 which added a workflow to handle integer
currencies but it also sent the *100 amount to /website_payment/transaction
that would create a TX with that amount instead of the normal amount.

Now, the normal amount is correctly sent to the backend, the multiplied amount
is just sent to StripeCheckout handler to correctly display the amount on the
popup after clicking on "Pay Now".

Note: the amount will be multiplied on the backend independently ecda057e11
2018-02-07 13:59:33 +01:00
Romain Derie b2b71efb36 [BACKPORT] website: translation if website default lang is not en_US
Before this commit:
When website default lang was not en_US, the translation of fields* in the
web_editor would not be saved correctly.
Let's illustrate with fr_BE set as main lang:

  The web_editor's RPC calls does not send language in the context when editing
  a page (6ebcc06), but it does in translation mode.
  Note that editing is always performed in the website main lang, fr_BE in this
  case.
  Therefore:
  1. When EDITING:
    The backend suppose the language is en_US as there is no lang in the
    context (hardcoded everywhere).
    It then write in the record itself instead of the ir.translation as it
    should since fr_BE is a translation. (In Odoo, every lang is a translation,
    en_US is  always the main lang)
  2. When TRANSLATING (in en_US):
    It would also write on model as the web_editor send the language to the
    backend when in translate mode. But since en_US is recognized as the main
    lang (which is correct), it also writes in the model, overriding the
    incorrect fr_BE writing which was also wrote on the model.

This has been fixed in 10.0 with these 2 commits:
036ccbe
2955bf2

With these fixes, the lang is correctly added (by the backend) if the website
module is installed.
By ensuring the lang is correctly set, the ORM _write() function will process
the edition and translation datas as it should:

  - If it receive en_US, it will write on the model
  - If it receive another lang, it will write on ir.translation

This closes #10883, closes #22403

*Not the HTML/XML fields which are handled differently by the ORM/translation
2018-02-07 13:35:03 +01:00
Christophe Simonis ae3643ba2a [MERGE] forward port branch 10.0 up to a93a9d43e6 2018-02-07 13:34:03 +01:00
Martin Trigaux 2c6bad6b75 [FIX] calendar: wrong label on field
Was not meaning anything, or implying a number while the fields is a boolean

Courtesy of e2f translators
2018-02-07 17:54:10 +05:30
qsm-odoo a93a9d43e6 [FIX] website: allow "Customize theme" when CDN option enabled
Traceback because the `_get_asset` function was called by the
`theme_customize` route without the `values` argument (which is not
necessary for the feature).

Closes https://github.com/odoo/odoo/issues/22516
2018-02-07 12:50:28 +01:00
Christophe Simonis 7f153c021a [MERGE] forward port branch 9.0 up to 80f88ad63b 2018-02-07 12:32:32 +01:00
celm1990 80f88ad63b [FIX] point_of_sale: unmark order finalized when invoice failed
When we validate an order that need to be invoiced, and the customer is
not set, you have to enter a customer, but your order is finalized so
you have a traceback saying it cannot be modified when you try to set
the customer.

When the invoicing fails, we don't set the order as finalized.
2018-02-07 11:00:48 +01:00
Aaron Bohy 7937347d75 [IMP] web: invalidate JS cache for some models
Models concerned are 'ir.ui.view', 'ir.actions.act_window' and
'ir.filters'.

The DataManager's cache is invalidated at each create, update and
unlink operation. This cache stores actions (results of calls to
/web/action/load route), views (results of load_views RPCs) and
filters (fetched alonside views).

This rev. thus spares the user from reloading the webclient after
performing such operations on these models to see the changes in
the interface, as he only has to replay the action to see the
changes.
2018-02-07 08:49:58 +01:00
Florent de Labarre ee7e9198f2 [FIX] stock: don't update a move line with qty=1 with serial product
Use case to reproduce:
- create a product A with serial number
- add 2 product A in stock
- create a delivery order with this 4 product
- Check Availability
- add 2 more product A in stock
- Check Availability
- in the first line the quantity is now 3

It happens because _update_reserved_quantity on stock move
try to add the quantity reserved on simililar move lines.
Howevever in serial case we don't want to have a move line
with a reserved quantity greater than 1.
2018-02-06 17:10:20 +01:00
Nicolas Lempereur c123049805 [FIX] mail: notif display form view not kanban
In mail change about activities in 07f1e902 when opening the record of a
notification, kanban view was in the action views but there doesn't seem
to be a reason and this caused an issue on enterprise mobile (since
kanban view if available has priority).

opw-804529
closes #22848
2018-02-06 15:53:25 +01:00
Martin Trigaux 34d2765faa [FIX] crm: allow to unlink multiple records
Closes #22647
2018-02-06 20:12:37 +05:30
Martin Trigaux 20f2de8296 [FIX] resource: prevent adding wrong hours
e.g. negative hours, over 24h, start > end

Task id: 36965
opw-802816
Closes #20449
2018-02-06 19:58:42 +05:30
Mehul Patel 2a350c0934 [IMP] *: Add kanban view for smart mobile list view
See https://www.odoo.com/web#id=40281&view_type=form&model=project.task&action=333&active_id=131&menu_id=4720 for more information...
2018-02-06 15:23:44 +01:00
Florent de LabarreandNicolas Martinelli 71d5425c83 [FIX] purchase: update PO line in procurement
Allow inheritance for PO update as it is already the case for PO
creation.

Closes #22224
opw-806807

Co-authored-by: Nicolas Martinelli <nim@odoo.com>
2018-02-06 13:38:12 +01:00
Nicolas Martinelli 4d213a3795 [IMP] purchase: consistency in method parameters
Make `_prepare_purchase_order` and `_prepare_purchase_order_line` using
consistent parameters.

opw-806807
2018-02-06 13:36:46 +01:00
Mitali Patel 3d913cd5f4 [IMP] website_quote: show product description only once ,In case of several variants of the same product template in the quotation
Purpose
=======

In website quote template
Example: I have 3 bikes with 3 different colors.
     On web page i have 3 blocks, 1 per variant.
This is confusing to have 3 times the same description...

Specification
=============

In case of several variants of the same product template in the quotation, only show the product html description once (since it's common to all the variants)

- On the Preview Quotation page, display the product description only once.
- On the Quotation Template edition, display the suggested product and the product description only one.
2018-02-06 13:08:59 +01:00
Pierre Rousseau 3c2d407dd6 [IMP] sms: show characters count 2018-02-06 12:57:50 +01:00
Martin Trigaux 0bd8c0ddc8 [FIX] account: typo 2018-02-06 17:12:22 +05:30
Martin Trigaux 539a67e62f [IMP] account: clarify error message
Courtesy of e2f translators
2018-02-06 17:03:47 +05:30
Martin Trigaux 57da0a5d60 [FIX] hr_payroll: fix typo
Courtesy of the e2f translators
2018-02-06 16:38:35 +05:30
rmu-odoo f6216a99df [IMP] sale,account: display tax amount when rounding method is perline
Display the tax amount on the sale/invoice line report

Task id: 31052
Closes #20531
2018-02-06 15:49:45 +05:30
Nikunj Ladava 7895862584 [IMP] sale_payment: hide payment acquirer form when order total is 0 2018-02-06 10:35:39 +01:00
Nikunj Ladava 359769aa8b [FIX] sale_payment: able to pay sale order from portal
Revision on https://github.com/odoo/odoo/commit/eefe879a37aba221bda84adfd880fb7876955920
Changes in the portal payment are wrong, it stops user to pay sale order from portal.
2018-02-06 10:35:39 +01:00
Swapnesh Shah a04a97cec5 [Fix] hr_maintenance: typo
`auto-install` key in manifest instead of `auto_install`
2018-02-06 10:19:38 +01:00
Kinjal Mehta e25d0b3891 [IMP] project: Remove a shared stage if no linked record inside this project
Purpose
=======

Projects may have share columns. If we want to delete a stage on a project there's several use case

Specification
=============

Different use cases:
- The stage is shared
	- There's no task in this stage for this project: Remove the stage from this project, don't delete it
	- There's a task in this stage (Active or not): Raise an error from the ondelete restrict
- The stage is not shared
	- There's no task in this stage: Delete the stage (unlink)
        - There's a task in this stage (Active or not): Raise an error from the ondelete restrict
2018-02-06 08:56:54 +01:00
Kinjal Mehta 05fc6f52d0 [IMP] web: combine user context with record context on 'deleteRecords' 2018-02-06 08:56:54 +01:00
Kinjal Mehta 89c07862d5 [IMP] crm, project,...: Prevent stage deletion when there's a linked record
Purpose
=======

Avoid having people getting some tasks lost in the "undefined" column. Because they won't understand what it means an how they achieve it.

Specification
=============

Add an "ondelete='restrict'" on the stage field definition.
2018-02-06 08:56:54 +01:00
Nikunj Ladava b2d4238246 [FIX] account_payment: Remove the title argument form UserError
Purpose
=======

Actually UserError is not made to take a title actument.
2018-02-06 08:49:31 +01:00
Miquel Raïch d219963192 [FIX] purchase_mrp: correct manifest
Title underline was too shat, making the rendering crash

Closes #21756
2018-02-06 12:46:19 +05:30
Wolfgang Taferner 90ab699d90 [CLA] WT-IO-IT GmbH signature of Corporate CLA
Closes #22825
2018-02-06 12:43:23 +05:30
Kirti Choudhary bacc043fb5 [IMP] mass_mailing: Display the number of clicks on reporting
Purpose
=======

On the pivot table for reporting on mass mailing you have all the options on the individual mass mailing, except clicks.
This stat is however available in mass mail form

Secification
============

Add 'Clicks' in pivot table reporting view
2018-02-06 06:36:05 +01:00
Wolfgang Taferner 3b8ba47f11 [FIX] purchase: Display a more accurate title on purchase report 2018-02-06 06:32:17 +01:00
Joren Van Onder 392fa1471e [IMP] l10n_co: add some lesser used document types
These should be all legally recognized documents.

opw-781247
2018-02-05 16:25:55 -08:00
Joren Van Onder 4b74cea413 [FIX] l10n_co: only validate VAT for RUT document types
In Colombia customers can legally identify themselves with various
codes, one of which is the RUT. This is the traditional TIN and
adheres to the rules implement by base_vat. The other types however
don't and so shouldn't be checked by base_vat.

opw-781247
2018-02-05 16:19:48 -08:00
Joren Van Onder b44f559fe7 [FIX] l10n_co: no longer use l10n_co_verification_code
The l10n_co_verification_code field shouldn't have been added in
l10n_co. Instead users should simply append the verification code to
the VAT. This way the vatnumber module used by base_vat will handle
validation correctly.

Removing this is necessary because otherwise we give the impression
that the verification code doesn't have to be included in the VAT
number which makes base_vat complain.

The l10n_co_verification_code will be removed in master.

opw-781247
2018-02-05 16:19:48 -08:00
Joren Van Onder 50f6b19660 [IMP] l10n_co: set some default accounts on taxes
opw-781247
2018-02-05 16:19:48 -08:00
Joren Van Onder a7ca77ce7f [FIX] l10n_co: IVA Compra tax increased to 19% in 2017
opw-781247
2018-02-05 16:19:48 -08:00
Joren Van Onder 4dcb0c83d3 [IMP] l10n_co: set the correct default sale and purchase tax
The default sale and purchase tax are determined by the default_get
method of wizard.multi.charts.accounts. It will pick the sale and
purchase tax with the lowest sequence.

This adds a sequence field in account.tax.template.csv so the default
ones can be given a lower sequence.

opw-781247
2018-02-05 16:19:48 -08:00
Joren Van Onder 986a7550a5 [IMP] l10n_co: add some useful accounts
- Certain income accounts
- Accounts related to taxes
- Accounts related to the Rte Fuente Certificate Report

opw-781247
2018-02-05 16:19:48 -08:00
Géry Debongnie a98beb13db [FIX] web_editor: correct check of 'rules' property
see issue #22517
2018-02-05 20:24:23 +01:00
remi-filament 160ddc8567 [FIX] web_editor: correct check of property 'rules'
Port of PR #22603 from v9 to v10
See Issue #22517

 (#22679)
2018-02-05 20:21:45 +01:00
Nicolas Lempereur 32ba4a20ca [FIX] website_quote: website quote array on mobile
On website quote the main informations are displayed in 4 columns (2 for
headers, 2 for content) which can be ugly or having content overlaying
content on mobile.

This commit makes a change so mobile gets only two columns (header and
content).

opw-805200
closes #22808
2018-02-05 17:26:35 +01:00
Christophe Simonis bba0bc6ded [MERGE] forward port branch saas-11.2 up to eefca5d492 2018-02-05 17:21:35 +01:00
Christophe Simonis eefca5d492 [MERGE] forward port branch saas-11.1 up to 73610ff992 2018-02-05 16:20:48 +01:00
Christophe Simonis 73610ff992 [MERGE] forward port branch 11.0 up to d130f22432 2018-02-05 15:59:31 +01:00
Pierre Masereel 86c0045bef [REF] stock,stock_account: remove function do_transfer
We removed the function do_transfer that is deprecated since Odoo 10.0

We also remove useless call of functions with context 'debug'
2018-02-05 15:54:25 +01:00
qsm-odoo d130f22432 [FIX] web_editor: resolved failed forward-port
Forward-port https://github.com/odoo/odoo/commit/f5e7b866860436782ade53308da1ff725be1f124
failed for commit https://github.com/odoo/odoo/commit/78a556601e6b1e72c6d1ac776e31588dd2ffa28f
2018-02-05 15:30:18 +01:00
qsm-odoo 1ed7f219a5 [FIX] mass_mailing: complete commit 66aefb1723
- There should not be margins around lists
- There should not be editor overlay on the whole content
2018-02-05 15:18:55 +01:00
qsm-odoo 4999449c8a [FIX] mass_mailing: resolve failed forward-port
Forward-port https://github.com/odoo/odoo/commit/e00a447e2ca277697bd3e3cae5196e8177d3e867
failed for commit https://github.com/odoo/odoo/commit/94c954121efafcf01e0ae4a37425678642b5d4a5
2018-02-05 15:18:55 +01:00