[FIX] l10n_co: no longer use l10n_co_verification_code

The l10n_co_verification_code field shouldn't have been added in
l10n_co. Instead users should simply append the verification code to
the VAT. This way the vatnumber module used by base_vat will handle
validation correctly.

Removing this is necessary because otherwise we give the impression
that the verification code doesn't have to be included in the VAT
number which makes base_vat complain.

The l10n_co_verification_code will be removed in master.

opw-781247

addons/l10n_co/models/res_partner.py

@@ -12,7 +12,7 @@ class ResPartner(models.Model):
                                               ('foreign_id_card', 'Cedula de Extranjeria'),
                                               ('external_id', 'ID del Exterior')], string='Document Type',
                                              help='Indicates to what document the information in here belongs to.')
-    l10n_co_verification_code = fields.Char(compute='_compute_verification_code', string='VC',
+    l10n_co_verification_code = fields.Char(compute='_compute_verification_code', string='VC',  # todo remove this field in master
                                             help='Redundancy check to verify the vat number has been typed in correctly.')
 
     @api.depends('vat')

addons/l10n_co/views/res_partner.xml

@@ -9,7 +9,7 @@
                 <field name="l10n_co_document_type"/>
             </field>
             <field name="vat" position="after">
-                <field name="l10n_co_verification_code"/>
+                <field name="l10n_co_verification_code" invisible="1"/>
             </field>
         </field>
     </record>