Commit Graph
127612 Commits
Author SHA1 Message Date
tbe-odoo 825180867a [FIX] hr_holidays: Remove related on employee's department
- In SaaS-16 we have added a related on the employee's department.
    This causes access rights issues when changing the employee's department.
    We do not want to rewrite all the old records, only the new ones should use the new employee's department.
2018-02-19 10:39:04 +01:00
Goffin Simon 5c1f025a42 [FIX] sale_timesheet: Field Invoicing Policy in Product Variants not saved correctly
When a product variant from Catalog > Product variant was created
with invoice policy = 'delivery', it was set as 'order'.

opw:815112
2018-02-19 10:24:36 +01:00
Arnold Moyaux e242ee5f74 [FIX] stock: log activity with SO without line
Use case to reproduce:
- Install sale_stock
- Create a SO
- Cancel it
Traceback

It happens because _log_activity_get_documents need at least
one entry in the dict orig_obj_changes.
2018-02-19 10:18:00 +01:00
Kishan Gajjar 90e8da9b4f [FIX] portal: It ask to login even if user already logged in
- options inside the template will not be correct if we set options in start method(template already loaded when start is call), for the correct value of options inside the template we must set it inside willstart

(PR  #22751)
2018-02-19 10:09:08 +01:00
David Arnold 906a9af8f2 [FIX] bus: set timeout to gracefully recover
Before this in the event of a network failure that lasts longer than the respective return cycle of the deferred call,
this deferred will keep in purgatory forever (until reload of the client).
This is not problematic in the normal use case, but working with offline modules, such as POS or similar making use of the
long polling concept for synchronization purposes, this generates toxic behavior.
Simply: The client state never recovers on it's own from the network failure

(PR #21653)
2018-02-19 10:05:50 +01:00
David Arnold 59202d5e8c [FIX] bus: set timeout to gracefully recover
Before this in the event of a network failure that lasts longer than the respective return cycle of the deferred call,
this deferred will keep in purgatory forever (until reload of the client).
This is not problematic in the normal use case, but working with offline modules, such as POS or similar making use of the
long polling concept for synchronization purposes, this generates toxic behavior.
Simply: The client state never recovers on it's own from the network failure

(PR #21653)
2018-02-19 09:59:01 +01:00
XavierDo 813065cb5b [IMP] mail: add settings button on channels
The settings of a channel were available in debug mode only. Adding a settings button on each channel allows to read/edit a channel settings easily.

Remove the unsubribe button and the settings button from the top of the page since they can be acceses another way now.
2018-02-19 09:48:38 +01:00
Xavier Morel 965f492018 [FIX] website: don't include empty keyword & description metas
Apparently, SEO audit thingies (possibly google's own? unclear) don't
ignore *empty* keyword or description meta tags, then complain that
they're duplicated (there's a use case for SQL-like nulls).

So remove the keyword & description metas entirely if the
corresponding fields are empty.

OPW-815492
2018-02-19 09:47:28 +01:00
Jordi Ballester Alomar 5404b8b4e7 [FIX] doc: update default values
limit_memory_soft and limit_memory_hard had values default different that the
ones written in the documentation

Introduced at 3ef93918a

Closes #23131
2018-02-19 08:52:14 +01:00
Odoo Translation Bot d070bdf536 [I18N] Update translation terms from Transifex 2018-02-18 07:06:15 +01:00
Odoo Translation Bot 0be75775de [I18N] Update translation terms from Transifex 2018-02-18 04:28:35 +01:00
Odoo Translation Bot 40aedd74a3 [I18N] Update translation terms from Transifex 2018-02-18 01:04:11 +01:00
Joren Van Onder f76cc095b8 [FIX] point_of_sale: fix the behavior of default fiscal positions
Issue 1) and 3) in 73f7567627 still
occured in 11.0. It seems this was not fully forward-ported, most
likely due to conflicts caused by
ac89783d2f.

opw-782855
2018-02-16 13:48:59 -08:00
Aaron Bohy ff019aa52f [FIX] web: BasicModel: onchange on X2M: handle command 6
Before this rev., when an onchange returned a command 6 for an
x2many field, it was completely ignored by the BasicModel.
2018-02-16 14:28:50 +01:00
Aaron Bohy cf03101447 [FIX] web: BasicModel: fetch nested x2manys after onchange
When onchange RPCs return a command 4 (LINK TO), the res_id of the
record to link is given, and the BasicModel has to read the fields
in the view for that record. When one of those fields is an x2many
(for instance, displayed with widget many2many_tags), the
subrecords in the relation must be read as well (at least their
display_name).

Before this rev., this last part wasn't done by the BasicModel, and
as a consequence, the many2many_tags widget was always empty, even
though there were records in the relation.

Same thing applied to reference fields, but this is way more
uncommon.

This rev. ensures that x2manys and reference fields are correctly
fetched in this scenario.
2018-02-16 14:28:50 +01:00
Christophe Simonis 0017902733 [MERGE] forward port branch saas-16 up to 675a876347 2018-02-16 13:58:16 +01:00
Christophe Simonis 675a876347 [MERGE] forward port branch saas-15 up to 3a25ff6ccd 2018-02-16 13:57:38 +01:00
Christophe Simonis 3a25ff6ccd [MERGE] forward port branch saas-14 up to 67cc7a7c26 2018-02-16 13:57:03 +01:00
Christophe Simonis 67cc7a7c26 [MERGE] forward port branch 10.0 up to dce265e8fe 2018-02-16 13:25:38 +01:00
xmo-odoo dce265e8fe [FIX] stock_account: typos causing errors
OPW-816769
2018-02-16 13:22:12 +01:00
xmo-odoo 06b565e942 [FIX] stock_account: typos causing errors
OPW-816769
2018-02-16 12:49:29 +01:00
Olivier Colson a42ee08676 [FIX] stock_account: use correct rounding for anglosaxon accounting's price difference line generation
These data are expressed in invoice currency, they must be rounded accordingly.
2018-02-16 12:41:48 +01:00
Alexandre Kühn b09f0c99be [FIX] web: discard new record with empty required field
Before this commit, there is an issue with one2many lists with records that
have been created on 'default_get': if the record has a required field that
is empty, when the user clicks on this empty required field and then somewhere
else, the record is removed from the list.

The cause of this bug is that these records have invalid field changes, here
the required field that is empty. As a consequence, it checks whether the
record is "new", and if so, removes it visually from the editable list.
(Note: a record is "new" when it is not stored in DB).

This behaviour is expected when discarding records created from "Add an item".
However, that is not intended for records that have been created as default
items of the list. These records are still considered as "new"  items, because
they are not stored in DB, but they should stay in the list on discard.

This commit solves the issue by making an additional check before assuming
that the record for which we discard changes comes from "Add an item":
if the record in the list has been created before user interacts on the list
(in other words, the record has been added in the list when the user accesses
it), then we should not remove the record from the list, even though the record
has some invalid fields from the savepoint (e.g. empty required).

opw-806650
2018-02-16 11:17:36 +01:00
Alexandre Kühn aa8745f1a8 [FIX] web,*: various nocontent helper fixes
* account, board, hr_holidays, mail, sale, website_sale

Small fixes on nocontent onboarding screens.

Initial commit: https://github.com/odoo/odoo/commit/a87d761fdbf345ada5dc93e0a686b08a0f5a0417

Details:

- list: centered;
- pivot/graph: centered + empty folder face;
- Dashboard app with nocontent helper;
- Discuss inbox/starred: centered without neutral/smiling faces;
    => no faces because it's too much with animated
       rainbow man when emptying the any of the boxes.
- hr_holidays: fixed onboarding screens;
- (technical) dropped obsolete 'o_view_nocontent_container' style;
- manual reconciliation 'nothing to reconcile': centered + inside form sheet;
    => renamed account's o_view_nocontent to o_view_noreconciliation,
       so that it doesn't use the style of views.less.
- kanban: nocontent helper above the columns (if any);
- texts "no order to upsell"/"abandonned cart" paragraph split in two.
2018-02-16 10:23:01 +01:00
David Arnold fcaf459a89 [FIX] account: aged partner report in multi-company.
Was PR #23074. Courtesy of David Arnold
2018-02-16 10:03:30 +01:00
Joren Van Onder e5c6c5db42 [FIX] stock_account: correct forward-port 251b2fdc
5ca0ef97 was forward-ported from 9.0. In 10.0 the function signature
of product.uom's _compute_price has changed. In 10.0 it uses the new
API and it no longer takes a to_uom_id keyword argument.

opw-816738
2018-02-15 15:42:31 -08:00
Romain Derie 4f418c26d5 [FIX] website: sitemap.xml incorrect domain
Before this commit, the domain use to retrieve pages in enumerate_pages was
wrong (mainly used for sitemap.xml). It would only show website.page that:
1. are published
2. are indexed
3. have a publishing date (whatever date, future or past).
Last point was incorrect

Now, we correctly retrieve pages that:
1. are published
2. are indexed
3. have no publishing date or a publishing date in the past
2018-02-15 23:13:50 +01:00
Christophe Simonis ac7abc9879 [MERGE] forward port branch saas-16 up to 7e42a21ee2 2018-02-15 19:40:21 +01:00
Christophe Simonis 7e42a21ee2 [MERGE] forward port branch saas-15 up to d952e3678b 2018-02-15 19:36:09 +01:00
Christophe Simonis d952e3678b [MERGE] forward port branch saas-14 up to 1677d618f0 2018-02-15 19:32:28 +01:00
Christophe Simonis 1677d618f0 [MERGE] forward port branch 10.0 up to 6cedc90f69 2018-02-15 19:31:24 +01:00
Christophe Simonis 6cedc90f69 [FIX] stock_account: method expect a record, not an id
opw-816729
2018-02-15 19:26:33 +01:00
Christophe Simonis c5899612ef [MERGE] forward port branch 10.0 up to 251b2fdc54 2018-02-15 18:43:15 +01:00
Mohammed Shekha e93a5cec48 [FIX] web: archive records in a new Kanban column
Create a new column in Project, add a record and then hit 'Archive Records' : a
traceback occurs.

When creating the new column, the `groupedBy` attribute on the datapoint is set
according to the parent list datapoint, which makes no sense as the records are
not grouped inside the column.

The mentioned attribute is now removed as the records cannot be grouped inside
the column.
2018-02-15 17:26:48 +01:00
Nikunj Ladava 4c186f30c3 [FIX] web: ActionManager: handle false actions
Server actions return an action to execute, or false. When they
return false, an 'ir.actions.act_window_close' must be executed,
such that the current dialog closes (if any) and mostly, the
'on_close' handler is executed, which ensures for example that the
current view is reloaded.

The case where server actions return false has been broken by rev.
32b8cec53. It produced tracebacks in several models, when clicking
on some actions in the 'Action' dropdown. For instance, in lunch,
go to Configuration > Products, open one in a form view, and click
on 'Lunch: Archive/Restore products' in the Action dropdown.
2018-02-15 17:25:00 +01:00
Christophe Simonis 71c36f608b [FIX] hr_holidays: use renamed model. 2018-02-15 16:35:09 +01:00
Jeremy Kersten 665496fc5c [FIX] website_forum: fix 'submit a link' feature
The pooling of the title was wrong since P3 refactoring.
2018-02-15 16:01:45 +01:00
Goffin Simon 1550c27b84 [FIX] mrp_repair: Only sale taxes must be available on a repair order
Like for the SO, only the taxes of type_tax_use = 'sale' must be displayed
on repair order.

opw:815028
2018-02-15 15:00:15 +01:00
Thibault Delavallée 6a1047111a [MERGE][IMP] portal, various: add access tokens in document access button for customer notification emails
Previously to this merge portal customers receiving a notification email
on a shared document could not directly reach the document on the portal
as the access token was not given to them. The only way to give access
to portal was done using the specific email implemented for sale orders
or invoices. This behavior is now extended to notification emails.

This merge adds the token support for customers through inheritance in
portal mixin. It also fixes inherit order so that the call chain
effectively goes through portal before calling the mail.thread base
implementation.

This merge is related to task 40064. #Closes #21426.
2018-02-15 14:57:31 +01:00
Thibault Delavallée 398c126cfa [IMP] account: display access buttons in notification email only on not draft not canceled invoices
Indeed draft and canceled invoices should not be displayed to customer or
portal customers.
2018-02-15 14:50:36 +01:00
Thibault Delavallée 467e490e5d [FIX] project: reorder inherit to be able to pass through portal before mail thread
Purpose is to enable override of mail.thread methods in portal mixin.
An example is the _notification_recipients method defined in mail.thread
and customized in portal.mixin.
2018-02-15 14:50:36 +01:00
Thibault Delavallée 2bf370ac28 [FIX] account: reorder inherit to be able to pass through portal before mail thread
Purpose is to enable override of mail.thread methods in portal mixin.
An example is the _notification_recipients method defined in mail.thread
and customized in portal.mixin.
2018-02-15 14:50:36 +01:00
Thibault Delavallée 75ec7ab257 [FIX] sale: reorder inherit to be able to pass through portal before mail thread
Purpose is to enable override of mail.thread methods in portal mixin.
An example is the _notification_recipients method defined in mail.thread
and customized in portal.mixin.
2018-02-15 14:50:36 +01:00
Thibault Delavallée 0e22ccb721 [IMP] portal: add access token link in notification emails for customers
Purpose of this commit is to allow customer portal to have an access link
containing an access token. Portal mixin now override the default mail.thread
behavior when classifying recipients of a notification email in groups.

If the model has an access_token and a customer field correctly defined
the recipient that matches the customer will have an access link in its
notification email holding the access token. It will also contain an
auth signup token if it is enabled.
2018-02-15 14:50:36 +01:00
Thibault Delavallée 7176d04f3b [IMP] mail: allow parameters to /mail/view link
Purpose is to allow to add parameters to the view link. Currently it is
formatted like '/mail/view?model=model&res_id=res_id'. We would like to
be able to add parameters like access token for example. It will allow
to create view links specifically tailored for some people like customer
portal.
2018-02-15 14:50:36 +01:00
Christophe Simonis 806f42b065 [MERGE] forward port branch saas-11.2 up to 8b9e854be4 2018-02-15 13:46:23 +01:00
Nicolas Lempereur 4e061d8c51 [REV] crm: allow a user assigned to activity to see lead
This reverts commit ab65a02f5a.

Before that commit "Sales / User: Own Documents Only" had access to
self-assigned or without salesperson assigned leads.

With the change, user of this group were meant to also have access to
leads with an activity to which they were assigned to.

But:

- this is a different behavior from activities on other models.

- there is a technical disability that in some case prevent to have
  fully functionning access rules if based on one2many with
  auto_join=True (we will try to fix this in master).

opw-816246
closes #23085
2018-02-15 13:38:40 +01:00
Alexandre Kühn 8b9e854be4 [FIX] im_livechat: livechat button not rely on JS services
Revision of https://github.com/odoo/odoo/commit/02ec09cb1c3e2d7bc7968f40c18f2208d7f3f498

One of the purposes of the previous commit was to test discuss.
There was an attempt to test im_livechat, but it has been aborted due to the possibility
to use livechat on an external website.

However, some bits remain from this attempt, such as LivechatButton becoming a JS service
provider in order to use those services with the external lib. LivechatButton was not working
for the following reasons:

    - ServiceProviderMixin.init was not called (so it couldn't load any service);
    - On website, there are two service providers (LivechatButton & websiteRootInstance).

This fix ensures that LivechatButton does not rely on JS services, such as the bus_service.
2018-02-15 13:24:37 +01:00
Lucas Perais (lpe) 6899bb829a [FIX] point_of_sale: http fetch img require right headers
The pos must be in http to talk to the posbox
The problem here is that imgs can sometime be fetch in https depending on the server's configuration

Before this commit, when converting imgs to base64, a "Tainted canvas" traceback was thrown by the browser
due to difference in domain that http VS https make

After this commit, we explicitly allow cross origin when fetching the image
while requiring the server to send the right headers

OPW 805860
2018-02-15 13:22:39 +01:00
Christophe Simonis 251b2fdc54 [MERGE] forward port branch 9.0 up to 840c3be7b5 2018-02-15 12:56:01 +01:00