Commit Graph
127612 Commits
Author SHA1 Message Date
TWA 326e48a112 [IMP] purchase_stock, sale_stock : Show stat button instead of m2m widget
On stock production lot, we show stat buttons redirecting to purchase
orders and sale orders where the lot has been used instead of showing
Many2many in the form view.

TASK-ID: 1873101
2018-08-21 22:25:26 +02:00
Pierre Masereel c9f899b99a [FIX] mrp: Traceability show MO final product reference
When a final product move line is shown in the traceability report is
displayed, the reference to the MO is not displayed because the finish
products move lines don't have any productio_id on it.

So to fix this we take the production_id of the move_id when it's a
finished product, and the raw_material_production_id of the move_id when
it's a consumed product that are always set.

TASK-ID: 1873101
2018-08-21 22:25:26 +02:00
Pierre Masereel 9524341a81 [IMP] stock: picking and mo traceability improvements
We now only show the move lines that are processed before (in date and
location) when we display the move lines from a picking or a
manuficturing order, before it was showing all move lines that
where processed before (only in date) meaning that if you display a
delivery, you were also seeing the other deliveries done before this
one.

TASK-ID: 1873101
2018-08-21 22:25:26 +02:00
TWA 0cd475124f [IMP] stock,mrp: Enable traceability report for non-tracked products
PURPOSE
=======

Make the traceability report available in more use cases.

SPECIFICATIONS
==============

1. Traceability Button on Manufacturing Orders
There should always be a traceability report available on the MO,
no matter if the finished product is tracked or not.

Example 1 : finished product is not tracked
            but the components are tracked
Example 2 : finished product is not tracked (qty>0)) but
            the components are tracked
Example 3 : no products are tracked

Task id: 1861928
2018-08-21 22:25:25 +02:00
Alexandre Kühn 5999ba86c7 [FIX] mail: "is typing..." notification sticky top for DESC threads
Revision on https://github.com/odoo/odoo/commit/4fa071339a8f381b1336fe326577c9decc04a1e1

There was a typo in the style of the 'is typing...' notification bar,
which resulted in applying the wrong sticky behaviour to ASC and no
sticky behaviour at all for DESC.

This commit applies the correct sticky behaviours to the notification
bar in both configurations:

      ORDER:                   ASC                           DESC

                     +--------[top]--------+        +--------[top]--------+
                     |                     |        |                     |
                     |  (older messages)   |        |  (newer messages)   |
                     |                     |        |                     |
   visible top ----> |- - - - - - - - - - -|        |- - - - - - - - - - -|
                     |                     |        |   X is typing...    |
                     | ...                 |        | ...                 |
                     | message i           |        | message i + 1       |
                     | message i + 1       |        | message i           |
                     | ...                 |        | ...                 |
                     |    X is typing...   |        |                     |
visible bottom ----> |- - - - - - - - - - -|        |- - - - - - - - - - -|
                     |                     |        |                     |
                     |  (newer messages)   |        |  (older messages)   |
                     |                     |        |                     |
                     +------[bottom]-------+        +------[bottom]-------+
2018-08-21 20:14:09 +02:00
Christophe Simonis ef6b574eda [MERGE] forward port branch saas-11.3 up to 6cc7d3f945 2018-08-21 18:48:13 +02:00
XavierDo 7f8ffba48e [FIX] mail: remove bolt on notification request
Since the title of a notification is in a t-esc, the style wont be applied
2018-08-21 17:55:27 +02:00
Christophe Simonis 6cc7d3f945 [FIX] web: correct test view option name 2018-08-21 17:36:34 +02:00
Christophe Simonis 70d0148d0d [MERGE] forward port branch 11.0 up to fbfb91799e 2018-08-21 16:58:17 +02:00
Alexandre Kühn 4fa071339a [FIX] mail: "is typing..." notification sticky top for DESC threads
Before this commit, the 'is typing...' notification bar was sticky
to the bottom of the thread, independently of the ASC or DESC mode
order of threads.

This is okay for ASC, but not for DESC: it should stick to the
visible top of the thread for DESC.

As a result, this notification bar was always at the top of the
thread, without the 'sticky' behaviour:

        +--------[top]--------+
        |   X is typing...    |
        |                     |
        |  (newer messages)   |
        |                     |
        |- - - - - - - - - - -|   <---- visible top
        |                     |
        | ...                 |
        | message i + 1       |
        | message i           |
        | ...                 |
        |                     |
        |- - - - - - - - - - -|   <---- visible bottom
        |                     |
        |  (older messages)   |
        |                     |
        +------[bottom]-------+

With this commit, the 'is typing...' notification bar sticks
to the visible top of DESC threads:

        +--------[top]--------+
        |                     |
        |  (newer messages)   |
        |                     |
        |- - - - - - - - - - -|   <---- visible top
        |   X is typing...    |
        | ...                 |
        | message i + 1       |
        | message i           |
        | ...                 |
        |                     |
        |- - - - - - - - - - -|   <---- visible bottom
        |                     |
        |  (older messages)   |
        |                     |
        +------[bottom]-------+
2018-08-21 16:57:51 +02:00
Alexandre Kühn 7e7e72edfd [FIX] mail: 'is typing...' notification bar next to composer.
Revision on https://github.com/odoo/odoo/commit/0eab8f6e0b17a4ff6a859d14b14b643212cbadc1

The commit above fixed the definition of ASC/DESC on the rendering
of mail threads.

However, the 'is typing...' notification bar was still partially
using the old definitions. As a result, this notification bar was
not sticking at the visible bottom of the thread when there were
few messages:

        +--------[top]--------+   <---- visible top
        | 1st message         |
        | 2nd message         |
        | 3rd message         |
        |    X is typing...   |
        |                     |
        |                     |
        |                     |
        +------[bottom]-------+   <---- visible bottom

This commit fixes the issue so that the 'is typing...' notification
bar is always at the bottom of the thread in such case:

        +--------[top]--------+   <---- visible top
        | 1st message         |
        | 2nd message         |
        | 3rd message         |
        |                     |
        |                     |
        |                     |
        |    X is typing...   |
        +------[bottom]-------+   <---- visible bottom

Note that it fixes the case with 'few messages', without altering the case with
'several' messages:

        +--------[top]--------+
        |                     |
        |  (older messages)   |
        |                     |
        |- - - - - - - - - - -|   <---- visible top
        | ...                 |
        | message i           |
        | message i + 1       |
        | ...                 |
        |                     |
        |    X is typing...   |
        |- - - - - - - - - - -|   <---- visible bottom
        |                     |
        |  (newer messages)   |
        |                     |
        +------[bottom]-------+
2018-08-21 16:57:51 +02:00
XavierDo 2831fa7926 [IMP] core, test_mail: improve query count assertions
-remove margin
With the spirit of making tests determinists,
we can remove margins to have a real test of query count.

-mock random on assert query count
bus gc is triggered using random. Therefore, when send_many is called,
we have 1% chance to have more query. Mocking random.random to 1
will disable gc during query count tests (not during warmup).
Could be interresting to put gc collection in a cron latter

-add more info on querycount
Adding file and line number on query count failure/info will help to update
the query counts.

-update query count based on enterprise
Update all query count with enterprise values (exactly)

-normalize query counts with enterprise
voip module add a read on activity type (during create) in enterprise,
leading to one more query but also more information in cache.
Therefore, the next assertion will need one more query to access this data
in community.
Adding an access to activity type in the first assertion will allow
to have the same cache state in community and enterprise.

Task: #1878588
PR: #26476
2018-08-21 16:56:54 +02:00
David Arnold 0b72446340 [FIX] account: unproxy company currency
This indirection is the only place in the whole codebase, which indirects in
this way.

This block downstream code which relies on:
 - access to the line's company
 - while not necesarily having access to the account's company

(being line's company different than account's company)

Disclaimer: This use case is not officially supported.
However, this indirection does not make sense under the currently
supported model, neither.
2018-08-21 16:54:45 +02:00
David Arnold 7b492498eb [FIX] account_voucher: copy product in acc voucher (#26336)
* [FIX] account_voucher: copy product/qty from receipt to journal items

Before this commit, product_id and quantity were not passed
to the aml from account vouchers.

This caused inexpected behaviour, if products are a relevant dimension in cost
or revenue analysis analysis: Whereas on invoices, this product is copied to aml
on voucher, it is not.

Was PR #26336 . Courtesy of David Arnold (XOE Solutions)
2018-08-21 16:45:06 +02:00
qdp-odoo 0c34698c47 [FIX] account_voucher: unexpected error thrown when using a tax
In case of a sale receipt including a tax, the error 'cannot create unbalanced entry' was raised illegetimately. The reason was simply that the tax line was defining a debit instead of a credit.
2018-08-21 16:41:40 +02:00
Alexandre Kühn eea2366fd2 [FIX] web, mail, bus: no running services on top of tests
Before this commit, the web client in the JS tests environments
might be influenced by `longpolling/poll` or `mail/init_messaging`
RPCs. For instance, if we received a new direct message in Odoo
during some JS tests, it would open a thread window. As a result,
the tests on thread window will fail because of this newly and
externally added thread window.

After this commit, no service is deployed on the webclient on top
of the JS tests environment. This should prevent most undesirable
side-effects of RPCs, such as opening a thread window when receiving
a new direct message on the longpolling bus.
2018-08-21 16:07:30 +02:00
Christophe Simonis fbfb91799e [MERGE] forward port branch saas-15 up to 9cf0dbe226 2018-08-21 16:00:40 +02:00
Christophe Simonis 9cf0dbe226 [FIX] base_sparse_field: improve fields' view
Set default values when creating serialized field from contained field.
2018-08-21 15:12:16 +02:00
Nicolas Martinelli 65c2a9b70c [FIX] sales_team: default team is active
Check the default team is active. Moreover, make the return object type
consistent.

opw-1876966
2018-08-21 14:46:11 +02:00
Christophe Simonis c619b19f66 Revert "[FIX] manual creation of serialized field from the interface"
Non applicable since b0646f9d2c.

This reverts commit 03395ea103.
2018-08-21 14:13:15 +02:00
XavierDo 616fa4f6e4 [IMP] mail_bot: change Odoobot to OdooBot 2018-08-21 13:44:33 +02:00
Nicolas Martinelli f46761caa8 [FIX] membership: change partner on invoice
- Go to a contact C1 > Membership tab > Buy membership
- Create an invoice with the membership
  => It creates a membership line on C1
- Change the partner on the invoice to C2

The membership line and the membership status is not transfered to C2.

We first need to recompute on C1, and we also need to explicitly write
the new partner C2 on the membership lines.

opw-1875673
2018-08-21 13:39:16 +02:00
Nicolas Martinelli b8161ec806 [FIX] membership: cancel invoice
- Go to a contact > Membership tab > Buy membership
- Create an invoice with the membership
  => The status of the member goes to 'Waiting membership'
- Validate the invoice
  => The status of the member goes to 'Invoiced membership'
- Create a credit note to cancel the membership
  => The status of the member goes to 'Paid members'.

It shouldn't be the case because the client has canceled his membership.

We look on `payment_move_line_ids` instead of `payment_ids`. Indeed, the
latter doesn't list credit notes, while the first one lists all move
lines used for payment.

opw-1875673
2018-08-21 13:39:16 +02:00
Nicolas Seinlet e8f01b94ce [IMP] sale,sale_*: denormalize sale.order to speed up sale.report
Impacted modules: sale, sale_margin, sale_timesheet, pos_sale

This speed up a lot reports like sale.report when multiple currencies
with multiple rates are used, even with few currencies and few rates.
Using `_select_companies_rates` in SQL view bring lots of JOINs,
which slow down the view generation. This commit adds a computed
stored field containing the currency rate at the order date to speed
up report generation (database schema denormalisation).

This commit also use this new column on sale.report extensions and on
the project.profitability.report in sale_timesheet module.

Since a4d6bff197, the pos.report is
included in the sale.report. So, the same change had to be
applied on the pos.order model.

Task #1877418
Closes #25089
2018-08-21 13:28:42 +02:00
Dipalee Bhalodia 43e29e5d8f [FIX] web_editor: restore custom colors feature
- The current code found colors in the page which were not custom colors
  (because we were case-sensitive for hex values)
- Applying custom colors font font/background were inverted
2018-08-21 12:09:45 +02:00
Christophe Monniez c8762eaa03 [FIX] hr: properly set label in kanban-box
In recruitment, clicking on configuration > job positions > kanban view
leads to an odoo client error.

The qweb template cannot evaluate the condition on the client side.
With this commit, the ternary condition is properly evaluated.

Also, an unnecessary t-attf is removed.

Closes #26486
2018-08-21 12:08:31 +02:00
Christophe Simonis e80f853ab3 [MERGE] forward port branch saas-14 up to aafa6e38c4 2018-08-21 12:06:23 +02:00
Toufik Benjaa a05ae78abd [FIX] mail & project: Display access button on mail notifications
This commit fixes two issues:

	- If a partner has multiple users and if any of these users is a
          share user, then the access button on mail notifications is not displayed.

	- If a project.task is either assigned or has its stage folded
	  the access button may not be displayed for certain users.
	  The users affected by this bug are the one who have their user's
	  partner is linked to multiple users with at least one flagged as a share user.
2018-08-21 11:58:50 +02:00
Christophe Simonis aafa6e38c4 [MERGE] forward port branch 10.0 up to 342d037373 2018-08-21 11:33:53 +02:00
Raphael Collet 0218c4d506 [FIX] stock: missing decorator 2018-08-21 11:03:44 +02:00
Christophe Simonis 342d037373 [MERGE] forward port branch 9.0 up to f750393030 2018-08-21 10:50:32 +02:00
Pedro M. Baeza 87a6b879a2 [FIX] account: Fix tax summary on invoice report
We want to show the base amount for the tax when there are multiple taxes or the
amount is not the invoice total, not the contrary.
2018-08-21 10:36:53 +02:00
Yanina (Vauxoo) 384f6a6254 [FIX] l10n_mx: bad function renaming in COA creation
_prepare_transfer_account had been renamed _get_default_bank_journals_data instead of _prepare_transfer_account_for_direct_creation, by mistake. The original renaming was made at https://github.com/odoo/odoo/commit/87f0d2eefb77bfc6a9a0fa7f7dcd1475c7c34639#diff-ce53c5491cb2c9ab3dbbd41ecabf594f
2018-08-21 10:28:08 +02:00
jeffery chen fan 53889d9ba5 [ADD] l10n_cn: add all china cities
Make the module depends of base_address_city

Closes #23879
2018-08-21 10:20:08 +02:00
Lucas Perais (lpe) cc72b0c2fa [FIX] crm: fix API
Because of 2917b38f28 which appeared in v9.0 but has not been adapted to the new API
afterwards, the early return was out of sync with what a search returns in new API

in v9.0: search returns a list, so must our early return

in v10.0: search returns a recordset, hence the fix

OPW 1878192
closes #26474
2018-08-21 09:37:54 +02:00
Nicolas Martinelli 07b5f205ab [FIX] models: unlink ir.property
On a new DB with demo data, as Demo User:
- Create a partner
- Unlink the partner

An `AccessError` is raised.

The error is raised on `ir.property`, for the field
`property_product_pricelist`. An entry was indeed automatically created
at partner creation. However, a regular user is not allowed to delete an
`ir.property`.

The property can be safely deleted as SUPERUSER as long as the proper
unlink access rights have been tested beforehand.

opw-1870737
2018-08-21 09:32:01 +02:00
Raphael Collet b1cc28be00 [FIX] tests: clean up code
Closes #26467
2018-08-21 09:21:11 +02:00
dat-odoo ca707502a6 [FIX] purchase_requisition: vendor name management from purchase agreements.
Purchase orders created from purchase agreement behave differently depending on
the agreement type.
On one hand, if the agreement is a blanket order, the vendor must be set automatically on the
purchase order and be the same as the BO. Changing the vendor is forbidden.
On the other hand, if the agreement is a call for tender, multiple purchase order can be
created with different vendors. It that case, the vendor field must be editable in RfQ states.

This commit is related to task ID 1866975.
2018-08-21 09:05:20 +02:00
Akram Ben Aissi cae7c71635 [IMP] cli: allows to run odoo with openshift
For containers using random uids[1], use the higher level method getpass.getuser
which as the same effect but also looks consider the environment variables to
determine the user name.

Details from
http://blog.dscpl.com.au/2015/12/unknown-user-when-running-docker.html

CLA signature for akram

Closes #26452

[1] openshift or docker as explained at
http://blog.dscpl.com.au/2015/12/random-user-ids-when-running-docker.html
2018-08-21 08:34:14 +02:00
Olivier Dony f750393030 [FIX] website_forum: properly catch errors for email activation 2018-08-21 03:28:59 +02:00
Vandan ShahandMohammed Shekha f4ee61f950 [IMP] web: mobile: add swipe support in form views
This rev. allows to navigate, in mobile, through records in form
views by swiping.

We also moved mobile-specific tests involving a form view to the
mobile test suite, since those tests became async because of the
lazy loading of the swipe lib (in the mobile suite, that lib is
already loaded).

Related to task #34727

Co-authored-by: Mohammed Shekha <msh@openerp.com>
2018-08-20 21:11:54 +02:00
Jeremy Kersten a7e94f1a83 [FIX] website: remove field from view and security
related to ac58a0ef87
2018-08-20 20:52:02 +02:00
Jeremy Kersten ac58a0ef87 [IMP] website_sale: product.public.category publish feature is useless 2018-08-20 18:07:59 +02:00
Jeremy Kersten 50217184d2 [IMP] website: make abandoned cart parameter website_specific
+ implement specific_user_account option

Now you can choose if when you create an user on a website,
it this user is dedicated to this website or not.
2018-08-20 18:07:59 +02:00
qsm-odoo 4d00958480 [FIX] website_sale: missing href on <a/> element
With BS4, those elements have no style anymore.
2018-08-20 17:59:24 +02:00
qsm-odoo 36430cae5e [FIX] website_event: adapt some layouts to new snippets and BS4 2018-08-20 17:46:46 +02:00
qsm-odoo b4fa0a510e [FIX] website_hr_recruitment: BS4, restore application form layout
Col must be direct children of rows.
2018-08-20 17:46:46 +02:00
qsm-odoo 66a46c3e3a [FIX] website: border-width of inputs was raised for no good reasons 2018-08-20 17:46:46 +02:00
qsm-odoo 604a6673a6 [FIX] website, portal: BS4, force list-group-item colors
Placing a list-group inside an element whose text color is forced is
buggy as the background of list-group items is forced to white and
the text color left untouched.
2018-08-20 17:46:46 +02:00
qsm-odoo fdd89d2a77 [FIX] web: BS4, restore some community nav elements
The 'nav-link' class was added on wrong elements.
2018-08-20 17:46:46 +02:00