before this commit, subject field in
email form view was short
and user has to scroll through
the field to see the full subject
after this commit, subject field is long
enough to see the content without
scrolling
closesodoo/odoo#123909
X-original-commit: 7b1732f1e13239191fcc3b9c467d6d1c343aa6bc
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Following https://github.com/odoo/odoo/pull/123266 that removes
some vertical spacing between messages.
The date text on squashed messages was increasing size of messages
that fits on a single line.
This commit fixes the issue by slightly reducing the size of date
text in sidebar, so that when hovering messages it doesn't affect
the size of messages.
closesodoo/odoo#123799
X-original-commit: 454d250e6c88b09d616d4d3404204d57addf8b28
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Before this commit, when hr was installed and Demo clicks on avatar
of Mitchell Admin, open chat failed due to access right exception.
This happens because open chat works only with internal users, and
when we don't know whether the partner has an internal user, we have
to check whether there's a user linked to this partner.
Doing `searchRead()` without passing any field triggers this missing
access right for some reasons.
Only the knowledge of an existing `userId` is enough, so we
can actually just make a `search()` to get the user id. This won't
trigger the access right exception while giving the user id of
the partner if this exists, thus proceeding with open chat request.
closesodoo/odoo#123796
X-original-commit: 2f6dc5f4222d380cf77c6660ccce8b7381e0e64a
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
This will remove the necessity to patch component, and remove
duplciation between discuss and chat window.
Part of task-3265211
closesodoo/odoo#123454
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Since [1], messages were ordered in ascendant order if the
`after` parameter was passed to the `_message_fetch` method.
This leads to messages being inserted in the wrong order
when several messages are batched then fetched via the
`/thread/messages` route. In practice, this order can
be removed since the `/channel/messages` route already
orders its messages correctly.
1: https://github.com/odoo/odoo/pull/116666/
task-3349175
closesodoo/odoo#123727
X-original-commit: 597b0b00068f6ab99632563faeb2ea18f5c9056f
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Stockbauer Matthieu (tsm) <tsm@odoo.com>
This PR makes two small improvments on the embed livechat:
- Same top/bottom padding for the livechat button
- Remove rounded border at the bottom of the livechat button.
- Put the chat window border on the web patch instead of
the base chat window: patch should add features to the
base component, not remove it.
closesodoo/odoo#123684
Signed-off-by: Louis Wicket (wil) <wil@odoo.com>
Follow-up of https://github.com/odoo/odoo/pull/123143
This is the same fix applied to discus sidebar, which used another
component that had the exact same issue.
This omission comes from code duplication as a consequence of
added technical debt during a recent refactoring of Discuss code.
We will avoid making this mistake again in master, by cleaning and
properly sharing code for all showing of im status in Discuss.
closesodoo/odoo#123526
X-original-commit: 576e3caa50f6e23525b49fc3790ab29647903ed1
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Before this commit, squashed messages in chat window had part of
the action list being cut by the message above.
This comes from `overflow-auto` on the message content, which was
defined to make content shrink, but had the unintended side-effect
of cutting the message action list for squashed messages in chat
window.
This commit fixes the solution by using `min-width: 0;` instead to
shrink flex item to lower of content width. This style-rule works
like setting `overflow-auto` without actually affecting overflow.
X-original-commit: 3e4b32361ade567d8d4fde37f0ed2542a3e2e215
Part-of: odoo/odoo#123526
All features are not working as intended (examples: side panels should
be full screen instead of on the right, missing user rename/avatar
change) but at least something is shown with this commit.
closesodoo/odoo#123030
X-original-commit: 35a87c21230613852e1536eb0d717ad3f5753b5e
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
There exists edge case on `reply_model`. when value of
`mail_messages.model` in database is empty then `mail_messages.model`
returns False, hence `reply_model` becomes False which raises
an error because _get_id does not accept a falsy values.
(because query: `SELECT id FROM ir_model WHERE model=false` has to
be run and model is char). Because of the fact that this query never
runs and fails opportunity is lost.
task-3248489
closesodoo/odoo#123488
X-original-commit: 6c0d2d7a9d44459f3e09a38bd80ef9b018e8c946
Signed-off-by: Stéphane Debauche (std) <std@odoo.com>
This PR refactors the public livechat in order for it to use
owl and to rely on the discuss components as much as possible.
task-2212347
closesodoo/odoo#122834
Related: odoo/enterprise#41636
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
This prevents from having files floating in the root folder and making
the navigation between subfolders more complex.
Part of task-3265211
closesodoo/odoo#123344
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
When the route to your file contains more than one argument, the
arguments following the first one are not taken into account. The
arguments that are after '&' symbol are considered as a arguments of the
route 'viewer.html' and not of the 'file' route.
To avoid this issue, we are encod the file route in URI, as documented
in https://github.com/mozilla/pdf.js/wiki/Viewer-optionsclosesodoo/odoo#123355
X-original-commit: 86a4fcf4647c9c6006b69c35d76bf80d87204114
Related: odoo/enterprise#41815
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Masereel Pierre <pim@odoo.com>
*: gamification, hr, hr_contract, hr_expense, hr_holidays, hr_org_chart,
lunch, mail, web
Since the Milk refactoring, the backend uses only `.rounded` avatar
images. The `.rounded-circle` classes on images have been replaced by
`.rounded`.
task-3336569
part of task-3326263
closesodoo/odoo#123286
X-original-commit: b492049788353274fb32bb6fbe4d40e97a184a87
Related: odoo/enterprise#41798
Signed-off-by: Pierre Paridans (app) <app@odoo.com>
Before this commit, im status icon for "away" was brown
in white mode.
This comes from MILK redesign change changes the color of
`text-warning`, from yellow to brown in white mode.
This commit fixes the issue by explicitly using yellow color,
regardless of theme. Dark mode kept the yellow color, so this
is unchanged.
closesodoo/odoo#123188
X-original-commit: d500608c01370ffb712ea45ce3f6b58e706ed760
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Before this commit, the attachment button had icon and label on
different lines in mobile, which made the chatter topbar bigger
in height than it should.
closesodoo/odoo#123098
X-original-commit: 1afe20789fcf197ccc0a240d39d57d10e1f1454a
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
This commit removes the css that was creating two layout issues :
[1] When the chatter was rendered under the form view with the
`isInFormSheetBg` class, it added an unwanted background and border.
[2] When an attachment was uploaded and created a preview (eg. in
approvals), it created an unwanted border.
This commit fixes these issues.
task-3334866
Part of task-3326263
closesodoo/odoo#123095
X-original-commit: 5171b0bb2054f4755d0ba70b6820806c5253774d
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Before this commit, when clicking on a category in emoji picker
when using Firefox, sometimes the previous category was selected.
This come from Firefox selecting the previous sticky section with
`getBoundingRect()` and `elementFromPoint` on grid top coordinate.
This commit fixes the issue by rounding to the integer, so that
the previous hidden and sticky section is not selected in Firefox.
closesodoo/odoo#123068
X-original-commit: ecae83ef9bd93a55e296023bc8c735f04d5e73f8
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
A recent refactoring of discuss app unintentionally removed the
feature to automatically notify and open chat window with new user
when they log in for the 1st time.
closesodoo/odoo#123044
X-original-commit: 9132dacbf9b4b9d000b6d0be23938b46db1035a1
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
A raw query is not necessary to produce the desired result, found
activities need to be kept only if the corresponding record can be found
with standard search (which includes multi-company check).
Part of task-3266643
closesodoo/odoo#123070
X-original-commit: 9dd7ae942aebe2cfd3e2dcd52e10b3bff5c8e0a9
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Before this commit, when a discuss composer is open on Safari,
the focus was locked inside the composer. Click away did not
resolve it.
This most certainly happens because changing `selectionStart`
and `selectionEnd` on an input in Safari puts the focus on the
input.
This commit fixes the issue by not changing the current selection
of input just before backing up.
Related to https://github.com/odoo/odoo/commit/4efb465f6adcf8e4f9c6d4daa0b6f90079832af5closesodoo/odoo#123069
X-original-commit: 71c745ea81baeb02bf217f37bf9a4c64e435da05
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Prior to this commit, in the "Chatter", when a user planned an activity,
a new section appeared at the top of the chatter displaying the planned
activities. Users had the ability to collapse this section. When the
section was collapsed, a title and a badge were displayed next to it,
indicating the number of activities.
However, since milk, it was observed that the badge was positioned too
close to the title, requiring some spacing adjustments. Additionally,
the badge has been updated to adhere to milk by adopting a rounded-pill
shape.
task-3339256
part of task-3326263
closesodoo/odoo#122945
X-original-commit: fab1f6242cc0d8984a5f36876dcbf4150c340d8d
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
- rounded avatar in member list and invitation link
- improved color in selectable users in invitation link
- show "Add Users" action in DM chat window
- no border on panels in chat windows
- slight header style adjusments on emoji picker
- improved borders on chat window (shared between content and header)
closesodoo/odoo#122731
X-original-commit: 0f7f858514126a6898c01bb6a8389d0b066b8a3f
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
The discuss app uses an url regex in order to find links and
transform them to html before posting a message.
Before this commit, some unsafe url characters were missing
from this regex, resulting in incorrectly parsed url.
This commit adds missing characters in order to match RFC1738
[1].
However the dot, comma and semicolon character won't be matched
if they are at the end of the url since those can be used as
punctuation.
[1]: https://www.ietf.org/rfc/rfc1738.txtclosesodoo/odoo#122621
Forward-port-of: 0dc68dc, 9302a23
X-original-commit: 80da20092b42d927ce8b09eb3b45de7216695263
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Stockbauer Matthieu (tsm) <tsm@odoo.com>
Since MILK, the `bg-*` classes which used to set an appropriate
text color have turned into `text-bg-*`. Some were missed which resulted
in elements with low contrast between the text and the background.
This commit fixes this issue.
closesodoo/odoo#122606
X-original-commit: 15a2192c4fed0be7a62dbb6e0ab9eaadaecc10ce
Signed-off-by: Stockbauer Matthieu (tsm) <tsm@odoo.com>
Signed-off-by: Thanh Dodeur (tso) <tso@odoo.com>
During the refactoring of discuss in 16.3, the setting to filter
the videos was wrongly observed on the settings instead of the channel.
This commit fixes this issue.
closesodoo/odoo#122605
X-original-commit: 00f55c6f925fa02cd292549498643f5415392a9f
Signed-off-by: Stockbauer Matthieu (tsm) <tsm@odoo.com>
Signed-off-by: Thanh Dodeur (tso) <tso@odoo.com>
Before this commit, attachment cards overflow in chat window
when attachment name is very long.
Text is properly flagged for truncate, but the container had neither
`overflow-auto` or `min-width: 0` to allow flex to shrink below
its content size.
Also add some horizontal spacing in attachment list so the
attachment cards do not have any contact with composer border.
closesodoo/odoo#122583
X-original-commit: 0d0ab2543d8c6a944fb091fa4ac30a19e1924e71
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
- (rounded) buttons in header
- header buttons keep grayscale filter regardless of active
- search bar is rounded
- section in emoji content show the icon and the name of category
- less dark color in dark mode
closesodoo/odoo#122565
X-original-commit: 2c53cb5b07f3f940cd27b242949ff2ff4bae7672
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Before this commit, chat window header showed all actions,
which made it quite bloated. The name of conversation was
sometimes completely truncated by available actions.
This commit fixes the issue by showing at most 2 actions
immediately in the chat window header. When there are more
actions, it shows an expandable more menu.
As a consequence of this change, when a panel is open, it
was harder to see the button to close the active panel
(toggling off the button).
To solve this issue, when a panel is open in chat window,
there's a floating button in the top-right corner of content
to close the panel.
Task-3334793
closesodoo/odoo#122419
X-original-commit: eef4ef86e66709eef5b34ebce37cda3aab037bf9
Related: odoo/enterprise#41466
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Follow-up of MILK web client redesign.
Before this commit, the avatar and im status in invitation popover
in discuss app were not showing properly: avatar not rounded,
and im status mispositionned in top-right corner.
This commit fixes the issue by absolutely positioning im status
like all other uses of IM status on top of user avatar.
closesodoo/odoo#122459
X-original-commit: 6061d4e718a8e15a1448c236414e8326ba5e13c5
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
In this commit we remove overrides of create / write on subscription model to
make 'unsubscription_date' an editable computed field instead.
While being there, tracking on blacklist model is ordered, as a side dish
to prepare other mailing improvements.
Prepares Task-2150462 (Mass Mailing: Improve subscription management)
closesodoo/odoo#122106
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Overwriting array with new array triggers reactive. This leads to
uncessary renders, and potential infitine loop if both read and insert
methods are used inside rendering cycle.
Part-of: odoo/odoo#121418
As it holds full HTML documents, mail.mail often encounters issues with
the html editor.
We piggy-back off the intoduction of the switching
behavior between code-view and readonly-view behavior introduced in
a5c0085ce91570c6c961e3293dfe50f4faba6043
The 'sandboxed preview' mode can now be enabled with an option
and will ensure all content can only be viewed in a sandboxed iframe
or in the code editor.
This re-introduces editing, which was mistakenly fully disabled in the
usability fix that introduced body_content here:
5055b374c3bac0126f441dad61afd7e0b68b1370
Some tests are added to ensure the key points of this commit remain
the same. Tests are re-ordered alphabetically to match the order
of execution, making debugging easier.
task-3255777
closesodoo/odoo#121976
X-original-commit: 062569ef042f3b01044c5e4cdbd8b71e96bfd39d
Signed-off-by: David Monjoie (dmo) <dmo@odoo.com>
It can be useful to search the body_content field
to find specific text while not including HTML tags
and attributes in the search.
task-3255777
X-original-commit: 1c60ffa13ca0d383480cae562379a7cde387a2df
Part-of: odoo/odoo#121976
Since the attachement viewer was moved to core, this renames it to file
viewer to decouple it from the Attachment model/concept from the mail
module.
Part-of: odoo/odoo#119625
The `mail` module's `attachment_viewer` is useful for more than `mail`
alone. In order to be able to use it in the `web_editor` module (which
doesn't depend on `mail`), we move it to the `web` module.
task-3109331
Part-of: odoo/odoo#119625
Currently, only stable releases see their translations updated. This has
resulted in master accumulating outdated stuff for years, which can be
confusing for users testing master on runbot.
This one-shot commit resynchronizes master translations based on the
content from 16.0 and removes empty PO files (i.e. no longer containing
translations).
closesodoo/odoo#121629
Related: odoo/enterprise#41171
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
With redesign of web client style, buttons by default are now rounded
, this commit removes the border-radius for the members list buttons in
discuss sidebar.
task-3329620
part of task-3326263
closesodoo/odoo#121904
X-original-commit: 3d2953e4129ac3267dc08eeebda5cdc3569e4b62
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Prior to this commit, the SVG's viewBox attribute was missing, which
prevented svgs from being scaled.
This commit fixes this issue.
task-3326633
Part of task-3326263
X-original-commit: 30300c373ad1c63a6cf8b035cae0785a09c6933f
Part-of: odoo/odoo#121886
The introduction of Milk has brought new app icons.
Using the svg format creates a lack of anti-aliasing on the edges of the
shapes, which makes the icons look bad.
Since the png size has been reduced, we can afford to use the png format
to have the best possible quality without having a lack of performance.
task-3326633
Part of task-3326263
X-original-commit: e07cb722f2b11407a3ad093bd688b7d37afd5a88
Part-of: odoo/odoo#121886
mehjabinfarsana