[FIX] mail: im status away should be yellow

Before this commit, im status icon for "away" was brown
in white mode.

This comes from MILK redesign change changes the color of
`text-warning`, from yellow to brown in white mode.

This commit fixes the issue by explicitly using yellow color,
regardless of theme. Dark mode kept the yellow color, so this
is unchanged.

closes odoo/odoo#123188

X-original-commit: d500608c01370ffb712ea45ce3f6b58e706ed760
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>

addons/hr_holidays/static/src/im_status_patch.xml

@@ -3,7 +3,7 @@
     <t t-inherit="mail.ImStatus" t-inherit-mode="extension">
         <xpath expr="//*[@name='icon']" position="replace">
             <i t-if="props.persona.im_status === 'leave_online'" class="fa fa-plane text-success" title="Online" role="img" aria-label="User is online"/>
-            <i t-elif="props.persona.im_status === 'leave_away'" class="fa fa-plane text-warning" title="Idle" role="img" aria-label="User is idle"/>
+            <i t-elif="props.persona.im_status === 'leave_away'" class="fa fa-plane o-away" title="Idle" role="img" aria-label="User is idle"/>
             <i t-elif="props.persona.im_status === 'leave_offline'" class="fa fa-plane text-700" title="Out of office" role="img" aria-label="User is out of office"/>
             <t t-else="">$0</t>
         </xpath>

addons/mail/static/src/discuss_app/im_status.scss

@@ -2,6 +2,10 @@
 .o-mail-ImStatus {
     width: $font-size-lg;
     height: $font-size-lg;
+
+    .o-away {
+        color: $yellow;
+    }
 }
 
 .o-bg-inherit {

addons/mail/static/src/discuss_app/im_status.xml

@@ -5,7 +5,7 @@
         <div class="o-mail-ImStatus d-flex justify-content-center flex-shrink-0 align-items-center rounded-circle o-bg-inherit" t-att-class="props.className" t-att-style="props.style">
             <span t-if="props.persona.im_status" class="d-flex flex-column" name="icon">
                 <i t-if="props.persona.im_status === 'online'" class="fa fa-circle text-success" title="Online" role="img" aria-label="User is online"/>
-                <i t-elif="props.persona.im_status === 'away'" class="fa fa-circle text-warning" title="Idle" role="img" aria-label="User is idle"/>
+                <i t-elif="props.persona.im_status === 'away'" class="fa fa-circle o-away" title="Idle" role="img" aria-label="User is idle"/>
                 <i t-elif="props.persona.im_status === 'offline'" class="fa fa-circle-o text-700" title="Offline" role="img" aria-label="User is offline"/>
                 <i t-elif="props.persona.im_status === 'bot'" class="fa fa-heart text-success" title="Bot" role="img" aria-label="User is a bot"/>
                 <i t-else="" class="fa fa-fw fa-question-circle" title="No IM status available"/>