Commit Graph
126256 Commits
Author SHA1 Message Date
Jigar Patel 41b8aa7f91 [IMP] website_form, website_crm: auto install website_form/website_crm
When website is installed, we want website_form to be auto installed so there
will be a nice form available instead of just a href mailto button.

Also, when both website_form and crm are installed, we want website_crm to be
loaded. Removing website_partner dependency do the trick. That dependency seems
to be only historical and not needed anymore anyway.

task-32212
2019-04-19 07:16:40 +00:00
Jinal Patel ba80cc63a7 [FIX] l10n_in: remove required
- Purpose of this task is to remove required attribute on HSN field because that is not more required.
- before applied this commit if set up an indian company, we have an error if we edit a product because of HSN field is required.

Related Task: 1948171

closes odoo/odoo#32077

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-19 05:19:51 +00:00
Jinal Patel bd4edfd5f1 [ADD] l10n_in(_pos,_sale,_stock): add demo data
- Add demo data in the field HSN/SAC Code and HSN Description into the products.

Related Task : 1948171
2019-04-19 05:18:01 +00:00
Yenthe666 4c333ec57c [IMP] mass_mailing: set ids on elements for cleaner xpath expressions
closes odoo/odoo#32751

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-04-17 07:13:39 +00:00
Kinjal Mehta 2b484317ff [ADD] website_sale_stock: allow to set warehouse on the website.
Purpose: Add option to set a default warehouse on the website.

Before this: We are showing all quantity of product for specific company not
specific warehouse.

After this: We will see availability of product based on warehouse set on the
website.

task-1913031

closes odoo/odoo#30104

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-19 06:22:02 +00:00
jpr-odoo ee0a5ca449 [MOV/IMP] web, mail: update attachment widget and moved the common scss code from mail to web
with this commit, we have updated the attachment widget view same as like chatter attachment view
moved the common scss code from mail to web for many2many_binary widget, which is used for attachment
and update test case according to the widget

Task ID: 1930087
2019-04-12 09:04:28 +00:00
jpr-odoo d6d7554a6e [IMP] account: improvement into the invoice mail template
with this commit, we have added  comma ',' after the name of the customer

Task ID: 1930087
2019-04-12 09:04:27 +00:00
jpr-odoo caad35c29c [IMP] account, sale: improvement into the invoice report view
with this commit, changed the label of 'Shipping address' => 'Shipping Address' and removed 'Reference'
into the printed invoice report for a portal view

Task ID: 1930087
2019-04-12 09:04:26 +00:00
jpr-odoo 3d204d063f [IMP]account, website_sale: improvement into the invoice form view
with this commit, we have restructured 'other info' tab with few fields and updated the tooltips
and update the 'XPath' regarding the new restructure

Task ID: 1930087
2019-04-12 09:04:26 +00:00
Jinal Patel 25153b50ef [IMP] sale: apply correct header to quotation email template
This commit applies the correct quotation header to the quotation email.
The header now states "Your Quotation" if the stage is quotation instead of "Your Sale Order".

Related Task ID : 1936003

closes odoo/odoo#30849

Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-04-08 13:20:14 +00:00
Prakash Prajapati 0b9d752333 [IMP] payment: typo PayU Latam.
Change the label from PayUlatam to PayU Latam.

Hide s2s Form template field where Payment Flow is not s2s.

task-1940000

closes odoo#31048

closes odoo/odoo#31048

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-18 13:51:45 +00:00
Suraj Shukla 3f6aadaac4 [MOV] web, project: make cover image generic in kanban
Previously, we could only set cover image on the kanban view of project
task. This commit makes the feature generic so now cover image can be
added to any kanban view.

Technical notes:
- field used to display the cover image has to be set as 'data-field'
  attribute on the kanban dropdown's  menu related to cover image
- developer will have to take care while designing kanban views with
  cover image ability in such a way that it does not break the design

Task 32108

closes odoo/odoo#31731

Signed-off-by: Martin Geubelle (mge) <mge@openerp.com>
2019-04-18 10:26:51 +00:00
RomainLibert 3c32f9b903 [IMP] fleet: add future drivers on cars + managers on models
Basically when someone requests a new car, getting that car ready takes
some time, this means that during the waiting period, that person is
still driving its old car.

This commit adds a field future_driver_id on fleet.vehicle to tackle
that problem and a boolean plan_to_change_car on the partner to track
who wants to change car.

+ Apply some linting to the files
This commit cleans the vehicle form view, the vehicle contract form
view, the cost list view and adds a manager_id field on the
vehicle.model which is then used as a related on the vehicle.

Task: 1930298

closes odoo/odoo#31197

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-04-18 11:55:25 +00:00
Yenthe666 5b2cf15c05 [IMP] website_forum: use plural for action and tree name
As multiple records are displayed

closes odoo/odoo#32588

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-04-18 10:17:05 +00:00
jbm-odoo 4b7f05face [IMP] hr(_presence): Merge reporting menu
hr_prensence add a menu 'reports' in employee app and

hr_contract_dashboard add a 'Reporting' menu.

Merge both together.

closes odoo/odoo#32377

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-04-18 08:07:43 +00:00
jbm-odoo c44f6ffd61 [IMP] registry.py: Log info instead of warning about dropped view during installation
This problem appears when the module l10n_be_hr_payroll_fleet is installed with the
dynamic report for employees (enterprise module hr_contract_reports).

This module inherits from hr.contract and will create and modify some fields.

By modifying contract's table, PostgreSQL will drop the view from
hr_contract_employee_report. At the end of the installation, PostgreSQL will
check if tables exist, it isn't the case for the view from
hr_contract_employee_report, so it will recreate it.

It's the normal behavior.

But when a table is missing, a warning is logged and create problem with
Runbot. For this reason, it's better to log an Info and not a Warning message.

Validated with @rco
2019-04-18 08:07:43 +00:00
William Henrotin 204a673ca6 [FIX] stock: computation of quantity on hand
On the product form view, the stat button computing the quantity on hand
doesn't give the same result as the quants list triggered by this button

    What's displayed in the stat button of the quantity on hand ?
    1 get the view location of all the warehouses
    2 built the generation tree from the view locations
    3 get all the quants for those locations

    What's displayed in the quants list of the quantity on hand ?
    1 get all the quants stored in internal locations

This commit share the same logic for those two views, by building the
generation tree for the view location then filter on internal locations

Task : 1929515

closes odoo/odoo#30501

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-04-18 08:37:59 +00:00
Josse Colpaert 06320be488 [FIX] l10n_in: do not set country on main company in demo data
Before this commit, the demo data in the
Italian localization would give errors,
because it was setting fields incompatible
with the company being Indian.

It is better not to do this and leave it empty.
 (Indian localization is the only to do this)

closes odoo/odoo#32781

Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2019-04-17 14:49:58 +00:00
Pierre Rousseau fa87df0ddb [IMP] crm_iap_lead*: improve credits consumed feedback
To be able to correctly translate the information message on consumed credits, we are building those message in python in a computed field instead of building in xml with four computed fields.

Task-ID 1965687

closes odoo/odoo#32676

Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
2019-04-18 07:51:01 +00:00
Robot Odoo 7aa1e72779 [IMP] mail: Delete tracking values when uninstalling module
[IMP] mail: Delete tracking values when uninstalling module
--------------
### Purpose

mail.tracking.values should be deleted when the corresponding field is deleted (when the module which defined it is uninstalled).

Firstly because we don't want useless data in db.
Secondly because the groups associated with the field can no longer be checked if it was deleted. As we don't know to whom the value was restricted, the value should not be displayed anyway.

Note: this case was fixed in saas-12.2 by b9e96b7 but the proper
way to fix it is to delete the tracking values.

### Specification

Delete `mail.tracking.value` when the associated `ir.model.fields` is deleted.

Two alternatives were considered:

1. Change the `field` field of `mail.tracking.value` from Char to a m2o to `ir.model.fields` which allows to use delete oncascade. This implies to modify existing code, but more importantly it adds database queries.

2. Override the unlink method of `ir.model.fields` to first unlink associated tracking values.

The first method is probably cleaner but the second method was nonetheless chosen as we don't want to impact performance in the main tracking flow only to better support module uninstalls which happens rarely.

Note: when a module is uninstalled, `ir.model.fields` are unlinked one by one (in a for loop). Tracking values are therefore also unlinked field by field. Batchifying field deletion would greatly reduce the amount of queries.

[IMP] mail: Rename groups field of mail.tracking.value
----------------

This commit renames the `groups` field into `field_groups`.

The previous name was impossible to grep as the word `groups` is everywhere in the code base.

Also the new name better follows the implicit convention that fields related to the tracked field all start
with `field_`.

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

closes odoo/odoo#31861

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-04-18 11:01:15 +02:00
Jigar Vaghela ab4f5b1ff3 [imp] point_of_sale: payment journal filter
Before this commit, payment journal "Available in PoS" should not
ticked by default if created from PoS. And if I remove the filter
"Available in PoS", I should not see all payments methods.

Now, payment journal "Available in PoS" is ticked by default if
created from PoS. And if I remove the filter "Available in PoS",
I should see all payment methods.

closes odoo/odoo#30748

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-04-18 07:11:57 +00:00
Dharmraj Jhala c1dbc3f5ab [IMP] website: make hamburger menu scrollable in small devices
Currently, in small devices, hamburger menu of the cloned navbar
is not scrollable due to fixed position.

This commit improves the behavior and makes the affixed navbar
scrollable, enabling user to navigate through all the available
menus.

task-1938637

closes odoo/odoo#32359

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-04-18 05:18:49 +00:00
Lucas Lefèvre ad8e969323 [FIX] mail: Don't display message if only subtype
Currently, if a message does not have any tracking
value, any attachment and no body BUT has a subtype
with a description, the message is not considered
as empty.

The message subtype should not influence its
"emptyness".
2019-04-17 17:44:08 +02:00
Lucas Lefèvre fbf9b55c5b [IMP] mail: Rename groups field of mail.tracking.value
This commit renames the `groups` field into
`field_groups`.

The previous name was impossible to grep as
the word `groups` is everywhere in the code base.

Also the new name better follows the implicit convention
that fields related to the tracked field all start
with `field_`.
2019-04-17 17:05:17 +02:00
Lucas Lefèvre 8d2d41068d [IMP] mail: Delete tracking values when uninstalling module
Purpose
=======
mail.tracking.values should be deleted when the corresponding
field is deleted (when the module which defined it is uninstalled).

Firstly because we don't want useless data in db.

Secondly because the groups associated with the field can no longer
be checked if it was deleted. As we don't know to whom the value
was restricted, the value should not be displayed anyway.
Note: this case was fixed in saas-12.2 by b9e96b7 but the proper
way to fix it is to delete the tracking values.

Specification
=============

Delete `mail.tracking.value` when the associated
`ir.model.fields` is deleted.

Two alternatives were considered:

1. Change the `field` field of `mail.tracking.value` from Char
to a m2o to `ir.model.fields` which allows to use delete
oncascade. This implies to modify existing code, but more
importantly it adds database queries.

2. Override the unlink method of `ir.model.fields` to
first unlink associated tracking values.

The first method is probably cleaner but the second method
was nonetheless chosen as we don't want to impact
performance in the main tracking flow only to better
support module uninstalls which happens rarely.

Note: when a module is uninstalled, `ir.model.fields`
are unlinked one by one (in a for loop). Tracking values are
therefore also unlinked field by field. Batchifying field
deletion would greatly reduce the amount of queries.
2019-04-17 17:05:17 +02:00
jbm-odoo 82f33e90d5 [IMP] hr_contract: Improve display of contract related buttons
There is a button on the employee form that show the number of
contracts. This button is only accessible for hr manager,
but not for contract manager.

It's make more sense that this button is accessible for contract
manager. The contract manager can already see all contract from
the menu. Hr manager inherit rights of contract manager.

With this commit, the button is accessible with contract manager
rights and hr manager.

closes odoo/odoo#31415

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-04-17 12:10:22 +00:00
jbm-odoo dbd6fb4e8c [IMP] l10n_be_hr_payroll: manage credit time during contract
In Belgium, we have the concept of time credit and parental leaves.
Globally the person keep full time rights and the initial contract
is always signed on a full time basis. But an avenant with the new
time schedule must be signed.

A new wizard on contract allows to manage credit time. We can
specify the start and stop date, the new calendar and the work
time ratio. The new wage will be computed.

After validation, the current contract will be duplicate two times,
one modified for the time credit contract and the second for after
the time credit period. The current contract will have end date at
the beginnig of the time credit period.

TaskID: 1924200
2019-04-17 12:08:29 +00:00
mgh-odoo 131b5e2519 [REF] mass_mailing: cleanup redundant check in commitChanges()
* Use === for stricter comparison.
* Merge checks on this.wysiwyg and this.mode as they are redundant in
  this case.

Task-ID: 1950784

closes odoo/odoo#32280

Signed-off-by: Pierre Paridans <pparidans@users.noreply.github.com>
2019-04-17 09:30:38 +00:00
mgh-odoo 1f57d4a34c [FIX] web_editor: FieldHtml commitChanges called too soon
The original issue appeared in mass_mailing where triggering the mail
template preview throws a client error.

This commit prevents commitChanges() from being called before the
element is rendered.

Task-ID: 1950784
2019-04-17 09:30:38 +00:00
Florent de Labarre defbb16835 [IMP] product: allow to inherit items search
Create hook method

closes odoo/odoo#32526

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-04-16 15:56:35 +00:00
Jeremy Kersten 8d64971e99 [FIX] website_sale: some quick fix related to odoo/odoo@1537b475b0
iframe autoclose failed
bad label for
typo

closes odoo/odoo#32740

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-16 15:27:32 +00:00
jbm-odoo 59e6611736 [IMP] hr_skills*: Add certification and course in employee profile
When a employee succeed a course or a certification, a new line
will be added in resumé of employee profile.

+ [FIX] hr_skills: remove sequence to sort resumé

Actually, sorting a resumé doesn't work because we add new line for
title in the array.

With this commit, all sequence are removed. The resumé is sorted
by date and skills are sorted by level.

closes odoo/odoo#31764

Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
2019-04-16 14:48:25 +00:00
jem-odoo a54d5eede8 [FIX] hr_timesheet: timesheet UoM widget restored
When the assets are loaded, the `hr_timesheet.timesheet_uom` scope is
loaded in order
to bind the `timesheet_uom` to the correct already existing widget (defined
in the session, like `float_time` or `float_factor`, ...).
The problem is that in normal mode (not debug assets), when the binding is
done, the field_registry is empty, so the correct base widget is not applied.

The fix is to add the scope filling the registry in the requirements of the
`timesheet_uom` scope. Strangely, it was working in debug assets mode.

closes odoo/odoo#32736

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
2019-04-16 09:20:09 +00:00
Romain Derie 0034fd14f1 [FIX] website_sale: flag tests as post_install
Before this commit, runbot-theme was red somehow for the geoip pricelist test.
Adding post_install seems to fix the issue, anyway it is better to flag the
tests as such as it make no sense to test pricelists during module install.

closes odoo/odoo#32727

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-04-16 13:52:53 +00:00
Rohan Patel 2869750e0f [IMP] website_sale: add new button for buy now on eCommerce
task-1928466

closes odoo/odoo#32440

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-16 13:26:11 +00:00
mgh-odoo 208287385e [FIX] base_gengo: private key password field
Before this commit, the gengo private password was displayed in
plaintext in edit mode. This is due to text fields being rendered as
`textarea` in edit mode, which does not support the "password" type.

This commit fixes the issue by turning this field to `Char`, so that
it is rendered as `input` with type "password" in edit mode.

The loss of multi-line from `textarea` is not a big deal, because
gengo passwords are not that long.

Task-ID 1892058

closes odoo/odoo#32725

Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
2019-04-16 12:33:45 +00:00
Dharmraj Jhala 1537b475b0 [IMP] website_sale: showcase product videos on eCommerce
This commit adds facility to showcase product videos on it's
eCommerce page. They can be added to 'product.image' model,
same as extra images, thus allowing user to enter multiple
videos per template and per variant. Also, associated image
will be used as a thumbnail for the video on the product's
website page.

task-1945483

closes odoo/odoo#32298

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-16 10:34:49 +00:00
Dharmraj Jhala 33e17775e1 [ADD] website: added tools file for utility methods
This commit adds a new file 'tools.py' that can contain
utility methods which can be used at more than one places.

For now it contains a method 'get_video_embed_url', that
will accept a URL for the video and return an iframe snippet
that can be embedded if the provided URL is valid (returns
False otherwise).

task-1945483
2019-04-16 10:34:49 +00:00
Parth Choksi 378d7478b6 [IMP] website: improvements in SEO dialog
In this commit, we have changed behaviour of SEO dialog. Now when you
keep title and description fields empty, then the page will use default
title and description. We have added default_title and default_description
to render the preview with default values when title and description
fields are empty in SEO dialog.

Task ID:1949636

closes odoo/odoo#32449

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-04-05 11:34:19 +00:00
Parth Choksi dc44bf3b6a [FIX] website: allow empty strings in title and meta description
Before this commit, In SEO dialog once you set the title and description,
it was not possible to reset title and description. The reason behind the
issue was, update method was taking title and description from DOM
instead of dialog inputs.

After this commit, you will be able to save empty strings in the title and
description. Once user will do this, the page will use default title.

Task ID:1949636
2019-04-05 11:34:19 +00:00
Parth Choksi 14804b2cd1 [FIX] website: rendering 1 preview instead of 2 in SEO dialog
Before this commit, In dialog box of Optimize SEO, we were getting 2 previews.
This fix will remove the rendering of extra preview.

Task ID:1949636
2019-04-05 11:34:19 +00:00
Priyanka Kakadiya facacc3c19 [IMP] website_sale: make tour tooltip more visible
A tour tooltip was targeting a snippet which is at the bottom of the
page, we now target a snippet which is on top of the list so that the
related tour tooltip is more visible.

task-1942742

closes odoo/odoo#31400

Signed-off-by: Romain Derie (rde) <rde@odoo.com>
2019-04-16 09:10:32 +00:00
Geoffroy Larue 7f0d904d3a [IMP] sale_timesheet: profitability report
In the Project Overview, the Profitability report takes into account
Timesheet costs, but doesn't include information on Revenue.
Because of that, the user is missing crucial information to determine
the profitability of a given project.

This commit aims at fixing this issue by sending the user to the
'Project Costs and Revenues' report of the concerned project when
clicking the 'Profitability' button within the Project Overview page.

Task-1963932

closes odoo/odoo#32554

Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
2019-04-15 09:32:11 +00:00
Geoffroy Larue 637f19e621 [IMP] sale_timesheet: fix typo
Fix a tiny typo in sale_timesheet.

Task-1963932
2019-04-15 09:01:17 +00:00
jpr-odoo 10ce3f7030 [IMP] website: improve UX for logo/font size changing
This removes the 'V' box and it now validates the entered value when the
user clicks outside the box.

task-1952964

closes odoo/odoo#32291

Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-04-16 06:37:48 +00:00
Romain DerieandMitali Patel bc6a680482 [IMP] sale_quotation_builder: uniformize back button
Before this commit, the back button was a small button top right.
But in other modules, the back button is a full width button, like on /my/order
This commit adapt the back button to have the same style by using the adequate
template.

To do so properly, the `o_portal_fullwidth_alert` div was moved from
`portal.portal_layout` to `portal.frontend_layout`.
That way, templates calling `website.layout` can also use it as it inherits
from `portal.frontend_layout`.

task-1943427

closes odoo/odoo#31387

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>


Co-authored-by: Mitali Patel <mpa@odoo.com>
Co-authored-by: Romain Derie <rde@odoo.com>
2019-04-11 10:30:09 +00:00
Romain DerieandMitali Patel d3a95ccdea [IMP] sale_quotation_builder: uniformize back button
Before this commit, the back button was a small button top right.
But in other modules, the back button is a full width button, like on /my/order
This commit adapt the back button to have the same style by using the adequate
template.

To do so properly, the `o_portal_fullwidth_alert` div was moved from
`portal.portal_layout` to `portal.frontend_layout`.
That way, templates calling `website.layout` can also use it as it inherits
from `portal.frontend_layout`.

task-1943427

closes odoo/odoo#31387

Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>


Co-authored-by: Mitali Patel <mpa@odoo.com>
Co-authored-by: Romain Derie <rde@odoo.com>
2019-04-11 10:30:09 +00:00
Swapnesh Shah 634006ad81 [FIX] sale_management: fix field's attribute
on_delete had no effect

closes odoo/odoo#32596

Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-04-15 14:00:22 +00:00
svs-odoo 761cc0d707 [IMP] mrp,stock: more consistent sml button
Set the same icon and title for stock move line buttons and change the
action of the sml button in MRP Unbuild to open stock.move.line model
instead of stock.move model.

Task #1966567

closes odoo/odoo#32570

Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
2019-04-15 12:06:15 +00:00
mgh-odoo c159735a54 [FIX] pos: Negative payment (refund) on touchscreen
currently, if a user wants to return fund to the customer.
we don't have a button to bill negatively. that will fixed.

Task-ID: 1929650
Closes: #31054

Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-04-03 12:13:18 +00:00