This commit add some tests related to the mail gateway: more bounce management
tests and some additional thread formation tests. Some test asserts about
bounce / blacklist management are commented as they are not completely working
currently. This will be improved in master soon.
Some cleaning in also done in all mail gateway tests. Notably some call to
tool methods are cleaned / simplified, duplicate tests are removed. Some
low-level checks are removed.
A new test model is added for mail gateway: mail.test.gateway. It is a
chatter model with blacklist enabled on it. It allows to tests the
various blacklist-related overrides and features as well as all basic
mail gateway features.
Sub-part of task 1853147 (pre-cleaning before implementing mail gateway
improvements)
Linked to PR #32974
Purpose: fix crash when removing someone from followers through UI.
Sub-part of task 1853147 (pre-cleaning before implementing mail gateway
improvements)
Linked to PR #32974
Purpose: small cleaning of code linked to mail.mail model in order to
avoid unnecessary overrides
* create mail: default_fetchmail_server_id in context should be sufficient
as it is the base mechanism of default_get;
* write: unused in codebase. Anyway we should not write on mail and if it
is the case giving fetchmail_server_id directly should be the correct
way of doing it;
In case of a clean_context use we might loose default_fetchmail_server_id
key. It is used notably for tracking message generation. In that case
this information could be lost. However the whole concept of propagating
a fetrchmail_server-id from incoming mail server to outgoing emails (as
mail.mail is used only for sending email) is strange and does not require
so much specific code.
Sub-part of task 1853147 (pre-cleaning before implementing mail gateway
improvements)
Linked to PR #32974
Before this commit:
If the user was GeoIP located and it's pricelist (property_product_pricelist)
was not allowed for it's GeoIP country, that pricelist would still be return.
This issue was detected as a test `test_get_pricelist_available_geoip2` was not
working since forward ported in master (only on theme runbot or local..).
Before master (saas-12.4), `property_product_pricelist` would not be recomputed
once set, so the test was actually not working as expected.
Since master, reading `property_product_pricelist` just after setting it goes
through the compute method, resulting in different value than in previous
versions.
closesodoo/odoo#32961
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Stages modification through the clickable statusbar wasn't very intuitive.
By fixing default behavior through states (and corresponding buttons), default user experience is simplified.
3 static states available : draft, open, closed
Form view: navigation through states with buttons
Kanban view: disabled modification of survey state
Task ID : 1949110
closesodoo/odoo#32325
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
As original timezone is not taken into account when computing recurrent event
time of a given recurrency change depending on the DST. This commit fixes that
behavior by correctly storing the event timezone and using it when computing
recurrency datetimes.
Related to task 30388
closesodoo/odoo#32950
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
When a product's name is too big, in the structure & cost report, the
product's name line go to the line automatically.
Before this commint, the indentation applied on the products in the
report was only applied on the first line of the product's name.
Now, the indentation is applied on all the lines of the product.
opw-1966440
closesodoo/odoo#32945
Signed-off-by: Arnold Moyaux <amoyaux@users.noreply.github.com>
This commit synchronises the editable tree view and the form readonly view of
the following objects:
- account.invoice.line
- purchase.order.line
- sale.order.line
- repair.line
Task-1912608
Closes : #29566
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
While printing the reports using boxed layout, the font-size is bit smaller
and the report does not look so good. This commit improves the boxed layout
by slightly increasing the font-size.
Task id: #1931768closesodoo/odoo#30497
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Tour steps on m2x widgets are now consumed only when an actual record
is selected (not on random click on the widget).
closesodoo/odoo#21625
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>
* barcodes, calendar, partner_autocomplete, web_settings_dashboard
Make the notification system better, using bootstrap toast component,
and make it available in the frontend.
The toast component allowed to remove some JS code and made the
component customizable by themes but it had to be reviewed/fixed to make
it functional (maybe bootstrap will review its work in next versions).
This work should still be improved because there are still too many
ways (deprecated and not deprecated) to instantiate toasts in the
backend. The goal here was however to make the toasts more modern and
make them available in the frontend.
This work is needed for some tasks. @kig-odoo and @fja-odoo made a
pre-work to instantiate toasts in the frontend for their respective
tasks. This commit unifies the system.
Part of https://github.com/odoo/odoo/pull/32793
task-1970731
closesodoo/odoo#32793
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Just reorganize the files by alphabetical order and group them by
folder (core / services / ...) and move the libs on top.
Part of https://github.com/odoo/odoo/pull/32793
task-1970731
In some occasions, products can be available in a location,
but are still ignored when the MTO is set on those products.
(e.g.: When a product is returned)
To avoid this, we add a `procure_method` named `mts_else_mto`,
allowing procurement to reserve the products if enough of them
are available in his source location.
In order to achieve this, we apply the MTS or the MTO `procure_method`
on the moves from the procurement depending on whether or not there are
enough quantities of the needed products in the source location
('All or nothing' logic).
Quick performance test:
With a Sale Order of 800 differents products set as MTO+Buy,
Half of these products available in stock.
Before the patch :
2m30s to confirm the SO (800 PO Lines created)
After the patch:
MTO (procure method MTO):
2m30s to confirm the SO (800 PO Lines created)
MTO (procure method MTS_ELSE_MTO):
2m26s to confirm the SO (400 PO Lines created)
TaskID: 1831347
closesodoo/odoo#32778
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Purpose: allow to check email preview in a specific language in order to see
the result in a given translation context.
Specifications
* added preview_lang field to change language of template
* set default language from the template by evaluating expression if lang field of template is set,
This commit is related to task ID: 30245
closesodoo/odoo#19165
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
When using the 'tag' quicksearch on the contacts, it should search on the
parent tags as well. It is what users expect from this kind of search.
Using child_of is considered valid here as people should not have a huge
list of nested categories / tags. Even a famous production db like Odoo
does not have more than 215 of them.
Related Task ID: 1903699
closes#30733
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
When altering a view (regular or wizard's) in code/file (rather than via the
client's interface) and restarting the server view caches don't get cleared and
it's necessary to reload the entire client before the changes can be seen.
This is annoying, and sometimes confusing so the cache is now disable in debug
assets.
Task 1911601
closesodoo/odoo#31667
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
A `description` key has been added on AbstractField and all generic
field widgets ; it is used to display a more user friendly name (both in
the webclient and in Studio).
Non-generic field widgets have an empty string as description.
Related task 1918327
closesodoo/odoo#30131
Signed-off-by: Martin Geubelle (mge) <mge@openerp.com>
Co-authored-by: Mohammed Shekha <msh@openerp.com>
This widget was exactly the same as a `one2many` and was kept for backward
compatibility reasons. It can be safely removed in master.
Related to task 1918327
Merges mrp_bom_cost into mrp_account since they have both the same
depedences.
Task #1964809closesodoo/odoo#32722
Signed-off-by: Simon Lejeune (sle) <sle@openerp.com>
Before the changes, when a message was posted (on Discuss or in
the chat window), the composer was cleared directly as it didn't
wait for the rpc response. If there was latency or a connection
loss, the message disappeared from the composer but took time to
appear in the content window or didn't appear at all and was lost.
Now, the composer waits for the rpc response and then is cleared.
Task #1957856closesodoo/odoo#32422
Signed-off-by: Alexandre Kühn (aku) <aku@odoo.com>
With this rev., the resequencing feature (with drag and drop) that
was already available in list views is now available also in kanban
views having a field with widget="handle". This works for main as
well as x2many kanban views.
Some code handling the resequencing has been moved from the list
components (controller and renderer) to the basic ones, so that the
logic is shared between list and kanban.
Task 1902808
closesodoo/odoo#28581
Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
Co-authored-by: Mohammed Shekha <msh@openerp.com>
Co-authored-by: Aaron Bohy <aab@odoo.com>
Impacted modules: account, mail and web. (The 2 last only for the upload widget).
The merge brings lots of small UI improvements for invoices:
- reorganize form view to group field by their puprose and information type they provide to the end user
- remove duplicate information
- clean labels and tooltips for some fields
It also makes the "upload multiple widget" (the cutom one from the chatter) generic for all form views, ... (notably for the email composer wizard).
Task-1930087
closesodoo/odoo#30600
Signed-off-by: Jérome Maes (jem) <jem@openerp.com>
Notably
* remove cdata and fix html code when necessary;
* re-order fields declaration to have globally the same order in various
template definition;
* remove unnecessary reply-to, make user signature and auto delete fields
explicit when necessary;
* improve some name to ease template ordering and understanding in the
template list view;
Related to task 1972615
Linked to PR #32872
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Purpose: use more email_formatted when possible, clean and simplify
email_from, email_to and partner_to computation.
Next step is to try to extract some common patterns in tools or methods in
order to simplify template creation and customization.
Related to task 1972615
Linked to PR #32872
Allow to use todo activity type by default in hr plan in order to avoid
having to define a lot of unnecessary activity types. Custom activity
types are still supported in plan, just not mandatory to create new one
for each step.
Linked to task 1923387 .
closesodoo/odoo#30235
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
Some fields are missing to ease configuration and daily use of plan and plan
activity types.
While we are at it some xml ids are updated according to guidelines.
Commit linked to task ID 1923387 and PR #30235.
Purpose of this merge is to avoid having to define custom activity types for
each step of HR onboarding plan. This is done by adding a summary field
on hr activities, allowing to use default Todo activity type and customize
directly the summary itself.
Using custom activity types is still possible. Here we allow to avoid noise
and having too much activity types defined as most of those activities can
be simulated using the default Todo.
People can still define and use their own activity types if necessary and
required in their daily workflow.
Commit linked to task ID 1923387 and PR #30235.
Recent merge d5fd84b89a added onboarding plans to employees with some
new models. However conventions for naming files and views are not done.
This commit fixes that to ensure code readability.
Commit linked to task ID 1923387 and PR #30235.
This commit will fix UI glitch when seletion field and
any other field kept on same line
Using o_row we can put two divs, two inputs side by side but
if we have case where from two elements 1 is input and second one
is selection widget then we will have glitches in UI,
this commit will fix that glitch
task-31003
closesodoo/odoo#23914
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
This will fix UI glitch for fields added in form view side by side
to get fields on same line and also to get space between
two fields use o_row oe_inline is used to put two elements
on same line but it is used mostly where 1 element is field
and second one is static string maybe in span, oe_inline on
two field creates glitch in UI, to have two fields or divs on
same line we should use o_row class, o_row class meant to do that
task-31003
There was multiple issues with `website_sequence` field, mostly coming from
commits during the last few years (eg 43c544f8a8) that tried to change the
`website_sequence` order to be the same as `sequence` but changing only part of
the code.
Other commits tried to restore that again by changing only some parts.
This commit does:
1. Originally, the `website_sequence` was supposed to be the opposite of
`sequence` field, the greater the first.
This commit ensure this is not the case anymore and it is used as the
regular `sequence` field.
2. `website_sequence` demo data was set between 4 and 1000, no need to use so
big differences. Plus, having a website_sequence set to 4 means the next
product would already have negative value.
3. Add `website_sequence` field in tree view in place of `sequence` for website
product view, and in debug mode on form view.
task-1960777
closesodoo/odoo#32593
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
The comment for the question types:
- matrix
- simple_choice
- multiple_choice
Is now a textarea with a single row to allow expending it and see the full
answer when there is too much text to fit on the screen.
Some labels & alignments were also reworked in the process.
Task-ID: 1960726
closes : #32189
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
* website_crm_partner_assign
Before this task, portal section titles were not unified, some titles had
'your', some 'my', some none.
This commit unifies everything.
task-51585
closesodoo/odoo#24697
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
Display field in two groups to display in four column.
Plus, email_from is used to 'Allow communication with a customer without
creating a partner'.
Since this field is not very useful, it is best to hide it to clean the UI.
Something was already done at aa33c81535
task-54027
closesodoo/odoo#22845
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
Fixing missed 'pivot_row_groupby' assigned to groupedBy in pivot_model.js in
Load function (Already done in reload function), which was missed in commit
42f22a2.
Added qunit test case for testing correct value.
Apply pivot_row_groupby on user in project
task-54027
Before this PR, if you don't know that we have a website_form module, you will never use it and keep the 80's feature of send an email. Now, it is automatically with website.
Before, when you drop a new form, you just had the default required fields.
Now, you will have default form and will be able to finetune this one.
There still some fixes to do:
- extra_step: restore default value
- contact_form: default value based on request.params
- Refresh optionally data-source of x2many
That's one small step for Odoo, one giant leap for website_form.
See commits to have more details.
task-32212
closesodoo/odoo#32565
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
`t-att-` inside form should be removed because it makes the form not editable
by the form builder.
Instead of having these values set to the `<form>` DOM element, it will use a
`<span>` outside it.
task-32212
Now, the default form already has multiple fields by defult, including
`subject` one.
The test was adding that field, so it now needs to add another one that is not
on the form.
task-32212
That way, it is possible to add the template, fields and success page to
different type of form.
Next commits will use what has been done in this commit.
task-32212
As website_form is now auto installed with website, we want that module to
create a nice form by default but leave the possibility to the user to disable
it.
Wealso want a thank you page in website_form as it now have a nice form on
contact us page.
task-32212
Thibault Delavallée