Commit Graph
131229 Commits
Author SHA1 Message Date
Christophe Monniez 03a1b34fc3 [FIX] packaging: adapt Odoo version in windows installer
Packaging oversight, the displayed version in the installer window was still
12.0.

closes odoo/odoo#38486

X-original-commit: c5bd1a4f9730064f53ff633592dbf83ca7c1e4f7
Signed-off-by: Christophe Monniez (moc) <moc@odoo.com>
2019-10-11 09:58:46 +00:00
Antoine Prieels 01535c618a [FIX] pos_hr: res.users loaded twice
When pos_hr was installed, `load_models` was called twice for res.users
and calls to `load_fields` were not processed correctly.

closes odoo/odoo#38462

X-original-commit: 26274dbb9720743461be2a70de02bf4c1ea377f4
Signed-off-by: Antoine Prieëls <aprieels@users.noreply.github.com>
2019-10-11 08:23:24 +00:00
Antoine Prieels 93deb095c8 [FIX] point_of_sale: Scrollbar on receipt print
A scrollbar appeared every time a receipt was printed. To fix this,
we put a height of 0 to the div that contains the receipt.

html2canvas then had trouble computing the height of the background.
There's a `height` option that can be given to the library but if the
logo on the receipt was not loaded yet, the size we computed was wrong.
We then compute the height only once the images have been loaded, in
the `onparsed` method.

We also remove a CSS class that wasn't used anymore.

X-original-commit: 84418ae5bc1509c2c45323ecf6aed4ce4811f4d5
2019-10-11 08:23:23 +00:00
fw-bot 3a2c69edbf [FIX] web: use language week_start in datepickers
Before this rev., if the week_start param (the first day of week)
of the user language was changed, it wasn't reflected on datepickers
(however, it worked fine in the calendar view). This rev. makes this
work by updating the moment locale with the corresponding param.

Fixes #36450
Closes #36532

closes odoo/odoo#38472

X-original-commit: eeb518316f25d652bea3ec6d387db6ad93284fb2
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2019-10-11 09:15:43 +00:00
qdp-odoo b33f98d81f [FIX] account, usability: field label renaming
closes odoo/odoo#38485

X-original-commit: 806456f7c7780a544958791e4ca47fbf8c2fa2fd
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-10-11 09:58:13 +00:00
Andrea Grazioso (agr-odoo) 2300964058 [FIX] account: restore "View accounts detail" button
closes odoo/odoo#38474

X-original-commit: db32eafd3d67c158b76202187c7e311dd828d3f7
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-10-11 09:16:29 +00:00
Pedro M. Baeza 54116b1327 [IMP] purchase: Take into account purchase order date for sequence
**Steps to reproduce**

* Define "Purchase Order" sequence for using date ranges checking "Use subsequences per date_range".
* Change sequence prefix to "PO/%(year)s/".
* Create a purchase order with order date in 2020 (a different year than current one).

**Current behavior**

Got a purchase order with 2019 (current year) number.

**Expected behavior**

Got a purchase order with 2020 number.

closes odoo/odoo#38468

X-original-commit: ce423e6adb6659a1d5885bad158c59b882cb4565
Signed-off-by: Damien Bouvy (dbo) <dbo@odoo.com>
2019-10-11 09:14:28 +00:00
Pedro M. Baeza 9927b012ec [IMP] sale: Take into account sales order date for sequence
**Steps to reproduce**

* Define "Sales Order" sequence for using date ranges checking "Use subsequences per date_range".
* Change sequence prefix to "SO/%(year)s/".
* Create a sales order with order date in 2020 (a different year than current one).

**Current behavior**

Got a sales order with 2019 (current year) number.

**Expected behavior**

Got a sales order with 2020 number.

X-original-commit: 20baf00d07868a83cd73a13a6141bc0d36c85c44
2019-10-11 09:14:27 +00:00
Nans Lefebvre dcca8ae272 [FIX] website: fix _update_visitor_last_visit concurrency issues
Install the website, install a second language.
Switch the language on the website: error 500.

The function opened a new cursor, to update website_visitor.
It did so at the end of the query dispatch.
However when switching the language of the website, the lang is written on the
website visitor. This is done at the flush, done at the end (exit) of the query.
This is done on the cursor that was used for all the transaction.
Therefore that write would systemically fail on a
ERROR: could not serialize access due to concurrent update

opw 2080986

closes odoo/odoo#38453

X-original-commit: cc88a36744dc3c2949c47e8b163e1de98f5dbd95
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
2019-10-11 07:33:40 +00:00
Odoo's Mergebot e3117013ba Forward Port of #38303 to master
[MERGE][FIX] product: make copy of variants just copy template

Variants are generated depending on the configuration of attributes
and values on the template, so copying them does not make sense.

For convenience the template is copied instead and its first variant is
returned.

closes #38151

closes odoo/odoo#38452

Forward-port-of: odoo/odoo#38303
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2019-10-11 13:53:03 +02:00
Victor Feyens 76183692c7 [FIX] purchase_stock: remove use of product.product copy.
X-original-commit: 48ce2753b70cfcce01bacbda2f4727c62b092e4b
2019-10-11 07:33:23 +00:00
Sébastien Theys e7093827d2 [FIX] product: make copy of variants just copy template
Variants are generated depending on the configuration of attributes
and values on the template, so copying them does not make sense.

For convenience the template is copied instead and its first variant is
returned.

closes #38151

X-original-commit: 259f3b7fcdb88d1f458ee7ea3667964412b88ea1
2019-10-11 07:33:23 +00:00
qsm-odoo d499779e7e [FIX] website_mass_mailing, *: fix display of backend popup edition
In the backend, when a mailing popup was being edited, it was not
centered in the edition area (and went under the editor UI) and was not
using the correct style.

task-2083465

closes odoo/odoo#38449

X-original-commit: 6ccf3b618b4b0774deccb4f75bf33f3ea4dc8b75
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-10-11 06:45:11 +00:00
Swapnesh Shah 9fe33e650e [FIX] account: Use correct field in domain
Fixes https://github.com/odoo/odoo/issues/38308
payment_term_id has been replaced by invoice_payment_term_id

closes odoo/odoo#38448

X-original-commit: f6a5510e677404d6f917049b732b8fe5ba98a78b
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2019-10-11 03:12:05 +00:00
fw-bot bf5744b5c3 [FIX] website_slides: Do not copy Members on duplicate
closes odoo/odoo#38447

X-original-commit: ef34fc7b900d9da46354a49f3f283531d29d3978
Signed-off-by: Thibault Delavallee (tde) <tde@openerp.com>
2019-10-11 02:02:33 +00:00
Susana 38e7ba14cc [FIX] l10n_cl: fixed wrong domain getting document types
closes odoo/odoo#38446

X-original-commit: 089a9d9fb447a5717469bf931a62526d5462a361
Signed-off-by: Josse Colpaert <jco@openerp.com>
2019-10-11 01:16:21 +00:00
fja-odooandqsm-odoo 46b818db1e [FIX] website_sale: fix behaviors for loading recently viewed products
If there is no product in the recently viewed product snippet, it will
simply not be shown. It appears only if there are products (with some
flickering we may decide to improve in future versions).

Also fix the behavior when the last product of the snippet is moved to
the cart.

task-2076271

closes odoo/odoo#38438

X-original-commit: 02037bc20c6d3f5f2bad70a1a30b424ec432eb6b
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>
2019-10-11 08:48:09 +00:00
Swapnesh Shah 91a5021763 [FIX] hr_recruitment: Do not copy employee on duplicate
When recruitment is duplicated, `emp_id` should not be copied for obvious reason.

closes odoo/odoo#38442

X-original-commit: 68820340ce4adc5a31df23f0b5ff2c715a695fdc
Signed-off-by: Romain Libert (rli) <rli@odoo.com>
2019-10-10 19:01:11 +00:00
Nans Lefebvre 609ff1f0fe [FIX] calendar: handle inactive system language or missing date format
It is possible to select "System (English)" as chosen language,
or False in v12 or earlier versions.
However, if the language has not been activated,
then record_lang is an empty recordset, so record_lang.date_format is False,
(respectively time_format), and so the formatting crashes.

Note that if this happens, the calendar notification mechanism generates a crash
at each page load.

Instead we use get_lang which defaults to the most appropriate activated
language: the one given in argument if it exists, or the company one.

co-authored with @mart-e

closes odoo/odoo#38445

X-original-commit: 738214f00dff33389e7211ee73eae76b196b7844
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
2019-10-11 01:16:04 +00:00
Nans Lefebvre 4ef3a14ea3 [FIX] account_facturx: cleanup attachment management
Since 5cf9d55bbc, attachments are always records.
Before, they could also be named tuples, so helpers were needed.
Since they are now useless, we can remove them to clean up things.

closes odoo/odoo#38414

X-original-commit: 63a937a954c310af88cec214d683f61c64263407
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
2019-10-10 14:28:09 +00:00
Nans Lefebvre 66a2ca0591 [FIX] account_facturx: process pdf with .PDF extensions
In fact, "not filename.endswith('.pdf')" does not
"Check if the attachment is a pdf".
Some pdf files have filenames with a pdf extension, but .PDF, .Pdf
work generally just as well, and it's also possible to live without a file
extension.
In any case, it doesn't prevent from crashes because of corrupted files,
or files that are not pdf files but have the extension.

opw 2075933

X-original-commit: 3f63447d8f25f6ff8a4d9951a74db069d41332f3
2019-10-10 14:28:09 +00:00
Nans Lefebvre 381fa5abdd [FIX] account_facturx: do not write non-existing fields
If a field does not exist, writing it creates a warning in the logs.
This would for example prevent a valid test to pass.
This is needed because extract_state is a field from account_invoice_extract,
which is not a dependency of account_facturx.

X-original-commit: bb03b05df39097a954388ba6b00c025989351f16
2019-10-10 14:28:08 +00:00
Victor Feyens 1ef89f0928 [FIX] point_of_sale: use sudo instead of with_user(SUPERUSER_ID).
Since https://github.com/odoo/odoo/pull/34297, sudo() allows to keep
current user information when creating/modifying records.

There is no need anymore to use with_user(SUPERUSER_ID) to have sudo rights.

This commit ensures the user information is kept when creating pos sessions,
instead of having OdooBot as create_user.

closes odoo/odoo#38441

X-original-commit: aff1dc1ea68c345fb2632f9666dc298f685b8748
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2019-10-10 19:00:54 +00:00
Victor Feyens 75f2d8444e [FIX] mail: fix mailing wizard when partners and template specified
if partner_ids and template_id are set, a traceback happens.

Indeed, some mail fields are not taken from the res_ids when partner_ids
is set.

When trying to update the values with the one from the template, the
existing values are popped, which raised an error as those keys weren't
set.

closes odoo/odoo#38434

X-original-commit: c8ad614718674b55e9af5edd062ded958136e7ac
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2019-10-10 16:39:09 +00:00
fw-bot 04ada1ddae [FIX] l10n_mx: Transition Tax Accounts must be reconcilable
This issue is relevant for MX Localization because Cash Basis is created
with the rate of the payment, and not with the rate of the invoice as is
done for odoo core.

closes odoo/odoo#38399

X-original-commit: 10bb81c837c0d88ac4ec396442bd86a654c78646
Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-10-10 13:11:35 +00:00
jbm-odoo 6a2179fafc [IMP] web calendar: Keep width box while drag or resize
When there are many events at the same moment in a calendar,
events are thin and on mouse hover the event take all the width.

Before this commit, when we drag or we resize a event in calendar,
the event returns to the state thin.

After this commit, the width event stay width during resizing and
draging.

closes odoo/odoo#38384

X-original-commit: 405294602070590083a2b438f631615f72000292
Signed-off-by: Aaron Bohy (aab) <aab@odoo.com>
2019-10-10 11:58:07 +00:00
Goffin Simon f520ee8f7b [FIX] odoo: Import data with falsy many2one fields
Steps to reproduce:

- Export a partner with country set to False, using EXCELL
- Try to import it with the xls file

Bug:

It raised: "No matching record found for name 'False' in field 'Country' at row 2"

opw:2080376

closes odoo/odoo#38379

X-original-commit: 01caf1e44f653a8e9bf5edd583bc2421905d9464
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-10-10 11:28:09 +00:00
Nans Lefebvre d77a8de5f9 [FIX] account: round debit and credit of account move lines at creation
This fix is similar to 8020033; both are workarounds for the bug (limitation)
introduced by 9d87d15db6.
In this case, the currency_field is a related field, and these fields are only
computed after scalar values are written in database.
As a result, this value is not rounded at creation.

It is a problem since typically accounting reports are written directly in SQL,
and thus reuse the values directly.
Anyway even in the ORM the convert_to_cache optimised this away using the
assumption that 'the value should have been rounded in convert_to_column'.
It follows that in the report, errors can be accumulated
to the point where the report is not balanced.
This needs to be fixed in database by going through every existing line.

Of note: the limitation that was readily acknowledged has not been worked around
anywhere, in fact almost every single currency_field is a related one.
Also of note, commit afef71d6b should "Always round monetary values in database"
while it explicitly checked for the presence of the currency_field in the values
and while not introducing a mechanism to make sure it would always be in the
values.

opw 2066849

closes odoo/odoo#38376

X-original-commit: 937893379ba8c149c681b61a951ca507df798e6b
Signed-off-by: Nans Lefebvre (len) <len@odoo.com>
2019-10-10 11:11:30 +00:00
Nicolas Martinelli 398592fb9d [FIX] sale: edit lead time
Allow the edition of Lead Time only when the SO is not confirmed yet
since the modification of the scheduled date on an existing picking is
not expected.

opw-2083070

closes odoo/odoo#38375

X-original-commit: ee8476c8d57c06c724a9777494a86a88c623bd2c
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2019-10-10 11:11:06 +00:00
Romain Derie 9bbf57f915 [REM] web: remove unused controller /apps/<app>
This controller never really worked in the last 3 versions.
It was fixed in 11.3 with e9350993ca but broken with refactoring in 12.0 at a
higher level with 19eacf7d23.

It was even worse in 13.0 as it was leading to a traceback: `view_type` field
got removed with 3cd7ed07a2 but this controller was still reading that
field.

closes odoo/odoo#38355

X-original-commit: a5c4e262449fef03d05d5250e4523832db5fbf00
Signed-off-by: Jérémy Kersten (jke) <jke@openerp.com>
2019-10-10 08:56:22 +00:00
fja-odoo bdb08d0bcc [FIX] website_sale: fix list view variant JS error
Part of https://github.com/odoo/odoo/pull/37135
task-2070507

closes odoo/odoo#38349

X-original-commit: a273a53dd7915415f03f04a0072d1c23651da9d2
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-10-10 08:14:04 +00:00
fja-odoo b8c9dbcd5e [FIX] website_sale: prevent selecting itself as an alternative product
Part of https://github.com/odoo/odoo/pull/37135
task-2070507

X-original-commit: b289170f6c709b6869c034ba349b1d6ff4ab1dda
2019-10-10 08:14:04 +00:00
fja-odoo 2f0832a611 [FIX] website_sale: fix found count in product
The product count was not returned in the product page thus the search
count feature that you can enable in the customize was broken.
Now we reset the search in the product page.

Part of https://github.com/odoo/odoo/pull/37135
task-2070507

X-original-commit: db5447f8cae4c7976fca8d751e2494cba73d2d5f
2019-10-10 08:14:04 +00:00
Martin Trigaux 536b0b1523 [IMP] payment: uniform translatable messages
Avoid trailing space:
In translation content, these tends to be skipped during translation,
making the message inconsistent. There is already a translation for
the term without the space so can reuse it.

Merge "setup"
Use the same writing to avoid having two similar messages

Remove unnecessary comma

Merge PayPal and Paypal

Courtesy of Primesh on Transifex

closes odoo/odoo#38348

X-original-commit: c1fb136cc684eba0cdeec302f27268ccda7fa5d2
Signed-off-by: Martin Trigaux (mat) <mat@odoo.com>
2019-10-10 08:10:13 +00:00
Martin Trigaux dcc737bd08 [FIX] account: add missing space
Courtesy of primes2h on Transifex

X-original-commit: 0e5e8a9f6d6eb111392237b1bf860b060a5889fc
2019-10-10 08:10:13 +00:00
Juan Jose Scarafia a3a5625c6a [IMP] l10n_latam_invoice_document: refund sequence on journals
On l10n_latam_invoice_document, if a sales/purchase journal use documents, then the journal sequences are not used, with this improvement the user don't see fields that are no needed (Credit Notes Next Number) and also it avoids the creation of the refunds sequences that is not going to be used

closes odoo/odoo#38335

X-original-commit: 1b647b8ead1fc70c18223914c96619c7f9a21b6e
Signed-off-by: Josse Colpaert <jco@openerp.com>
2019-10-10 06:34:31 +00:00
Victor Feyens 20c48953f8 [FIX] snailmail_account: send multiple invoices
* Ensure compute always sets partner_id.
* Don't show "to" when partner_id is not set

closes odoo/odoo#38334

X-original-commit: 7e122140b13fce5cf466376fe9fcb631e4b6bd75
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
2019-10-10 06:34:13 +00:00
Christophe Simonis 0f6d2a42ca [FIX] account: remove duplicated record definition
closes odoo/odoo#38333

X-original-commit: aab017f1489b8c966b9de1f8c900f7cb9eab0656
Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-10-10 06:33:54 +00:00
Raphael ColletandSébastien Theys 8218642541 [FIX] website_theme_install: theme installation
Group the upgrade of upstream dependencies with the installation of a
new theme into a single install/upgrade operation.  This fixes cache
misses occurring when accessing the state of a module after having
upgraded other modules.

closes odoo/odoo#38331

X-original-commit: 03b796b9e92e6eeeee877beaea133bdb6de0c6a3
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
Co-authored-by: Sébastien Theys <seb@odoo.com>
2019-10-10 06:33:16 +00:00
lejeune quentin 5d7e0b3735 [IMP] hw_drivers: Change version of IoT Box
We update the version of the build for IoT Box

closes odoo/odoo#38328

X-original-commit: be464a3759a4fe395334a1b26b90f7395e031d1a
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-10-10 06:31:41 +00:00
lejeune quentin 59173b6569 [FIX] hw_drivers: Fix for Customer display
When a box was unable to reach the Odoo server the customer display
show a white screen.

With this fix we show the default POS Client display with IP address

closes odoo/odoo#38315

X-original-commit: 290c2be72cd8305fbf8093d782604e8b0f4a80c4
Signed-off-by: Quentin Lejeune (qle) <qle@odoo.com>
2019-10-10 06:26:38 +00:00
Jigar Patel 7704a56df1 [IMP] doc: update documentation of map view
For simplicity marker popup fields are declared as a direct child of the root
element.
consistency in the name of marker popup fields
added new 'hide_name' and 'hide_address' option in the calendar view

task-2009017

closes odoo/odoo#37433

Signed-off-by: VincentSchippefilt <VincentSchippefilt@users.noreply.github.com>
2019-10-10 12:03:34 +00:00
Sébastien Theys 9fc948f963 [FIX] base: fix company logo placeholder
- fix condition to correctly display company logo placeholder
- use avatar_grey on the "Contacts & Addresses" as white on white is not visible
- use `cover` to avoid excessive zoom on mobile

closes #38001

closes odoo/odoo#38319

X-original-commit: 1210cb70bec421936c9d332b1347797bc83845cf
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2019-10-10 06:28:03 +00:00
Christophe Simonis 4ea8f780ff [FIX] lunch: don't update or recreate initial data
closes odoo/odoo#38317

X-original-commit: b50bccb28973bf939ac34c6aabe69bc3d3da8734
Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-10-10 06:27:29 +00:00
Christophe Simonis 1662d0cfe6 [FIX] lunch: force empty context in action
X-original-commit: 46a3ac1985346ad8f9b23ace73d825d1120830d1
2019-10-10 06:27:28 +00:00
fw-bot 91e4b00b8b [FIX] base_sparse_field,mail: handle None _instanciate_attrs override
The parent was expected to return a dict, but it can also return None in some
cases. When that happens, the overrides were crashing because it is impossible
to assign a key/val to None.

Note that using `if` conditions like this also prevents from writing on the dict
if it is existing but empty, but due to the definition of the parent, if there
is a dict, it will not be empty.

closes odoo/odoo#38316

X-original-commit: 3525fad3b1729286d139b19a4a92f1821d94ad88
Signed-off-by: Sébastien Theys (seb) <seb@odoo.com>
2019-10-10 06:27:09 +00:00
qsm-odoo b0fc1cd455 [FIX] website: make background videos in mega menus work
When a background video was used in a mega menu, it was only working in
edit mode. Indeed, the background video size is computed on page load
(and on window resize) but as the video is inside a hidden dropdown
menu in this case, the size cannot be properly computed.

This commit fixes the issue by recomputing the video size on dropdown
menu opening.

task-2080590

closes odoo/odoo#38314

X-original-commit: 66ec1c19b63fe26e559ed2d8d7359df974ade789
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
2019-10-10 06:26:21 +00:00
Christophe Simonis 7af8534d07 [FIX] mail: force empty value on record
closes odoo/odoo#38327

X-original-commit: da9e377ba480a034c5d740a6bcb4325f70e7f9e8
Signed-off-by: Christophe Simonis <chs@odoo.com>
2019-10-10 06:31:21 +00:00
Antoine Vandevenne (anv) c9a54e1d05 [FIX] sale: fix down payments being deducted when they should not
Prior to this commit, un-checking 'Deduct down payments' on the invoice wizard had no effect: down payments were still deducted from the final (regular) invoice.

task-2081012

closes odoo/odoo#38326

X-original-commit: 4ef49cafec13e614c788354bc35fd232abab296b
Signed-off-by: Antoine Vandevenne (anv) <AntoineVDV@users.noreply.github.com>
2019-10-10 06:31:02 +00:00
Andrea Ullianaandqsm-odoo af847832e8 [FIX] website, *: force website UI dropdown style
* web_editor

The purpose is to force our dropdown style in our UI so that themes do
not break it anymore (same way all the other elements are forced (cards,
headings, etc)).

task-2059538

closes odoo/odoo#38321

X-original-commit: 4ef0eac5ba134f462f72f3e9c60e5c9fc95f3a8c
Signed-off-by: Quentin Smetz (qsm) <qsm@odoo.com>
Co-authored-by: qsm-odoo <qsm@odoo.com>
2019-10-10 06:28:50 +00:00