Commit Graph
118442 Commits
Author SHA1 Message Date
Thibault Delavallée 0113d989a8 [REV] hr_holidays: revert "[FIX] hr_holidays: officers can CRUD leaves for their companies"
This commit was not correct and was a quick fix to avoid blocking daily use
of odoo saas-11.3. Next commit will fix access rights and enforce their
definition through more detailed tests.

This reverts commit ae34db3221.

This commit is linked to task ID 1876795 and PR #26656 .
2018-08-31 14:19:23 +02:00
Olivier Colson e886c2edd3 [IMP] base: res.partner.bank: always display account holder name field (not only in debug) 2018-08-28 10:54:31 +02:00
Lucas Perais (lpe) ae34db3221 [FIX] hr_holidays: officers can CRUD leaves for their companies
Before this, CRUD leaves was limited to department

After this, we go back to what was in 11.2: CRUD for the whole company, and children of it

OPW 1878869
closes #26516
2018-08-27 10:37:44 +02:00
Christophe Simonis 9eef533e98 [MERGE] forward port branch 11.0 up to 3c9aa50449 2018-08-27 10:04:06 +02:00
Dipalee Bhalodia 3c9aa50449 [FIX] web: Graph: group by two fields on line chart
Before this commit, when we applied two or more groupbys in line
graph, the groups displayed on the X axis where shifted to the left,
and the first one wasn't displayed at all.

related task: #1848289
Closes: #25037
2018-08-27 08:21:40 +02:00
Moises Lopez - https://www.vauxoo.com/ 8bda4744b5 [FIX] requirements: improve python3.7 compatibility
Continuation from https://github.com/odoo/odoo/commit/27c017ad98b4c9ac5fdcd28c9fd84d3690993118
PyYAML was missed in the list
Closes #26587
2018-08-27 08:19:53 +02:00
Odoo Translation Bot 7526b64e8a [I18N] Update translation terms from Transifex 2018-08-26 04:10:40 +02:00
Christophe Simonis 3be46428cc [MERGE] forward port branch 11.0 up to 302ad0632c 2018-08-24 21:12:27 +02:00
Christophe Simonis 302ad0632c [FIX] base: set filename of javascript files of assets
A side effect of this bug was that other bugs like [1] wasn't caught by
the test suite.

[1] 2ed13c583e
2018-08-24 21:07:09 +02:00
Christophe Simonis 2ed13c583e [FIX] web: run all tests, not *only* this one 2018-08-24 21:05:50 +02:00
Christophe Simonis 2438aff60c [FIX] web: remove broken test
This test doesn't pass for unknown reason. We can safely remove it as it
behavior is already tested in test above (create a column in grouped on
m2o).
2018-08-24 19:36:29 +02:00
Christophe Simonis 4a6c3da238 [MERGE] forward port branch 11.0 up to 33981790de 2018-08-24 18:22:27 +02:00
Christophe Simonis 33981790de [MERGE] forward port branch saas-15 up to 4703d649dc 2018-08-24 18:03:00 +02:00
len-odoo 818c18e55d [FIX] web: fix js data during consecutive sequence of resequence moves
Let x_1, ..., x_a, x_{a+1}, ..., x_{a+k}, x_{a+k+1}, ..., x_{n} be a record
sequence ordered by its 'sequence' field.
Suppose the reordering occurs between elements x_{a+k} and x_{a+1}.
If the subsequence x_1, ..., x_a is ordered, then it does not change.
This is also true of the subsequence x_{a+k+1}, ..., x_{n}.
The resquence function makes exactly this assumption, and only sends the server
the subsequence x_{a+1}, ..., x_{a+k} to update its 'sequence' field.
The update of x is done as follows: it is index + offset, where index is the
position of x in the subsequence, and offset is the 'sequence' of the first
element of the sequence (i.e. x_{a+1}.sequence).

It is easy to see that we need another hypothesis: that the sequence numbers are
unique. To show it, suppose that the sequence of x_1, ..., x_a is 0, then all
x_{a+1}, ..., x_{a+k} have sequence 1, and lastly all x_{a+k}, x_{a+k+1}, ...,
x_{n} have sequence 2. Then after the call to the server resequence, the
subsequence x_{a+1}, ..., x_{a+k} would have sequence numbers 1, 2,..., k.
Since the x_{a+k+1}, ..., x_{n} subsequence have 'sequence' value 1, this would
obviously be incorrect.

We fix the reordering of the data in the js frontend to be consistent with
what is done by the server.
Note that this is only pertinent for sequences of reordering moves, since
otherwise the data comes directly from the server.

opw 1867049
2018-08-24 17:25:54 +02:00
Christophe Simonis 4703d649dc [MERGE] forward port branch saas-14 up to aeb3391a2d 2018-08-24 14:07:40 +02:00
Christophe Simonis aeb3391a2d [MERGE] forward port branch 10.0 up to b50958c40f 2018-08-24 11:42:33 +02:00
Toufik Benjaa f12287c356 [FIX] website_crm_partner_assign: display partner ordered by sequence
- Fix for e2310eec60
2018-08-24 11:13:47 +02:00
sed-odoo 4015c84633 [FIX] web: Disable keyboard shortcuts on BlockUI
Related to the bug: 1874270

Purpose
=======

Keyboard shortcuts working on BlockUI and can cause some issues when used.

Specification
=============

It should not work and should not be display while some process is being executed.

- add function to remove the "accesskey" attributes to avoid the use of the
  access keys while the blockUI is enable.

- add function to reset the "accesskey" attributes when the blockUI is disable.

- add condition to avoid the "Alt" key to reattribute access keys.
2018-08-24 10:49:30 +02:00
Lucas Perais (lpe) b50958c40f [FIX] account: allow range amount search for reconciliation widget
In the reconciliation widget, search for an amount like 5361.61

Before this commit, if the targetted line that you want to see was represented as 5361.61000001
you did not see it in the results of the search

After this commit, you do!

OPW 1872543
closes #26523
2018-08-24 09:43:51 +02:00
Invitu a19d2c98f4 [FIX] point_of_sale: consider timezone in return orders
Similar to 21575407 for returns
payment_date is a date field, make sure the day is the one of the user

Closes #25342
2018-08-23 15:52:55 +02:00
Nicolas Lempereur 01b1830219 [FIX] mail: access token in received cid images
Following 50ab18176 an access token is added in the URL, but there may
not be an existing access token. If so this commit generate one.

opw-1877347
closes #26526
2018-08-23 15:38:34 +02:00
Toufik Benjaa 61d790d6e2 [FIX] base: avoid crash when acessing image without access_token
- When accessing an image from an "ir.attachment" which doesn't have an
  access_token, the code crashes if you provide the argument access_token
  on the URL.

  This is due to a comparison between a boolean and a string using the
  consteq function.
2018-08-23 15:20:24 +02:00
Christophe Monniez d4f36c0e8b [FIX] hr_holidays: remove unread meassages filter
Before the models split in a0f4f65 the Leaves Summary report inherited
the message_needaction from mail.thread.  Now the hr.leave.report model
does not have this field and leads to a traceback.

With this commit, the filter is removed from the search view of the
report.
2018-08-23 14:57:14 +02:00
Toufik Benjaa e2310eec60 [FIX] website_crm_partner_assign: display partner ordered by sequence 2018-08-23 14:54:08 +02:00
Olivier Colson 12fbbacc6d [IMP] account: reconciliation widget: format dates depending on user's language preferences. 2018-08-23 14:53:25 +02:00
Swapnesh Shah d6ee2abb98 [FIX] point_of_sale: force invoice journal if enabled
When the option "iface_invoicing" is enabled, an account journal must be set.

Closes #24380
2018-08-23 14:10:14 +02:00
Hiral Bhavsar 5830fcf506 [FIX] account: reconciliation: Pass context properly when making RPC call
This way, language formatting is always performed (123.30 becomes 123,30 in French for example).
2018-08-23 13:29:41 +02:00
Lucas Perais (lpe) 7ea67cea2e [FIX] crm: make sure there is a create date when computing date_open
Display the field date_open in the crm.lead form view
Create a new record

Before this commit, there was a crash because since the record is a virtual one
there is no create_date, hence the crash

After this commit, we make sure we select records that have a create_date, and there is no crash

OPW 1877080
closes #26499
2018-08-23 11:27:26 +02:00
Christophe Simonis b844e9af8b [MERGE] forward port branch 9.0 up to 81f975d3f4 2018-08-23 10:54:52 +02:00
Toufik Benjaa 81f975d3f4 [FIX] mail: channel_get return wrong channel when duplicate partners
- In some cases (merge of partners, etc ...) there might be mail.channel
  that have two mail.channel.partner with the same res.partner.
  When you try to open a discuss window with a partner for which you
  have no existing mail.channel.
  The channel opened is the one where your partner is duplicated.
  This is due to the fact that the SQL request to find the mail.channel
  doesn't take in account that a mail.channel may have twice the same
  partner.

  To fix this issue, we try to exactly match the partners we search.
2018-08-22 17:59:22 +02:00
David Monjoie a66650a7fa [FIX] web: esc cancels kanban column quick create
The feature was already declared in AbstractQuickCreate, but the
ColumnQuickCreate object did not define a _cancel function.
2018-08-22 15:54:21 +02:00
Arnold Moyaux be4651cda3 [FIX] stock: compare quantities with different uom
Usecase to reproduce:
- Create a receipt for 1 dozen.
- Mark as todo
- Unlock and update initial demand to 3 dozen.
The reserved quantity on move line is 36 dozen.

It happens because reserved_availability and product_qty are
compare. However reserved_availability is in move UoM and product_qty
is in move's product UoM.

This commit clean the code in order to compare field that use the same
UoM.

Close #26504
2018-08-22 15:44:54 +02:00
Toufik Benjaa 26084f1cc7 [FIX] web: allow to bypass postprocess on image widget
- If a CDN is used, this might cause issues for images that need access
  rights to be display.

  This is due to the fact that users are not connected on their account
  under the CDN domain, which makes the CDN requests reject since it is
  not authorized to access to those resources.
2018-08-22 15:30:52 +02:00
Toufik Benjaa 7f775f0677 [FIX] hr_expense/holidays: approval issue if manager in different company
- When trying to retrieve the manager of an employee who is in a
different company, an access right error appears.
  This commit fixes this issue.
2018-08-22 12:17:44 +02:00
tanghulu0608 e1d4b48d8e [FIX] web: correctly apply pdf_viewer style
The pdf_viewer widget has been moved from mrp to web in rev. odoo/odoo@a7b521f
but the corresponding style was still in the mrp module. It's now put in the
right place.

Closes #26449
2018-08-22 11:40:40 +02:00
Lucas Perais (lpe) 350a4ff861 [FIX] crm: fix API merge, other spot
fix cc72b0c2fa did not go far enough

Sorry for it
2018-08-22 11:00:43 +02:00
Christophe Simonis 6cc7d3f945 [FIX] web: correct test view option name 2018-08-21 17:36:34 +02:00
Christophe Simonis 70d0148d0d [MERGE] forward port branch 11.0 up to fbfb91799e 2018-08-21 16:58:17 +02:00
Christophe Simonis fbfb91799e [MERGE] forward port branch saas-15 up to 9cf0dbe226 2018-08-21 16:00:40 +02:00
Christophe Simonis 9cf0dbe226 [FIX] base_sparse_field: improve fields' view
Set default values when creating serialized field from contained field.
2018-08-21 15:12:16 +02:00
Nicolas Martinelli 65c2a9b70c [FIX] sales_team: default team is active
Check the default team is active. Moreover, make the return object type
consistent.

opw-1876966
2018-08-21 14:46:11 +02:00
Christophe Simonis c619b19f66 Revert "[FIX] manual creation of serialized field from the interface"
Non applicable since b0646f9d2c.

This reverts commit 03395ea103.
2018-08-21 14:13:15 +02:00
Nicolas Martinelli f46761caa8 [FIX] membership: change partner on invoice
- Go to a contact C1 > Membership tab > Buy membership
- Create an invoice with the membership
  => It creates a membership line on C1
- Change the partner on the invoice to C2

The membership line and the membership status is not transfered to C2.

We first need to recompute on C1, and we also need to explicitly write
the new partner C2 on the membership lines.

opw-1875673
2018-08-21 13:39:16 +02:00
Nicolas Martinelli b8161ec806 [FIX] membership: cancel invoice
- Go to a contact > Membership tab > Buy membership
- Create an invoice with the membership
  => The status of the member goes to 'Waiting membership'
- Validate the invoice
  => The status of the member goes to 'Invoiced membership'
- Create a credit note to cancel the membership
  => The status of the member goes to 'Paid members'.

It shouldn't be the case because the client has canceled his membership.

We look on `payment_move_line_ids` instead of `payment_ids`. Indeed, the
latter doesn't list credit notes, while the first one lists all move
lines used for payment.

opw-1875673
2018-08-21 13:39:16 +02:00
Christophe Monniez c8762eaa03 [FIX] hr: properly set label in kanban-box
In recruitment, clicking on configuration > job positions > kanban view
leads to an odoo client error.

The qweb template cannot evaluate the condition on the client side.
With this commit, the ternary condition is properly evaluated.

Also, an unnecessary t-attf is removed.

Closes #26486
2018-08-21 12:08:31 +02:00
Christophe Simonis e80f853ab3 [MERGE] forward port branch saas-14 up to aafa6e38c4 2018-08-21 12:06:23 +02:00
Toufik Benjaa a05ae78abd [FIX] mail & project: Display access button on mail notifications
This commit fixes two issues:

	- If a partner has multiple users and if any of these users is a
          share user, then the access button on mail notifications is not displayed.

	- If a project.task is either assigned or has its stage folded
	  the access button may not be displayed for certain users.
	  The users affected by this bug are the one who have their user's
	  partner is linked to multiple users with at least one flagged as a share user.
2018-08-21 11:58:50 +02:00
Christophe Simonis aafa6e38c4 [MERGE] forward port branch 10.0 up to 342d037373 2018-08-21 11:33:53 +02:00
Christophe Simonis 342d037373 [MERGE] forward port branch 9.0 up to f750393030 2018-08-21 10:50:32 +02:00
Pedro M. Baeza 87a6b879a2 [FIX] account: Fix tax summary on invoice report
We want to show the base amount for the tax when there are multiple taxes or the
amount is not the invoice total, not the contrary.
2018-08-21 10:36:53 +02:00