36 Commits
Author SHA1 Message Date
Wolfgang Taferner f62d35e3de [FIX] base_vat: properly display in context
Having the VAT VIES Check valid field directly next to the VAT number
as an inline element becomes unreadable, so we wrap it add padding and text-nowrap

closes odoo/odoo#159332

Signed-off-by: William André (wan) <wan@odoo.com>
2024-04-03 16:27:08 +00:00
Wolfgang Taferner 801ce62150 [FIX] hr_holidays: correct unclear time off approval email flow
- Remove context which came from the calendar action to only show short name in activity message
- Replace date connector with - as a / does not help to better understand the data given

closes odoo/odoo#158220

X-original-commit: 125793980e10f0c7d186f5662e4abbb3de3e212a
Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
Signed-off-by: Wolfgang Taferner <w.taferner@wtioit.at>
2024-03-21 18:35:48 +00:00
Wolfgang Taferner 851eb19843 [FIX] account_payment: new transaction will fail based on NewId / None in query
In order to avoid failing on this computation make sure actual ids are available
to be used in query.

closes odoo/odoo#150201

X-original-commit: c133d584153d3acc617433380773ac5d66419d80
Signed-off-by: Morgane Demesmaeker <edm@odoo.com>
2024-01-22 09:08:55 +00:00
Wolfgang Taferner 5065f52392 [FIX] stock: add dedicated owner to move to avoid wrong quantity at date
As _compute_quantities_dict does use stock.move as a source of calculation
we need to make sure that the dedicated owner is set also on inventory
moves which was forgotten and resulted in wrongly computed quantities
in the past in case of such an use case.

closes odoo/odoo#149596

X-original-commit: 02d5c04e85e0bc1b9c0edf66969066ba4f2d769c
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Signed-off-by: Wolfgang Taferner <w.taferner@wtioit.at>
2024-01-16 22:40:03 +00:00
Wolfgang Taferner a9a1c5d40b [FIX] l10n_ca: only show PST on reports if set
Add a missed condition to only show the label if the value is set

closes odoo/odoo#148650

X-original-commit: 4766809fdd4c04eb2258da4ff9e312dac7c09ea0
Signed-off-by: Florian Gilbert (flg) <flg@odoo.com>
2024-01-10 19:39:29 +00:00
Wolfgang Taferner 398e99b52e [FIX] purchase_stock: do not try to manipulate done or scrapped moves
In case of chained stock moves, we need to consider that
a purchase order might be linked to other orders which
are already fulfilled differently on the same order line,
so we filter for those which are still relevant for propagation
or change in procure method.

closes odoo/odoo#143338

X-original-commit: 468fc94afe4e2776abb526a67cc3785d903f088a
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
2023-11-26 19:02:46 +00:00
Wolfgang Taferner 039407cf29 [FIX] delivery: avoid endless loop
- Have a delivery order sent to a shipper and done
- Return this delivery order completely (without a shipper, might not be important)
- Return of the return to resend to the customer (with a shipper and therefore a tracking number)

This will lead to a endless loop as the move_origin_ids say so (might be a bug or not)

Anyway, we make sure that the logic makes sure that we do not process twice the same stock move.

closes odoo/odoo#143076

X-original-commit: 73b41f5fa403f2737302441ce0039ee138a408c0
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
Signed-off-by: William André (wan) <wan@odoo.com>
Signed-off-by: Wolfgang Taferner <w.taferner@wtioit.at>
2023-11-22 07:43:12 +00:00
Wolfgang Taferner cd14667605 [IMP] sale_purchase: give the possibility to inject a partner
closes odoo/odoo#131399

X-original-commit: 3631c5c1e143a1634a392c510b27d1b222e68912
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
2023-08-10 04:16:22 +02:00
Wolfgang Taferner 562c5120dc [IMP] product: add method to apply own criteria on seller selection
X-original-commit: aa0a3c07f722ecf0cc61d1872d12da2733fa8a18
Part-of: odoo/odoo#131399
2023-08-10 04:16:22 +02:00
Wolfgang Taferner d93efc5b5c [FIX] hr: always retrieve valid employee
if you are a multi company user and you are employee
in another company than the current one you will
end up not be able to use your department as a filter
even if the department is defined for multiple companies

closes odoo/odoo#129665

X-original-commit: 8a30dbb4937ffad93e9d310ca4996d6ff5eac268
Signed-off-by: Sofie Gvaladze (sgv) <sgv@odoo.com>
Signed-off-by: Wolfgang Taferner <w.taferner@wtioit.at>
2023-07-25 22:36:36 +02:00
Wolfgang Taferner 945ed63bb8 [FIX] hr_work_entry_holidays: a leave can be of type other as well
The previous domain fix 84d8bf8167
was skipping all potential leaves of type other left out for work entries
therefore properly inherit instead of overriding and add the proper domain

closes odoo/odoo#128527

X-original-commit: 076d2179ad2f19c0ff8be043e492bdc7b780baef
Signed-off-by: Kevin Baptiste <kba@odoo.com>
2023-07-15 12:00:42 +02:00
Wolfgang Taferner 6a8562f3d1 [FIX] hr_*: unusual days + public holidays independent of employee
In case we use multi company and a user does not have an employee
in every company which is quite normal (mostly you are employed with
exactly one company), the calendar is skipping the provision of the
unusual days like public holidays or the working schedule.

To be able to access and see the calendar in such a case we fallback
to the company calendar and fixed a domain for the public holiday
retrieval whereas the public holidays are not assigned to an employee
but the company or the companies chosen to be displayed.

closes odoo/odoo#126420

X-original-commit: d80a3965b7356f9d6b1294cf428667a1057a272b
Signed-off-by: Kevin Baptiste <kba@odoo.com>
2023-06-26 22:15:34 +02:00
Wolfgang Taferner 080c2fc574 [IMP] hr_*_attendance: leave in terms of working time not respected
As the leave is deducted from the needed time to work
in case for example Home Office which is configured as
working time (other) is handled like a real leave (absence)
which will lead to an extensive overtime instead the difference
to the work entry defining the work time.

A domain clearing out this missing link and variation
cleans up this misalignment and therefore overtime will
be computed correctly.

closes odoo/odoo#126373

X-original-commit: 02a679d6ab7db49c8338471e5fc85c1141f8e877
Signed-off-by: Kevin Baptiste <kba@odoo.com>
Signed-off-by: Wolfgang Taferner <w.taferner@wtioit.at>
2023-06-26 21:10:37 +02:00
Wolfgang Taferner fcbf264d52 [FIX] mrp_subcontracting_dropshipping: technical fields should not trigger UserError
As a display line does not need to fulfill the dropship check, we skip those
and we do give the user a hint which lines are potentially not fulfilling
the check.

Reproduce:
- Create a purchases order with a picking type for dropshipping
- Add a different destination address (i.e. of another subcontractor to follow up the next manufacturing process)
- Add products with a defined BoM with type subcontractor and vendor
- Additionally add a section or a note
- Try to confirm the purchase order

Result:
- A user error will be triggered about a line which does not fit the current use case

Solution:
- as a section or a note should not be checked we do not trigger for those
- for other products which do not fit the use case we let the user know which lines are blocking

closes odoo/odoo#115044

X-original-commit: 5ba435d1ece208453fc73993b8018c68bb5f889d
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
2023-04-18 09:24:31 +02:00
Wolfgang Taferner ed8b0cb1dc [FIX] delivery: update_prices does ignore shipping rate
As sale does not know about special lines it will always update
the price based on product and price list instead of applying the correct
shipping rate, so we do skip those lines by using a newly introduced hook method

closes odoo/odoo#110782

X-original-commit: f1265b7fdce6bbe3fea97fc4b275dc2dca18103d
Signed-off-by: Arnold Moyaux (arm) <arm@odoo.com>
2023-01-24 10:20:38 +01:00
Wolfgang Taferner 7f684fcac0 [FIX] website_form: prevent crash on form many2one attachment upload
The current implementation of the many2one file upload in website form
will lead to a traceback in case of m2o fields.
It is currently only working with x2many fields. Note that it was
introduced as such with [1].

Step to reproduce:
- install website_sale
- drag & drop form snippet and click on it
- select "create customer" as action option
- add new existing field
- select "Main attachment" and save
- try to submit the form with a file uploaded in that new field
-> Traceback `ValueError: Wrong value for..`

This commit makes it work for all type of relational field.

[1]: https://github.com/odoo/odoo/commit/a77f5cf42faa75a2dd3931d83ad8ea86648248c0

closes odoo/odoo#104241

X-original-commit: addea33a8cb6c47bacdbfad0f3082f88763b59ef
Signed-off-by: Romain Derie (rde) <rde@odoo.com>
2022-10-27 11:38:50 +02:00
Wolfgang Taferner 873add0dd6 [FIX] payment: if image is missing icon view will crash
closes odoo/odoo#93533

X-original-commit: e0fe725df5e2522c1abf3e7c1fec6f3c1696e35c
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Signed-off-by: Wolfgang Taferner <w.taferner@wtioit.at>
2022-06-17 19:30:58 +02:00
Wolfgang Taferner 6aa942189d [IMP] website: show author website for localization on /website/info
Since [1] the l10n modules are displayed together at the bottom of the
page and redirect to the Odoo.com accounting page, regardless of the
localization author.

Now, if the localization was done by a third party, we use that author
website as link.

Note that this is already the case for the regular modules, like the
`payment_mollie` app for instance.

[1]: https://github.com/odoo/odoo/commit/562a2ac270ef8aac3afde05625008cef64f62f89

Part-of: odoo/odoo#91131
2022-05-12 14:50:59 +02:00
Wolfgang Taferner f826718365 [FIX] stock_account: stock inventory garbage adjustments
In case you applied inventory in batch the system would create a lot of useless
stock moves and stock move lines.

closes odoo/odoo#87771

X-original-commit: 07f18f62db490608b316cc9482f228252ed8fc63
Signed-off-by: William Henrotin (whe) <whe@odoo.com>
Signed-off-by: Wolfgang Taferner <w.taferner@wtioit.at>
2022-04-01 17:57:02 +02:00
Wolfgang Taferner c099709b85 [FIX] http_routing: mitigate key does not exist in context for lang
closes odoo/odoo#84478

X-original-commit: bdde46dad4d5886a8423bfaa0cac316784c7d382
Signed-off-by: Olivier Dony <odo@odoo.com>
2022-02-14 19:25:02 +00:00
Wolfgang Taferner e85c2041fd [FIX] payment: Chatter will not convert to breaks
As the message is thought to be posted in chatter replacing returns with html break.

closes odoo/odoo#81937

X-original-commit: 6cb616d74f71951b3989880ae232702d2257d292
Signed-off-by: Antoine Vandevenne (anv) <anv@odoo.com>
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Signed-off-by: Wolfgang Taferner <w.taferner@wtioit.at>
2021-12-28 10:39:01 +00:00
Wolfgang Taferner b71d4c44b3 [FIX] l10n_at: supplement and fix tags + remove empty tax_ids
Cash flow tags were supplemented and useless and empty tax_ids removed.
Additionally account 7990 had a wrongly tag which was corrected.

closes odoo/odoo#80135

X-original-commit: b3313905a973758da11f5bb9ea3efc6913491ef5
Signed-off-by: Josse Colpaert <jco@openerp.com>
2021-11-19 18:08:50 +00:00
Wolfgang Taferner 2c1617d22b [IMP] l10n_at: replace with specific formula to not confuse users
As it was confusing to have some autogenerated sum on the parent model
we show the proper tax value of the report

+ add missing report line to related taxes

closes odoo/odoo#79534

X-original-commit: 163e4c069a15c75d75df980c558a03cc89fd254c
Signed-off-by: Josse Colpaert <jco@openerp.com>
Signed-off-by: William André (wan) <wan@odoo.com>
2021-11-09 14:46:17 +00:00
Wolfgang Taferner be28be1eb0 [FIX] account: only display qr code if residual > 0
In case an invoice is already paid it is useless to provide
a QR Code for scanning to pay a residual of zero.

closes odoo/odoo#78437

X-original-commit: bfb5bcc07465240b0952e031522dd513dff8c2ab
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2021-10-15 16:13:51 +00:00
Wolfgang Taferner 018d4856db [FIX] models: log field names in api.onchange warning
Without this, the warning isn't very actionable.

closes odoo/odoo#75858

X-original-commit: afe7c9895914125fb31dbfde15903fa41e000948
Signed-off-by: Olivier Dony (odo) <odo@openerp.com>
Signed-off-by: Wolfgang Taferner <wtaferner@users.noreply.github.com>
2021-09-02 04:41:50 +00:00
Wolfgang Taferner e8f8939db7 [FIX] hr_attendance: wrong model for loading employee image
closes odoo/odoo#75488

X-original-commit: b2ccb469622e2fef776b21149ff2f253c1cccca1
Signed-off-by: Yannick Tivisse (yti) <yti@odoo.com>
Signed-off-by: Wolfgang Taferner <wtaferner@users.noreply.github.com>
2021-08-23 16:49:10 +00:00
Wolfgang Taferner 2cb678d4a1 [FIX] delivery: only update not yet processed pickings based on the n…
…ew carrier

closes odoo/odoo#74419

X-original-commit: 3dce2fdea0060b1bc13bb35610b7fe01c71ef054
Signed-off-by: pimodoo <pimodoo@users.noreply.github.com>
Signed-off-by: Wolfgang Taferner <wtaferner@users.noreply.github.com>
2021-07-29 10:48:22 +00:00
Wolfgang Taferner 3050e78ee2 [FIX] sale: make sure that bulk invoice creation is not blocked and those orders are skipped instead
In case you have installed sale_timesheet and try to do a bulk invoice creation you will be blocked if one order does not have invoiceable lines instead of skipping this specific order.

closes odoo/odoo#73261

X-original-commit: 3e03fe467b9fd459223113e477bc31811fbd35ed
Signed-off-by: Victor Feyens (vfe) <vfe@odoo.com>
Signed-off-by: Wolfgang Taferner <wtaferner@users.noreply.github.com>
2021-07-05 17:54:54 +00:00
Wolfgang Taferner 03f14189cb [FIX] account/purchase: onchange on purchase create bill does not work
closes odoo/odoo#64777

X-original-commit: 0f36bbd257ba5e8e03462f675d81fdbdece1893a
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2021-01-20 08:42:21 +00:00
Wolfgang Taferner 1e6dce9d4e [FIX] account: onchange of product and uom should not use currency rounding
As the price_unit and the uom rounding can be more detailed than the currency/accounting rounding (2 decimals as a standard) to cut the number before subtotal is wrong.

closes odoo/odoo#63817

X-original-commit: 1b4005f50ac45b53a73e0b95cfb661e8ccf040cd
Signed-off-by: Nicolas Martinelli (nim) <nim@odoo.com>
2020-12-28 10:21:46 +00:00
Wolfgang Taferner ccdfa1498f [FIX] account: if the base_tags are empty, it won't be updated
If you have a move line which was having tag_ids before and you apply a new tax
which has no values defined and result in an empty list, the assignment does not work on a x2m field,
so we do offer the proper notation for such a use case.

Closes #62934

closes odoo/odoo#63176

X-original-commit: f7cbbe381950699f2aeb26c454a4a955ed3bf2b4
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
2020-12-10 14:25:33 +00:00
Wolfgang Taferner 25a6f79e4a [FIX] base: key error during uninstall of unavailable module
In case a user has installed a module where the code becomes unavailable or during migration a module was removed and needs to be removed after migration it is impossible to uninstall the module from a database still holding the fields or the models.
In order to disable prefetch based on information from the database it is needed that the module and models of the unavailable module are initialized with related fields and models.

closes odoo/odoo#62895

X-original-commit: e4a1121e572d07cc720ede8c1b1116d4f1d7ae98
Signed-off-by: Raphael Collet (rco) <rco@openerp.com>
2020-12-04 14:06:32 +00:00
Wolfgang Taferner 2a7f5e25f1 [FIX] account: balance with line quantity > 1 and fiscal position
Currently the onchange is setting the price_unit to the price_subtotal to work out the proper price unit related to the tax, but does not have a different line quantity in mind.
The update of the price_unit was raising a balance difference UserError which is now resolved by the fact that we only update the price_unit if it is affected

OPW-2362066

closes odoo/odoo#60256

X-original-commit: 8c8d803992c31ba68a12801fa6dd4dcf909d9ed9
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2020-10-19 10:51:33 +00:00
Wolfgang Taferner 8dcc8bc217 [FIX] account: wrong implementation of journal account check
In case we have an account type which is allowed it is not needed to check the account allowed as it would fail although the account type is allowed before, so we need to do the check correctly as it was done in previous versions.

closes odoo/odoo#59547

X-original-commit: 220a1ffe69ddd9e4b45f31bf2911f1b6c3bfdfd7
Signed-off-by: oco-odoo <oco-odoo@users.noreply.github.com>
Signed-off-by: Laurent Smet <smetl@users.noreply.github.com>
2020-10-08 16:31:31 +00:00
Wolfgang Taferner 02f2691bff [REF] l10n_at: complete refactoring
As the available Austrian Localization was very basic and migrated for
years without any contribution or consolidation, a complete refactoring
was contributed by WT-IO-IT GmbH to move forward.

closes odoo/odoo#35642

Signed-off-by: Josse Colpaert <jco@openerp.com>
2019-08-19 09:54:06 +00:00
Wolfgang Taferner f20a8285f3 [FIX] account: extend the scope of the template tax too for the usage
closes odoo/odoo#35622

Signed-off-by: Quentin De Paoli (qdp) <qdp@openerp.com>
2019-08-11 17:12:46 +00:00