odoo_source

2 Commits

Author SHA1 Message Date

Author	SHA1	Message	Date
Isaac Gallart Bochons	ca217195d7	[FW][FIX] base: postgres subprocess error when dumping database When Odoo is installed with the latest version of the PostgreSQL client (postgres-client or postgres-client-16) and running in Docker (possibly other environments as well but not reproduced so far), executing `pg_dump` via `exec_pg_command` fails with Database backup error: Postgres subprocess ('/usr/bin/pg_dump', '--no-owner', '--file=/tmp/tmpmnqiktog/dump.sql', '15TEST') error 1 This seems to be because `os.devnull` is being opened in read mode which is incorrect (as it's written to). It's not entirely clear if older `pg_dump` simply ignored the non-writable stdout or if docker adds some restrictions which cause the failure. Either way this can be solved by either opening `os.devnull` in write mode or switching to the `DEVNULL` constant. While the function is deprecated in 16.0 (`7f14631fe8`) and removed in master (ae3056f3f4fca82c6aee69bf201532e14829c45e) the latter is not a huge change and it a touch cleaner. fixes #139687 closes odoo/odoo#143198 Forward-port-of: odoo/odoo#142987 Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>	2023-11-22 21:45:11 +00:00
Isaac Gallart Bochons	48cebafdaf	[FIX] mrp: call message_post separately message_post accepts only one id CLA signature for igallart done at #15625 Closes #15625	2017-02-27 12:26:42 +01:00

ca217195d7

[FW][FIX] base: postgres subprocess error when dumping database

When Odoo is installed with the latest version of the PostgreSQL client (postgres-client or postgres-client-16) and running in Docker (possibly other environments as well but not reproduced so far), executing `pg_dump` via `exec_pg_command` fails with

    Database backup error: Postgres subprocess ('/usr/bin/pg_dump', '--no-owner', '--file=/tmp/tmpmnqiktog/dump.sql', '15TEST') error 1

This seems to be because `os.devnull` is being opened in *read* mode which is incorrect (as it's written to). It's not entirely clear if older `pg_dump` simply ignored the non-writable stdout or if docker adds some restrictions which cause the failure.

Either way this can be solved by either opening `os.devnull` in write mode or switching to the `DEVNULL` constant. While the function is deprecated in 16.0 (7f14631fe8) and removed in master (ae3056f3f4fca82c6aee69bf201532e14829c45e) the latter is not a huge change and it a touch cleaner.

fixes #139687

closes odoo/odoo#143198

Forward-port-of: odoo/odoo#142987
Signed-off-by: Xavier Morel (xmo) <xmo@odoo.com>

2023-11-22 21:45:11 +00:00

Isaac Gallart Bochons

48cebafdaf

[FIX] mrp: call message_post separately

message_post accepts only one id

CLA signature for igallart done at #15625

Closes #15625

2017-02-27 12:26:42 +01:00