pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] mail: allow empty message edition

Browse Source 
Before this PR, it was not possible to edit a message that has an empty body.

Task-3387170

closes odoo/odoo#137996

Signed-off-by: Didier Debondt (did) <did@odoo.com>
This commit is contained in:
Didier (did)
2023-10-09 20:31:50 +00:00
parent a656a5a9a4
commit fd68c7d343
2 changed files with 26 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/mail/static/src/core/common/message.xml
+1 -1
View File
@@ -72,7 +72,7 @@
>
<div class="o-mail-Message-content o-min-width-0" t-att-class="{ 'w-100': state.isEditing }">
<div class="o-mail-Message-textContent position-relative d-flex" t-att-class="{ 'w-100': state.isEditing }">
<t t-if="message.type !== 'notification' and !message.isTransient and (message.hasTextContent or message.subtypeDescription)">
<t t-if="message.type !== 'notification' and !message.isTransient and (message.hasTextContent or message.subtypeDescription or state.isEditing)">
<LinkPreviewList t-if="!state.isEditing and message.linkPreviewSquash" linkPreviews="message.linkPreviews" deletable="false"/>
<t t-else="">
<div class="position-relative overflow-x-auto d-inline-block" t-att-class="{ 'w-100': state.isEditing }">
addons/mail/static/tests/message/message_tests.js
+25
View File
@@ -1594,3 +1594,28 @@ QUnit.test("Message should display attachments in order", async () => {
await contains(":nth-child(2 of .o-mail-AttachmentCard)", { text: "B.txt" });
await contains(":nth-child(3 of .o-mail-AttachmentCard)", { text: "C.txt" });
});
QUnit.test("Can edit a message only containing an attachment", async () => {
const pyEnv = await startServer();
const channelId = pyEnv["discuss.channel"].create({
name: "general",
channel_type: "channel",
});
const attachmentId = pyEnv["ir.attachment"].create({
name: "Blah.jpg",
mimetype: "image/jpeg",
});
pyEnv["mail.message"].create({
attachment_ids: [attachmentId],
author_id: pyEnv.currentPartnerId,
body: "",
model: "discuss.channel",
res_id: channelId,
message_type: "comment",
});
const { openDiscuss } = await start();
openDiscuss(channelId);
await click(".o-mail-Message [title='Expand']");
await click(".o-mail-Message [title='Edit']");
await contains(".o-mail-Message-editable .o-mail-Composer-input");
});