pengyuthon/odoo_source
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

[FIX] web: BufferedDataSet write to length field

Browse Source 
Underscore method _.each expects an array like object when a
"length" property is present.

This was an issue with a record having a numeric "length" field set
to a non-negative value.

opw-691070
This commit is contained in:
Nicolas Lempereur
2016-10-24 15:57:43 +02:00
parent 7974cc6597
commit f82ab99c1a
1 changed files with 6 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
addons/web/static/src/js/framework/data.js
+6 -5
View File
@@ -799,18 +799,19 @@ var BufferedDataSet = DataSetStatic.extend({
var def = $.Deferred();
this.mutex.exec(function () {
var dirty = false;
_.each(data, function (v, k) {
if (!_.isEqual(v, cached.values[k])) {
// _.each is broken if a field "length" is present
for (var k in data) {
if (!_.isEqual(data[k], cached.values[k])) {
dirty = true;
if (_.isEqual(v, cached.from_read[k])) { // clean changes
if (_.isEqual(data[k], cached.from_read[k])) { // clean changes
delete cached.changes[k];
} else {
cached.changes[k] = v;
cached.changes[k] = data[k];
}
} else {
delete data[k];
}
});
}
self._update_cache(id, options);
if (dirty) {