[IMP] base: use less tools method

Instead, updating the translations of a module can be done directly
on the ir.module.module record
Remove one call to _update_translation by the actual creation of the
language

odoo/addons/base/models/res_lang.py

@@ -226,7 +226,7 @@ class Lang(models.Model):
         active_lang = [lang.code for lang in self.filtered(lambda l: l.active)]
         if active_lang:
             mods = self.env['ir.module.module'].search([('state', '=', 'installed')])
-            mods._update_translations(filter_lang=active_lang)
+            mods._update_translations(active_lang)
 
     @api.model_create_multi
     def create(self, vals_list):

odoo/addons/base/tests/test_expression.py

@@ -673,11 +673,12 @@ class TestExpression(SavepointCaseWithUserDemo):
         """ Check that we can exclude translated fields (bug lp:1071710) """
         # first install french language
         self.env['res.lang']._activate_lang('fr_FR')
-        self.env['ir.translation']._load_module_terms(['base'], ['fr_FR'])
         self.env['res.partner'].search([('name', '=', 'Pepper Street')]).country_id = self.env.ref('base.be')
         # actual test
         Country = self.env['res.country'].with_context(lang='fr_FR')
         be = self.env.ref('base.be')
+        be.with_context(lang='fr_FR').name = "Belgique"
+        self.assertNotEqual(be.name, "Belgique", "Setting a translation should not impact other languages")
         not_be = self._search(Country, [('name', '!=', 'Belgique')])
         self.assertNotIn(be, not_be)
 

odoo/addons/base/tests/test_translate.py

@@ -248,7 +248,7 @@ class TestTranslation(TransactionCase):
     def setUp(self):
         super(TestTranslation, self).setUp()
         lang = self.env['res.lang']._activate_lang('fr_FR')
-        self.env['ir.translation']._load_module_terms(['base'], ['fr_FR'])
+        self.env.ref('base.module_base')._update_translations(['fr_FR'])
         self.customers = self.env['res.partner.category'].create({'name': 'Customers'})
         self.env['ir.translation'].create({
             'type': 'model',
@@ -579,7 +579,7 @@ class TestXMLTranslation(TransactionCase):
         super(TestXMLTranslation, self).setUp()
         self.env['res.lang']._activate_lang('fr_FR')
         self.env['res.lang']._activate_lang('nl_NL')
-        self.env['ir.translation']._load_module_terms(['base'], ['fr_FR', 'nl_NL'])
+        self.env.ref('base.module_base')._update_translations(['fr_FR', 'nl_NL'])
 
     def create_view(self, archf, terms, **kwargs):
         view = self.env['ir.ui.view'].create({

odoo/addons/test_new_api/tests/test_ui.py

@@ -28,7 +28,7 @@ class TestUiTranslation(odoo.tests.HttpCase):
     def test_01_sql_constraints(self):
         # Raise an SQL constraint and test the message
         self.env['res.lang']._activate_lang('fr_FR')
-        self.env['ir.translation']._load_module_terms(['test_new_api'], ['fr_FR'])
+        self.env.ref('base.module_test_new_api')._update_translations(['fr_FR'])
         constraint = self.env.ref('test_new_api.constraint_test_new_api_category_positive_color')
         message = constraint.with_context(lang='fr_FR').message
         self.assertEqual(message, "La couleur doit être une valeur positive !")