[FIX] P3: correct more dict iterable builtins use

Some bits posterior or leftover from fffaf735f5

See also parent commit.
This commit is contained in:
Olivier Dony
2017-08-20 23:25:54 +02:00
parent 695716efb0
commit f5b7de0e6c
3 changed files with 3 additions and 6 deletions
+1 -1
View File
@@ -767,7 +767,7 @@ class StockMove(models.Model):
grouped_move_lines_out[k] = sum(self.env['stock.move.line'].concat(*list(g)).mapped('product_qty'))
available_move_lines = {key: grouped_move_lines_in[key] - grouped_move_lines_out.get(key, 0) for key in grouped_move_lines_in.keys()}
# pop key if the quantity available amount to 0
available_move_lines = dict((k, v) for k, v in available_move_lines.iteritems() if v)
available_move_lines = dict((k, v) for k, v in available_move_lines.items() if v)
if not available_move_lines:
continue
+1 -4
View File
@@ -452,12 +452,9 @@ So, you can write ``if some_collection:`` instead of ``if len(some_collection):`
# better
for key in my_dict:
"do something..."
# creates a temporary list
# accessing the key,value pair
for key, value in my_dict.items():
"do something..."
# only iterates
for key, value in my_dict.iteritems():
"do something..."
- Use dict.setdefault
+1 -1
View File
@@ -876,7 +876,7 @@ def trans_generate(lang, modules, cr):
for dummy, val in field.selection:
push_translation(module, 'selection', name, 0, val)
for field_name, field in record._fields.iteritems():
for field_name, field in record._fields.items():
if field.translate:
name = model + "," + field_name
try: